From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-08 19:03:07
|
https://bugzilla.gnome.org/show_bug.cgi?id=634349 gnome-perl | Glib | unspecified Summary: ParamSpec get_default_value() for override and gtype Classification: Bindings Product: gnome-perl Version: unspecified OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: Glib AssignedTo: gtk...@li... ReportedBy: us...@zi... QAContact: gtk...@li... GNOME target: --- GNOME version: --- Created an attachment (id=174087) View: https://bugzilla.gnome.org/attachment.cgi?id=174087 Review: https://bugzilla.gnome.org/review?bug=634349&attachment=174087 patch and test cases This is a get_default_value() method for the new Glib::Param::Override and Glib::Param::GType, using g_param_value_set_default(). It's done slightly with an eye to replacing the specific get_default_value() methods of the various param types, per other ticket, but to start with it gets override and gtype going. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-08 20:05:32
|
https://bugzilla.gnome.org/show_bug.cgi?id=634349 gnome-perl | Glib | unspecified Kevin Ryde <user42> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-12 20:10:10
|
https://bugzilla.gnome.org/show_bug.cgi?id=634349 gnome-perl | Glib | unspecified Kevin Ryde <user42> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174087|0 |1 is obsolete| | --- Comment #1 from Kevin Ryde <us...@zi...> 2010-11-12 20:09:57 UTC --- Created an attachment (id=174357) View: https://bugzilla.gnome.org/attachment.cgi?id=174357 Review: https://bugzilla.gnome.org/review?bug=634349&attachment=174357 patch and test cases I see I should conditionalize the g_param_spec_get_redirect_target() bit for glib pre-2.4, and I seem to have accumulated too many unapplied changes to t/e.t, so this one perhaps applies clean against the head :-) -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-13 00:05:35
|
https://bugzilla.gnome.org/show_bug.cgi?id=634349 gnome-perl | Glib | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaf...@gm... --- Comment #2 from Torsten Schoenfeld <kaf...@gm...> 2010-11-13 00:05:21 UTC --- Patch looks good to me. I'm slightly uneasy about the fixed-size stack allocation of the g_unichar_to_utf8 target but that seems to be common enough. Also, instead of newSVpv + SvUTF8_on, you could use newSVGChar. More importantly, though: what prevents us from removing the specialized get_default_value() methods now? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-13 21:22:30
|
https://bugzilla.gnome.org/show_bug.cgi?id=634349 gnome-perl | Glib | unspecified --- Comment #3 from Kevin Ryde <us...@zi...> 2010-11-13 21:22:15 UTC --- I looked for the glib equiv of MB_LEN_MAX, I mean everything else in the C library has been duplicated, but apparently not that! The specific get_default_value()s would only want the test cases of my other ticket re-diffed, just to make sure the new generic comes out right. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-13 23:07:46
|
https://bugzilla.gnome.org/show_bug.cgi?id=634349 gnome-perl | Glib | unspecified Kevin Ryde <user42> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174357|0 |1 is obsolete| | --- Comment #4 from Kevin Ryde <us...@zi...> 2010-11-13 23:07:28 UTC --- Created an attachment (id=174409) View: https://bugzilla.gnome.org/attachment.cgi?id=174409 Review: https://bugzilla.gnome.org/review?bug=634349&attachment=174409 patch and test cases I don't think newSVGChar suits as g_unichar_to_utf8() isn't null terminated, and the default value itself can be nul "\0". I copied from the typemap T_GUNICHAR outputer, so the goodness from there is carried over :-) I added test cases to exercise "0" and "\0" though. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-21 20:12:55
|
https://bugzilla.gnome.org/show_bug.cgi?id=634349 gnome-perl | Glib | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #5 from Torsten Schoenfeld <kaf...@gm...> 2010-11-21 20:12:42 UTC --- I see. Looks great, committed. Thanks. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-11-21 20:12:57
|
https://bugzilla.gnome.org/show_bug.cgi?id=634349 gnome-perl | Glib | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174409|none |committed status| | -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |