gtk2-perl-bugs

[Gtk2-perl-bugs] [Bug 629727] New: CellLayout get_cells() empty list not undef

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=629727
  gnome-perl | Gtk2 | unspecified

           Summary: CellLayout get_cells() empty list not undef
    Classification: Bindings
           Product: gnome-perl
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: Gtk2
        AssignedTo: gtk...@li...
        ReportedBy: us...@zi...
         QAContact: gtk...@li...
      GNOME target: ---
     GNOME version: ---


Created an attachment (id=170309)
 View: https://bugzilla.gnome.org/attachment.cgi?id=170309
 Review: https://bugzilla.gnome.org/review?bug=629727&attachment=170309

patch and test case

When a CellLayout interfaced widget has no renderers I think get_cells() should
return an empty list, not an undef.  An undef return is rather inconvenient if
doing a foreach ($viewer->get_cells).  Perhaps per attached.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 629727] CellLayout get_cells() empty list not undef

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=629727
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |kaf...@gm...
     Ever Confirmed|0                           |1

--- Comment #1 from Torsten Schoenfeld <kaf...@gm...> 2010-09-19 16:05:43 UTC ---
I agree that (undef) for no cells is definitely very inconvenient, and your
patch corrects that.  (And git puts the blame on me. :-/)  But I worry about
backwards compatibility.  Is it conceivable that someone somewhere relies on
(undef) signaling "no cells"?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 629727] CellLayout get_cells() empty list not undef

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=629727
  gnome-perl | Gtk2 | unspecified

--- Comment #2 from Kevin Ryde <us...@zi...> 2010-09-21 00:19:44 UTC ---
As a boolean it's unchanged (new .t diff attached), if that helps.

It seems unlikely that getting back a non-cell from get_cells could do anyone
much good.  My guess would be that nobody has done an empty get_cells before
now and that returning undef instead of empty may be rated a bug.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 629727] CellLayout get_cells() empty list not undef

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=629727
  gnome-perl | Gtk2 | unspecified

--- Comment #3 from Kevin Ryde <us...@zi...> 2010-09-21 00:20:38 UTC ---
Created an attachment (id=170727)
 View: https://bugzilla.gnome.org/attachment.cgi?id=170727
 Review: https://bugzilla.gnome.org/review?bug=629727&attachment=170727

tests

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 629727] CellLayout get_cells() empty list not undef

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=629727
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #4 from Torsten Schoenfeld <kaf...@gm...> 2011-10-03 15:08:15 UTC ---
I just pushed a patch to master that documents the unusual current return
semantics of get_cells().  I feel that changing it like you proposed would be
too risky.  I'll try to make sure that Gtk3 gets this right.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.