From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-25 23:14:02
|
https://bugzilla.gnome.org/show_bug.cgi?id=613972 gnome-perl | Gtk2 | unspecified Summary: AboutDialog show_about_dialog() same screen as parent Classification: Bindings Product: gnome-perl Version: unspecified OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: Normal Component: Gtk2 AssignedTo: gtk...@li... ReportedBy: us...@zi... QAContact: gtk...@li... GNOME target: --- GNOME version: --- Created an attachment (id=157124) View: https://bugzilla.gnome.org/attachment.cgi?id=157124 Review: https://bugzilla.gnome.org/review?bug=613972&attachment=157124 make show_about_dialog() default to the screen of the parent I wonder if Gtk2->show_about_dialog might popup the new AboutDialog on the same screen as the $parent it's given. In a multi-screen/multi-display program I think that might make most sense. If $parent is a main window running a Help/About then that screen is almost certainly where you're looking. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-25 23:42:51
|
https://bugzilla.gnome.org/show_bug.cgi?id=613972 gnome-perl | Gtk2 | unspecified muppet <scott> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157124|none |rejected status| | --- Comment #1 from muppet <sc...@as...> 2010-03-25 23:42:42 UTC --- Review of attachment 157124: --> (https://bugzilla.gnome.org/review?bug=613972&attachment=157124) This xs convenience impl was originally a copy of the C function from gtk+/gtk/gtkabout.c. If you look in there, they actually call gtk_window_set_transient_for() if you give a parent pointer. Just do what gtk+ does. :-) http://git.gnome.org/browse/gtk+/tree/gtk/gtkaboutdialog.c -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-26 00:35:59
|
https://bugzilla.gnome.org/show_bug.cgi?id=613972 gnome-perl | Gtk2 | unspecified --- Comment #2 from Kevin Ryde <us...@zi...> 2010-03-26 00:35:50 UTC --- Ah, I see, copied because it's hard to call a varargs. Is there a reason it's Gtk2->show_about_dialog and not Gtk2::AboutDialog->show_about_dialog? If the latter I wondered if called on a subclass like MyAboutDialogSubclass->show_about_dialog it could create an instance of the subclass, instead of always gtk_about_dialog_new(). -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-13 00:33:34
|
https://bugzilla.gnome.org/show_bug.cgi?id=613972 gnome-perl | Gtk2 | unspecified Kevin Ryde <user42> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157124|0 |1 is obsolete| | --- Comment #3 from Kevin Ryde <us...@zi...> 2010-04-13 00:24:34 UTC --- Created an attachment (id=158565) View: https://bugzilla.gnome.org/attachment.cgi?id=158565 Review: https://bugzilla.gnome.org/review?bug=613972&attachment=158565 using gtk_window_transient_for This one using transient_for the same as the gtk code. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-24 23:49:25
|
https://bugzilla.gnome.org/show_bug.cgi?id=613972 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaf...@gm... --- Comment #4 from Torsten Schoenfeld <kaf...@gm...> 2010-04-24 23:49:14 UTC --- The gtk+ code also does gtk_window_set_destroy_with_parent (GTK_WINDOW (dialog), TRUE). Should we do the same? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-05-10 02:26:48
|
https://bugzilla.gnome.org/show_bug.cgi?id=613972 gnome-perl | Gtk2 | unspecified muppet <scott> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sc...@as... --- Comment #5 from muppet <sc...@as...> 2010-05-10 02:26:36 UTC --- Yes, we should. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-05-16 11:38:13
|
https://bugzilla.gnome.org/show_bug.cgi?id=613972 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #6 from Torsten Schoenfeld <kaf...@gm...> 2010-05-16 11:38:01 UTC --- Alright, I committed a slightly modified variant of Kevin's patch. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |