Menu
▾
▴
gtk2-perl-bugs
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-25 23:19:31
|
https://bugzilla.gnome.org/show_bug.cgi?id=613973 gnome-perl | Gtk2 | unspecified Summary: Menu popup() protect against die Classification: Bindings Product: gnome-perl Version: unspecified OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: Gtk2 AssignedTo: gtk...@li... ReportedBy: us...@zi... QAContact: gtk...@li... GNOME target: --- GNOME version: --- Created an attachment (id=157125) View: https://bugzilla.gnome.org/attachment.cgi?id=157125 Review: https://bugzilla.gnome.org/review?bug=613973&attachment=157125 G_EVAL around the positioning func for Menu popup() I wonder if $menu->popup() could have an eval to protect against die() in the positioning function. In some of my code an error caused a persistent X grab, locking the screen until the client program is killed. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-25 23:37:10
|
https://bugzilla.gnome.org/show_bug.cgi?id=613973 gnome-perl | Gtk2 | unspecified muppet <scott> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157125|none |accepted-commit_now status| | --- Comment #1 from muppet <sc...@as...> 2010-03-25 23:37:00 UTC --- Review of attachment 157125: --> (https://bugzilla.gnome.org/review?bug=613973&attachment=157125) I heartily condone this change. My one reservation was about eating errors, but you've addressed that with the g_warning(). Now, if you have a g_log handler installed, and it decides to die on that warning, you have the same issue, right? -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-26 00:48:54
|
https://bugzilla.gnome.org/show_bug.cgi?id=613973 gnome-perl | Gtk2 | unspecified --- Comment #2 from Kevin Ryde <us...@zi...> 2010-03-26 00:48:42 UTC --- Is it permitted to die in a log handler? There'd have to be quite a few places that'd be a bad thing wouldn't there? The gperl_log_func() callback invocation may even be another of the various GPerlCallbacks which would benefit from eval protection. For the popup I'm open to ideas for the right log level and domain. "Error" may be better than warning, but non-fatal, still continuing with the code, not jumping out. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-03-31 17:27:39
|
https://bugzilla.gnome.org/show_bug.cgi?id=613973 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157125|accepted-commit_now |needs-work status| | --- Comment #3 from Torsten Schoenfeld <kaf...@gm...> 2010-03-31 17:27:26 UTC --- Review of attachment 157125: --> (https://bugzilla.gnome.org/review?bug=613973&attachment=157125) Looks good to me in general. Two minor things: ::: t/GtkMenu.t @@ +142,3 @@ + 'popup positioning die() is not fatal'); +} + What's with $popup_runs here? Looks like dead code. ::: xs/GtkMenu.xs @@ +88,1 @@ Here and in the previous chunk above, you use spaces for indentation, but we use tabs in XS code. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-03 00:54:48
|
https://bugzilla.gnome.org/show_bug.cgi?id=613973 gnome-perl | Gtk2 | unspecified Kevin Ryde <user42> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157125|0 |1 is obsolete| | --- Comment #4 from Kevin Ryde <us...@zi...> 2010-04-03 00:53:51 UTC --- Created an attachment (id=157782) View: https://bugzilla.gnome.org/attachment.cgi?id=157782 Review: https://bugzilla.gnome.org/review?bug=613973&attachment=157782 second effort G_EVAL popup() Err, umm, that looks a bit doubtful on re-reading. I think $popup_runs was to allow it to skip if the menu doesn't pop up. Is the the reason for $i_know_you? At any rate second effort attached. (I've lately tried to get the tabs mode right from my .emacs, but I'm also forever switching between my own xs-mode based on c-mode, and plain text-mode or pod-mode the xs directives upset the C parsing ...) -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-25 15:15:37
|
https://bugzilla.gnome.org/show_bug.cgi?id=613973 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #5 from Torsten Schoenfeld <kaf...@gm...> 2010-04-25 15:15:25 UTC --- Committed. Thanks. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
|
From: gnome-perl (bugzilla.gnome.o. <bug...@gn...> - 2010-04-25 15:15:43
|
https://bugzilla.gnome.org/show_bug.cgi?id=613973 gnome-perl | Gtk2 | unspecified Torsten Schoenfeld <kaffeetisch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157782|none |committed status| | -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X