gtk2-perl-bugs

[Gtk2-perl-bugs] [Bug 592391] New: Gtk2::MenuItem leaks in some cases

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

http://bugzilla.gnome.org/show_bug.cgi?id=592391

           Summary: Gtk2::MenuItem leaks in some cases
    Classification: Bindings
           Product: gnome-perl
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: Gtk2
        AssignedTo: gtk...@li...
        ReportedBy: squ...@fr...
         QAContact: gtk...@li...
      GNOME target: ---
     GNOME version: ---


--- Comment #0 from Quentin Sculo <squ...@fr...> 2009-08-19 22:54:37 UTC ---
Created an attachment (id=141193)
test case

A Gtk2::MenuItem (and Gtk2::CheckMenuItem ...) created with
my $item=Gtk2::MenuItem->new('sometext');
will not be automatically destroyed unless it has been added to a menu.
This does not happen if the Gtk2::MenuItem has been created with :
my $item=Gtk2::MenuItem->new;
even if a label is added afterward.

You might say that menuitem are almost always added to a menu :)
But in the case of menuitem used as proxy_menu_item for a Gtk2::ToolItem, the
menuitem won't be destroyed unless the menuitem has been added to the overflow
menu.

-- 
Configure bugmail: http://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 592391] Gtk2::MenuItem leaks in some cases

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=592391
  gnome-perl | Gtk2 | unspecified

Kevin Ryde <user42> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |us...@zi...

--- Comment #1 from Kevin Ryde <us...@zi...> 2010-03-18 22:50:37 UTC ---
I think this is dodginess in Gtk itself.  A new_with_label makes an
GtkAccelLabel with its "accel-widget" set to the item, which is a circular
reference between the item and label.  Sample accel.pl attached.

I suppose the circularity is normally undone by a destroy() on the top GtkMenu
calling destroy on all its children and sub-children.

Needing to call $item->destroy from perl is unpleasant, but I suppose it's not
a bug strictly speaking.  We've got notes in Gtk2::Window on the need for
explicit destroy() there.  Perhaps a similar bit in Gtk2::MenuItem, and a cross
reference in Gtk2::AccelLabel.  I might have a go at a few words if no-one
beats me to it.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 592391] Gtk2::MenuItem leaks in some cases

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=592391
  gnome-perl | Gtk2 | unspecified

--- Comment #2 from Kevin Ryde <us...@zi...> 2010-03-18 22:52:50 UTC ---
Created an attachment (id=156519)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=156519)
sample circular ref between MenuItem and AccelLabel

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 592391] Gtk2::MenuItem leaks in some cases

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=592391
  gnome-perl | Gtk2 | unspecified

--- Comment #3 from Kevin Ryde <us...@zi...> 2010-03-19 19:39:00 UTC ---
Created an attachment (id=156579)
 View: https://bugzilla.gnome.org/attachment.cgi?id=156579
 Review: https://bugzilla.gnome.org/review?bug=592391&attachment=156579

docs of MenuItem circular ref

I got to these few words, plus test cases exercising the truth of the words
:-).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 592391] Gtk2::MenuItem leaks in some cases

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=592391
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156579|none                        |committed
             status|                            |

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

[Gtk2-perl-bugs] [Bug 592391] Gtk2::MenuItem leaks in some cases

[gnome-perl (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=592391
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |NOTABUG

--- Comment #4 from Torsten Schoenfeld <kaf...@gm...> 2010-03-29 13:52:03 UTC ---
Patch committed.  Thanks!  Since this is not a bug in the bindings, I'm marking
this report accordingly.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.