Menu
▾
▴
gtk2-perl-bugs
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-01-07 10:51:03
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=566884 gnome-perl | Gtk2 | Ver: unspecified Summary: a patch to add support for gdk_x11_atom_to_xatom_for_display Product: gnome-perl Version: unspecified Platform: Other OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: Gtk2 AssignedTo: gtk...@li... ReportedBy: cs...@ne... QAContact: gtk...@li... GNOME version: Unspecified GNOME milestone: Unspecified Hi, I've done a patch to add support for gdk_x11_atom_to_xatom_for_display and gdk_x11_atom_to_xatom These functions return the X11 atom (a number) corresponding to a GdkAtom. The X11 atom number is required to implement (for example) ICCCM compliant behaviour (some X11 client-message events need to include the X11 atom number in the Gtk2::Gdk::Event::Client.data field). In particular I need it to broadcast ownership of a selection by sending a MANAGER client-message, so that I can implement the freedesktop systray spec. If I can figure out how to attach a patch, I will attach two. - the first adds support into the Gtk2::Gdk::Atom class. The type of the atom number is declared as UV (the same as the current behaviour for XID and XWINDOW). Also the method is aliased to XATOM just like Gtk2::Gdk::Window->XWINDOW. - the second patch instead just adds support into the Gtk2::Gdk::X11 package, which keeps the X11 specific stuff out of Gtk2::Gdk::Atom (just in case that is preferred). - the idea being that one or the other would be used. My guess is the first patch is better since it has a more intuitive usage and is inline with the current behaviour of XWINDOW and XID. -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=566884. |
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-01-07 10:52:14
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=566884 gnome-perl | Gtk2 | Ver: unspecified ------- Comment #1 from chris 2009-01-07 10:52 UTC ------- patches coming in a short while. -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=566884. |
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-01-08 09:36:43
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=566884 gnome-perl | Gtk2 | Ver: unspecified ------- Comment #2 from chris 2009-01-08 09:36 UTC ------- Created an attachment (id=126015) --> (http://bugzilla.gnome.org/attachment.cgi?id=126015&action=view) patch adding X11 xatom support to the Gtk2::Gdk::Atom package -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=566884. |
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-01-08 09:37:51
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=566884 gnome-perl | Gtk2 | Ver: unspecified ------- Comment #3 from chris 2009-01-08 09:37 UTC ------- Created an attachment (id=126016) --> (http://bugzilla.gnome.org/attachment.cgi?id=126016&action=view) patch adding X11 xatom support to the Gtk2::Gdk::Atom package this patch is a possible alternative to the first patch -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=566884. |
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-01-08 10:15:49
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=566884 gnome-perl | Gtk2 | Ver: unspecified ------- Comment #4 from chris 2009-01-08 10:15 UTC ------- (From update of attachment 126016) dont use this patch. I've already discovered a problem -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=566884. |
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-01-08 10:17:31
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=566884 gnome-perl | Gtk2 | Ver: unspecified ------- Comment #5 from chris 2009-01-08 10:17 UTC ------- oops. oops. don't use the initial patches in comments 2-3. while while updating the .t test file I've realised one of the new methods won't work. I need to reorder the params in one of the methods. So I've got to look into this XS stuff a bit more. -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=566884. |
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-01-08 11:03:56
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=566884 gnome-perl | Gtk2 | Ver: unspecified chris changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126015|0 |1 is obsolete| | Attachment #126016|0 |1 is obsolete| | ------- Comment #6 from chris 2009-01-08 11:03 UTC ------- Created an attachment (id=126021) --> (http://bugzilla.gnome.org/attachment.cgi?id=126021&action=view) patch to add support for gdk_x11_atom_to_xatom OK please ignore the above patches. Instead here is a single patch which includes the updated xs file and an updated test file. -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=566884. |
|
From: gnome-perl (bugzilla.gnome.org) <bug...@bu...> - 2009-01-20 20:26:57
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=566884 gnome-perl | Gtk2 | Ver: unspecified Torsten Schoenfeld changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaf...@gm... Attachment #126021|none |committed Flag| | Status|UNCONFIRMED |RESOLVED Resolution| |FIXED ------- Comment #7 from Torsten Schoenfeld 2009-01-20 20:26 UTC ------- Thanks for the patch! I slightly altered it, mainly to remove the XATOM alias. to_xatom() is a converter, not an accessor, so I think we should keep the "to" part. Otherwise it looked fine to me, so I committed it. -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=566884. |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X