From: <bug...@bu...> - 2005-04-19 10:09:32
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified Summary: Adding Glib::KeyFile Product: gnome-perl Version: unspecified Platform: Other OS/Version: All Status: UNCONFIRMED Severity: enhancement Priority: Normal Component: Glib AssignedTo: gtk...@li... ReportedBy: emm...@em... CC: all...@bu... Perl bindings for the GKeyFile object ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-19 10:12:58
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified ------- Additional Comments From Emmanuele Bassi 2005-04-19 06:12 ------= - Created an attachment (id=3D45435) --> (http://bugzilla.gnome.org/attachment.cgi?id=3D45435&action=3Dview) Glib::KeyFile glue code The glue code for Glib::KeyFile, with the remarks from Torsten fro condit= ional compilation. ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-19 10:14:32
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified ------- Additional Comments From Emmanuele Bassi 2005-04-19 06:14 ------= - Created an attachment (id=3D45436) --> (http://bugzilla.gnome.org/attachment.cgi?id=3D45436&action=3Dview) Glib::KeyFile XS code Glib::KeyFile XS, with *_list variants implemented, and muppet's remarks = on string freeing ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-19 10:15:11
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified ------- Additional Comments From Emmanuele Bassi 2005-04-19 06:15 ------= - Created an attachment (id=3D45437) --> (http://bugzilla.gnome.org/attachment.cgi?id=3D45437&action=3Dview) Glib::KeyFile test suite Glib::KeyFile test suite for use with make test ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-19 12:23:57
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified ------- Additional Comments From muppet 2005-04-19 08:23 ------- In get_keys() and get_groups(), you return a list of strings, or undef if= the C function returns no strings. =20 in perl that means that whether the function returned anything or not, @= return > 0. to check if there=20 are keys, i have to explicitly check defined($ret[0]). it would be easie= r to use (and code) if it returned an=20 empty list instead of undef. in the set_boolean case of set_boolean, you want SvTRUE rather than SvIV = -- this will allow you to=20 handle undef without warnings at runtime. similarly, get_boolean should = use boolSV for the new=20 boolean output value instead of newSViv. (yeah, 0 is false, but that's n= ot perl's boolean false -- that's=20 ''.) the same goes for the [sg]et_boolean_list ones. ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-20 15:51:45
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified Emmanuele Bassi changed: What |Removed |Added -------------------------------------------------------------------------= --- Attachment #45436|0 |1 is obsolete| | ------- Additional Comments From Emmanuele Bassi 2005-04-20 11:51 ------= - Created an attachment (id=3D45491) --> (http://bugzilla.gnome.org/attachment.cgi?id=3D45491&action=3Dview) Glib::KeyFile XS code New XS file, implementing muppet's remarks ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-20 15:52:38
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified Emmanuele Bassi changed: What |Removed |Added -------------------------------------------------------------------------= --- Attachment #45437|0 |1 is obsolete| | ------- Additional Comments From Emmanuele Bassi 2005-04-20 11:52 ------= - Created an attachment (id=3D45492) --> (http://bugzilla.gnome.org/attachment.cgi?id=3D45492&action=3Dview) Glib::KeyFile test suite New test suite, with a check for initial group state. ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-20 18:38:32
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified ------- Additional Comments From muppet 2005-04-20 14:38 ------- I'm happy with the xs file now, but the test file looks a bit lean for as= many functions as the xs file creates. ;-) ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-21 13:27:45
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified Emmanuele Bassi changed: What |Removed |Added -------------------------------------------------------------------------= --- Attachment #45492|0 |1 is obsolete| | ------- Additional Comments From Emmanuele Bassi 2005-04-21 09:27 ------= - Created an attachment (id=3D45515) --> (http://bugzilla.gnome.org/attachment.cgi?id=3D45515&action=3Dview) Glib::KeyFile test suite Here's the latest test suite. It will skip the tests if we are not using a Glib >=3D 2.6.0. ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-25 19:14:31
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified ------- Additional Comments From Emmanuele Bassi 2005-04-25 19:14 ------= - If it's okay, I could commit it by tomorrow, in order to be included in t= he next release of the 1.09x series. ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-26 16:52:09
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified ------- Additional Comments From Torsten Schoenfeld 2005-04-26 16:52 ---= ---- Everything looks fine to me. Just a minor nag: the copyright disclaimer = in the XS file says 2003-2005. ------- You are receiving this mail because: ------- You are the assignee for the bug. |
From: <bug...@bu...> - 2005-04-26 23:02:03
|
Please DO NOT reply to this by email. All additional comments should be m= ade in the comments box of this bug report. http://bugzilla.gnome.org/show_bug.cgi?id=3D301171 gnome-perl | Glib | Ver: unspecified Emmanuele Bassi changed: What |Removed |Added -------------------------------------------------------------------------= --- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED ------- Additional Comments From Emmanuele Bassi 2005-04-26 23:01 ------= - Committed the latest patch ------- You are receiving this mail because: ------- You are the assignee for the bug. |