RE: [Gtk1-win-developers] GLIB 2.2.3

[Donald M. <do...@dr...>]

 

> -----Original Message-----
> From: gtk...@li... 
> [mailto:gtk...@li...] On 
> Behalf Of Robin Rowe
> Sent: 04 December 2003 15:14
> To: gtk...@li...
> Subject: Re: [Gtk1-win-developers] GLIB 2.2.3
> 
> Donald,
> 
> > Downloaded both glib-2.2.1 and 2.2.3 from ftp.gtk.org and 
> made patch based
> > on this.
> >
> > Was easy - just a few rejects.
> 
> Good.
> 
> > From looking at the diffs it seems that the main
> > Difference is that you add GLIB_VAR for many more functions 
> than in the
> real
> > distro.
> 
> That's right.
> 
> FYI, once we have 1.4 stable I will go back to GTK and get 
> changes into CVS
> there.
> 
> > It is these that are giving me problems sometimes, eg in 
> gmodule/gmodule.h
> > GLIB_VAR is not set as dllexport because we are not 
> compiling glib so no
> > -DGLIB_COMPILATION and this is required in glib/gtypes.h to get the
> correct
> > setting to export these functions. If -DGLIB_COMPILATION is 
> set the other
> > symbols also get exported from gmodule, e.g. glib_*_version 
> which causes
> > problems at runtime.
> >
> > Gmodule.h does have the start of the correct way to handle 
> this, but does
> > not depend on DLL_EXPORT.
> 
> Can you explain what the extra plumbing with GLIB_COMPILATION 
> does in glib?
> Why not like DLL_API that I implemented in dll_api.h in gtk?

In your dll_api.h only WIN32 and DLL_EXPORT are enough to cause symbols to
be defined as declspec(dllexport).
If you were then to build another dll based on this then they would be
re-exported from the second dll, this would compile and link quite happily
but will be unpredictable at runtime - depends on the order the libraries
were specified on the link command line. 

Since glib is being built as a dll and then used to link against in another
dll and the gtypes.h header is used by all then the above problem exists.


> 
> > Sounds fine. I can send a patch for the glib that is there 
> to 2.2.3 if you
> > like?
> 
> Yes, please send to SF Patches.
> 
> Cheers,
> 
> Robin
> --------------------------------------------------------------
> -------------
> Rob...@Mo...   Hollywood, California
> www.CinePaint.org   Free motion picture and still image 
> editing software
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive?  Does it
> help you create better code?  SHARE THE LOVE, and help us help
> YOU!  Click Here: http://sourceforge.net/donate/
> _______________________________________________
> Gtk1-win-developers mailing list
> Gtk...@li...
> https://lists.sourceforge.net/lists/listinfo/gtk1-win-developers
>