Re: [Gtk-gnutella-devel] Patch src/core/sockets.c

[Bill P. <bpr...@sy...>]

Bill Pringlemeir wrote:

>> Using "-DTRACK_ZALLOC -DTRACK_MALLOC -DUSE_MALLOC", I get many
>> lines like this,

>> "(src/core/sockets.c:1355) attempt to free block at 0x0 twice?"

On 20 Jan 2007, chr...@gm... wrote:

> This is clearly bogus because the function doesn't check for
> NULL. We should however always use G_FREE_NULL() like most of the
> code already does. I've fixed it similar to your suggestion.

I did see that macro after posting.  It also helps to prevent double
frees.  However, an alternative is to change the memory logging code.
I guess that is more a philosophical debate.  I think explicitly
handling NULLs separate seems to be the general consensus in GTKG.