[gst-cvs] gst-plugins-good: gstrtpsession: Fallback for FIR to PLI if PLI isn' t available

[<wt...@ke...>]

Module: gst-plugins-good
Branch: master
Commit: 7350d2adfad6d6d3bef63fb793739204048612c5
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=7350d2adfad6d6d3bef63fb793739204048612c5

Author: Sjoerd Simons <sjo...@co...>
Date:   Wed Nov 24 15:27:46 2010 -0500

gstrtpsession: Fallback for FIR to PLI if PLI isn't available

---

 gst/rtpmanager/gstrtpsession.c |   25 +++++++++++++++++++------
 1 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/gst/rtpmanager/gstrtpsession.c b/gst/rtpmanager/gstrtpsession.c
index 6d36633..cc784c8 100644
--- a/gst/rtpmanager/gstrtpsession.c
+++ b/gst/rtpmanager/gstrtpsession.c
@@ -1383,22 +1383,35 @@ gst_rtp_session_request_remote_key_unit (GstRtpSession * rtpsession,
     gboolean fir, pli;
     const GstStructure *s = gst_caps_get_structure (caps, 0);
 
-    if (all_headers &&
-        gst_structure_get_boolean (s, "rtcp-fb-nack-fir", &fir) && fir) {
-      /* 500 ms acceptable delay for FIR request is a guesstimate, it could
+    if (!gst_structure_get_boolean (s, "rtcp-fb-nack-fir", &fir))
+      fir = FALSE;
+
+    if (!gst_structure_get_boolean (s, "rtcp-fb-nack-pli", &pli))
+      pli = FALSE;
+
+    gst_caps_unref (caps);
+
+    if (!pli && !fir)
+      goto out;
+
+    /* When we need all headers, use FIR if possible falling back to PLI if
+     * it's available */
+    if (all_headers) {
+      /* 500 ms acceptable delay for urgent request is a guesstimate, it could
        * be made configurable if needed
        */
+      /* If we don't have fir, fall back to pli */
+      rtp_session_request_key_unit (rtpsession->priv->session, ssrc, fir);
       rtp_session_request_early_rtcp (rtpsession->priv->session,
           gst_clock_get_time (rtpsession->priv->sysclock), 500 * GST_MSECOND);
-      rtp_session_request_key_unit (rtpsession->priv->session, ssrc, TRUE);
       requested = TRUE;
-    } else if (gst_structure_get_boolean (s, "rtcp-fb-nack-pli", &pli) && pli) {
+    } else if (pli) {
       rtp_session_request_key_unit (rtpsession->priv->session, ssrc, FALSE);
       requested = TRUE;
     }
-    gst_caps_unref (caps);
   }
 
+out:
   return requested;
 }