[gstreamer-bugs] [Bug 618409] jackaudiosrc: improve process callback

[GStreamer (bugzilla.gnome.o. <bug...@gn...>]

https://bugzilla.gnome.org/show_bug.cgi?id=618409
  GStreamer | gst-plugins-bad | git

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |wim...@gm...
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |0.10.19

--- Comment #3 from Wim Taymans <wim...@gm...> 2010-05-13 10:57:11 UTC ---
(In reply to comment #2)
> Created an attachment (id=160906)
 View: https://bugzilla.gnome.org/attachment.cgi?id=160906
 Review: https://bugzilla.gnome.org/review?bug=618409&attachment=160906

> advance the ringbuffer as we copy samples
> 
> We should also advance the ringbuffer as segments are copied over, not just
> once in the process callback but everytime we copy over more than the length
> parameter given by the gst_ringbuffer_prepare_read call.

I commited the following patch instead. Just like in the sink case, the number
of frames is always exactly equal to the size we get from the prepare_read call
or else something else is wrong.

commit d4f6a94b93291d36fd3658d790869f757187df05
Author: Wim Taymans <wim...@co...>
Date:   Thu May 13 12:55:29 2010 +0200

    jacksrc: make sure we always read nframes

    Error out when we are asked to read a different size that what was
configured as
    the jack period size because that would mean something else is wrong.

    Fixes #618409

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.