Re: [Gstreamer-openmax] [PATCH 8/8] Add GstOmxBaseAudioDec base class

[Felipe C. <fel...@gm...>]

On Thu, Mar 18, 2010 at 2:59 AM, Rob Clark <ro...@ti...> wrote:
> Refactor some common functionality, in particular the settings_changed_cb,
> into an abstract base class.
> ---
>  omx/Makefile.am            |    1 +
>  omx/gstomx_aacdec.c        |   45 +--------------------
>  omx/gstomx_aacdec.h        |    6 +-
>  omx/gstomx_adpcmdec.c      |    1 +
>  omx/gstomx_amrnbdec.c      |   48 +---------------------
>  omx/gstomx_amrnbdec.h      |    6 +-
>  omx/gstomx_amrwbdec.c      |   48 +---------------------
>  omx/gstomx_amrwbdec.h      |    6 +-
>  omx/gstomx_base_audiodec.c |   97 ++++++++++++++++++++++++++++++++++++++++++++
>  omx/gstomx_base_audiodec.h |   53 ++++++++++++++++++++++++
>  omx/gstomx_g711dec.c       |    1 +
>  omx/gstomx_g729dec.c       |    4 +-
>  omx/gstomx_g729dec.h       |    6 +-
>  omx/gstomx_ilbcdec.c       |    1 +
>  omx/gstomx_mp2dec.c        |   55 +------------------------
>  omx/gstomx_mp2dec.h        |    6 +-
>  omx/gstomx_mp3dec.c        |   56 +-------------------------
>  omx/gstomx_mp3dec.h        |    6 +-
>  omx/gstomx_vorbisdec.c     |   45 +--------------------
>  omx/gstomx_vorbisdec.h     |    6 +-
>  20 files changed, 183 insertions(+), 314 deletions(-)
>  create mode 100644 omx/gstomx_base_audiodec.c
>  create mode 100644 omx/gstomx_base_audiodec.h

> diff --git a/omx/gstomx_base_audiodec.c b/omx/gstomx_base_audiodec.c
> new file mode 100644
> index 0000000..8dc37d7
> --- /dev/null
> +++ b/omx/gstomx_base_audiodec.c
> @@ -0,0 +1,97 @@
> +/*
> + * Copyright (C) 2009 Texas Instruments, Inc - http://www.ti.com/

Why the web url? I don't think that's customary.

> + * Description: Base audio decoder element
> + *  Created on: Aug 2, 2009
> + *      Author: Rob Clark <ro...@ti...>

I don't see the point of this. Author, yes, but date and description?
Perhaps the description would make sense if it's picked by the
automatic doc generator.

> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public
> + * License along with this library; if not, write to the
> + * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> + * Boston, MA 02111-1307, USA.
> + */

This copyright notice is not only outdated but doesn't match the rest
of the notices (not to mention that it's LGPL 2.1+ and not LGPL 2.1).

-- 
Felipe Contreras