Re: [Gstreamer-openmax] [PATCH 1/8] core: call OMX_GetHandle in g_omx_core_new

[Felipe C. <fel...@gm...>]

On Wed, Mar 24, 2010 at 12:36 AM, Clark, Rob <ro...@ti...> wrote:
> On Mar 23, 2010, at 5:25 PM, Felipe Contreras wrote:
>> I don't like this. It would be better to pass the GType directly.
>>
>> But also, it's messing up g_omx and gstomx_ functions... Can you move
>> g_omx_core_new to gstomx.c and make it gstomx_core_new() or something
>> like that?
>
> I could do that for now.
>
> But actually I would like to change the g_omx_ stuff to gstomx_..  I think there are some parts of logic, such as handling the share_buffer vs !share_buffer cases, which could be consolidated in GOmxPort (or GstOmxPort).  Similar for handling of EOS.

Yeah, I've been meaning to fix the share_buffer stuff like that, but I
haven't really looked into it. I don't think there's a need to mix gst
stuff though.

> And for upstream caps negotiation to work properly, we need to do a pad_alloc() before SendCommand(SetState, Idle) or SendCommand(EnablePort)..  which could be more easily done in one place in GOmxPort.

Haven't really thought about that... I would have to see the patches.

-- 
Felipe Contreras