Re: [Gstreamer-openmax] [PATCH 5/8] Add component-role support

[Felipe C. <fel...@gm...>]

On Thu, Mar 18, 2010 at 1:58 AM, Rob Clark <ro...@ti...> wrote:

> @@ -337,7 +339,23 @@ core_init (GOmxCore *core)
>             core->omx_handle, core->omx_error);
>
>     if (!core->omx_error)
> +    {
>         core->omx_state = OMX_StateLoaded;
> +
> +        if (core->component_role)
> +        {
> +            OMX_PARAM_COMPONENTROLETYPE param;
> +
> +            GST_DEBUG_OBJECT (core->object, "setting component role: %s",
> +                    core->component_role);
> +
> +            G_OMX_INIT_PARAM (param);
> +
> +            strcpy((char*)param.cRole, core->component_role);

How about strncpy with OMX_MAX_STRINGNAME_SIZE instead?

Otherwise looks ok. Thanks.

-- 
Felipe Contreras