Re: [Gstreamer-openmax] [PATCH 1/8] core: call OMX_GetHandle in g_omx_core_new

[Felipe C. <fel...@gm...>]

On Thu, Mar 18, 2010 at 1:58 AM, Rob Clark <ro...@ti...> wrote:
> This way omx_handle is always valid, and can be used in get/set_property
> methods.
> ---

> @@ -282,12 +285,22 @@ g_omx_core_new (void *object)
>
>     core->omx_state = OMX_StateInvalid;
>
> +    /* it is a bit awkward to have to pass the element's g_class to
> +     * g_omx_core_new(), but since this is called from type_inistance_init
> +     * function, we can't rely on G_OBJECT_TYPE()..
> +     */
> +    gstomx_get_component_info (core, G_TYPE_FROM_CLASS (g_class));

I don't like this. It would be better to pass the GType directly.

But also, it's messing up g_omx and gstomx_ functions... Can you move
g_omx_core_new to gstomx.c and make it gstomx_core_new() or something
like that?

Cheers.

-- 
Felipe Contreras