|
From: Felipe C. <fel...@gm...> - 2010-03-23 22:11:15
|
On Thu, Mar 18, 2010 at 12:50 AM, Rob Clark <ro...@ti...> wrote: > The port objects are constructed up in element constructor (so they are > valid at any point in the element's lifecycle), and bound to a port_index > at construction time, rather than getting constructed in setup_ports. > > This will be useful later to enable properties that directly set port > params. Looks fine to me but I recall making some comments on previous revisions. Did you forget to mention that in the commit message? -- Felipe Contreras |