Re: [Gstreamer-openmax] [PATCH 03/10] add accessor for OMX_HANDLE

[Felipe C. <fel...@gm...>]

On Tue, Mar 9, 2010 at 6:15 AM, Rob Clark <ro...@ti...> wrote:
> On Mar 8, 2010, at 10:09 AM, Felipe Contreras wrote:
>> I think I already said this before; if the core needs to be initialized
>> before; it should be initialized before, manually, and visibly. I think
>> that was the point of the config stuff; so that we can initialize the
>> core sooner.
>
> hmm, I didn't think a lazy initializer getter function was such a strange design pattern.

It's not about familiarity, it's about "goodness"... you can argue
that it's an anti-pattern :)

> but, that said, we could do GetHandle() when GOmxCore is constructed, and FreeHandle() when it is free'd.. but I have some worries that this would make things more prone to problems if the application (or playbin, etc) doesn't release the reference to the element.

I think discussed this offline after this mail was sent and the
consensus was that if this is indeed an issue it should be handled
either in the driver release() function, or on the library destructor
function. After all a process can be killed any time.

-- 
Felipe Contreras