Re: [Gstreamer-openmax] [PATCH 04/10] add some debug traces

[Felipe C. <fel...@no...>]

On Mon, Mar 08, 2010 at 12:14:51AM +0100, Rob Clark wrote:
> ---
>  omx/gstomx_util.c |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
> 
> diff --git a/omx/gstomx_util.c b/omx/gstomx_util.c
> index efe953d..b6633e4 100644
> --- a/omx/gstomx_util.c
> +++ b/omx/gstomx_util.c
> @@ -157,6 +157,9 @@ imp_new (const gchar *name)
>          void *handle;
>  
>          imp->dl_handle = handle = dlopen (name, RTLD_LAZY);
> +
> +        GST_DEBUG ("dlopen(%s) -> %p", name, handle);

I think this should be done before the dlopen(). Suppose dlopen()
crashes; we want the debug to appear before it does.

The rest looks ok.

-- 
Felipe Contreras