From: GStreamer (bugzilla.gnome.o. <bug...@gn...> - 2010-03-04 14:11:05
|
https://bugzilla.gnome.org/show_bug.cgi?id=611692 GStreamer | gstreamer (core) | git --- Comment #24 from Benjamin Otte (Company) <ot...@gn...> 2010-03-04 14:10:53 UTC --- (In reply to comment #20) > (From update of attachment 155119 [details]) > But what's with the gst_element_request_compatible_pad() (re-)addition? Why > first remove it in an earlier patch? Why not just make it static instead? > It seems I messed that up (forgetting --amend to git commit). I had wanted to merge the two commits and just declare that function static. Will fix that when I commit. (In reply to comment #19) > (From update of attachment 155124 [details]) > Not a big fan of this. I don't think this is useful in a GStreamer context. In > the one or two places where it might be useful (e.g. gstvideo) it should just > be added specifically. So -1 from me. This is just a nuisance. > -Wswitch-default is not a big of a problem usually - it's just "default: break" or "default: assert_not_reached(); break;", but it comes in very handy when you refactor things and add values to enums, because it will actually abort with the assertion while testing and not silently do nothing. I agree that from a code beauty and maintenance perspective it's not necessary. I also didn't find a bug while doing this, so it seems to get caught very well - unless you count the fact the GstStateTransition misses GST_STATE_FOO_TO_FOO transitions. -- Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. |