|
From: Felipe C. <fel...@no...> - 2010-03-03 09:59:42
|
On Wed, Mar 03, 2010 at 03:06:24AM +0100, Rob Clark wrote: > On Mar 2, 2010, at 6:35 PM, Felipe Contreras wrote: > > Note that here I'm not creating a file with the default_config. > > > > I think it's a bad idea; the conf file wouldn't be human readable, and > > in case gst-omx is updated with a new default_config it will not be > > used because the old one is already stored. > > re: human-readable: as long as you aren't using > gst_structure_to_string(), it should be readable.. Well, when I took a look at the file (which I scratched my head for quite some time trying to figure out how it got there) everything was on one line. So that's not readable to me. > re: writing default config: I was debating back and forth on this.. > it would be nice to make it easier for someone to take the current > config, and make a few tweaks. Maybe the better approach would be to > write out gst-openmax.conf-example which the user could modify and > rename if desired.. Yeah, in some kind of documentation, but we shouldn't polute the user's config directory. Most people wouldn't care about this, and if every project out there does this, it would be chaos. I don't recall any project doing something like this. The other option is to provide a system-wide config file instead, so the user can copy it to ~/.config, and then modify it. But in that case I'm against having an internal 'default_config'. In fact, now that I think again... most systems would rather have a system-wide config file. Cheers. -- Felipe Contreras |