From: GStreamer (bugzilla.gnome.org) <bug...@bu...> - 2008-03-12 07:10:35
|
If you have any questions why you received this email, please see the text at the end of this email. Replies to this email are NOT read, please see the text at the end of this email. You can add comments to this bug at: http://bugzilla.gnome.org/show_bug.cgi?id=396779 GStreamer | gstreamer (core) | Ver: HEAD CVS ------- Comment #65 from Stefan Kost (gstreamer, gtkdoc dev) 2008-03-12 07:10 UTC ------- If we want a "preset-name" iface property, so that we can specify a preset on gst-launch we need to decide now. If we add this later, elements that implement the iface, but which do not override the property will cause a warning (gst-inspect-0.10:23733): GLib-GObject-CRITICAL **: Object class GstSimSyn doesn't implement property 'preset-name' from interface 'GstPreset' Adding it on the preset-iface side is easy: gst_preset_base_init() will need: /* create interface properties, each element would need to override this * g_object_class_override_property(gobject_class, PROP_PRESET_NAME, "preset-name"); * and in _set_propert() do * case PROP_PRESET_NAME: { * gchar *name = g_value_get_string (value); * if (name) * gst_preset_load_preset(self, name); * } break; */ g_object_interface_install_property (g_class, g_param_spec_string ("preset-name", "preset-name property", "load given preset hen setting", NULL, G_PARAM_WRITABLE)); One more comment. If we decide for adding the iface to gstreamer core. I can do follow-up patches to support it in gst-inspect, so that it can show a list of presets. -- See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received this email, why you can't respond via email, how to stop receiving emails (or reduce the number you receive), and how to contact someone if you are having problems with the system. You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=396779. |