From: <sl...@ke...> - 2007-06-28 20:34:17
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Thu Jun 28 2007 20:34:05 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_handle_first_frame): Copy the complete Xing seek table in the 100 byte array instead of copying the first byte 100 times. * gst/mpegaudioparse/gstmpegaudioparse.c: (mp3parse_total_bytes), (mp3parse_total_time), (mp3parse_time_to_bytepos): Add seeking support based on the Xing header but comment it out for now as it seems to yield worse result than the other method. Also use gst_pad_query_peer_duration() instead of getting the peer pad ourself, creating a new GstQuery, etc. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2225&r2=1.2226 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.64&r2=1.65 |
From: <sl...@ke...> - 2007-07-01 19:12:56
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Sun Jul 01 2007 19:12:46 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_base_init), (gst_mp3parse_init): Use GST_BOILERPLATE instead of manual GType magic. * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_handle_first_frame), (mp3parse_time_to_bytepos), (mp3parse_bytepos_to_time): * gst/mpegaudioparse/gstmpegaudioparse.h: Implement seeking, byte->time, time->byte conversions with the Xing seek table if available. This allows better at least a bit more accurate seeks and file position reporting. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c gstmpegaudioparse.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2226&r2=1.2227 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.65&r2=1.66 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.h.diff?r1=1.16&r2=1.17 |
From: <sl...@ke...> - 2007-07-13 16:28:22
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Fri Jul 13 2007 16:28:11 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_reset), (gst_mp3parse_init), (gst_mp3parse_dispose), (gst_mp3parse_sink_event), (mp3parse_seek_table_last_entry), (gst_mp3parse_emit_frame), (gst_mp3parse_chain), (mp3parse_handle_seek), (mp3parse_src_query): * gst/mpegaudioparse/gstmpegaudioparse.h: Implement accurate seeking in mpegaudioparse. Fixes #308312. Also implement segment seeks. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c gstmpegaudioparse.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2235&r2=1.2236 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.66&r2=1.67 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.h.diff?r1=1.17&r2=1.18 |
From: <sl...@ke...> - 2007-07-18 17:52:19
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Wed Jul 18 2007 17:52:09 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_reset), (gst_mp3parse_emit_frame), (mp3parse_handle_seek): * gst/mpegaudioparse/gstmpegaudioparse.h: Save some memory for each frame by only saving the start timestamp and start byte position instead of additionally the stop timestamp and stop byte position. This requires us to use a doubly-linked list but still saves 8-12 bytes per frame. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c gstmpegaudioparse.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2239&r2=1.2240 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.68&r2=1.69 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.h.diff?r1=1.18&r2=1.19 |
From: <sl...@ke...> - 2007-12-13 12:36:12
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Thu Dec 13 2007 11:20:25 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_sink_event), (mp3parse_handle_seek): Don't post SEGMENT_START messages on the bus, only the element driving the pipeline should do that. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2293&r2=1.2294 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.76&r2=1.77 |
From: <sl...@ke...> - 2008-01-14 09:13:43
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon Jan 14 2008 09:13:43 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_handle_first_frame): Guard against 0 values in the Xing header as frame count and byte count and calculate the bitrate when we have all values we need and not before. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2303&r2=1.2304 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.78&r2=1.79 |
From: <sl...@ke...> - 2008-01-14 10:42:59
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon Jan 14 2008 10:43:02 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_reset), (gst_mp3parse_emit_frame), (gst_mp3parse_handle_first_frame), (mp3parse_total_bytes), (mp3parse_total_time): * gst/mpegaudioparse/gstmpegaudioparse.h: Add initial support for reading VBRI headers as found in VBR files created by some Fraunhofer encoders. Currently we only read the number of frames and bytes (and calculate duration, etc from this) but there is also a seek table that we currently don't use. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c gstmpegaudioparse.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2305&r2=1.2306 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.79&r2=1.80 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.h.diff?r1=1.20&r2=1.21 |
From: <sl...@ke...> - 2008-01-14 15:02:23
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon Jan 14 2008 15:02:28 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_reset), (gst_mp3parse_handle_first_frame), (mp3parse_time_to_bytepos), (mp3parse_bytepos_to_time): * gst/mpegaudioparse/gstmpegaudioparse.h: Add support for seeking based on the VBRI seek table. Might make sense to use interpolation in the table later to get hopefully a bit more accurate values. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c gstmpegaudioparse.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2308&r2=1.2309 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.80&r2=1.81 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.h.diff?r1=1.21&r2=1.22 |
From: <sl...@ke...> - 2008-01-15 17:18:41
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Tue Jan 15 2008 17:18:45 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_handle_first_frame), (mp3parse_time_to_bytepos), (mp3parse_bytepos_to_time): Interpolate the VBRI seek table entries to get better results, support 3 byte seek table entries and prevent overflows in the seek table by adding the relative offsets when using the seek table in a large enough data type. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2309&r2=1.2310 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.81&r2=1.82 |
From: <sl...@ke...> - 2008-01-29 19:10:48
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Tue Jan 29 2008 19:10:53 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (mp3_caps_create), (gst_mp3parse_chain): Don't set new caps on the srcpad everytime the bitrate or MPEG version changes but calculate new spf value when the MPEG version changes. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2314&r2=1.2315 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.82&r2=1.83 |
From: <sl...@ke...> - 2008-02-11 13:29:16
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon Feb 11 2008 13:29:21 UTC Log message: * gst/mpegaudioparse/gstxingmux.c: (generate_xing_header): Correctly write the size in bytes on big endian systems. Fixes bug #515725. Modified files: . : ChangeLog gst/mpegaudioparse: gstxingmux.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2322&r2=1.2323 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstxingmux.c.diff?r1=1.12&r2=1.13 |
From: <sl...@ke...> - 2008-02-14 13:58:51
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Thu Feb 14 2008 13:58:56 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_emit_frame): Return GST_FLOW_UNEXPECTED if we get data that is after our configured segment. This makes upstream go EOS immediately instead of sending us the complete stream. Also improve debugging a bit. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2326&r2=1.2327 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.85&r2=1.86 |
From: <sl...@ke...> - 2008-02-18 10:25:25
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon Feb 18 2008 10:25:31 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_emit_frame): Handler buffers without valid timestamp more correctly: Don't drop them and don't use the invalid timestamp to calculate the next timestamp. Fixes bug #516811. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2329&r2=1.2330 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.87&r2=1.88 |
From: <sl...@ke...> - 2008-02-22 06:25:39
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Fri Feb 22 2008 06:25:43 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_emit_frame), (gst_mp3parse_chain): Try a bit harder to get valid timestamps, especially if upstream gives us one and we are at the first frame or resyncing. Return UNEXPECTED if we get a valid timestamp that is outside of our configured segment. After all changes done so far this doesn't seem to cause any regression, please test. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2334&r2=1.2335 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.88&r2=1.89 |
From: <sl...@ke...> - 2008-02-22 07:11:26
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Fri Feb 22 2008 07:11:32 UTC Log message: Patch by: Thiago Sousa Santos <thiagoss at lcc dot ufcg dot edu dot br> * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3_channel_mode_get_type), (mp3_type_frame_length_from_header), (gst_mp3parse_class_init), (gst_mp3parse_reset), (gst_mp3parse_emit_frame), (gst_mp3parse_chain): * gst/mpegaudioparse/gstmpegaudioparse.h: Post channel mode and CRC as tags. Fixes bug #504493. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c gstmpegaudioparse.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2336&r2=1.2337 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.89&r2=1.90 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.h.diff?r1=1.22&r2=1.23 |
From: <sl...@ke...> - 2008-02-27 12:48:49
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Wed Feb 27 2008 12:48:55 UTC Log message: * gst/mpegaudioparse/gstxingmux.c: (get_xing_offset): Write Xing header at the correct position in the MP3 frame for stereo files. Fixes bug #518676. Modified files: . : ChangeLog gst/mpegaudioparse: gstxingmux.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2339&r2=1.2340 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstxingmux.c.diff?r1=1.13&r2=1.14 |
From: <sl...@ke...> - 2008-03-12 16:09:57
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Wed Mar 12 2008 16:10:02 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_sink_event): Don't take the stream lock when caching events. This is not necessary and results in a deadlock when seeking with rhythmbox (but not with totem or banshee for some reason). Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2346&r2=1.2347 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.93&r2=1.94 |
From: <sl...@ke...> - 2008-04-03 15:22:12
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Thu Apr 03 2008 15:22:04 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (mpeg_audio_seek_entry_new), (mpeg_audio_seek_entry_free), (gst_mp3parse_reset), (gst_mp3parse_emit_frame): * gst/mpegaudioparse/gstxingmux.c: (gst_xing_seek_entry_new), (gst_xing_seek_entry_free), (gst_xing_mux_finalize), (xing_reset), (gst_xing_mux_chain): Use GSlice for allocating the seek table entries if we compile with GLib 2.10 or newer. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c gstxingmux.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2352&r2=1.2353 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.94&r2=1.95 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstxingmux.c.diff?r1=1.14&r2=1.15 |
From: <sl...@ke...> - 2008-04-04 19:04:28
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Fri Apr 04 2008 19:04:34 UTC Log message: * configure.ac: * gst/mpegaudioparse/gstmpegaudioparse.c: (mpeg_audio_seek_entry_free): * gst/mpegaudioparse/gstxingmux.c: (gst_xing_seek_entry_free): Depend on GLib 2.12 and use it unconditionally as we do in other modules too already. Modified files: . : ChangeLog configure.ac gst/mpegaudioparse: gstmpegaudioparse.c gstxingmux.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2353&r2=1.2354 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/configure.ac.diff?r1=1.664&r2=1.665 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.95&r2=1.96 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstxingmux.c.diff?r1=1.15&r2=1.16 |
From: <sl...@ke...> - 2008-05-05 08:43:47
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon May 05 2008 08:43:52 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_emit_frame): Send a new duration message if the average bitrate changed and we don't know the duration from the Xing or VBRI header. Fixes bug #321857. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2361&r2=1.2362 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.96&r2=1.97 |
From: <sl...@ke...> - 2008-05-26 07:41:31
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon May 26 2008 07:41:40 UTC Log message: * gst/mpegaudioparse/gstxingmux.c: (generate_xing_header): Fix alignment issues that caused SIGBUS on some architectures. Modified files: . : ChangeLog gst/mpegaudioparse: gstxingmux.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2375&r2=1.2376 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstxingmux.c.diff?r1=1.17&r2=1.18 |
From: <sl...@ke...> - 2008-06-09 07:51:12
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon Jun 09 2008 07:51:14 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (head_check): Don't mark MPEG headers with emphasis == 0x2 as invalid. This emphasis value is reserved but unfortunately files with that value exist and the information is not important for the decoder anyway. Fixes bug #537235. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2380&r2=1.2381 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.98&r2=1.99 |
From: <sl...@ke...> - 2008-07-31 14:35:46
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Thu Jul 31 2008 14:35:55 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_sink_event), (gst_mp3parse_emit_frame), (mp3parse_total_time), (mp3parse_bytepos_to_time): Don't recurse from mp3parse_bytepos_to_time() to mp3parse_total_time() if we're called from there already. Otherwise we end up in a endless recursion and crash with a stack overflow. This can happen when a Xing or VBRI header with TOC exists but it doesn't contain the total time. Fixes bug #545370. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2397&r2=1.2398 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.101&r2=1.102 |
From: <sl...@ke...> - 2008-10-13 09:07:10
|
CVS Root: /cvs/gstreamer Module: gst-plugins-ugly Changes by: slomo Date: Mon Oct 13 2008 09:04:30 UTC Log message: * gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_sink_event): Post a GST_ELEMENT_ERROR if we get EOS before seeing any valid frames. Partially fixes bug #552237. Modified files: . : ChangeLog gst/mpegaudioparse: gstmpegaudioparse.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/ChangeLog.diff?r1=1.2419&r2=1.2420 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins-ugly/gst/mpegaudioparse/gstmpegaudioparse.c.diff?r1=1.102&r2=1.103 |