From: <en...@ke...> - 2008-04-23 10:14:50
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Apr 23 2008 10:14:52 UTC Log message: * gst/gstsegment.c: The glib macro seems to be borked. Use g_slice_copy directly and cast in the hope that this fixes the warning on 64bit. Modified files: . : ChangeLog gst : gstsegment.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3800&r2=1.3801 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstsegment.c.diff?r1=1.33&r2=1.34 ====Begin Diffs==== Index: gstsegment.c =================================================================== RCS file: /cvs/gstreamer/gstreamer/gst/gstsegment.c,v retrieving revision 1.33 retrieving revision 1.34 diff -u -d -r1.33 -r1.34 --- gstsegment.c 23 Apr 2008 07:08:53 -0000 1.33 +++ gstsegment.c 23 Apr 2008 10:14:38 -0000 1.34 @@ -99,7 +99,7 @@ GstSegment *result = NULL; if (segment) { - result = g_slice_dup (GstSegment, segment); + result = (GstSegment *) g_slice_copy (sizeof (GstSegment), segment); } return result; } Index: ChangeLog RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3800 retrieving revision 1.3801 diff -u -d -r1.3800 -r1.3801 --- ChangeLog 23 Apr 2008 07:08:51 -0000 1.3800 +++ ChangeLog 23 Apr 2008 10:14:36 -0000 1.3801 @@ -1,6 +1,12 @@ 2008-04-23 Stefan Kost <en...@us...> * gst/gstsegment.c: + The glib macro seems to be borked. Use g_slice_copy directly and cast + in the hope that this fixes the warning on 64bit. + +2008-04-23 Stefan Kost <en...@us...> + * gst/gstsegment.c: Document the new function. Use g_slice_dup() (no need for gst_segment_init()). |
From: <en...@ke...> - 2008-04-23 13:55:30
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Apr 23 2008 13:55:15 UTC Log message: * gst/gstregistry.c: Improve the documentation. Modified files: . : ChangeLog gst : gstregistry.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3801&r2=1.3802 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistry.c.diff?r1=1.78&r2=1.79 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3801 retrieving revision 1.3802 diff -u -d -r1.3801 -r1.3802 --- ChangeLog 23 Apr 2008 10:14:36 -0000 1.3801 +++ ChangeLog 23 Apr 2008 13:54:59 -0000 1.3802 @@ -1,5 +1,10 @@ 2008-04-23 Stefan Kost <en...@us...> + * gst/gstregistry.c: + Improve the documentation. + +2008-04-23 Stefan Kost <en...@us...> * gst/gstsegment.c: The glib macro seems to be borked. Use g_slice_copy directly and cast in the hope that this fixes the warning on 64bit. Index: gstregistry.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistry.c,v retrieving revision 1.78 retrieving revision 1.79 diff -u -d -r1.78 -r1.79 --- gstregistry.c 11 Apr 2008 09:27:44 -0000 1.78 +++ gstregistry.c 23 Apr 2008 13:55:01 -0000 1.79 @@ -545,7 +545,8 @@ * If the first flag is set, only the first match is * returned (as a list with a single object). * - * Returns: a GList of plugin features, gst_plugin_feature_list_free after use. + * Returns: a #GList of #GstPluginFeature. Use gst_plugin_list_free() after + * usage. * MT safe. */ @@ -652,8 +653,8 @@ * Retrieves a #GList of #GstPluginFeature of @type. - * Returns: a #GList of #GstPluginFeature of @type. gst_plugin_feature_list_free - * after usage. + * Returns: a #GList of #GstPluginFeature of @type. Use + * gst_plugin_feature_list_free() after usage. @@ -680,7 +681,7 @@ * Get a copy of all plugins registered in the given registry. The refcount * of each element in the list in incremented. - * Returns: a #GList of #GstPlugin. gst_plugin_list_free after use. + * Returns: a #GList of #GstPlugin. Use gst_plugin_list_free() after usage. @@ -990,7 +991,8 @@ * Retrieves a #GList of features of the plugin with name @name. - * Returns: a #GList of #GstPluginFeature. gst_plugin_feature_list_free() after usage. + * Returns: a #GList of #GstPluginFeature. Use gst_plugin_feature_list_free() + * after usage. GList * gst_registry_get_feature_list_by_plugin (GstRegistry * registry, |
From: <en...@ke...> - 2008-04-24 06:47:01
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Apr 24 2008 06:47:08 UTC Log message: * gst/gstregistry.c: Tell the *truth* when improving the documentation. Modified files: . : ChangeLog gst : gstregistry.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3803&r2=1.3804 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistry.c.diff?r1=1.79&r2=1.80 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3803 retrieving revision 1.3804 diff -u -d -r1.3803 -r1.3804 --- ChangeLog 23 Apr 2008 14:54:17 -0000 1.3803 +++ ChangeLog 24 Apr 2008 06:46:52 -0000 1.3804 @@ -1,3 +1,8 @@ +2008-04-24 Stefan Kost <en...@us...> + + * gst/gstregistry.c: + Tell the *truth* when improving the documentation. 2008-04-23 Sebastian Dröge <sl...@ci...> * gst/gstelementfactory.c: (gst_element_factory_make): Index: gstregistry.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistry.c,v retrieving revision 1.79 retrieving revision 1.80 diff -u -d -r1.79 -r1.80 --- gstregistry.c 23 Apr 2008 13:55:01 -0000 1.79 +++ gstregistry.c 24 Apr 2008 06:46:54 -0000 1.80 @@ -545,8 +545,8 @@ * If the first flag is set, only the first match is * returned (as a list with a single object). * - * Returns: a #GList of #GstPluginFeature. Use gst_plugin_list_free() after - * usage. + * Returns: a #GList of #GstPluginFeature. Use gst_plugin_feature_list_free() + * after usage. * MT safe. */ |
From: <en...@ke...> - 2008-04-24 08:28:15
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Apr 24 2008 08:28:13 UTC Log message: * gst/gstregistrybinary.c: Add a warning of we hit unhandled factories when saving. More debug logging detail, but move to LOG category. Modified files: . : ChangeLog gst : gstregistrybinary.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3804&r2=1.3805 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistrybinary.c.diff?r1=1.31&r2=1.32 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3804 retrieving revision 1.3805 diff -u -d -r1.3804 -r1.3805 --- ChangeLog 24 Apr 2008 06:46:52 -0000 1.3804 +++ ChangeLog 24 Apr 2008 08:27:57 -0000 1.3805 @@ -1,5 +1,11 @@ 2008-04-24 Stefan Kost <en...@us...> + * gst/gstregistrybinary.c: + Add a warning of we hit unhandled factories when saving. + More debug logging detail, but move to LOG category. + +2008-04-24 Stefan Kost <en...@us...> * gst/gstregistry.c: Tell the *truth* when improving the documentation. Index: gstregistrybinary.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistrybinary.c,v retrieving revision 1.31 retrieving revision 1.32 diff -u -d -r1.31 -r1.32 --- gstregistrybinary.c 19 Apr 2008 15:42:19 -0000 1.31 +++ gstregistrybinary.c 24 Apr 2008 08:27:59 -0000 1.32 @@ -545,7 +545,7 @@ goto fail; } } - GST_DEBUG ("Save plugin '%s' with %d features", plugin->desc.name, + GST_DEBUG ("Save plugin '%s' with %d feature(s)", plugin->desc.name, pe->nfeatures); gst_plugin_feature_list_free (plugin_features); @@ -949,6 +949,10 @@ unpack_string (*in, factory->longdesc); #endif + else { + GST_WARNING ("unhandled factory type : %s", G_OBJECT_TYPE_NAME (feature)); + goto fail; + } feature->rank = pf->rank; @@ -1016,13 +1020,20 @@ unpack_const_string (*in, plugin->desc.source); unpack_const_string (*in, plugin->desc.package); unpack_const_string (*in, plugin->desc.origin); - GST_LOG ("read strings for '%s'", plugin->desc.name); + GST_LOG ("read strings for name='%s'", plugin->desc.name); + GST_LOG (" desc.description='%s'", plugin->desc.description); + GST_LOG (" filename='%s'", plugin->filename); + GST_LOG (" desc.version='%s'", plugin->desc.version); + GST_LOG (" desc.license='%s'", plugin->desc.license); + GST_LOG (" desc.source='%s'", plugin->desc.source); + GST_LOG (" desc.package='%s'", plugin->desc.package); + GST_LOG (" desc.origin='%s'", plugin->desc.origin); plugin->basename = g_path_get_basename (plugin->filename); /* Takes ownership of plugin */ gst_registry_add_plugin (registry, plugin); - GST_INFO ("Added plugin '%s' plugin with %d features from binary registry", + GST_DEBUG ("Added plugin '%s' plugin with %d features from binary registry", plugin->desc.name, pe->nfeatures); for (i = 0; i < pe->nfeatures; i++) { if (!gst_registry_binary_load_feature (registry, in, plugin->desc.name)) { |
From: <en...@ke...> - 2008-04-30 14:40:22
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Apr 30 2008 07:56:53 UTC Log message: * gst/gstdebugutils.c: Refactor code and fix handling of ghostpads and their proxypads. Modified files: . : ChangeLog gst : gstdebugutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3815&r2=1.3816 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstdebugutils.c.diff?r1=1.16&r2=1.17 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3815 retrieving revision 1.3816 diff -u -d -r1.3815 -r1.3816 --- ChangeLog 29 Apr 2008 11:23:47 -0000 1.3815 +++ ChangeLog 30 Apr 2008 07:56:36 -0000 1.3816 @@ -1,3 +1,8 @@ +2008-04-30 Stefan Kost <en...@us...> + + * gst/gstdebugutils.c: + Refactor code and fix handling of ghostpads and their proxypads. 2008-04-29 Wim Taymans <wim...@co...> * docs/gst/gstreamer-sections.txt: Index: gstdebugutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstdebugutils.c,v retrieving revision 1.16 retrieving revision 1.17 diff -u -d -r1.16 -r1.17 --- gstdebugutils.c 31 Mar 2008 07:49:26 -0000 1.16 +++ gstdebugutils.c 30 Apr 2008 07:56:39 -0000 1.17 @@ -119,6 +119,225 @@ return param_name; } +static void +debug_dump_element_pad (GstPad * pad, GstElement * element, + GstDebugGraphDetails details, FILE * out, const gint indent) +{ + GstElement *target_element; + GstPad *target_pad, *tmp_pad; + GstPadDirection dir; + guint src_pads, sink_pads; + gchar *pad_name, *element_name; + gchar *target_pad_name, *target_element_name; + gchar *color_name; + gchar *spc = NULL; + spc = g_malloc (1 + indent * 2); + memset (spc, 32, indent * 2); + spc[indent * 2] = '\0'; + dir = gst_pad_get_direction (pad); + pad_name = debug_dump_make_object_name (GST_OBJECT (pad)); + element_name = debug_dump_make_object_name (GST_OBJECT (element)); + if (GST_IS_GHOST_PAD (pad)) { + color_name = + (dir == GST_PAD_SRC) ? "#ffdddd" : ((dir == + GST_PAD_SINK) ? "#ddddff" : "#ffffff"); + /* output target-pad so that it belongs to this element */ + if ((tmp_pad = gst_ghost_pad_get_target (GST_GHOST_PAD (pad)))) { + if ((target_pad = gst_pad_get_peer (tmp_pad))) { + target_pad_name = debug_dump_make_object_name (GST_OBJECT (target_pad)); + if ((target_element = gst_pad_get_parent_element (target_pad))) { + target_element_name = + debug_dump_make_object_name (GST_OBJECT (target_element)); + } else { + target_element_name = ""; + } + fprintf (out, + "%s %s_%s [color=black, fillcolor=\"%s\", label=\"%s\"];\n", + spc, target_element_name, target_pad_name, color_name, + GST_OBJECT_NAME (target_pad)); + g_free (target_pad_name); + if (target_element) { + g_free (target_element_name); + gst_object_unref (target_element); + gst_object_unref (target_pad); + } + gst_object_unref (tmp_pad); + } + } else { + (dir == GST_PAD_SRC) ? "#ffaaaa" : ((dir == + GST_PAD_SINK) ? "#aaaaff" : "#cccccc"); + } + /* pads */ + fprintf (out, + "%s %s_%s [color=black, fillcolor=\"%s\", label=\"%s\"];\n", + spc, element_name, pad_name, color_name, GST_OBJECT_NAME (pad)); + if (dir == GST_PAD_SRC) + src_pads++; + else if (dir == GST_PAD_SINK) + sink_pads++; + g_free (pad_name); + g_free (element_name); +} +debug_dump_element_pad_link (GstPad * pad, GstElement * element, + GstElement *peer_element, *target_element; + GstPad *peer_pad, *target_pad, *tmp_pad; + GstCaps *caps; + GstStructure *structure; + gboolean free_caps, free_media; + gchar *media = NULL; + gchar *peer_pad_name, *peer_element_name; + if ((peer_pad = gst_pad_get_peer (pad))) { + free_media = FALSE; + if ((details & GST_DEBUG_GRAPH_SHOW_MEDIA_TYPE) || + (details & GST_DEBUG_GRAPH_SHOW_CAPS_DETAILS) + ) { + if ((caps = gst_pad_get_negotiated_caps (pad))) { + free_caps = TRUE; + } else { + free_caps = FALSE; + if (!(caps = (GstCaps *) + gst_pad_get_pad_template_caps (pad))) { + /* this should not happen */ + media = "?"; + if (caps) { + if (details & GST_DEBUG_GRAPH_SHOW_CAPS_DETAILS) { + gchar *tmp = g_strdelimit (gst_caps_to_string (caps), ",", + '\n'); + media = g_strescape (tmp, NULL); + free_media = TRUE; + g_free (tmp); + if (GST_CAPS_IS_SIMPLE (caps)) { + structure = gst_caps_get_structure (caps, 0); + media = (gchar *) gst_structure_get_name (structure); + } else + media = "*"; + if (free_caps) { + gst_caps_unref (caps); + pad_name = debug_dump_make_object_name (GST_OBJECT (pad)); + if (element) { + element_name = debug_dump_make_object_name (GST_OBJECT (element)); + } else { + element_name = ""; + peer_pad_name = debug_dump_make_object_name (GST_OBJECT (peer_pad)); + if ((peer_element = gst_pad_get_parent_element (peer_pad))) { + peer_element_name = + debug_dump_make_object_name (GST_OBJECT (peer_element)); + peer_element_name = ""; + if (GST_IS_GHOST_PAD (pad)) { + if ((tmp_pad = gst_ghost_pad_get_target (GST_GHOST_PAD (pad)))) { + if ((target_pad = gst_pad_get_peer (tmp_pad))) { + target_pad_name = + debug_dump_make_object_name (GST_OBJECT (target_pad)); + if ((target_element = gst_pad_get_parent_element (target_pad))) { + target_element_name = + debug_dump_make_object_name (GST_OBJECT (target_element)); + } else { + target_element_name = ""; + } + /* src ghostpad relationship */ + fprintf (out, "%s%s_%s -> %s_%s [style=dashed]\n", spc, + target_element_name, target_pad_name, element_name, pad_name); + g_free (target_pad_name); + if (target_element) { + g_free (target_element_name); + gst_object_unref (target_element); + gst_object_unref (target_pad); + gst_object_unref (tmp_pad); + if (GST_IS_GHOST_PAD (peer_pad)) { + if ((tmp_pad = gst_ghost_pad_get_target (GST_GHOST_PAD (peer_pad)))) { + /* sink ghostpad relationship */ + peer_element_name, peer_pad_name, + target_element_name, target_pad_name); + /* FIXME: we are missing links from the proxy pad + * theoretically we need to: + * pad=gst_object_ref(target_pad); + * goto line 280: if ((peer_pad = gst_pad_get_peer (pad))) + * as this would e ugly we need to refactor ... + */ + debug_dump_element_pad_link (target_pad, target_element, details, out, + indent); + /* pad link */ + if (media) { + fprintf (out, "%s%s_%s -> %s_%s [label=\"%s\"]\n", spc, + element_name, pad_name, peer_element_name, peer_pad_name, media); + if (free_media) { + g_free (media); + fprintf (out, "%s%s_%s -> %s_%s\n", spc, + element_name, pad_name, peer_element_name, peer_pad_name); + g_free (pad_name); + g_free (element_name); + g_free (peer_pad_name); + if (peer_element) { + g_free (peer_element_name); + gst_object_unref (peer_element); + gst_object_unref (peer_pad); /* * debug_dump_element: * @bin: the bin that should be analyzed @@ -133,18 +352,11 @@ { GstIterator *element_iter, *pad_iter; gboolean elements_done, pads_done; - GstElement *element, *peer_element, *target_element; - GstPad *pad, *peer_pad, *target_pad, *tmp_pad; + GstElement *element; + GstPad *pad; GstPadDirection dir; - GstCaps *caps; - GstStructure *structure; - gboolean free_caps, free_media; guint src_pads, sink_pads; - gchar *media = NULL; - gchar *pad_name, *element_name; - gchar *peer_pad_name, *peer_element_name; - gchar *target_pad_name, *target_element_name; - gchar *color_name; + gchar *element_name; gchar *state_name = NULL; gchar *param_name = NULL; gchar *spc = NULL; @@ -192,31 +404,12 @@ while (!pads_done) { switch (gst_iterator_next (pad_iter, (gpointer) & pad)) { case GST_ITERATOR_OK: + debug_dump_element_pad (pad, element, details, out, indent); dir = gst_pad_get_direction (pad); - pad_name = debug_dump_make_object_name (GST_OBJECT (pad)); - element_name = - debug_dump_make_object_name (GST_OBJECT (element)); - if (GST_IS_GHOST_PAD (pad)) { - color_name = - (dir == GST_PAD_SRC) ? "#ffdddd" : ((dir == - GST_PAD_SINK) ? "#ddddff" : "#ffffff"); - } else { - (dir == GST_PAD_SRC) ? "#ffaaaa" : ((dir == - GST_PAD_SINK) ? "#aaaaff" : "#cccccc"); - } - /* pads */ - fprintf (out, - "%s %s_%s [color=black, fillcolor=\"%s\", label=\"%s\"];\n", - spc, element_name, pad_name, color_name, - GST_OBJECT_NAME (pad)); - if (dir == GST_PAD_SRC) src_pads++; else if (dir == GST_PAD_SINK) sink_pads++; - g_free (pad_name); - g_free (element_name); gst_object_unref (pad); break; case GST_ITERATOR_RESYNC: @@ -252,141 +445,8 @@ if (gst_pad_is_linked (pad) && gst_pad_get_direction (pad) == GST_PAD_SRC) { - if ((peer_pad = gst_pad_get_peer (pad))) { - free_media = FALSE; - if ((details & GST_DEBUG_GRAPH_SHOW_MEDIA_TYPE) || - (details & GST_DEBUG_GRAPH_SHOW_CAPS_DETAILS) - ) { - if ((caps = gst_pad_get_negotiated_caps (pad))) { - free_caps = TRUE; - } else { - free_caps = FALSE; - if (!(caps = (GstCaps *) - gst_pad_get_pad_template_caps (pad))) { - /* this should not happen */ - media = "?"; - } - } - if (caps) { - if (details & GST_DEBUG_GRAPH_SHOW_CAPS_DETAILS) { - gchar *tmp = - g_strdelimit (gst_caps_to_string (caps), ",", - '\n'); - media = g_strescape (tmp, NULL); - free_media = TRUE; - g_free (tmp); - } else { - if (GST_CAPS_IS_SIMPLE (caps)) { - structure = gst_caps_get_structure (caps, 0); - media = - (gchar *) gst_structure_get_name (structure); - } else - media = "*"; - if (free_caps) { - gst_caps_unref (caps); - } - pad_name = debug_dump_make_object_name (GST_OBJECT (pad)); - element_name = - debug_dump_make_object_name (GST_OBJECT (element)); - peer_pad_name = - debug_dump_make_object_name (GST_OBJECT (peer_pad)); - if ((peer_element = gst_pad_get_parent_element (peer_pad))) { - peer_element_name = - debug_dump_make_object_name (GST_OBJECT - (peer_element)); - } else { - peer_element_name = ""; - /* pad link */ - if (media) { - fprintf (out, "%s%s_%s -> %s_%s [label=\"%s\"]\n", spc, - element_name, pad_name, peer_element_name, - peer_pad_name, media); - if (free_media) { - g_free (media); - fprintf (out, "%s%s_%s -> %s_%s\n", spc, - peer_pad_name); - if (GST_IS_GHOST_PAD (pad)) { - if ((tmp_pad = - gst_ghost_pad_get_target (GST_GHOST_PAD (pad)))) { - if ((target_pad = gst_pad_get_peer (tmp_pad))) { - target_pad_name = - debug_dump_make_object_name (GST_OBJECT - (target_pad)); - if ((target_element = - gst_pad_get_parent_element (target_pad))) { - target_element_name = - debug_dump_make_object_name (GST_OBJECT - (target_element)); - } else { - target_element_name = ""; - } - /* src ghostpad relationship */ - fprintf (out, "%s%s_%s -> %s_%s [style=dashed]\n", - spc, target_element_name, target_pad_name, - element_name, pad_name); - g_free (target_pad_name); - if (target_element) { - g_free (target_element_name); - gst_object_unref (target_element); - gst_object_unref (target_pad); - gst_object_unref (tmp_pad); - if (GST_IS_GHOST_PAD (peer_pad)) { - gst_ghost_pad_get_target (GST_GHOST_PAD - (peer_pad)))) { - /* sink ghostpad relationship */ - spc, peer_element_name, peer_pad_name, - target_element_name, target_pad_name); - g_free (pad_name); - g_free (element_name); - g_free (peer_pad_name); - if (peer_element) { - g_free (peer_element_name); - gst_object_unref (peer_element); - gst_object_unref (peer_pad); - } + debug_dump_element_pad_link (pad, element, details, out, + indent); } |
From: <en...@ke...> - 2008-05-14 18:17:42
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed May 14 2008 18:17:49 UTC Log message: * gst/gstinfo.c: Explain why we copy the list. * gst/gstpipeline.c: Improve docs. * gst/gstutils.c: Add one debug-log statement to help tracing probelms with linking pads. Modified files: . : ChangeLog gst : gstinfo.c gstpipeline.c gstutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3852&r2=1.3853 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstinfo.c.diff?r1=1.147&r2=1.148 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpipeline.c.diff?r1=1.148&r2=1.149 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstutils.c.diff?r1=1.177&r2=1.178 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3852 retrieving revision 1.3853 diff -u -d -r1.3852 -r1.3853 --- ChangeLog 14 May 2008 18:08:59 -0000 1.3852 +++ ChangeLog 14 May 2008 18:17:32 -0000 1.3853 @@ -1,3 +1,14 @@ +2008-05-14 Stefan Kost <en...@us...> + + * gst/gstinfo.c: + Explain why we copy the list. + * gst/gstpipeline.c: + Improve docs. + * gst/gstutils.c: + Add one debug-log statement to help tracing probelms with linking pads. 2008-05-12 Stefan Kost <en...@us...> * tests/check/gst/gstinfo.c: Index: gstinfo.c RCS file: /cvs/gstreamer/gstreamer/gst/gstinfo.c,v retrieving revision 1.147 retrieving revision 1.148 diff -u -d -r1.147 -r1.148 --- gstinfo.c 7 May 2008 19:24:44 -0000 1.147 +++ gstinfo.c 14 May 2008 18:17:34 -0000 1.148 @@ -799,6 +799,8 @@ new = __log_functions; while ((found = g_slist_find_custom (new, data, func))) { if (new == __log_functions) { + /* make a copy when we have the first hit, so that we modify the copy and + * make that the new list later */ new = g_slist_copy (new); continue; } Index: gstpipeline.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpipeline.c,v retrieving revision 1.149 diff -u -d -r1.148 -r1.149 --- gstpipeline.c 22 Mar 2008 14:56:12 -0000 1.148 +++ gstpipeline.c 14 May 2008 18:17:34 -0000 1.149 @@ -563,7 +563,7 @@ * gst_pipeline_get_bus: * @pipeline: a #GstPipeline * - * Gets the #GstBus of @pipeline. + * Gets the #GstBus of @pipeline. The bus allows applications to receive #GstMessages. * Returns: a #GstBus, unref after usage. Index: gstutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstutils.c,v retrieving revision 1.177 retrieving revision 1.178 diff -u -d -r1.177 -r1.178 --- gstutils.c 17 Apr 2008 08:34:14 -0000 1.177 +++ gstutils.c 14 May 2008 18:17:34 -0000 1.178 @@ -959,6 +959,10 @@ } gst_iterator_free (pads); + GST_CAT_DEBUG_OBJECT (GST_CAT_ELEMENT_PADS, element, + "Could not find a compatible unlinked always pad to link to %s:%s, now checking request pads", + GST_DEBUG_PAD_NAME (pad)); /* try to create a new one */ /* requesting is a little crazy, we need a template. Let's create one */ templcaps = gst_pad_get_caps (pad); |
From: <en...@ke...> - 2008-07-01 05:53:36
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Jul 01 2008 05:53:46 UTC Log message: * gst/gstevent.c: Use gst_format_get_name() to improve debug output. * gst/gstpreset.c: Remove #ifdef'ed code. Add TODO comment. * gst/gstsegment.c: Add debug output to ease spotting format != segment.format assertions. Modified files: . : ChangeLog gst : gstevent.c gstpreset.c gstsegment.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3957&r2=1.3958 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstevent.c.diff?r1=1.115&r2=1.116 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.c.diff?r1=1.14&r2=1.15 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstsegment.c.diff?r1=1.35&r2=1.36 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3957 retrieving revision 1.3958 diff -u -d -r1.3957 -r1.3958 --- ChangeLog 30 Jun 2008 09:42:41 -0000 1.3957 +++ ChangeLog 1 Jul 2008 05:53:29 -0000 1.3958 @@ -1,3 +1,14 @@ +2008-07-01 Stefan Kost <en...@us...> + + * gst/gstevent.c: + Use gst_format_get_name() to improve debug output. + * gst/gstpreset.c: + Remove #ifdef'ed code. Add TODO comment. + * gst/gstsegment.c: + Add debug output to ease spotting format != segment.format assertions. 2008-06-30 Sebastian Dröge <seb...@co...> * tests/check/libs/gdp.c: (gst_dp_suite): Index: gstevent.c RCS file: /cvs/gstreamer/gstreamer/gst/gstevent.c,v retrieving revision 1.115 retrieving revision 1.116 diff -u -d -r1.115 -r1.116 --- gstevent.c 4 Jun 2008 11:31:15 -0000 1.115 +++ gstevent.c 1 Jul 2008 05:53:31 -0000 1.116 @@ -557,9 +557,10 @@ GST_TIME_ARGS (stop), GST_TIME_ARGS (position)); } else { GST_CAT_INFO (GST_CAT_EVENT, - "creating newsegment update %d, rate %lf, format %d, " + "creating newsegment update %d, rate %lf, format %s, " "start %" G_GINT64_FORMAT ", stop %" G_GINT64_FORMAT ", position %" - G_GINT64_FORMAT, update, rate, format, start, stop, position); + G_GINT64_FORMAT, update, rate, gst_format_get_name (format), start, + stop, position); } g_return_val_if_fail (position != -1, NULL); @@ -679,8 +680,8 @@ gint64 maxsize, gboolean async) { GST_CAT_INFO (GST_CAT_EVENT, - "creating buffersize format %d, minsize %" G_GINT64_FORMAT - ", maxsize %" G_GINT64_FORMAT ", async %d", format, + "creating buffersize format %s, minsize %" G_GINT64_FORMAT + ", maxsize %" G_GINT64_FORMAT ", async %d", gst_format_get_name (format), minsize, maxsize, async); return gst_event_new_custom (GST_EVENT_BUFFERSIZE, @@ -873,10 +874,11 @@ stop_type, GST_TIME_ARGS (stop)); - "creating seek rate %lf, format %d, flags %d, " + "creating seek rate %lf, format %s, flags %d, " "start_type %d, start %" G_GINT64_FORMAT ", " "stop_type %d, stop %" G_GINT64_FORMAT, - rate, format, flags, start_type, start, stop_type, stop); + rate, gst_format_get_name (format), flags, start_type, start, stop_type, + stop); return gst_event_new_custom (GST_EVENT_SEEK, Index: gstpreset.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.c,v retrieving revision 1.14 retrieving revision 1.15 diff -u -d -r1.14 -r1.15 --- gstpreset.c 11 Jun 2008 20:07:31 -0000 1.14 +++ gstpreset.c 1 Jul 2008 05:53:31 -0000 1.15 @@ -62,10 +62,24 @@ * - this would alloow to hanve preset-bundles too (a preset on bins that * specifies presets for children * - * - meta presets : presets that load presets for children (childproxy/bin) - * [<preset name>] - * _child/<childname>=<presetname> - * _child/... + * - GstChildProxy suport + * - if we stick with GParamSpec **_list_properties() + * we need to use g_param_spec_set_qdata() to specify the instance on each GParamSpec + * OBJECT_LOCK(obj); // ChildProxy needs GstIterator support + * num=gst_child_proxy_get_children_count(obj); + * for(i=0;i<num;i++) { + * child=gst_child_proxy_get_child_by_index(obj,i); + * // v1 ---- + * g_object_class_list_properties(child,&num); + * // foreach prop + * // g_param_spec_set_qdata(prop, quark, (gpointer)child); + * // add to result + * // v2 ---- + * // children have to implement preset-iface too tag the returned GParamSpec* with the owner + * props=gst_preset_list_properties(child); + * // add props to result + * } + * OBJECT_UNLOCK(obj); */ @@ -73,8 +87,9 @@ #include "gstpreset.h" -#include "stdlib.h" +#ifdef HAVE_UNISTD_H #include <unistd.h> +#endif #include <glib/gstdio.h> #define GST_CAT_DEFAULT preset_debug @@ -842,99 +857,6 @@ } -#if 0 -static void -gst_preset_default_randomize (GstPreset * preset) -{ - GList *properties; - GType base, parent; - - if ((properties = gst_preset_get_property_names (preset))) { - GParamSpec *property; - GList *node; - gdouble rnd; - for (node = properties; node; node = g_list_next (node)) { - property = g_object_class_find_property (G_OBJECT_CLASS - (GST_ELEMENT_GET_CLASS (preset)), node->data); - rnd = ((gdouble) rand ()) / (RAND_MAX + 1.0); - /* get base type */ - base = property->value_type; - while ((parent = g_type_parent (base))) - base = parent; - GST_INFO ("set random value for property: %s (type is %s)", - property->name, g_type_name (base)); - switch (base) { - case G_TYPE_BOOLEAN:{ - g_object_set (preset, property->name, (gboolean) (2.0 * rnd), NULL); - } - break; - case G_TYPE_INT:{ - const GParamSpecInt *int_property = G_PARAM_SPEC_INT (property); - g_object_set (preset, property->name, - (gint) (int_property->minimum + ((int_property->maximum - - int_property->minimum) * rnd)), NULL); - } break; - case G_TYPE_UINT:{ - const GParamSpecUInt *uint_property = G_PARAM_SPEC_UINT (property); - (guint) (uint_property->minimum + ((uint_property->maximum - - uint_property->minimum) * rnd)), NULL); - case G_TYPE_DOUBLE:{ - const GParamSpecDouble *double_property = - G_PARAM_SPEC_DOUBLE (property); - (gdouble) (double_property->minimum + ((double_property->maximum - - double_property->minimum) * rnd)), NULL); - case G_TYPE_ENUM:{ - const GParamSpecEnum *enum_property = G_PARAM_SPEC_ENUM (property); - const GEnumClass *enum_class = enum_property->enum_class; - (gulong) (enum_class->minimum + ((enum_class->maximum - - enum_class->minimum) * rnd)), NULL); - default: - GST_WARNING ("incomplete implementation for GParamSpec type '%s'", - G_PARAM_SPEC_TYPE_NAME (property)); - } - } - /* FIXME: handle childproxy properties as well */ - } -} -gst_preset_default_reset (GstPreset * preset) - GValue gvalue = { 0, }; - g_value_init (&gvalue, property->value_type); - g_param_value_set_default (property, &gvalue); - g_object_set_property (G_OBJECT (preset), property->name, &gvalue); - g_value_unset (&gvalue); -#endif /* wrapper */ /** Index: gstsegment.c RCS file: /cvs/gstreamer/gstreamer/gst/gstsegment.c,v retrieving revision 1.35 retrieving revision 1.36 diff -u -d -r1.35 -r1.36 --- gstsegment.c 9 May 2008 20:48:23 -0000 1.35 +++ gstsegment.c 1 Jul 2008 05:53:32 -0000 1.36 @@ -446,6 +446,12 @@ g_return_if_fail (applied_rate != 0.0); g_return_if_fail (segment != NULL); + GST_DEBUG ("configuring segment update %d, rate %lf, format %s, " + "start %" G_GINT64_FORMAT ", stop %" G_GINT64_FORMAT ", position %" + G_GINT64_FORMAT, update, rate, gst_format_get_name (format), start, + stop, time); + GST_DEBUG ("old segment was: %" GST_SEGMENT_FORMAT, segment); if (G_UNLIKELY (segment->format == GST_FORMAT_UNDEFINED)) segment->format = format; |
From: <en...@ke...> - 2008-07-11 19:30:52
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Fri Jul 11 2008 19:31:02 UTC Log message: * gst/gstdebugutils.c: Give request and sometimes pads a different shpe style. Condense the graphs a little more. Modified files: . : ChangeLog gst : gstdebugutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3967&r2=1.3968 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstdebugutils.c.diff?r1=1.19&r2=1.20 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3967 retrieving revision 1.3968 diff -u -d -r1.3967 -r1.3968 --- ChangeLog 10 Jul 2008 00:29:59 -0000 1.3967 +++ ChangeLog 11 Jul 2008 19:30:46 -0000 1.3968 @@ -1,3 +1,9 @@ +2008-07-11 Stefan Kost <en...@us...> + + * gst/gstdebugutils.c: + Give request and sometimes pads a different shpe style. Condense the + graphs a little more. 2008-07-09 Michael Smith <ms...@so...> * configure.ac: Index: gstdebugutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstdebugutils.c,v retrieving revision 1.19 retrieving revision 1.20 diff -u -d -r1.19 -r1.20 --- gstdebugutils.c 7 Jul 2008 11:01:26 -0000 1.19 +++ gstdebugutils.c 11 Jul 2008 19:30:48 -0000 1.20 @@ -22,8 +22,6 @@ * edge [ constraint=false ]; * edge [ minlen=0 ]; * does not create spacial dependency - * node [ margin="0.02,0.01" ]; - * space surrounding the label */ #include "gst_private.h" @@ -126,9 +124,11 @@ GstElement *target_element; GstPad *target_pad, *tmp_pad; GstPadDirection dir; + GstPadTemplate *pad_templ; + GstPadPresence presence; gchar *pad_name, *element_name; gchar *target_pad_name, *target_element_name; - gchar *color_name; + gchar *color_name, *style_name; gchar *spc = NULL; spc = g_malloc (1 + indent * 2); @@ -152,10 +152,19 @@ } else { target_element_name = ""; } + style_name = "filled,solid"; + if ((pad_templ = gst_pad_get_pad_template (target_pad))) { + presence = GST_PAD_TEMPLATE_PRESENCE (pad_templ); + if (presence == GST_PAD_SOMETIMES) { + style_name = "filled,dotted"; + } else if (presence == GST_PAD_REQUEST) { + style_name = "filled,dashed"; + } + } fprintf (out, - "%s %s_%s [color=black, fillcolor=\"%s\", label=\"%s\"];\n", + "%s %s_%s [color=black, fillcolor=\"%s\", label=\"%s\", height=\"0.2\", style=\"%s\"];\n", spc, target_element_name, target_pad_name, color_name, - GST_OBJECT_NAME (target_pad)); + GST_OBJECT_NAME (target_pad), style_name); g_free (target_pad_name); if (target_element) { g_free (target_element_name); @@ -171,9 +180,19 @@ GST_PAD_SINK) ? "#aaaaff" : "#cccccc"); } /* pads */ + style_name = "filled,solid"; + if ((pad_templ = gst_pad_get_pad_template (pad))) { + presence = GST_PAD_TEMPLATE_PRESENCE (pad_templ); + if (presence == GST_PAD_SOMETIMES) { + style_name = "filled,dotted"; + } else if (presence == GST_PAD_REQUEST) { + style_name = "filled,dashed"; + } + } fprintf (out, - "%s %s_%s [color=black, fillcolor=\"%s\", label=\"%s\"];\n", - spc, element_name, pad_name, color_name, GST_OBJECT_NAME (pad)); + "%s %s_%s [color=black, fillcolor=\"%s\", label=\"%s\", height=\"0.2\", style=\"%s\"];\n", + spc, element_name, pad_name, color_name, GST_OBJECT_NAME (pad), + style_name); g_free (pad_name); g_free (element_name); @@ -526,7 +545,7 @@ " nodesep=.1;\n" " ranksep=.2;\n" " label=\"<%s>\\n%s%s%s\";\n" - " node [style=filled, shape=box, fontsize=\"7\", fontname=\"Bitstream Vera Sans\"];\n" + " node [style=filled, shape=box, fontsize=\"7\", fontname=\"Bitstream Vera Sans\", margin=\"0.0,0.0\"];\n" " edge [labelfontsize=\"7\", fontsize=\"7\", labelfontname=\"Bitstream Vera Sans\", fontname=\"Bitstream Vera Sans\"];\n" "\n", G_OBJECT_TYPE_NAME (bin), GST_OBJECT_NAME (bin), (state_name ? state_name : ""), (param_name ? param_name : "") |
From: <en...@ke...> - 2008-07-12 09:59:38
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Sat Jul 12 2008 09:59:46 UTC Log message: * gst/gstdebugutils.c: Squeeze ghost-pad links and remove <> from classname labels to save more horizontal space. Modified files: . : ChangeLog gst : gstdebugutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3968&r2=1.3969 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstdebugutils.c.diff?r1=1.20&r2=1.21 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3968 retrieving revision 1.3969 diff -u -d -r1.3968 -r1.3969 --- ChangeLog 11 Jul 2008 19:30:46 -0000 1.3968 +++ ChangeLog 12 Jul 2008 09:59:30 -0000 1.3969 @@ -1,3 +1,9 @@ +2008-07-12 Stefan Kost <en...@us...> + + * gst/gstdebugutils.c: + Squeeze ghost-pad links and remove <> from classname labels to save + more horizontal space. 2008-07-11 Stefan Kost <en...@us...> * gst/gstdebugutils.c: Index: gstdebugutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstdebugutils.c,v retrieving revision 1.20 retrieving revision 1.21 diff -u -d -r1.20 -r1.21 --- gstdebugutils.c 11 Jul 2008 19:30:48 -0000 1.20 +++ gstdebugutils.c 12 Jul 2008 09:59:32 -0000 1.21 @@ -20,8 +20,8 @@ */ /* TODO: * edge [ constraint=false ]; - * edge [ minlen=0 ]; - * does not create spacial dependency + * this creates strange graphs ("minlen=0" is better) + * try puting src/sink ghostpads for each bin into invisible clusters #include "gst_private.h" @@ -280,7 +280,7 @@ target_element_name = ""; } /* src ghostpad relationship */ - fprintf (out, "%s%s_%s -> %s_%s [style=dashed]\n", spc, + fprintf (out, "%s%s_%s -> %s_%s [style=dashed, minlen=0]\n", spc, target_element_name, target_pad_name, element_name, pad_name); g_free (target_pad_name); @@ -305,7 +305,7 @@ /* sink ghostpad relationship */ peer_element_name, peer_pad_name, target_element_name, target_pad_name); /* FIXME: we are missing links from the proxy pad @@ -399,7 +399,7 @@ fprintf (out, "%s fontsize=\"8\";\n", spc); fprintf (out, "%s style=filled;\n", spc); fprintf (out, "%s color=black;\n\n", spc); - fprintf (out, "%s label=\"<%s>\\n%s%s%s\";\n", spc, + fprintf (out, "%s label=\"%s\\n%s%s%s\";\n", spc, G_OBJECT_TYPE_NAME (element), GST_OBJECT_NAME (element), (state_name ? state_name : ""), (param_name ? param_name : "") ); |
From: <en...@ke...> - 2008-08-04 12:30:33
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Aug 04 2008 12:30:40 UTC Log message: * gst/gsttaglist.c: * gst/gsttaglist.h: Do as tim pointed out and actually register the new tag. Also improve te docs and use gst_tag_merge_strings_with_comma() method to allow retriving all keywords merged in one list. Modified files: . : ChangeLog gst : gsttaglist.c gsttaglist.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4001&r2=1.4002 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttaglist.c.diff?r1=1.61&r2=1.62 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttaglist.h.diff?r1=1.48&r2=1.49 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4001 retrieving revision 1.4002 diff -u -d -r1.4001 -r1.4002 --- ChangeLog 1 Aug 2008 11:57:38 -0000 1.4001 +++ ChangeLog 4 Aug 2008 12:30:23 -0000 1.4002 @@ -1,3 +1,11 @@ +2008-08-04 Stefan Kost <en...@us...> + + * gst/gsttaglist.c: + * gst/gsttaglist.h: + Do as tim pointed out and actually register the new tag. Also improve + te docs and use gst_tag_merge_strings_with_comma() method to allow + retriving all keywords merged in one list. 2008-08-01 Stefan Kost <en...@us...> * configure.ac: Index: gsttaglist.c RCS file: /cvs/gstreamer/gstreamer/gst/gsttaglist.c,v retrieving revision 1.61 retrieving revision 1.62 diff -u -d -r1.61 -r1.62 --- gsttaglist.c 20 Jun 2008 08:39:54 -0000 1.61 +++ gsttaglist.c 4 Aug 2008 12:30:25 -0000 1.62 @@ -245,7 +245,9 @@ gst_tag_merge_use_first); gst_tag_register (GST_TAG_BEATS_PER_MINUTE, GST_TAG_FLAG_META, G_TYPE_DOUBLE, _("beats per minute"), _("number of beats per minute in audio"), NULL); - + gst_tag_register (GST_TAG_KEYWORDS, GST_TAG_FLAG_META, G_TYPE_STRING, + _("keywords"), _("comma separated keywords describing the content"), + NULL); } /** Index: gsttaglist.h RCS file: /cvs/gstreamer/gstreamer/gst/gsttaglist.h,v retrieving revision 1.48 retrieving revision 1.49 diff -u -d -r1.48 -r1.49 --- gsttaglist.h 1 Aug 2008 11:34:06 -0000 1.48 +++ gsttaglist.h 4 Aug 2008 12:30:26 -0000 1.49 @@ -677,7 +677,7 @@ * GST_TAG_KEYWORDS: * - * series of keywords describing the content (string). + * comma separated keywords describing the content (string). * Since: 0.10.21 */ |
From: <en...@ke...> - 2008-08-04 12:46:29
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Aug 04 2008 12:46:37 UTC Log message: * gst/gsttaglist.c: Argh. actually save the text before committing. Now adds gst_tag_merge_strings_with_comma() to gst_tag_register(). Modified files: . : ChangeLog gst : gsttaglist.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4002&r2=1.4003 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttaglist.c.diff?r1=1.62&r2=1.63 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4002 retrieving revision 1.4003 diff -u -d -r1.4002 -r1.4003 --- ChangeLog 4 Aug 2008 12:30:23 -0000 1.4002 +++ ChangeLog 4 Aug 2008 12:46:21 -0000 1.4003 @@ -1,6 +1,12 @@ 2008-08-04 Stefan Kost <en...@us...> * gst/gsttaglist.c: + Argh. actually save the text before committing. Now adds + gst_tag_merge_strings_with_comma() to gst_tag_register(). + +2008-08-04 Stefan Kost <en...@us...> + * gst/gsttaglist.c: * gst/gsttaglist.h: Do as tim pointed out and actually register the new tag. Also improve te docs and use gst_tag_merge_strings_with_comma() method to allow Index: gsttaglist.c RCS file: /cvs/gstreamer/gstreamer/gst/gsttaglist.c,v retrieving revision 1.62 retrieving revision 1.63 diff -u -d -r1.62 -r1.63 --- gsttaglist.c 4 Aug 2008 12:30:25 -0000 1.62 +++ gsttaglist.c 4 Aug 2008 12:46:23 -0000 1.63 @@ -247,7 +247,7 @@ _("beats per minute"), _("number of beats per minute in audio"), NULL); gst_tag_register (GST_TAG_KEYWORDS, GST_TAG_FLAG_META, G_TYPE_STRING, _("keywords"), _("comma separated keywords describing the content"), - NULL); + gst_tag_merge_strings_with_comma ()); } /** |
From: <en...@ke...> - 2008-08-12 06:27:39
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Aug 12 2008 06:27:50 UTC Log message: * gst/gstchildproxy.h: * gst/gstpreset.h: Remove double interface from doc-string. Modified files: . : ChangeLog gst : gstchildproxy.h gstpreset.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4019&r2=1.4020 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstchildproxy.h.diff?r1=1.5&r2=1.6 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.h.diff?r1=1.6&r2=1.7 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4019 retrieving revision 1.4020 diff -u -d -r1.4019 -r1.4020 --- ChangeLog 12 Aug 2008 06:15:59 -0000 1.4019 +++ ChangeLog 12 Aug 2008 06:27:33 -0000 1.4020 @@ -1,5 +1,11 @@ 2008-08-12 Stefan Kost <en...@us...> + * gst/gstchildproxy.h: + * gst/gstpreset.h: + Remove double interface from doc-string. + +2008-08-12 Stefan Kost <en...@us...> * libs/gst/base/gstbasesrc.c: * libs/gst/base/gstbasetransform.c: Fix headings in docs and gtk-doc warnings. Index: gstchildproxy.h RCS file: /cvs/gstreamer/gstreamer/gst/gstchildproxy.h,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- gstchildproxy.h 15 Feb 2007 12:05:08 -0000 1.5 +++ gstchildproxy.h 12 Aug 2008 06:27:35 -0000 1.6 @@ -47,7 +47,7 @@ * @get_child_by_index: virtual method to fetch the child * @get_children_count: virtual method to get the children count * - * #GstChildProxyInterface interface. + * #GstChildProxy interface. */ struct _GstChildProxyInterface { Index: gstpreset.h RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.h,v retrieving revision 1.7 diff -u -d -r1.6 -r1.7 --- gstpreset.h 11 Aug 2008 08:06:20 -0000 1.6 +++ gstpreset.h 12 Aug 2008 06:27:35 -0000 1.7 @@ -52,7 +52,7 @@ * @set_meta: virtual methods to set textual meta data to a preset * @get_meta: virtual methods to get textual meta data from a preset - * #GstPresetInterface interface. + * #GstPreset interface. struct _GstPresetInterface |
From: <en...@ke...> - 2008-08-20 07:22:15
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Aug 20 2008 07:22:25 UTC Log message: patch by: Murray Cumming <mu...@mu...> * gst/gstutils.c: Mention that this is just like gst_buffer_merge() but with extra unreffing for C coders. Advise language bindings not to wrap it. Fixes Bug #533856. Also fix file comment. Modified files: . : ChangeLog gst : gstutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4033&r2=1.4034 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstutils.c.diff?r1=1.183&r2=1.184 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4033 retrieving revision 1.4034 diff -u -d -r1.4033 -r1.4034 --- ChangeLog 20 Aug 2008 07:03:36 -0000 1.4033 +++ ChangeLog 20 Aug 2008 07:22:09 -0000 1.4034 @@ -1,5 +1,16 @@ 2008-08-20 Stefan Kost <en...@us...> + patch by: Murray Cumming <mu...@mu...> + + * gst/gstutils.c: + Mention that this is just like gst_buffer_merge() but with extra + unreffing for C coders. Advise language bindings not to wrap it. + Fixes Bug #533856. + + Also fix file comment. +2008-08-20 Stefan Kost <en...@us...> reviewed by: Wim Taymans <wim...@co...> * plugins/elements/gstfakesink.c: Index: gstutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstutils.c,v retrieving revision 1.183 retrieving revision 1.184 diff -u -d -r1.183 -r1.184 --- gstutils.c 27 May 2008 10:50:49 -0000 1.183 +++ gstutils.c 20 Aug 2008 07:22:11 -0000 1.184 @@ -3,7 +3,7 @@ * 2000 Wim Taymans <wt...@ch...> * 2002 Thomas Vander Stichele <th...@ap...> * - * gstutils.c: Utility functions: gtk_get_property stuff, etc. + * gstutils.c: Utility functions * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Library General Public @@ -2420,6 +2420,11 @@ * If the buffers point to contiguous areas of memory, the buffer * is created without copying the data. + * This is a convenience function for C programmers. See also + * gst_buffer_merge(), which does the same thing without + * unreffing the input parameters. Language bindings without + * explicit reference counting should not wrap this function. + * * Returns: the new #GstBuffer which is the concatenation of the source buffers. */ GstBuffer * |
From: <en...@ke...> - 2008-08-27 07:18:43
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Aug 27 2008 07:18:54 UTC Log message: * gst/gstobject.c: Due to popular request also include ObjectType in gst_object_get_path_string(). Makes gst-launch -v bit more useful. Modified files: . : ChangeLog gst : gstobject.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4041&r2=1.4042 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstobject.c.diff?r1=1.128&r2=1.129 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4041 retrieving revision 1.4042 diff -u -d -r1.4041 -r1.4042 --- ChangeLog 27 Aug 2008 03:04:21 -0000 1.4041 +++ ChangeLog 27 Aug 2008 07:18:32 -0000 1.4042 @@ -1,3 +1,9 @@ +2008-08-27 Stefan Kost <en...@us...> + + * gst/gstobject.c: + Due to popular request also include ObjectType in + gst_object_get_path_string(). Makes gst-launch -v bit more useful. 2008-08-26 David Schleef <ds...@sc...> * gst/gstutils.c: Remove check in gst_pad_query_convert() that Index: gstobject.c RCS file: /cvs/gstreamer/gstreamer/gst/gstobject.c,v retrieving revision 1.128 retrieving revision 1.129 diff -u -d -r1.128 -r1.129 --- gstobject.c 22 Mar 2008 14:56:12 -0000 1.128 +++ gstobject.c 27 Aug 2008 07:18:37 -0000 1.129 @@ -568,6 +568,7 @@ g_value_init (&value, G_PARAM_SPEC_VALUE_TYPE (pspec)); g_object_get_property (G_OBJECT (orig), pspec->name, &value); + /* FIXME: handle flags */ if (G_IS_PARAM_SPEC_ENUM (pspec)) { GEnumValue *enum_value; @@ -1062,6 +1063,7 @@ GSList *parents; void *parent; gchar *prevpath, *path; + const gchar *typename; gchar *component; gchar *separator; @@ -1090,16 +1092,25 @@ * decrease the refcounting on each element after we handled * it. */ for (parents = parentage; parents; parents = g_slist_next (parents)) { + if (G_IS_OBJECT (parents->data)) { + typename = G_OBJECT_TYPE_NAME (parents->data); + } else { + typename = NULL; + } if (GST_IS_OBJECT (parents->data)) { GstObject *item = GST_OBJECT_CAST (parents->data); GstObjectClass *oclass = GST_OBJECT_GET_CLASS (item); - component = gst_object_get_name (item); + component = g_strdup_printf ("%s:%s", typename, GST_OBJECT_NAME (item)); separator = oclass->path_string_separator; /* and unref now */ gst_object_unref (item); } else { - component = g_strdup_printf ("%p", parents->data); + if (typename) { + component = g_strdup_printf ("%s:%p", typename, parents->data); + } else { + component = g_strdup_printf ("%p", parents->data); + } separator = "/"; } |
From: <en...@ke...> - 2008-08-28 10:45:08
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Aug 28 2008 10:45:19 UTC Log message: * gst/gsturi.c: Don't segfault on input like "tel:+1-123-555-1234". Modified files: . : ChangeLog gst : gsturi.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4042&r2=1.4043 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsturi.c.diff?r1=1.47&r2=1.48 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4042 retrieving revision 1.4043 diff -u -d -r1.4042 -r1.4043 --- ChangeLog 27 Aug 2008 07:18:32 -0000 1.4042 +++ ChangeLog 28 Aug 2008 10:45:02 -0000 1.4043 @@ -1,3 +1,8 @@ +2008-08-28 Stefan Kost <en...@us...> + + * gst/gsturi.c: + Don't segfault on input like "tel:+1-123-555-1234". 2008-08-27 Stefan Kost <en...@us...> * gst/gstobject.c: Index: gsturi.c RCS file: /cvs/gstreamer/gstreamer/gst/gsturi.c,v retrieving revision 1.47 retrieving revision 1.48 diff -u -d -r1.47 -r1.48 --- gsturi.c 31 Jul 2008 17:16:50 -0000 1.47 +++ gsturi.c 28 Aug 2008 10:45:04 -0000 1.48 @@ -424,6 +424,8 @@ g_return_val_if_fail (gst_uri_is_valid (uri), NULL); colon = strstr (uri, "://"); + if (!colon) + return NULL; unescaped = unescape_string (colon + 3, "/"); |
From: <en...@ke...> - 2008-08-28 12:32:21
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Aug 28 2008 12:32:33 UTC Log message: * gst/gstpadtemplate.c: The old behaviour was that gst_pad_template_new() takes ownership of the caps. As we now call g_object_new() which calls g_object_set() and which copies the caps, we have to unref them to not leak them. Fixes make valgrid for me. Modified files: . : ChangeLog gst : gstpadtemplate.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4043&r2=1.4044 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpadtemplate.c.diff?r1=1.14&r2=1.15 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4043 retrieving revision 1.4044 diff -u -d -r1.4043 -r1.4044 --- ChangeLog 28 Aug 2008 10:45:02 -0000 1.4043 +++ ChangeLog 28 Aug 2008 12:32:17 -0000 1.4044 @@ -1,5 +1,13 @@ 2008-08-28 Stefan Kost <en...@us...> + * gst/gstpadtemplate.c: + The old behaviour was that gst_pad_template_new() takes ownership of + the caps. As we now call g_object_new() which calls g_object_set() and + which copies the caps, we have to unref them to not leak them. Fixes + make valgrid for me. + +2008-08-28 Stefan Kost <en...@us...> * gst/gsturi.c: Don't segfault on input like "tel:+1-123-555-1234". Index: gstpadtemplate.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpadtemplate.c,v retrieving revision 1.14 retrieving revision 1.15 diff -u -d -r1.14 -r1.15 --- gstpadtemplate.c 1 Aug 2008 10:02:49 -0000 1.14 +++ gstpadtemplate.c 28 Aug 2008 12:32:19 -0000 1.15 @@ -388,6 +388,9 @@ "name", name_template, "name-template", name_template, "direction", direction, "presence", presence, "caps", caps, NULL); + if (caps) + gst_caps_unref (caps); return new; } |
From: <en...@ke...> - 2008-08-28 20:12:58
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Aug 28 2008 20:13:08 UTC Log message: * gst/gstobject.c: Put the gst_object_get_name() back in. Modified files: . : ChangeLog gst : gstobject.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4044&r2=1.4045 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstobject.c.diff?r1=1.129&r2=1.130 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4044 retrieving revision 1.4045 diff -u -d -r1.4044 -r1.4045 --- ChangeLog 28 Aug 2008 12:32:17 -0000 1.4044 +++ ChangeLog 28 Aug 2008 20:12:52 -0000 1.4045 @@ -1,5 +1,10 @@ 2008-08-28 Stefan Kost <en...@us...> + * gst/gstobject.c: + Put the gst_object_get_name() back in. + +2008-08-28 Stefan Kost <en...@us...> * gst/gstpadtemplate.c: The old behaviour was that gst_pad_template_new() takes ownership of the caps. As we now call g_object_new() which calls g_object_set() and Index: gstobject.c RCS file: /cvs/gstreamer/gstreamer/gst/gstobject.c,v retrieving revision 1.129 retrieving revision 1.130 diff -u -d -r1.129 -r1.130 --- gstobject.c 27 Aug 2008 07:18:37 -0000 1.129 +++ gstobject.c 28 Aug 2008 20:12:54 -0000 1.130 @@ -1100,11 +1100,13 @@ if (GST_IS_OBJECT (parents->data)) { GstObject *item = GST_OBJECT_CAST (parents->data); GstObjectClass *oclass = GST_OBJECT_GET_CLASS (item); + gchar *objname = gst_object_get_name (item); - component = g_strdup_printf ("%s:%s", typename, GST_OBJECT_NAME (item)); + component = g_strdup_printf ("%s:%s", typename, objname); separator = oclass->path_string_separator; /* and unref now */ gst_object_unref (item); + g_free (objname); } else { if (typename) { component = g_strdup_printf ("%s:%p", typename, parents->data); |
From: <en...@ke...> - 2008-10-30 14:15:31
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Oct 30 2008 14:15:28 UTC Log message: * gst/gstregistrybinary.c: * gst/gstregistryxml.c: Use g_unlink() as none of these are directories. Modified files: . : ChangeLog gst : gstregistrybinary.c gstregistryxml.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4126&r2=1.4127 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistrybinary.c.diff?r1=1.37&r2=1.38 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistryxml.c.diff?r1=1.42&r2=1.43 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4126 retrieving revision 1.4127 diff -u -d -r1.4126 -r1.4127 --- ChangeLog 29 Oct 2008 17:04:47 -0000 1.4126 +++ ChangeLog 30 Oct 2008 14:15:12 -0000 1.4127 @@ -1,3 +1,9 @@ +2008-10-30 Stefan Kost <en...@us...> + + * gst/gstregistrybinary.c: + * gst/gstregistryxml.c: + Use g_unlink() as none of these are directories. 2008-10-29 Wim Taymans <wim...@co...> * gst/gstpipeline.c: (gst_pipeline_provide_clock_func): Index: gstregistrybinary.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistrybinary.c,v retrieving revision 1.37 retrieving revision 1.38 diff -u -d -r1.37 -r1.38 --- gstregistrybinary.c 8 Oct 2008 10:07:15 -0000 1.37 +++ gstregistrybinary.c 30 Oct 2008 14:15:14 -0000 1.38 @@ -350,7 +350,7 @@ fail_after_close: { - g_remove (cache->tmp_location); + g_unlink (cache->tmp_location); g_free (cache->tmp_location); g_free (cache); return FALSE; Index: gstregistryxml.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistryxml.c,v retrieving revision 1.42 retrieving revision 1.43 diff -u -d -r1.42 -r1.43 --- gstregistryxml.c 31 Jul 2008 15:20:30 -0000 1.42 +++ gstregistryxml.c 30 Oct 2008 14:15:14 -0000 1.43 @@ -921,7 +921,7 @@ if (g_file_test (tmp_location, G_FILE_TEST_EXISTS)) { #ifdef WIN32 - g_remove (location); + g_unlink (location); #endif if (g_rename (tmp_location, location) < 0) goto rename_failed; @@ -941,7 +941,7 @@ } - g_remove (tmp_location); + g_unlink (tmp_location); g_free (tmp_location); |
From: <en...@ke...> - 2008-10-31 14:25:09
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Fri Oct 31 2008 14:25:04 UTC Log message: * gst/gstpreset.c: Use g_unlink instead of unlink. * gst/gststructure.c: Use glib type. * gst/gstutils.c: Add a FIXME:. * gst/gsttaglist.c: * gst/gsttypefind.c: * gst/gstvalue.c: Formatting & whitespaces. Modified files: . : ChangeLog gst : gstpreset.c gststructure.c gsttaglist.c gsttypefind.c gstutils.c gstvalue.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4129&r2=1.4130 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.c.diff?r1=1.15&r2=1.16 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gststructure.c.diff?r1=1.99&r2=1.100 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttaglist.c.diff?r1=1.65&r2=1.66 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttypefind.c.diff?r1=1.63&r2=1.64 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstutils.c.diff?r1=1.186&r2=1.187 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.c.diff?r1=1.144&r2=1.145 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4129 retrieving revision 1.4130 diff -u -d -r1.4129 -r1.4130 --- ChangeLog 31 Oct 2008 08:53:24 -0000 1.4129 +++ ChangeLog 31 Oct 2008 14:24:45 -0000 1.4130 @@ -1,5 +1,21 @@ 2008-10-31 Stefan Kost <en...@us...> + * gst/gstpreset.c: + Use g_unlink instead of unlink. + + * gst/gststructure.c: + Use glib type. + * gst/gstutils.c: + Add a FIXME:. + * gst/gsttaglist.c: + * gst/gsttypefind.c: + * gst/gstvalue.c: + Formatting & whitespaces. +2008-10-31 Stefan Kost <en...@us...> * plugins/elements/gstidentity.c: Doc typo. Use return value of parent_class->event. Index: gstpreset.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.c,v retrieving revision 1.15 retrieving revision 1.16 diff -u -d -r1.15 -r1.16 --- gstpreset.c 1 Jul 2008 05:53:31 -0000 1.15 +++ gstpreset.c 31 Oct 2008 14:24:48 -0000 1.16 @@ -620,7 +620,7 @@ GST_WARNING_OBJECT (preset, "no presets, trying to unlink possibly existing preset file: '%s'", preset_path); - unlink (preset_path); + g_unlink (preset_path); return FALSE; } convert_failed: Index: gststructure.c RCS file: /cvs/gstreamer/gstreamer/gst/gststructure.c,v retrieving revision 1.99 retrieving revision 1.100 diff -u -d -r1.99 -r1.100 --- gststructure.c 5 Aug 2008 15:03:26 -0000 1.99 +++ gststructure.c 31 Oct 2008 14:24:48 -0000 1.100 @@ -1374,7 +1374,7 @@ typedef struct _GstStructureAbbreviation { - char *type_name; + gchar *type_name; GType type; } GstStructureAbbreviation; Index: gsttaglist.c RCS file: /cvs/gstreamer/gstreamer/gst/gsttaglist.c,v retrieving revision 1.65 retrieving revision 1.66 diff -u -d -r1.65 -r1.66 --- gsttaglist.c 1 Sep 2008 13:35:31 -0000 1.65 +++ gsttaglist.c 31 Oct 2008 14:24:49 -0000 1.66 @@ -811,9 +811,7 @@ const gchar * tag, va_list var_args) GstTagInfo *info; - GQuark quark; gchar *error = NULL; g_return_if_fail (GST_IS_TAG_LIST (list)); @@ -858,7 +856,6 @@ Index: gsttypefind.c RCS file: /cvs/gstreamer/gstreamer/gst/gsttypefind.c,v retrieving revision 1.63 retrieving revision 1.64 diff -u -d -r1.63 -r1.64 --- gsttypefind.c 19 May 2008 10:46:43 -0000 1.63 +++ gsttypefind.c 31 Oct 2008 14:24:49 -0000 1.64 @@ -85,13 +85,14 @@ factory = g_object_new (GST_TYPE_TYPE_FIND_FACTORY, NULL); GST_DEBUG_OBJECT (factory, "using new typefind factory for %s", name); g_assert (GST_IS_TYPE_FIND_FACTORY (factory)); - gst_plugin_feature_set_name (GST_PLUGIN_FEATURE (factory), name); + gst_plugin_feature_set_name (GST_PLUGIN_FEATURE (factory), name); gst_plugin_feature_set_rank (GST_PLUGIN_FEATURE (factory), rank); if (factory->extensions) g_strfreev (factory->extensions); factory->extensions = g_strdupv (extensions); gst_caps_replace (&factory->caps, (GstCaps *) possible_caps); factory->function = func; factory->user_data = data; Index: gstutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstutils.c,v retrieving revision 1.186 retrieving revision 1.187 diff -u -d -r1.186 -r1.187 --- gstutils.c 30 Aug 2008 11:55:58 -0000 1.186 +++ gstutils.c 31 Oct 2008 14:24:49 -0000 1.187 @@ -965,6 +965,7 @@ /* try to create a new one */ /* requesting is a little crazy, we need a template. Let's create one */ + /* FIXME: why not gst_pad_get_pad_template (pad); */ templcaps = gst_pad_get_caps (pad); templ = gst_pad_template_new ((gchar *) GST_PAD_NAME (pad), Index: gstvalue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.c,v retrieving revision 1.144 retrieving revision 1.145 diff -u -d -r1.144 -r1.145 --- gstvalue.c 22 Jul 2008 09:24:37 -0000 1.144 +++ gstvalue.c 31 Oct 2008 14:24:49 -0000 1.145 @@ -2346,8 +2346,8 @@ static gboolean - gst_value_intersect_fraction_range_fraction_range - (GValue * dest, const GValue * src1, const GValue * src2) +gst_value_intersect_fraction_range_fraction_range (GValue * dest, + const GValue * src1, const GValue * src2) GValue *min; GValue *max; |
From: <en...@ke...> - 2008-10-31 15:55:10
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Fri Oct 31 2008 15:54:58 UTC Log message: * gst/gstregistrybinary.c: Oh my, studip, stupid me. Remove double stat() call. Modified files: . : ChangeLog gst : gstregistrybinary.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4130&r2=1.4131 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistrybinary.c.diff?r1=1.38&r2=1.39 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4130 retrieving revision 1.4131 diff -u -d -r1.4130 -r1.4131 --- ChangeLog 31 Oct 2008 14:24:45 -0000 1.4130 +++ ChangeLog 31 Oct 2008 15:54:42 -0000 1.4131 @@ -1,5 +1,10 @@ 2008-10-31 Stefan Kost <en...@us...> + * gst/gstregistrybinary.c: + Oh my, studip, stupid me. Remove double stat() call. + +2008-10-31 Stefan Kost <en...@us...> * gst/gstpreset.c: Use g_unlink instead of unlink. Index: gstregistrybinary.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistrybinary.c,v retrieving revision 1.38 retrieving revision 1.39 diff -u -d -r1.38 -r1.39 --- gstregistrybinary.c 30 Oct 2008 14:15:14 -0000 1.38 +++ gstregistrybinary.c 31 Oct 2008 15:54:44 -0000 1.39 @@ -768,7 +768,6 @@ int ret; struct stat statbuf; - ret = g_stat (plugin->filename, &statbuf); if ((ret = g_stat (plugin->filename, &statbuf)) < 0 || plugin->file_mtime != statbuf.st_mtime || plugin->file_size != statbuf.st_size) |
From: <en...@ke...> - 2008-11-03 12:29:34
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Nov 03 2008 12:29:24 UTC Log message: * gst/gstregistrybinary.c: Don't bother with the GTimer if we don't output the results. Modified files: . : ChangeLog gst : gstregistrybinary.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4132&r2=1.4133 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistrybinary.c.diff?r1=1.39&r2=1.40 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4132 retrieving revision 1.4133 diff -u -d -r1.4132 -r1.4133 --- ChangeLog 3 Nov 2008 10:59:47 -0000 1.4132 +++ ChangeLog 3 Nov 2008 12:29:08 -0000 1.4133 @@ -1,3 +1,8 @@ +2008-11-03 Stefan Kost <en...@us...> + + * gst/gstregistrybinary.c: + Don't bother with the GTimer if we don't output the results. 2008-11-03 Wim Taymans <wim...@co...> Patch by: David Schleef <ds...@sc...> Index: gstregistrybinary.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistrybinary.c,v retrieving revision 1.39 retrieving revision 1.40 diff -u -d -r1.39 -r1.40 --- gstregistrybinary.c 31 Oct 2008 15:54:44 -0000 1.39 +++ gstregistrybinary.c 3 Nov 2008 12:29:10 -0000 1.40 @@ -1161,21 +1161,25 @@ gst_registry_binary_read_cache (GstRegistry * registry, const char *location) { GMappedFile *mapped = NULL; - GTimer *timer = NULL; gchar *contents = NULL; gchar *in = NULL; - gdouble seconds; gsize size; GError *err = NULL; gboolean res = FALSE; gint check_magic_result; +#ifndef GST_DISABLE_GST_DEBUG + GTimer *timer = NULL; + gdouble seconds; +#endif /* make sure these types exist */ GST_TYPE_ELEMENT_FACTORY; GST_TYPE_TYPE_FIND_FACTORY; GST_TYPE_INDEX_FACTORY; timer = g_timer_new (); mapped = g_mapped_file_new (location, FALSE, &err); if (err != NULL) { @@ -1235,8 +1239,10 @@ } } g_timer_stop (timer); seconds = g_timer_elapsed (timer, NULL); GST_INFO ("loaded %s in %lf seconds", location, seconds); @@ -1244,7 +1250,9 @@ /* TODO: once we re-use the pointers to registry contents return here */ Error: g_timer_destroy (timer); if (mapped) { g_mapped_file_free (mapped); } else { |
From: <en...@ke...> - 2008-11-17 21:25:57
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Nov 17 2008 21:25:53 UTC Log message: * gst/gstvalue.c: Don't crash if either of the string GValues is empty. Modified files: . : ChangeLog gst : gstvalue.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4155&r2=1.4156 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.c.diff?r1=1.148&r2=1.149 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4155 retrieving revision 1.4156 diff -u -d -r1.4155 -r1.4156 --- ChangeLog 17 Nov 2008 15:48:09 -0000 1.4155 +++ ChangeLog 17 Nov 2008 21:25:37 -0000 1.4156 @@ -1,3 +1,8 @@ +2008-11-17 Stefan Kost <en...@us...> + + * gst/gstvalue.c: + Don't crash if either of the string GValues is empty. 2008-11-17 Andy Wingo <wi...@po...> * tools/gst-inspect.c (print_all_uri_handlers): New function, Index: gstvalue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.c,v retrieving revision 1.148 retrieving revision 1.149 diff -u -d -r1.148 -r1.149 --- gstvalue.c 6 Nov 2008 15:37:16 -0000 1.148 +++ gstvalue.c 17 Nov 2008 21:25:39 -0000 1.149 @@ -1764,13 +1764,17 @@ static gint gst_value_compare_string (const GValue * value1, const GValue * value2) { - int x = strcmp (value1->data[0].v_pointer, value2->data[0].v_pointer); + if (!value1->data[0].v_pointer || !value2->data[0].v_pointer) { + return GST_VALUE_UNORDERED; + } else { + int x = strcmp (value1->data[0].v_pointer, value2->data[0].v_pointer); - if (x < 0) - return GST_VALUE_LESS_THAN; - if (x > 0) - return GST_VALUE_GREATER_THAN; - return GST_VALUE_EQUAL; + if (x < 0) + return GST_VALUE_LESS_THAN; + if (x > 0) + return GST_VALUE_GREATER_THAN; + return GST_VALUE_EQUAL; + } } /* keep in sync with gststructure.c */ |
From: <en...@ke...> - 2008-12-16 07:07:55
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Dec 16 2008 07:07:50 UTC Log message: * gst/gsttaglist.h: * gst/gsttagsetter.c: Update GstTagSetter and GstTagMergeMode documentation. Mention that tags can come from events and from application. Fix example. Modified files: . : ChangeLog gst : gsttaglist.h gsttagsetter.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4193&r2=1.4194 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttaglist.h.diff?r1=1.52&r2=1.53 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttagsetter.c.diff?r1=1.24&r2=1.25 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4193 retrieving revision 1.4194 diff -u -d -r1.4193 -r1.4194 --- ChangeLog 15 Dec 2008 15:27:03 -0000 1.4193 +++ ChangeLog 16 Dec 2008 07:07:33 -0000 1.4194 @@ -1,3 +1,10 @@ +2008-12-15 Stefan Kost <en...@us...> + + * gst/gsttaglist.h: + * gst/gsttagsetter.c: + Update GstTagSetter and GstTagMergeMode documentation. Mention + that tags can come from events and from application. Fix example. 2008-12-15 Wim Taymans <wim...@co...> * docs/design/part-TODO.txt: Index: gsttaglist.h RCS file: /cvs/gstreamer/gstreamer/gst/gsttaglist.h,v retrieving revision 1.52 retrieving revision 1.53 diff -u -d -r1.52 -r1.53 --- gsttaglist.h 3 Sep 2008 05:52:40 -0000 1.52 +++ gsttaglist.h 16 Dec 2008 07:07:36 -0000 1.53 @@ -40,11 +40,12 @@ * @GST_TAG_MERGE_COUNT: the number of merge modes * * The different tag merging modes are basically replace, overwrite and append, - * but they can be seen from two directions. Given two taglists: (A) the tags - * already in the element and (B) the ones that are supplied to - * gst_tag_setter_merge_tags() or gst_tag_setter_add_tags(), how are these tags - * merged? In the table below this is shown for the cases that a tag exists in - * the list (A) or does not exists (!A) and combinations thereof. + * but they can be seen from two directions. Given two taglists: (A) the tags + * already in the element and (B) the ones that are supplied to the element ( + * e.g. via gst_tag_setter_merge_tags() / gst_tag_setter_add_tags() or a + * %GST_EVENT_TAG), how are these tags merged? + * In the table below this is shown for the cases that a tag exists in the list + * (A) or does not exists (!A) and combinations thereof. * <table frame="all" colsep="1" rowsep="1"> * <title>merge mode</title> Index: gsttagsetter.c RCS file: /cvs/gstreamer/gstreamer/gst/gsttagsetter.c,v retrieving revision 1.24 retrieving revision 1.25 diff -u -d -r1.24 -r1.25 --- gsttagsetter.c 13 Apr 2008 19:58:43 -0000 1.24 +++ gsttagsetter.c 16 Dec 2008 07:07:36 -0000 1.25 @@ -24,30 +24,26 @@ * @short_description: Element interface that allows setting and retrieval * of media metadata - * <refsect2> - * <para> * Element interface that allows setting of media metadata. - * </para> + * * Elements that support changing a stream's metadata will implement this * interface. Examples of such elements are 'vorbisenc', 'theoraenc' and * 'id3v2mux'. + * * If you just want to retrieve metadata in your application then all you * need to do is watch for tag messages on your pipeline's bus. This * interface is only for setting metadata, not for extracting it. To set tags * from the application, find tagsetter elements and set tags using e.g. - * gst_tag_setter_merge_tags() or gst_tag_setter_add_tags(). The application - * should do that before the element goes to %GST_STATE_PAUSED. + * gst_tag_setter_merge_tags() or gst_tag_setter_add_tags(). Also consider + * setting the #GstTagMergeMode that is used for tag events that arrive at the + * tagsetter element (default mode is to keep existing tags). + * The application should do that before the element goes to %GST_STATE_PAUSED. * Elements implementing the #GstTagSetter interface often have to merge * any tags received from upstream and the tags set by the application via * the interface. This can be done like this: - * <programlisting> + * |[ * GstTagMergeMode merge_mode; * const GstTagList *application_tags; * const GstTagList *event_tags; @@ -57,7 +53,7 @@ * tagsetter = GST_TAG_SETTER (element); * * merge_mode = gst_tag_setter_get_tag_merge_mode (tagsetter); - * tagsetter_tags = gst_tag_setter_get_tag_list (tagsetter); + * application_tags = gst_tag_setter_get_tag_list (tagsetter); * event_tags = (const GstTagList *) element->event_tags; * GST_LOG_OBJECT (tagsetter, "merging tags, merge mode = %d", merge_mode); @@ -67,12 +63,9 @@ * result = gst_tag_list_merge (application_tags, event_tags, merge_mode); * GST_LOG_OBJECT (tagsetter, "final tags: %" GST_PTR_FORMAT, result); - * </programlisting> + * ]| * Last reviewed on 2006-05-18 (0.10.6) - * </refsect2> */ #ifdef HAVE_CONFIG_H |
From: <en...@ke...> - 2008-12-16 09:38:11
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Dec 16 2008 09:38:08 UTC Log message: * gst/gsttaglist.c: Avoid copy of empty taglist. Modified files: . : ChangeLog gst : gsttaglist.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4195&r2=1.4196 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttaglist.c.diff?r1=1.67&r2=1.68 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4195 retrieving revision 1.4196 diff -u -d -r1.4195 -r1.4196 --- ChangeLog 16 Dec 2008 09:23:18 -0000 1.4195 +++ ChangeLog 16 Dec 2008 09:37:51 -0000 1.4196 @@ -1,6 +1,11 @@ 2008-12-16 Stefan Kost <en...@us...> * gst/gsttaglist.c: + Avoid copy of empty taglist. + +2008-12-16 Stefan Kost <en...@us...> + * gst/gsttaglist.c: * tests/check/gst/gsttag.c: More complete unit tests. Fix handling of empty taglists (they were not merged before). Index: gsttaglist.c RCS file: /cvs/gstreamer/gstreamer/gst/gsttaglist.c,v retrieving revision 1.67 retrieving revision 1.68 diff -u -d -r1.67 -r1.68 --- gsttaglist.c 16 Dec 2008 09:23:21 -0000 1.67 +++ gsttaglist.c 16 Dec 2008 09:37:53 -0000 1.68 @@ -692,8 +692,8 @@ gst_tag_list_merge (const GstTagList * list1, const GstTagList * list2, GstTagMergeMode mode) { - const GstTagList *list1_cp, *list2_cp; - GstTagList *ret; + GstTagList *list1_cp; + const GstTagList *list2_cp; g_return_val_if_fail (list1 == NULL || GST_IS_TAG_LIST (list1), NULL); g_return_val_if_fail (list2 == NULL || GST_IS_TAG_LIST (list2), NULL); @@ -705,18 +705,15 @@ } /* create empty list, we need to do this to correctly handling merge modes */ - list1_cp = (list1) ? list1 : gst_tag_list_new (); + list1_cp = (list1) ? gst_tag_list_copy (list1) : gst_tag_list_new (); list2_cp = (list2) ? list2 : gst_tag_list_new (); - ret = gst_tag_list_copy (list1_cp); - gst_tag_list_insert (ret, list2_cp, mode); + gst_tag_list_insert (list1_cp, list2_cp, mode); - if (!list1) - gst_tag_list_free ((GstTagList *) list1_cp); if (!list2) gst_tag_list_free ((GstTagList *) list2_cp); - return ret; + return list1_cp; } /** |
From: <en...@ke...> - 2009-01-08 13:41:40
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Jan 08 2009 13:41:33 UTC Log message: * gst/gst.c: Create a registry if there is none also when the option for gst-disable-registry-update has been selected. Fixes #567002 Modified files: . : ChangeLog gst : gst.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.4217&r2=1.4218 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gst.c.diff?r1=1.268&r2=1.269 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.4217 retrieving revision 1.4218 diff -u -d -r1.4217 -r1.4218 --- ChangeLog 6 Jan 2009 18:10:19 -0000 1.4217 +++ ChangeLog 8 Jan 2009 13:41:17 -0000 1.4218 @@ -1,3 +1,9 @@ +2009-01-08 Stefan Kost <en...@us...> + + * gst/gst.c: + Create a registry if there is none also when the option for + gst-disable-registry-update has been selected. Fixes #567002 2009-01-06 Tim-Philipp Müller <tim.muller at collabora co uk> * gst/gst.c: (init_post): Index: gst.c RCS file: /cvs/gstreamer/gstreamer/gst/gst.c,v retrieving revision 1.268 retrieving revision 1.269 diff -u -d -r1.268 -r1.269 --- gst.c 6 Jan 2009 18:10:22 -0000 1.268 +++ gst.c 8 Jan 2009 13:41:19 -0000 1.269 @@ -903,6 +903,7 @@ gboolean ret = TRUE; gboolean do_fork; gboolean do_update; + gboolean have_cache; default_registry = gst_registry_get_default (); registry_file = g_strdup (g_getenv ("GST_REGISTRY")); @@ -918,19 +919,23 @@ GST_INFO ("reading registry cache: %s", registry_file); #ifdef USE_BINARY_REGISTRY - gst_registry_binary_read_cache (default_registry, registry_file); + have_cache = gst_registry_binary_read_cache (default_registry, registry_file); #else - gst_registry_xml_read_cache (default_registry, registry_file); + have_cache = gst_registry_xml_read_cache (default_registry, registry_file); #endif - do_update = !_gst_disable_registry_update; - if (do_update) { - const gchar *update_env; + if (have_cache) { + do_update = !_gst_disable_registry_update; + if (do_update) { + const gchar *update_env; - if ((update_env = g_getenv ("GST_REGISTRY_UPDATE"))) { - /* do update for any value different from "no" */ - do_update = (strcmp (update_env, "no") != 0); + if ((update_env = g_getenv ("GST_REGISTRY_UPDATE"))) { + /* do update for any value different from "no" */ + do_update = (strcmp (update_env, "no") != 0); + } } + } else { + do_update = TRUE; } if (do_update) { |