From: <en...@ke...> - 2007-10-22 11:10:39
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Oct 22 2007 11:10:42 UTC Log message: * gst/gstdebugutils.c: Reflow code to fix uninitialized variable warning. Modified files: . : ChangeLog gst : gstdebugutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3488&r2=1.3489 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstdebugutils.c.diff?r1=1.1&r2=1.2 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3488 retrieving revision 1.3489 diff -u -d -r1.3488 -r1.3489 --- ChangeLog 22 Oct 2007 08:53:24 -0000 1.3488 +++ ChangeLog 22 Oct 2007 11:10:27 -0000 1.3489 @@ -1,3 +1,8 @@ +2007-10-22 Stefan Kost <en...@us...> + + * gst/gstdebugutils.c: + Reflow code to fix uninitialized variable warning. 2007-10-22 Edgard Lima <edg...@in...> * gst/gstcaps.c: (gst_caps_to_string), @@ -21,7 +26,6 @@ API: add gst_value_set_structure() API: add gst_value_get_structure() - 2007-10-19 Tim-Philipp Müller <tim at centricular dot net> * gst/gstbus.c: Index: gstdebugutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstdebugutils.c,v retrieving revision 1.1 retrieving revision 1.2 diff -u -d -r1.1 -r1.2 --- gstdebugutils.c 17 Oct 2007 12:58:23 -0000 1.1 +++ gstdebugutils.c 22 Oct 2007 11:10:28 -0000 1.2 @@ -250,11 +250,10 @@ if ((caps = gst_pad_get_negotiated_caps (pad))) { free_caps = TRUE; } else { - if ((caps = + free_caps = FALSE; + if (!(caps = (GstCaps *) gst_pad_get_pad_template_caps (pad))) { - free_caps = FALSE; - } else { /* this should not happen */ media = "?"; } |
From: <en...@ke...> - 2007-11-18 19:30:22
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Sun Nov 18 2007 19:30:24 UTC Log message: * gst/gstbin.c: * gst/gstdebugutils.c: Fix build with --disable-gst-debug. Fixes #497859. Spotted by Sameer Naik. Modified files: . : ChangeLog gst : gstbin.c gstdebugutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3534&r2=1.3535 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstbin.c.diff?r1=1.371&r2=1.372 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstdebugutils.c.diff?r1=1.6&r2=1.7 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3534 retrieving revision 1.3535 diff -u -d -r1.3534 -r1.3535 --- ChangeLog 17 Nov 2007 17:50:18 -0000 1.3534 +++ ChangeLog 18 Nov 2007 19:30:07 -0000 1.3535 @@ -1,3 +1,10 @@ +2007-11-18 Stefan Kost <en...@us...> + + * gst/gstbin.c: + * gst/gstdebugutils.c: + Fix build with --disable-gst-debug. Fixes #497859. + Spotted by Sameer Naik. 2007-11-17 Stefan Kost <en...@us...> * gst/gstevent.c: Index: gstbin.c RCS file: /cvs/gstreamer/gstreamer/gst/gstbin.c,v retrieving revision 1.371 retrieving revision 1.372 diff -u -d -r1.371 -r1.372 --- gstbin.c 14 Oct 2007 15:54:02 -0000 1.371 +++ gstbin.c 18 Nov 2007 19:30:09 -0000 1.372 @@ -1531,10 +1531,9 @@ gst_bin_get_state_func (GstElement * element, GstState * state, GstState * pending, GstClockTime timeout) { - GstBin *bin = GST_BIN (element); GstStateChangeReturn ret; - GST_CAT_INFO_OBJECT (GST_CAT_STATES, bin, "getting state"); + GST_CAT_INFO_OBJECT (GST_CAT_STATES, element, "getting state"); ret = parent_class->get_state (element, state, pending, timeout); Index: gstdebugutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstdebugutils.c,v retrieving revision 1.6 retrieving revision 1.7 diff -u -d -r1.6 -r1.7 --- gstdebugutils.c 7 Nov 2007 15:53:52 -0000 1.6 +++ gstdebugutils.c 18 Nov 2007 19:30:10 -0000 1.7 @@ -19,16 +19,16 @@ * Boston, MA 02111-1307, USA. */ -#ifndef GST_DISABLE_GST_DEBUG - #include "gst_private.h" +#include "gstdebugutils.h" +#ifndef GST_DISABLE_GST_DEBUG #include <stdlib.h> #include <stdio.h> #include <string.h> #include "gstinfo.h" -#include "gstdebugutils.h" #include "gstbin.h" #include "gstobject.h" #include "gstghostpad.h" |
From: <en...@ke...> - 2007-11-19 11:54:22
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Nov 19 2007 11:54:27 UTC Log message: * gst/gstpreset.c: Fix bogus warning and make the property type specific code more similar. Modified files: . : ChangeLog gst : gstpreset.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3537&r2=1.3538 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.c.diff?r1=1.4&r2=1.5 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3537 retrieving revision 1.3538 diff -u -d -r1.3537 -r1.3538 --- ChangeLog 19 Nov 2007 09:33:03 -0000 1.3537 +++ ChangeLog 19 Nov 2007 11:54:12 -0000 1.3538 @@ -1,3 +1,9 @@ +2007-11-19 Stefan Kost <en...@us...> + + * gst/gstpreset.c: + Fix bogus warning and make the property type specific code more + similar. 2007-11-19 Julien MOUTTE <ju...@mo...> * gst/gstpreset.c: (gst_preset_default_create_preset): Make Index: gstpreset.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.c,v retrieving revision 1.4 retrieving revision 1.5 diff -u -d -r1.4 -r1.5 --- gstpreset.c 19 Nov 2007 09:33:05 -0000 1.4 +++ gstpreset.c 19 Nov 2007 11:54:13 -0000 1.5 @@ -351,9 +351,9 @@ property->name); /* get base type */ base = property->value_type; - while ((parent = g_type_parent (base))) { + while ((parent = g_type_parent (base))) base = parent; - } switch (base) { case G_TYPE_INT: case G_TYPE_UINT: @@ -528,12 +528,12 @@ /* get base type */ base = property->value_type; - while ((parent = g_type_parent (base))) { + while ((parent = g_type_parent (base))) base = parent; - } /* get value and serialize */ GST_INFO (" storing property: %s (type is %s)", property->name, g_type_name (base)); switch (base) { case G_TYPE_BOOLEAN: case G_TYPE_ENUM: @@ -768,7 +768,7 @@ { GParamSpec **properties, *property; guint i, number_of_properties; - GType param_type, base_type; + GType base, parent; if ((properties = g_object_class_list_properties (G_OBJECT_CLASS (GST_OBJECT_GET_CLASS @@ -794,15 +794,16 @@ } */ - GST_INFO ("property '%s' (GType=%lu)", property->name, - property->value_type); + rnd = ((gdouble) rand ()) / (RAND_MAX + 1.0); - param_type = property->value_type; - while ((base_type = g_type_parent (param_type))) - param_type = base_type; + /* get base type */ + base = property->value_type; + base = parent; + GST_INFO ("set random value for property: %s (type is %s)", + property->name, g_type_name (base)); - rnd = ((gdouble) rand ()) / (RAND_MAX + 1.0); - switch (param_type) { + switch (base) { case G_TYPE_BOOLEAN:{ g_object_set (self, property->name, (gboolean) (2.0 * rnd), NULL); } @@ -838,7 +839,8 @@ enum_class->minimum) * rnd)), NULL); } break; default: - GST_WARNING ("unhandled GType=%lu", param_type); + GST_WARNING ("incomplete implementation for GParamSpec type '%s'", + G_PARAM_SPEC_TYPE_NAME (property)); } } /* @todo: handle childproxy properties as well */ |
From: <en...@ke...> - 2007-11-19 15:23:54
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Nov 19 2007 15:23:58 UTC Log message: * gst/gstpreset.c: More cleanups, docs, and TODOs from comments that now slowly come in. Modified files: . : ChangeLog gst : gstpreset.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3539&r2=1.3540 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.c.diff?r1=1.5&r2=1.6 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3539 retrieving revision 1.3540 diff -u -d -r1.3539 -r1.3540 --- ChangeLog 19 Nov 2007 14:38:47 -0000 1.3539 +++ ChangeLog 19 Nov 2007 15:23:43 -0000 1.3540 @@ -1,3 +1,8 @@ +2007-11-19 Stefan Kost <en...@us...> + + * gst/gstpreset.c: + More cleanups, docs, and TODOs from comments that now slowly come in. 2007-11-19 Julien MOUTTE <ju...@mo...> * docs/faq/gst-uninstalled: Add new base libraries in the LD Index: gstpreset.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.c,v retrieving revision 1.5 retrieving revision 1.6 diff -u -d -r1.5 -r1.6 --- gstpreset.c 19 Nov 2007 11:54:13 -0000 1.5 +++ gstpreset.c 19 Nov 2007 15:23:44 -0000 1.6 @@ -34,12 +34,15 @@ * - we need locks to avoid two instances manipulating the preset list -> flock * - need to add support for GstChildProxy * - how can we support both Preferences and Presets, - * - preferences = static settings (non controlable) + * - preferences = static settings, configurations (non controlable) + * e.g. alsasink:device * - preset = a snapshot of dynamic params - * - flag - * - we could save all, but have a flag when loading - * - we could use a flag for _get_preset_names() - * + * e.g. volume:volume + * - we could use a flag for _get_preset_names() + * - we could even use tags as part of preset metadata + * e.g. quality, performance, preset, config + * if there are some agreed tags, one could say, please optimize the pipline + * for 'performance' * - should there be a 'preset-list' property to get the preset list * (and to connect a notify:: to to listen for changes) * - should there be a 'preset-name' property so that we can set a preset via @@ -130,12 +133,12 @@ GST_INFO ("file_name: '%s'", file_name); /* '/home/ensonic/buzztard/lib/gstreamer-0.10/libgstsimsyn.so' - -> '/home/ensonic/buzztard/share/gstreamer-0.10/GstSimSyn.xml' - -> '$HOME/.gstreamer-0.10/presets/GstSimSyn.xml' + -> '/home/ensonic/buzztard/share/gstreamer-0.10/GstSimSyn.prs' + -> '$HOME/.gstreamer-0.10/presets/GstSimSyn.prs' '/usr/lib/gstreamer-0.10/libgstaudiofx.so' - -> '/usr/share/gstreamer-0.10/GstAudioPanorama.xml' - -> '$HOME/.gstreamer-0.10/presets/GstAudioPanorama.xml' + -> '/usr/share/gstreamer-0.10/GstAudioPanorama.prs' + -> '$HOME/.gstreamer-0.10/presets/GstAudioPanorama.prs' */ } @@ -156,6 +159,19 @@ return (preset_path); } +static gboolean +preset_skip_property (GParamSpec * property) +{ + /* @todo: currently we skip non-controlable parameters and thus only create + * presets, skipping the controlable one would create a config/preference + */ + if (!(property->flags & GST_PARAM_CONTROLLABLE) || + !(property->flags & G_PARAM_READABLE) || + (property->flags & G_PARAM_CONSTRUCT_ONLY)) + return TRUE; + return FALSE; +} static void preset_cleanup (gpointer user_data, GObject * self) { @@ -313,6 +329,7 @@ instances = g_list_prepend (instances, self); g_type_set_qdata (type, instance_list_quark, (gpointer) instances); } + /* @todo: copy strings to avoid races? transform into a strv? */ return (presets); @@ -342,9 +359,9 @@ (GST_ELEMENT_GET_CLASS (self)), &number_of_properties))) { for (i = 0; i < number_of_properties; i++) { property = properties[i]; - /* skip non-controlable */ - if (!(property->flags & GST_PARAM_CONTROLLABLE)) + if (preset_skip_property (property)) continue; /* check if we have a settings for this property */ if ((val = (gchar *) g_hash_table_lookup (data, property->name))) { GST_DEBUG ("setting value '%s' for property '%s'", val, @@ -523,7 +540,7 @@ /*flags=GPOINTER_TO_INT(g_param_spec_get_qdata(property,gst_property_meta_quark_flags)); */ /* skip non-controlable */ - if (!(property->flags & GST_PARAM_CONTROLLABLE)) + if (preset_skip_property (property)) continue; /* get base type */ @@ -596,6 +613,7 @@ } + /* @todo: handle childproxy properties as well */ GST_INFO (" saved"); @@ -780,7 +798,7 @@ property = properties[i]; /* skip non-controlable, and non persistent params */ /* we do not want to create a setting for trigger properties, buzztard has more flags attached to g_param_specs @@ -853,7 +871,7 @@ * gst_preset_get_preset_names: * @self: a #GObject that implements #GstPreset * - * Get a copy of the preset list names. Free list when done. + * Get a copy of the preset name list. Free list when done. * Returns: list with names */ |
From: <en...@ke...> - 2007-11-20 16:10:41
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Nov 20 2007 15:46:54 UTC Log message: * gst/gstpreset.c: * gst/gstpreset.h: Change _get_preset_names API to return a strv with copies. Add _get_property_names to allow implementations to filter and provide good default implementation. Modified files: . : ChangeLog gst : gstpreset.c gstpreset.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3541&r2=1.3542 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.c.diff?r1=1.6&r2=1.7 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.h.diff?r1=1.2&r2=1.3 ====Begin Diffs==== Index: gstpreset.c =================================================================== RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.c,v retrieving revision 1.6 retrieving revision 1.7 diff -u -d -r1.6 -r1.7 --- gstpreset.c 19 Nov 2007 15:23:44 -0000 1.6 +++ gstpreset.c 20 Nov 2007 15:46:39 -0000 1.7 @@ -29,9 +29,15 @@ * All instances of one type will share the list of presets. The list is created * on demand, if presets are not used, the list is not created. * + * The interface comes with a default implementation that servers most plugins. + * Wrapper plugins will override most methods to implement support for the + * native preset format of those wrapped plugins. + * One method that is useful to be overridde is gst_preset_get_property_names(). + * With that one can control which properties are saved and in which order. */ /* @todo: * - we need locks to avoid two instances manipulating the preset list -> flock + * better save the new file to a tempfile and then rename * - need to add support for GstChildProxy * - how can we support both Preferences and Presets, * - preferences = static settings, configurations (non controlable) @@ -68,6 +74,8 @@ static GQuark preset_meta_quark = 0; static GQuark instance_list_quark = 0; +/*static GQuark property_list_quark = 0;*/ + /* default iface implementation */ /* max character per line */ @@ -100,7 +108,7 @@ GST_DEBUG ("new data hash"); } } - GST_INFO ("%ld:%s: presets: %p, %p, %p", type, G_OBJECT_TYPE_NAME (self), + GST_INFO ("%s: presets: %p, %p, %p", G_OBJECT_TYPE_NAME (self), *presets, (preset_meta ? *preset_meta : 0), (preset_data ? *preset_data : 0)); return (res); @@ -162,11 +170,7 @@ static gboolean preset_skip_property (GParamSpec * property) { - /* @todo: currently we skip non-controlable parameters and thus only create - * presets, skipping the controlable one would create a config/preference - */ - if (!(property->flags & GST_PARAM_CONTROLLABLE) || - !(property->flags & G_PARAM_READABLE) || + if (!(property->flags & (G_PARAM_READABLE | G_PARAM_WRITABLE)) || (property->flags & G_PARAM_CONSTRUCT_ONLY)) return TRUE; return FALSE; @@ -187,7 +191,7 @@ } -static GList * +static gchar ** gst_preset_default_get_preset_names (GstPreset * self) GType type = G_TYPE_FROM_INSTANCE (self); @@ -329,8 +333,48 @@ instances = g_list_prepend (instances, self); g_type_set_qdata (type, instance_list_quark, (gpointer) instances); - /* @todo: copy strings to avoid races? transform into a strv? */ - return (presets); + /* copy strings to avoid races */ + if (presets) { + gchar **preset_names = g_new (gchar *, g_list_length (presets) + 1); + GList *node; + guint i = 0; + for (node = presets; node; node = g_list_next (node)) { + preset_names[i++] = g_strdup (node->data); + } + preset_names[i] = NULL; + return (preset_names); + } + return (NULL); +} +static GList * +gst_preset_default_get_property_names (GstPreset * self) +{ + GParamSpec **properties, *property; + GList *names = NULL; + guint i, number_of_properties; + if ((properties = g_object_class_list_properties (G_OBJECT_CLASS + (GST_ELEMENT_GET_CLASS (self)), &number_of_properties))) { + for (i = 0; i < number_of_properties; i++) { + property = properties[i]; + if (preset_skip_property (property) || + (property->flags & GST_PARAM_CONTROLLABLE)) + continue; + names = g_list_prepend (names, property->name); + !(property->flags & GST_PARAM_CONTROLLABLE)) + return names; @@ -345,22 +389,21 @@ if ((node = g_list_find_custom (presets, name, (GCompareFunc) strcmp))) { GHashTable *data = g_hash_table_lookup (preset_data, node->data); - GParamSpec **properties, *property; + GList *properties; GType base, parent; - guint i, number_of_properties; gchar *val = NULL; GST_DEBUG ("loading preset : '%s', data : %p (size=%d)", name, data, g_hash_table_size (data)); /* preset found, now set values */ - if ((properties = - g_object_class_list_properties (G_OBJECT_CLASS - (GST_ELEMENT_GET_CLASS (self)), &number_of_properties))) { - for (i = 0; i < number_of_properties; i++) { - property = properties[i]; - if (preset_skip_property (property)) - continue; + if ((properties = gst_preset_get_property_names (self))) { + GParamSpec *property; + GList *node; + for (node = properties; node; node = g_list_next (node)) { + property = g_object_class_find_property (G_OBJECT_CLASS + (GST_ELEMENT_GET_CLASS (self)), node->data); /* check if we have a settings for this property */ if ((val = (gchar *) g_hash_table_lookup (data, property->name))) { @@ -404,7 +447,10 @@ GST_INFO ("parameter '%s' not in preset", property->name); } } + g_list_free (properties); return (TRUE); + } else { + GST_INFO ("no properties"); } } else { @@ -516,9 +562,8 @@ GList *presets; GHashTable *preset_meta, *preset_data; GHashTable *meta, *data; - GParamSpec **properties, *property; + GList *properties; GType base, parent; - guint i, number_of_properties; gchar *str = NULL, buffer[30 + 1]; /*guint flags; */ @@ -532,16 +577,13 @@ meta = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free); /* take copies of current gobject properties from self */ - if ((properties = - g_object_class_list_properties (G_OBJECT_CLASS (GST_ELEMENT_GET_CLASS - (self)), &number_of_properties))) { - for (i = 0; i < number_of_properties; i++) { - property = properties[i]; - /*flags=GPOINTER_TO_INT(g_param_spec_get_qdata(property,gst_property_meta_quark_flags)); */ + if ((properties = gst_preset_get_property_names (self))) { + GParamSpec *property; - /* skip non-controlable */ - if (preset_skip_property (property)) - continue; + for (node = properties; node; node = g_list_next (node)) { + property = g_object_class_find_property (G_OBJECT_CLASS + (GST_ELEMENT_GET_CLASS (self)), node->data); /* get base type */ base = property->value_type; @@ -611,14 +653,16 @@ g_hash_table_insert (data, (gpointer) property->name, (gpointer) str); str = NULL; - + g_list_free (properties); /* @todo: handle childproxy properties as well */ GST_INFO (" saved"); + } else { + GST_INFO ("no properties"); /* - * flock(fileno()) + * @todo: flock(fileno()) * http://www.ecst.csuchico.edu/~beej/guide/ipc/flock.html */ g_hash_table_insert (preset_data, (gpointer) name, (gpointer) data); @@ -784,33 +828,17 @@ static void gst_preset_default_create_preset (GstPreset * self) - g_object_class_list_properties (G_OBJECT_CLASS (GST_OBJECT_GET_CLASS gdouble rnd; - GST_INFO ("nr of values : %d", number_of_properties); - /* skip non-controlable, and non persistent params */ - /* we do not want to create a setting for trigger properties, buzztard - has more flags attached to g_param_specs - else { - guint flags=0; - if(BT_IS_PROPERTY_META(self)) { - flags=GPOINTER_TO_INT(g_param_spec_get_qdata(property,bt_property_meta_quark_flags)); - } - if(!(flags&BT_PROPERTY_META_STATE)) continue; - */ rnd = ((gdouble) rand ()) / (RAND_MAX + 1.0); @@ -871,11 +899,12 @@ * gst_preset_get_preset_names: * @self: a #GObject that implements #GstPreset - * Get a copy of the preset name list. Free list when done. + * Get a copy of preset names as a NULL terminated string array. Free with + * g_strfreev() wen done. * Returns: list with names -GList * +gchar ** gst_preset_get_preset_names (GstPreset * self) g_return_val_if_fail (GST_IS_PRESET (self), NULL); @@ -884,6 +913,22 @@ /** + * gst_preset_get_property_names: + * @self: a #GObject that implements #GstPreset + * + * Get a the gobject property names to use for presets. + * Returns: list with names + */ +GList * +gst_preset_get_property_names (GstPreset * self) + g_return_val_if_fail (GST_IS_PRESET (self), NULL); + return (GST_PRESET_GET_INTERFACE (self)->get_property_names (self)); +/** * gst_preset_load_preset: * @name: preset name to load @@ -1031,6 +1076,7 @@ gst_preset_class_init (GstPresetInterface * iface) iface->get_preset_names = gst_preset_default_get_preset_names; + iface->get_property_names = gst_preset_default_get_property_names; iface->load_preset = gst_preset_default_load_preset; iface->save_preset = gst_preset_default_save_preset; @@ -1054,11 +1100,12 @@ GST_DEBUG_FG_WHITE | GST_DEBUG_BG_BLACK, "preset interface"); /* create quarks for use with g_type_{g,s}et_qdata() */ - preset_list_quark = g_quark_from_string ("GstPreset::presets"); - preset_path_quark = g_quark_from_string ("GstPreset::path"); - preset_data_quark = g_quark_from_string ("GstPreset::data"); - preset_meta_quark = g_quark_from_string ("GstPreset::meta"); - instance_list_quark = g_quark_from_string ("GstPreset::instances"); + preset_list_quark = g_quark_from_static_string ("GstPreset::presets"); + preset_path_quark = g_quark_from_static_string ("GstPreset::path"); + preset_data_quark = g_quark_from_static_string ("GstPreset::data"); + preset_meta_quark = g_quark_from_static_string ("GstPreset::meta"); + instance_list_quark = g_quark_from_static_string ("GstPreset::instances"); + /*property_list_quark = g_quark_from_static_string ("GstPreset::properties"); */ initialized = TRUE; Index: gstpreset.h RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.h,v retrieving revision 1.2 retrieving revision 1.3 diff -u -d -r1.2 -r1.3 --- gstpreset.h 17 Nov 2007 17:24:52 -0000 1.2 +++ gstpreset.h 20 Nov 2007 15:46:39 -0000 1.3 @@ -41,7 +41,8 @@ GTypeInterface parent; - GList* (*get_preset_names) (GstPreset *self); + gchar** (*get_preset_names) (GstPreset *self); + GList* (*get_property_names) (GstPreset * self); gboolean (*load_preset) (GstPreset *self, const gchar *name); gboolean (*save_preset) (GstPreset *self, const gchar *name); @@ -68,7 +69,8 @@ GType gst_preset_get_type(void); -GList* gst_preset_get_preset_names (GstPreset *self); +gchar** gst_preset_get_preset_names (GstPreset *self); +GList *gst_preset_get_property_names (GstPreset * self); gboolean gst_preset_load_preset (GstPreset *self, const gchar *name); gboolean gst_preset_save_preset (GstPreset *self, const gchar *name); Index: ChangeLog RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3541 retrieving revision 1.3542 diff -u -d -r1.3541 -r1.3542 --- ChangeLog 20 Nov 2007 11:46:32 -0000 1.3541 +++ ChangeLog 20 Nov 2007 15:46:37 -0000 1.3542 @@ -1,3 +1,11 @@ +2007-11-20 Stefan Kost <en...@us...> + * gst/gstpreset.c: + * gst/gstpreset.h: + Change _get_preset_names API to return a strv with copies. Add + _get_property_names to allow implementations to filter and provide + good default implementation. 2007-11-20 Julien MOUTTE <ju...@mo...> * docs/faq/gst-uninstalled: Add another library to the uninstalled |
From: <en...@ke...> - 2007-11-20 16:34:55
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Nov 20 2007 16:34:53 UTC Log message: * gst/gstpreset.c: Plug a leak and fix saving. Modified files: . : ChangeLog gst : gstpreset.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3543&r2=1.3544 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.c.diff?r1=1.7&r2=1.8 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3543 retrieving revision 1.3544 diff -u -d -r1.3543 -r1.3544 --- ChangeLog 20 Nov 2007 16:10:19 -0000 1.3543 +++ ChangeLog 20 Nov 2007 16:34:36 -0000 1.3544 @@ -1,3 +1,8 @@ +2007-11-20 Stefan Kost <en...@us...> + + * gst/gstpreset.c: + Plug a leak and fix saving. 2007-11-20 Sebastian Dröge <sl...@ci...> * docs/gst/gstreamer-sections.txt: Index: gstpreset.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.c,v retrieving revision 1.7 retrieving revision 1.8 diff -u -d -r1.7 -r1.8 --- gstpreset.c 20 Nov 2007 15:46:39 -0000 1.7 +++ gstpreset.c 20 Nov 2007 16:34:38 -0000 1.8 @@ -357,6 +357,7 @@ if ((properties = g_object_class_list_properties (G_OBJECT_CLASS (GST_ELEMENT_GET_CLASS (self)), &number_of_properties))) { + GST_INFO (" filtering properties: %u", number_of_properties); for (i = 0; i < number_of_properties; i++) { property = properties[i]; if (preset_skip_property (property) || @@ -373,6 +374,9 @@ names = g_list_prepend (names, property->name); } + g_free (properties); + } else { + GST_INFO ("no properties"); } return names; } @@ -653,10 +657,10 @@ g_hash_table_insert (data, (gpointer) property->name, (gpointer) str); str = NULL; } - g_list_free (properties); /* @todo: handle childproxy properties as well */ GST_INFO (" saved"); + g_list_free (properties); } else { GST_INFO ("no properties"); |
From: <en...@ke...> - 2007-11-21 16:08:36
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Nov 21 2007 16:08:40 UTC Log message: * gst/gstpreset.c: For theses two fgets we handle the error below. Modified files: . : ChangeLog gst : gstpreset.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3548&r2=1.3549 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.c.diff?r1=1.8&r2=1.9 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3548 retrieving revision 1.3549 diff -u -d -r1.3548 -r1.3549 --- ChangeLog 21 Nov 2007 13:47:50 -0000 1.3548 +++ ChangeLog 21 Nov 2007 16:08:23 -0000 1.3549 @@ -1,3 +1,8 @@ +2007-11-21 Stefan Kost <en...@us...> + + * gst/gstpreset.c: + For theses two fgets we handle the error below. 2007-11-21 Wim Taymans <wim...@gm...> * libs/gst/base/gstbasesink.c: (gst_base_sink_send_event): Index: gstpreset.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.c,v retrieving revision 1.8 retrieving revision 1.9 diff -u -d -r1.8 -r1.9 --- gstpreset.c 20 Nov 2007 16:34:38 -0000 1.8 +++ gstpreset.c 21 Nov 2007 16:08:25 -0000 1.9 @@ -248,7 +248,7 @@ /* read preset entries */ while (!feof (in)) { /* read preset entry */ - fgets (line, LINE_LEN, in); + (void) fgets (line, LINE_LEN, in); g_strchomp (line); if (*line) { preset_name = g_strdup (line); @@ -261,7 +261,7 @@ /* read preset lines */ parse_preset = TRUE; while (parse_preset) { - fgets (line, LINE_LEN, in); + (void) fgets (line, LINE_LEN, in); if (feof (in) || (*line == '\n')) { GST_DEBUG ("preset done"); parse_preset = FALSE; |
From: <en...@ke...> - 2007-11-22 13:56:37
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Nov 22 2007 13:56:38 UTC Log message: * gst/gstpreset.c: Try harder to use the return value from fgets(). Modified files: . : ChangeLog gst : gstpreset.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3549&r2=1.3550 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpreset.c.diff?r1=1.9&r2=1.10 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3549 retrieving revision 1.3550 diff -u -d -r1.3549 -r1.3550 --- ChangeLog 21 Nov 2007 16:08:23 -0000 1.3549 +++ ChangeLog 22 Nov 2007 13:56:22 -0000 1.3550 @@ -1,3 +1,8 @@ +2007-11-22 Stefan Kost <en...@us...> + + * gst/gstpreset.c: + Try harder to use the return value from fgets(). 2007-11-21 Stefan Kost <en...@us...> * gst/gstpreset.c: Index: gstpreset.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpreset.c,v retrieving revision 1.9 retrieving revision 1.10 diff -u -d -r1.9 -r1.10 --- gstpreset.c 21 Nov 2007 16:08:25 -0000 1.9 +++ gstpreset.c 22 Nov 2007 13:56:24 -0000 1.10 @@ -141,11 +141,11 @@ GST_INFO ("file_name: '%s'", file_name); /* '/home/ensonic/buzztard/lib/gstreamer-0.10/libgstsimsyn.so' - -> '/home/ensonic/buzztard/share/gstreamer-0.10/GstSimSyn.prs' + -> '/home/ensonic/buzztard/share/gstreamer-0.10/presets/GstSimSyn.prs' -> '$HOME/.gstreamer-0.10/presets/GstSimSyn.prs' '/usr/lib/gstreamer-0.10/libgstaudiofx.so' - -> '/usr/share/gstreamer-0.10/GstAudioPanorama.prs' + -> '/usr/share/gstreamer-0.10/presets/GstAudioPanorama.prs' -> '$HOME/.gstreamer-0.10/presets/GstAudioPanorama.prs' */ } @@ -248,7 +248,8 @@ /* read preset entries */ while (!feof (in)) { /* read preset entry */ - (void) fgets (line, LINE_LEN, in); + if (!fgets (line, LINE_LEN, in)) + break; g_strchomp (line); if (*line) { preset_name = g_strdup (line); @@ -261,8 +262,7 @@ /* read preset lines */ parse_preset = TRUE; while (parse_preset) { - (void) fgets (line, LINE_LEN, in); - if (feof (in) || (*line == '\n')) { + if (!fgets (line, LINE_LEN, in) || (*line == '\n')) { GST_DEBUG ("preset done"); parse_preset = FALSE; break; |
From: <en...@ke...> - 2007-11-28 11:39:44
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Nov 28 2007 11:39:49 UTC Log message: * configure.ac: * gst/gstdebugutils.c: * gst/gstinfo.c: Apply the posix-timer check from #361155. Conditionally use the posix timer for logging. This gives better timestamp precission, less overhead and no ntp jitter. Modified files: . : ChangeLog configure.ac gst : gstdebugutils.c gstinfo.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3556&r2=1.3557 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/configure.ac.diff?r1=1.516&r2=1.517 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstdebugutils.c.diff?r1=1.8&r2=1.9 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstinfo.c.diff?r1=1.137&r2=1.138 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3556 retrieving revision 1.3557 diff -u -d -r1.3556 -r1.3557 --- ChangeLog 28 Nov 2007 11:11:56 -0000 1.3556 +++ ChangeLog 28 Nov 2007 11:39:33 -0000 1.3557 @@ -1,3 +1,12 @@ +2007-11-28 Stefan Kost <en...@us...> + + * configure.ac: + * gst/gstdebugutils.c: + * gst/gstinfo.c: + Apply the posix-timer check from #361155. Conditionally use the posix + timer for logging. This gives better timestamp precission, less + overhead and no ntp jitter. 2007-11-28 Sebastian Dröge <sl...@ci...> * gst/gstminiobject.c: (gst_mini_object_get_type), Index: configure.ac RCS file: /cvs/gstreamer/gstreamer/configure.ac,v retrieving revision 1.516 retrieving revision 1.517 diff -u -d -r1.516 -r1.517 --- configure.ac 16 Nov 2007 00:23:18 -0000 1.516 +++ configure.ac 28 Nov 2007 11:39:34 -0000 1.517 @@ -358,6 +358,58 @@ AC_FUNC_MMAP AM_CONDITIONAL(HAVE_MMAP, test "x$ac_cv_func_mmap_fixed_mapped" = "xyes") +dnl Check for POSIX timers +AC_CHECK_FUNCS(clock_gettime, [], [ + AC_CHECK_LIB(rt, clock_gettime, [ + AC_DEFINE(HAVE_CLOCK_GETTIME, 1) + LIBS="$LIBS -lrt" + ]) +]) +AC_CACHE_CHECK(for posix timers, gst_cv_posix_timers,AC_TRY_RUN([ +#include <time.h> +#ifdef HAVE_UNISTD_H +#include <unistd.h> +#endif + int main() { +#if defined(_POSIX_TIMERS) && _POSIX_TIMERS >= 0 && defined(CLOCK_REALTIME) + return 0; +#else + return 1; + }],gst_cv_posix_timers=yes,gst_cv_posix_timers=no)) +if test "$gst_cv_posix_timers" = "yes"; then + AC_DEFINE(HAVE_POSIX_TIMERS,1,[Have posix timers]) + GST_HAVE_POSIX_TIMERS_DEFINE="#define GST_HAVE_POSIX_TIMERS 1" +else + GST_HAVE_POSIX_TIMERS_DEFINE="#define GST_HAVE_POSIX_TIMERS 0" +fi +AC_SUBST(GST_HAVE_POSIX_TIMERS_DEFINE) +AM_CONDITIONAL(GST_HAVE_POSIX_TIMERS, test "$gst_cv_posix_timers" = "yes") +AC_CACHE_CHECK(for monotonic clock, gst_cv_monotonic_clock,AC_TRY_RUN([ +#if defined(_POSIX_MONOTONIC_CLOCK) && _POSIX_MONOTONIC_CLOCK >= 0 && defined(CLOCK_MONOTONIC) + }],gst_cv_monotonic_clock=yes,gst_cv_monotonic_clock=no)) +if test "$gst_cv_monotonic_clock" = "yes"; then + AC_DEFINE(HAVE_MONOTONIC_CLOCK,1,[Have a monotonic clock]) + GST_HAVE_MONOTONIC_CLOCK_DEFINE="#define GST_HAVE_MONOTONIC_CLOCK 1" + GST_HAVE_MONOTONIC_CLOCK_DEFINE="#define GST_HAVE_MONOTONIC_CLOCK 0" +AC_SUBST(GST_HAVE_MONOTONIC_CLOCK_DEFINE) +AM_CONDITIONAL(GST_HAVE_MONOTONIC_CLOCK, test "$gst_cv_monotonic_clock" = "yes") dnl Check for a way to display the function name in debug output AG_GST_CHECK_FUNCTION Index: gstdebugutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstdebugutils.c,v retrieving revision 1.8 retrieving revision 1.9 diff -u -d -r1.8 -r1.9 --- gstdebugutils.c 22 Nov 2007 15:59:00 -0000 1.8 +++ gstdebugutils.c 28 Nov 2007 11:39:35 -0000 1.9 @@ -496,7 +496,6 @@ const gchar * file_name) { gchar *ts_file_name = NULL; - GTimeVal now; GstClockTime elapsed; g_return_if_fail (GST_IS_BIN (bin)); @@ -508,8 +507,21 @@ } /* add timestamp */ - g_get_current_time (&now); - elapsed = GST_TIMEVAL_TO_TIME (now) - _priv_gst_info_start_time; +#ifdef HAVE_POSIX_TIMERS + { + struct timespec now; + clock_gettime (CLOCK_MONOTONIC, &now); + elapsed = GST_TIMESPEC_TO_TIME (now) - _priv_gst_info_start_time; + } + GTimeVal now; + g_get_current_time (&now); + elapsed = GST_TIMEVAL_TO_TIME (now) - _priv_gst_info_start_time; ts_file_name = g_strdup_printf ("%" GST_TIME_FORMAT "-%s", GST_TIME_ARGS (elapsed), file_name); Index: gstinfo.c RCS file: /cvs/gstreamer/gstreamer/gst/gstinfo.c,v retrieving revision 1.137 retrieving revision 1.138 diff -u -d -r1.137 -r1.138 --- gstinfo.c 6 Nov 2007 15:10:35 -0000 1.137 +++ gstinfo.c 28 Nov 2007 11:39:35 -0000 1.138 @@ -277,14 +277,25 @@ void _gst_debug_init (void) - GTimeVal current; - gst_atomic_int_set (&__default_level, GST_LEVEL_DEFAULT); gst_atomic_int_set (&__use_color, 1); /* get time we started for debugging messages */ - g_get_current_time (¤t); - _priv_gst_info_start_time = GST_TIMEVAL_TO_TIME (current); + struct timespec current; + clock_gettime (CLOCK_MONOTONIC, ¤t); + _priv_gst_info_start_time = GST_TIMESPEC_TO_TIME (current); + GTimeVal current; + g_get_current_time (¤t); + _priv_gst_info_start_time = GST_TIMEVAL_TO_TIME (current); #ifdef HAVE_PRINTF_EXTENSION register_printf_function (GST_PTR_FORMAT[0], _gst_info_printf_extension_ptr, @@ -629,7 +640,6 @@ gchar pidcolor[10]; const gchar *levelcolor; gint pid; gboolean free_color = TRUE; gboolean free_obj = TRUE; @@ -669,8 +679,21 @@ free_obj = FALSE; /* g_printerr ("%s (%p - %" GST_TIME_FORMAT ") %s%20s%s(%s%5d%s) %s%s(%d):%s:%s%s %s\n", |
From: <en...@ke...> - 2007-12-11 20:32:37
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Dec 11 2007 20:32:43 UTC Log message: * gst/gstutils.c: * gst/gstutils.h: Actually its not PURE as it gets the time from elsewhere. Modified files: . : ChangeLog gst : gstutils.c gstutils.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3566&r2=1.3567 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstutils.c.diff?r1=1.165&r2=1.166 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstutils.h.diff?r1=1.83&r2=1.84 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3566 retrieving revision 1.3567 diff -u -d -r1.3566 -r1.3567 --- ChangeLog 11 Dec 2007 20:23:54 -0000 1.3566 +++ ChangeLog 11 Dec 2007 20:32:26 -0000 1.3567 @@ -1,5 +1,11 @@ 2007-12-11 Stefan Kost <en...@us...> + * gst/gstutils.c: + * gst/gstutils.h: + Actually its not PURE as it gets the time from elsewhere. + +2007-12-11 Stefan Kost <en...@us...> * docs/gst/gstreamer-sections.txt: * gst/gstclock.h: * gst/gstdebugutils.c: Index: gstutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstutils.c,v retrieving revision 1.165 retrieving revision 1.166 diff -u -d -r1.165 -r1.166 --- gstutils.c 11 Dec 2007 20:23:57 -0000 1.165 +++ gstutils.c 11 Dec 2007 20:32:28 -0000 1.166 @@ -3339,7 +3339,7 @@ * * Since: 0.10.16 */ -G_GNUC_PURE GstClockTime +GstClockTime gst_util_get_timestamp (void) { #ifdef HAVE_POSIX_TIMERS Index: gstutils.h RCS file: /cvs/gstreamer/gstreamer/gst/gstutils.h,v retrieving revision 1.83 retrieving revision 1.84 diff -u -d -r1.83 -r1.84 --- gstutils.h 11 Dec 2007 20:23:57 -0000 1.83 +++ gstutils.h 11 Dec 2007 20:32:29 -0000 1.84 @@ -689,7 +689,7 @@ gboolean ghost_unconnected_pads, GError ** err); -GstClockTime gst_util_get_timestamp (void) G_GNUC_PURE; +GstClockTime gst_util_get_timestamp (void); G_END_DECLS |
From: <en...@ke...> - 2007-12-11 22:04:09
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Dec 11 2007 22:04:12 UTC Log message: * gst/gstplugin.c: Include "glib-compat-private.h" to fix the build on system with glib < 2.10. Fixes #503131. Modified files: . : ChangeLog gst : gstplugin.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3567&r2=1.3568 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstplugin.c.diff?r1=1.180&r2=1.181 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3567 retrieving revision 1.3568 diff -u -d -r1.3567 -r1.3568 --- ChangeLog 11 Dec 2007 20:32:26 -0000 1.3567 +++ ChangeLog 11 Dec 2007 22:03:57 -0000 1.3568 @@ -1,5 +1,11 @@ 2007-12-11 Stefan Kost <en...@us...> + * gst/gstplugin.c: + Include "glib-compat-private.h" to fix the build on system with + glib < 2.10. Fixes #503131. + +2007-12-11 Stefan Kost <en...@us...> * gst/gstutils.c: * gst/gstutils.h: Actually its not PURE as it gets the time from elsewhere. Index: gstplugin.c RCS file: /cvs/gstreamer/gstreamer/gst/gstplugin.c,v retrieving revision 1.180 retrieving revision 1.181 diff -u -d -r1.180 -r1.181 --- gstplugin.c 6 Nov 2007 15:10:35 -0000 1.180 +++ gstplugin.c 11 Dec 2007 22:03:58 -0000 1.181 @@ -64,6 +64,7 @@ #include <errno.h> #include "gst_private.h" +#include "glib-compat-private.h" #include <gst/gst.h> |
From: <en...@ke...> - 2007-12-12 06:59:06
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Dec 12 2007 06:59:10 UTC Log message: * gst/gstutils.c: Add mising "Since:" to docs. Modified files: . : ChangeLog gst : gstutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3568&r2=1.3569 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstutils.c.diff?r1=1.166&r2=1.167 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3568 retrieving revision 1.3569 diff -u -d -r1.3568 -r1.3569 --- ChangeLog 11 Dec 2007 22:03:57 -0000 1.3568 +++ ChangeLog 12 Dec 2007 06:58:54 -0000 1.3569 @@ -1,3 +1,8 @@ +2007-12-12 Stefan Kost <en...@us...> + + * gst/gstutils.c: + Add mising "Since:" to docs. 2007-12-11 Stefan Kost <en...@us...> * gst/gstplugin.c: Index: gstutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstutils.c,v retrieving revision 1.166 retrieving revision 1.167 diff -u -d -r1.166 -r1.167 --- gstutils.c 11 Dec 2007 20:32:28 -0000 1.166 +++ gstutils.c 12 Dec 2007 06:58:56 -0000 1.167 @@ -1031,6 +1031,8 @@ * Gets a string representing the given state change result. * * Returns: a string with the name of the state change result. + * + * Since: 0.10.11 */ G_CONST_RETURN gchar * gst_element_state_change_return_get_name (GstStateChangeReturn state_ret) |
From: <en...@ke...> - 2007-12-12 14:04:24
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Dec 12 2007 14:04:28 UTC Log message: * gst/gstvalue.c: * gst/gstvalue.h: Add more missing "Since:" tags to docs. Modified files: . : ChangeLog gst : gstvalue.c gstvalue.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3569&r2=1.3570 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.c.diff?r1=1.137&r2=1.138 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstvalue.h.diff?r1=1.48&r2=1.49 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3569 retrieving revision 1.3570 diff -u -d -r1.3569 -r1.3570 --- ChangeLog 12 Dec 2007 06:58:54 -0000 1.3569 +++ ChangeLog 12 Dec 2007 14:04:13 -0000 1.3570 @@ -1,5 +1,11 @@ 2007-12-12 Stefan Kost <en...@us...> + * gst/gstvalue.c: + * gst/gstvalue.h: + Add more missing "Since:" tags to docs. + +2007-12-12 Stefan Kost <en...@us...> * gst/gstutils.c: Add mising "Since:" to docs. Index: gstvalue.c RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.c,v retrieving revision 1.137 retrieving revision 1.138 diff -u -d -r1.137 -r1.138 --- gstvalue.c 6 Nov 2007 11:41:32 -0000 1.137 +++ gstvalue.c 12 Dec 2007 14:04:14 -0000 1.138 @@ -1292,6 +1292,8 @@ * @structure: the structure to set the value to * * Sets the contents of @value to @structure. The actual + * + * Since: 0.10.15 */ void gst_value_set_structure (GValue * value, const GstStructure * structure) @@ -1308,6 +1310,8 @@ * Gets the contents of @value. * Returns: the contents of @value const GstStructure * gst_value_get_structure (const GValue * value) Index: gstvalue.h RCS file: /cvs/gstreamer/gstreamer/gst/gstvalue.h,v retrieving revision 1.48 retrieving revision 1.49 diff -u -d -r1.48 -r1.49 --- gstvalue.h 2 Nov 2007 18:35:37 -0000 1.48 +++ gstvalue.h 12 Dec 2007 14:04:14 -0000 1.49 @@ -146,6 +146,8 @@ * @x: the #GValue to check * Checks if the given #GValue contains a #GST_TYPE_STRUCTURE value. #define GST_VALUE_HOLDS_STRUCTURE(x) (G_VALUE_HOLDS(x, GST_TYPE_STRUCTURE)) |
From: <en...@ke...> - 2008-01-10 21:07:07
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Jan 10 2008 21:07:13 UTC Log message: * gst/gstchildproxy.c: Improve docs and add some ideas for making this more general-purpose. Modified files: . : ChangeLog gst : gstchildproxy.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3624&r2=1.3625 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstchildproxy.c.diff?r1=1.10&r2=1.11 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3624 retrieving revision 1.3625 diff -u -d -r1.3624 -r1.3625 --- ChangeLog 10 Jan 2008 15:55:30 -0000 1.3624 +++ ChangeLog 10 Jan 2008 21:06:56 -0000 1.3625 @@ -1,3 +1,8 @@ +2008-01-10 Stefan Kost <en...@us...> + + * gst/gstchildproxy.c: + Improve docs and add some ideas for making this more general-purpose. 2008-01-10 Tim-Philipp Müller <tim at centricular dot net> * gst/gst_private.h: (GST_CAT_TYPES): Index: gstchildproxy.c RCS file: /cvs/gstreamer/gstreamer/gst/gstchildproxy.c,v retrieving revision 1.10 retrieving revision 1.11 diff -u -d -r1.10 -r1.11 --- gstchildproxy.c 14 Mar 2007 13:40:28 -0000 1.10 +++ gstchildproxy.c 10 Jan 2008 21:06:58 -0000 1.11 @@ -24,17 +24,26 @@ * @short_description: Interface for multi child elements. * @see_also: #GstBin * - * This interface abstracts handling of property sets for child elements. - * Imagine elements such as mixers or polyphonic generators. They all have - * multiple #GstPad or some kind of voice objects. The element acts as a - * parent for those child objects. Each child has the same properties. + * This interface abstracts handling of property sets for elements with + * children. Imagine elements such as mixers or polyphonic generators. They all + * have multiple #GstPad or some kind of voice objects. Another use case are + * container elements like #GstBin. + * The element implementing the interface acts as a parent for those child + * objects. * By implementing this interface the child properties can be accessed from the * parent element by using gst_child_proxy_get() and gst_child_proxy_set(). * Property names are written as "child-name::property-name". The whole naming * scheme is recursive. Thus "child1::child2::property" is valid too, if - * "child1" also implements the #GstChildProxy interface. + * "child1" and "child2" implement the #GstChildProxy interface. + */ +/* FIXME-0.11: + * it would be nice to make gst_child_proxy_get_child_by_name virtual too and + * use GObject instead of GstObject. We could eventually provide the current + * implementation as a default if children are GstObjects. + * This change would allow to propose the interface for inclusion with + * glib/gobject. IMHO this is useful for GtkContainer and compound widgets too. */ #include "gst_private.h" |
From: <en...@ke...> - 2008-01-14 13:18:48
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Jan 14 2008 13:18:52 UTC Log message: * gst/gstminiobject.c: Spelling fixes for the API docs. Modified files: . : ChangeLog gst : gstminiobject.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3628&r2=1.3629 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstminiobject.c.diff?r1=1.32&r2=1.33 ====Begin Diffs==== Index: gstminiobject.c =================================================================== RCS file: /cvs/gstreamer/gstreamer/gst/gstminiobject.c,v retrieving revision 1.32 retrieving revision 1.33 diff -u -d -r1.32 -r1.33 --- gstminiobject.c 28 Nov 2007 11:11:58 -0000 1.32 +++ gstminiobject.c 14 Jan 2008 13:18:37 -0000 1.33 @@ -235,7 +235,7 @@ * gst_mini_object_make_writable: * @mini_object: the mini-object to make writable * - * Checks if a mini-object is writable. If not, a writeable copy is made and + * Checks if a mini-object is writable. If not, a writable copy is made and * returned. This gives away the reference to the original mini object, * and returns a reference to the new object. @@ -270,7 +270,7 @@ * of @mini-object, see gst_mini_object_is_writable(). It is * important to note that keeping additional references to * GstMiniObject instances can potentially increase the number - * of memcpy operations in a pipeline, especially if the minibject + * of memcpy operations in a pipeline, especially if the miniobject * is a #GstBuffer. * Returns: the mini-object. @@ -280,7 +280,7 @@ { g_return_val_if_fail (mini_object != NULL, NULL); /* we cannot assert that the refcount > 0 since a bufferalloc - * function might resurect an object + * function might resurrect an object g_return_val_if_fail (mini_object->refcount > 0, NULL); */ #ifdef DEBUG_REFCOUNT Index: ChangeLog RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3628 retrieving revision 1.3629 diff -u -d -r1.3628 -r1.3629 --- ChangeLog 14 Jan 2008 11:47:32 -0000 1.3628 +++ ChangeLog 14 Jan 2008 13:18:35 -0000 1.3629 @@ -1,5 +1,10 @@ 2008-01-14 Stefan Kost <en...@us...> + * gst/gstminiobject.c: + Spelling fixes for the API docs. + +2008-01-14 Stefan Kost <en...@us...> * libs/gst/base/gstbasetransform.c: Fix long property description for QoS. |
From: <en...@ke...> - 2008-02-05 19:42:43
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Tue Feb 05 2008 19:42:46 UTC Log message: * gst/gstpluginfeature.h: Clarify GstRank range docs. Modified files: . : ChangeLog gst : gstpluginfeature.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3660&r2=1.3661 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpluginfeature.h.diff?r1=1.27&r2=1.28 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3660 retrieving revision 1.3661 diff -u -d -r1.3660 -r1.3661 --- ChangeLog 5 Feb 2008 18:37:05 -0000 1.3660 +++ ChangeLog 5 Feb 2008 19:42:30 -0000 1.3661 @@ -1,3 +1,8 @@ +2008-02-05 Stefan Kost <en...@us...> + + * gst/gstpluginfeature.h: + Clarify GstRank range docs. 2008-02-05 David Schleef <ds...@sc...> * gst/gst.c: Add a separate gst_deinitialized that prevents Index: gstpluginfeature.h RCS file: /cvs/gstreamer/gstreamer/gst/gstpluginfeature.h,v retrieving revision 1.27 retrieving revision 1.28 diff -u -d -r1.27 -r1.28 --- gstpluginfeature.h 13 Oct 2007 17:20:09 -0000 1.27 +++ gstpluginfeature.h 5 Feb 2008 19:42:31 -0000 1.28 @@ -59,9 +59,9 @@ * similar rank-picking mechanisms) will choose this element over an alternative * one with the same function. * - * The rank is a unsigned integer ranging from 0 (GST_RANK_NONE) to 256 - * (GST_RANK_PRIMARY). These constants serve as a rough guidiance for defining - * the rank of a #GstPlugin using gst_plugin_feature_set_rank(). + * These constants serve as a rough guidiance for defining the rank of a + * #GstPlugin using gst_plugin_feature_set_rank() - any value including those + * bigger than @GST_RANK_PRIMARY are valid. */ typedef enum { GST_RANK_NONE = 0, |
From: <en...@ke...> - 2008-02-15 12:33:11
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Fri Feb 15 2008 12:33:14 UTC Log message: * gst/gstbuffer.c: Copy selected buffer-flags when creating subbuffers. Fixes #516395. Modified files: . : ChangeLog gst : gstbuffer.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3668&r2=1.3669 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstbuffer.c.diff?r1=1.141&r2=1.142 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3668 retrieving revision 1.3669 diff -u -d -r1.3668 -r1.3669 --- ChangeLog 12 Feb 2008 12:04:41 -0000 1.3668 +++ ChangeLog 15 Feb 2008 12:32:58 -0000 1.3669 @@ -1,3 +1,9 @@ +2008-02-15 Stefan Kost <en...@us...> + + * gst/gstbuffer.c: + Copy selected buffer-flags when creating subbuffers. + Fixes #516395. 2008-02-12 Sebastian Dröge <sl...@ci...> * gst/gstbuffer.c: (gst_buffer_class_init), (gst_buffer_finalize): Index: gstbuffer.c RCS file: /cvs/gstreamer/gstreamer/gst/gstbuffer.c,v retrieving revision 1.141 retrieving revision 1.142 diff -u -d -r1.141 -r1.142 --- gstbuffer.c 12 Feb 2008 12:04:42 -0000 1.141 +++ gstbuffer.c 15 Feb 2008 12:33:00 -0000 1.142 @@ -464,12 +464,6 @@ } else { ret = gst_buffer_create_sub (buf, 0, GST_BUFFER_SIZE (buf)); - /* copy all the flags except IN_CAPS */ - GST_BUFFER_FLAGS (ret) = GST_BUFFER_FLAGS (buf); - GST_BUFFER_FLAG_UNSET (ret, GST_BUFFER_FLAG_IN_CAPS); - /* data should always be set to READONLY */ - GST_BUFFER_FLAG_SET (ret, GST_BUFFER_FLAG_READONLY); - gst_buffer_unref (buf); } @@ -599,6 +593,16 @@ GST_BUFFER_DATA (GST_BUFFER_CAST (subbuffer)) = buffer->data + offset; GST_BUFFER_SIZE (GST_BUFFER_CAST (subbuffer)) = size; + if ((offset == 0) && (size == GST_BUFFER_SIZE (buffer))) { + /* copy all the flags except IN_CAPS */ + GST_BUFFER_FLAG_SET (subbuffer, GST_BUFFER_FLAGS (buffer)); + GST_BUFFER_FLAG_UNSET (subbuffer, GST_BUFFER_FLAG_IN_CAPS); + } else { + /* copy only PREROLL & GAP flags */ + GST_BUFFER_FLAG_SET (subbuffer, (GST_BUFFER_FLAGS (buffer) & + (GST_BUFFER_FLAG_PREROLL | GST_BUFFER_FLAG_GAP))); + } /* we can copy the timestamp and offset if the new buffer starts at * offset 0 */ if (offset == 0) { |
From: <en...@ke...> - 2008-03-31 07:49:38
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Mar 31 2008 07:49:40 UTC Log message: * gst/gstdebugutils.c: Improve handling ghost/proxy pads. Modified files: . : ChangeLog gst : gstdebugutils.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3733&r2=1.3734 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstdebugutils.c.diff?r1=1.15&r2=1.16 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3733 retrieving revision 1.3734 diff -u -d -r1.3733 -r1.3734 --- ChangeLog 27 Mar 2008 19:13:38 -0000 1.3733 +++ ChangeLog 31 Mar 2008 07:49:24 -0000 1.3734 @@ -1,3 +1,8 @@ +2008-03-31 Stefan Kost <en...@us...> + + * gst/gstdebugutils.c: + Improve handling ghost/proxy pads. 2008-03-27 Stefan Kost <en...@us...> * docs/gst/gstreamer-sections.txt: Index: gstdebugutils.c RCS file: /cvs/gstreamer/gstreamer/gst/gstdebugutils.c,v retrieving revision 1.15 retrieving revision 1.16 diff -u -d -r1.15 -r1.16 --- gstdebugutils.c 5 Jan 2008 13:45:22 -0000 1.15 +++ gstdebugutils.c 31 Mar 2008 07:49:26 -0000 1.16 @@ -134,7 +134,7 @@ GstIterator *element_iter, *pad_iter; gboolean elements_done, pads_done; GstElement *element, *peer_element, *target_element; - GstPad *pad, *peer_pad, *target_pad; + GstPad *pad, *peer_pad, *target_pad, *tmp_pad; GstPadDirection dir; GstCaps *caps; GstStructure *structure; @@ -317,58 +317,64 @@ } if (GST_IS_GHOST_PAD (pad)) { - if ((target_pad = + if ((tmp_pad = gst_ghost_pad_get_target (GST_GHOST_PAD (pad)))) { - target_pad_name = - debug_dump_make_object_name (GST_OBJECT - (target_pad)); - if ((target_element = - gst_pad_get_parent_element (target_pad))) { - target_element_name = + if ((target_pad = gst_pad_get_peer (tmp_pad))) { + target_pad_name = debug_dump_make_object_name (GST_OBJECT - (target_element)); - } else { - target_element_name = ""; - } - /* src ghostpad relationship */ - fprintf (out, "%s%s_%s -> %s_%s [style=dashed]\n", spc, - target_element_name, target_pad_name, element_name, - pad_name); + (target_pad)); + if ((target_element = + gst_pad_get_parent_element (target_pad))) { + target_element_name = + debug_dump_make_object_name (GST_OBJECT + (target_element)); + } else { + target_element_name = ""; + } + /* src ghostpad relationship */ + fprintf (out, "%s%s_%s -> %s_%s [style=dashed]\n", + spc, target_element_name, target_pad_name, + element_name, pad_name); - g_free (target_pad_name); - if (target_element) { - g_free (target_element_name); - gst_object_unref (target_element); + g_free (target_pad_name); + if (target_element) { + g_free (target_element_name); + gst_object_unref (target_element); + gst_object_unref (target_pad); } - gst_object_unref (target_pad); + gst_object_unref (tmp_pad); } if (GST_IS_GHOST_PAD (peer_pad)) { gst_ghost_pad_get_target (GST_GHOST_PAD (peer_pad)))) { - /* sink ghostpad relationship */ - peer_element_name, peer_pad_name, - target_element_name, target_pad_name); + /* sink ghostpad relationship */ + spc, peer_element_name, peer_pad_name, + target_element_name, target_pad_name); |
From: <en...@ke...> - 2008-03-31 08:32:37
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Mar 31 2008 08:32:40 UTC Log message: * gst/gst.c: Fix type in log message and add one to ease seeing how long registry cache verification takes. * gst/gstregistry.c: Only test plugin filenames against G_MODULE_SUFFIX. Modified files: . : ChangeLog gst : gst.c gstregistry.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3734&r2=1.3735 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gst.c.diff?r1=1.253&r2=1.254 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistry.c.diff?r1=1.75&r2=1.76 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3734 retrieving revision 1.3735 diff -u -d -r1.3734 -r1.3735 --- ChangeLog 31 Mar 2008 07:49:24 -0000 1.3734 +++ ChangeLog 31 Mar 2008 08:32:24 -0000 1.3735 @@ -1,5 +1,14 @@ 2008-03-31 Stefan Kost <en...@us...> + * gst/gst.c: + Fix type in log message and add one to ease seeing how long registry + cache verification takes. + + * gst/gstregistry.c: + Only test plugin filenames against G_MODULE_SUFFIX. +2008-03-31 Stefan Kost <en...@us...> * gst/gstdebugutils.c: Improve handling ghost/proxy pads. Index: gst.c RCS file: /cvs/gstreamer/gstreamer/gst/gst.c,v retrieving revision 1.253 retrieving revision 1.254 diff -u -d -r1.253 -r1.254 --- gst.c 5 Feb 2008 18:37:08 -0000 1.253 +++ gst.c 31 Mar 2008 08:32:26 -0000 1.254 @@ -656,6 +656,8 @@ gboolean changed = FALSE; GList *l; + GST_INFO ("Validating registry cache"); /* scan paths specified via --gst-plugin-path */ GST_DEBUG ("scanning paths added via --gst-plugin-path"); for (l = plugin_paths; l != NULL; l = l->next) { @@ -723,7 +725,7 @@ } if (!write_changes) { - GST_INFO ("Registry cached changed, but writing is disabled. Not writing."); + GST_INFO ("Registry cache changed, but writing is disabled. Not writing."); return REGISTRY_SCAN_AND_UPDATE_FAILURE; Index: gstregistry.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistry.c,v retrieving revision 1.75 retrieving revision 1.76 diff -u -d -r1.75 -r1.76 --- gstregistry.c 31 Jul 2007 11:51:38 -0000 1.75 +++ gstregistry.c 31 Mar 2008 08:32:26 -0000 1.76 @@ -828,10 +828,7 @@ g_free (filename); continue; } - if (!g_str_has_suffix (filename, ".so") && - !g_str_has_suffix (filename, ".sl") && - !g_str_has_suffix (filename, ".dll") && - !g_str_has_suffix (filename, ".dynlib")) { + if (!g_str_has_suffix (filename, G_MODULE_SUFFIX)) { GST_LOG_OBJECT (registry, "extension is not recognized as module file, ignoring"); |
From: <en...@ke...> - 2008-03-31 13:47:35
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Mon Mar 31 2008 13:47:36 UTC Log message: * configure.ac: * gst/gstregistry.c: MacOS has plugins under .so or under .dylib. Add detection for MacOS and handle this case. * gst/gst.c: Add a comment here describing, why we stat each plugin and not try to be smart. Modified files: . : ChangeLog configure.ac gst : gst.c gstregistry.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3736&r2=1.3737 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/configure.ac.diff?r1=1.535&r2=1.536 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gst.c.diff?r1=1.254&r2=1.255 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstregistry.c.diff?r1=1.76&r2=1.77 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3736 retrieving revision 1.3737 diff -u -d -r1.3736 -r1.3737 --- ChangeLog 31 Mar 2008 10:21:56 -0000 1.3736 +++ ChangeLog 31 Mar 2008 13:47:20 -0000 1.3737 @@ -1,3 +1,14 @@ +2008-03-31 Stefan Kost <en...@us...> + + * configure.ac: + * gst/gstregistry.c: + MacOS has plugins under .so or under .dylib. Add detection for MacOS + and handle this case. + * gst/gst.c: + Add a comment here describing, why we stat each plugin and not try to + be smart. 2008-03-31 Sebastian Dröge <sl...@ci...> * libs/gst/base/gstbasetransform.c: Index: configure.ac RCS file: /cvs/gstreamer/gstreamer/configure.ac,v retrieving revision 1.535 retrieving revision 1.536 diff -u -d -r1.535 -r1.536 --- configure.ac 21 Mar 2008 00:35:10 -0000 1.535 +++ configure.ac 31 Mar 2008 13:47:21 -0000 1.536 @@ -223,6 +223,15 @@ fi AC_SUBST(GST_HAVE_UNALIGNED_ACCESS_DEFINE) +dnl check for extra platform specific plugin suffixes +case $host_os in + darwin* | rhapsody*) + AC_DEFINE_UNQUOTED(GST_EXTRA_MODULE_SUFFIX, [.dylib], [Extra platform specific plugin suffix]) + ;; + *) +esac dnl * software * dnl check for large file support Index: gst.c RCS file: /cvs/gstreamer/gstreamer/gst/gst.c,v retrieving revision 1.254 retrieving revision 1.255 diff -u -d -r1.254 -r1.255 --- gst.c 31 Mar 2008 08:32:26 -0000 1.254 +++ gst.c 31 Mar 2008 13:47:22 -0000 1.255 @@ -656,13 +656,17 @@ gboolean changed = FALSE; GList *l; - GST_INFO ("Validating registry cache"); + GST_INFO ("Validating registry cache: %s", registry_file); + /* It sounds tempting to just compare the mtime of directories with the mtime + * of the registry cache, but it does not work. It would not catch updated + * plugins, which might bring more or less features. + */ /* scan paths specified via --gst-plugin-path */ GST_DEBUG ("scanning paths added via --gst-plugin-path"); for (l = plugin_paths; l != NULL; l = l->next) { GST_INFO ("Scanning plugin path: \"%s\"", (gchar *) l->data); - /* CHECKME: add changed |= here as well? */ + /* FIXME: add changed |= here as well? */ gst_registry_scan_path (default_registry, (gchar *) l->data); } /* keep plugin_paths around in case a re-scan is forced later on */ Index: gstregistry.c RCS file: /cvs/gstreamer/gstreamer/gst/gstregistry.c,v retrieving revision 1.76 retrieving revision 1.77 diff -u -d -r1.76 -r1.77 --- gstregistry.c 31 Mar 2008 08:32:26 -0000 1.76 +++ gstregistry.c 31 Mar 2008 13:47:22 -0000 1.77 @@ -828,7 +828,11 @@ g_free (filename); continue; } - if (!g_str_has_suffix (filename, G_MODULE_SUFFIX)) { + if (!g_str_has_suffix (filename, G_MODULE_SUFFIX) +#ifdef GST_EXTRA_MODULE_SUFFIX + || !g_str_has_suffix (filename, GST_EXTRA_MODULE_SUFFIX) +#endif + ) { GST_LOG_OBJECT (registry, "extension is not recognized as module file, ignoring"); |
From: <en...@ke...> - 2008-04-10 14:11:06
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Thu Apr 10 2008 14:11:06 UTC Log message: * gst/gstpad.c: Do not abort on out of memory for pad_alloc_buffer. Modified files: . : ChangeLog gst : gstpad.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3764&r2=1.3765 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstpad.c.diff?r1=1.567&r2=1.568 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3764 retrieving revision 1.3765 diff -u -d -r1.3764 -r1.3765 --- ChangeLog 10 Apr 2008 13:59:21 -0000 1.3764 +++ ChangeLog 10 Apr 2008 14:10:49 -0000 1.3765 @@ -1,5 +1,10 @@ 2008-04-10 Stefan Kost <en...@us...> + * gst/gstpad.c: + Do not abort on out of memory for pad_alloc_buffer. + +2008-04-10 Stefan Kost <en...@us...> * libs/gst/check/gstcheck.c: Remove blank line between symbol name ad parameters to fix gtkdoc warning. Index: gstpad.c RCS file: /cvs/gstreamer/gstreamer/gst/gstpad.c,v retrieving revision 1.567 retrieving revision 1.568 diff -u -d -r1.567 -r1.568 --- gstpad.c 27 Mar 2008 19:13:43 -0000 1.567 +++ gstpad.c 10 Apr 2008 14:10:51 -0000 1.568 @@ -2699,11 +2699,15 @@ /* fallback case, allocate a buffer of our own, add pad caps. */ GST_CAT_DEBUG_OBJECT (GST_CAT_PADS, pad, "fallback buffer alloc"); - *buf = gst_buffer_new_and_alloc (size); - GST_BUFFER_OFFSET (*buf) = offset; - gst_buffer_set_caps (*buf, caps); - - return GST_FLOW_OK; + if ((*buf = gst_buffer_try_new_and_alloc (size))) { + GST_BUFFER_OFFSET (*buf) = offset; + gst_buffer_set_caps (*buf, caps); + return GST_FLOW_OK; + } else { + GST_CAT_DEBUG_OBJECT (GST_CAT_PADS, pad, + "out of memory allocating %d bytes", size); + return GST_FLOW_ERROR; + } } } |
From: <en...@ke...> - 2008-04-16 08:31:06
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Apr 16 2008 08:31:12 UTC Log message: * gst/gsttaglist.h: Clarify some tag item docs after discussion on irc. Modified files: . : ChangeLog gst : gsttaglist.h Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3778&r2=1.3779 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gsttaglist.h.diff?r1=1.45&r2=1.46 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3778 retrieving revision 1.3779 diff -u -d -r1.3778 -r1.3779 --- ChangeLog 15 Apr 2008 06:23:12 -0000 1.3778 +++ ChangeLog 16 Apr 2008 08:30:55 -0000 1.3779 @@ -1,3 +1,8 @@ +2008-04-16 Stefan Kost <en...@us...> + + * gst/gsttaglist.h: + Clarify some tag item docs after discussion on irc. 2008-04-15 Stefan Kost <en...@us...> * docs/gst/gstreamer-docs.sgml: Index: gsttaglist.h RCS file: /cvs/gstreamer/gstreamer/gst/gsttaglist.h,v retrieving revision 1.45 retrieving revision 1.46 diff -u -d -r1.45 -r1.46 --- gsttaglist.h 13 Apr 2008 18:50:05 -0000 1.45 +++ gsttaglist.h 16 Apr 2008 08:30:57 -0000 1.46 @@ -632,13 +632,14 @@ /** * GST_TAG_LANGUAGE_CODE: * - * Language code (ISO-639-1) (string) + * Language code (ISO-639-1) (string) of the content */ #define GST_TAG_LANGUAGE_CODE "language-code" * GST_TAG_IMAGE: - * image (buffer) (buffer caps should specify the content type) + * image (buffer) (buffer caps should specify the content type and preferably + * also set "image-type" field as #GstTagImageType) * Since: 0.10.6 @@ -646,8 +647,8 @@ * GST_TAG_PREVIEW_IMAGE: - * image that is meant for preview purposes (buffer) - * (buffer caps should specify the content type) + * image that is meant for preview purposes, e.g. small icon-sized version + * (buffer) (buffer caps should specify the content type) * Since: 0.10.7 |
From: <en...@ke...> - 2008-04-16 18:38:25
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Apr 16 2008 18:38:30 UTC Log message: * gst/gstmessage.c: Use G_GINT64_CONSTANT in varargs function. Modified files: . : ChangeLog gst : gstmessage.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3782&r2=1.3783 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstmessage.c.diff?r1=1.65&r2=1.66 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3782 retrieving revision 1.3783 diff -u -d -r1.3782 -r1.3783 --- ChangeLog 16 Apr 2008 15:51:15 -0000 1.3782 +++ ChangeLog 16 Apr 2008 18:38:14 -0000 1.3783 @@ -1,3 +1,8 @@ +2008-04-16 Stefan Kost <en...@us...> + + * gst/gstmessage.c: + Use G_GINT64_CONSTANT in varargs function. 2008-04-16 Sebastian Dröge <sl...@ci...> * gst/gstregistrybinary.c: (gst_registry_binary_initialize_magic): Index: gstmessage.c RCS file: /cvs/gstreamer/gstreamer/gst/gstmessage.c,v retrieving revision 1.65 retrieving revision 1.66 diff -u -d -r1.65 -r1.66 --- gstmessage.c 8 Apr 2008 19:59:05 -0000 1.65 +++ gstmessage.c 16 Apr 2008 18:38:16 -0000 1.66 @@ -473,8 +473,8 @@ GST_QUARK (BUFFERING_MODE), GST_TYPE_BUFFERING_MODE, GST_BUFFERING_STREAM, GST_QUARK (AVG_IN_RATE), G_TYPE_INT, -1, GST_QUARK (AVG_OUT_RATE), G_TYPE_INT, -1, - GST_QUARK (BUFFERING_LEFT), G_TYPE_INT64, -1, - GST_QUARK (ESTIMATED_TOTAL), G_TYPE_INT64, -1, NULL); + GST_QUARK (BUFFERING_LEFT), G_TYPE_INT64, G_GINT64_CONSTANT (-1), + GST_QUARK (ESTIMATED_TOTAL), G_TYPE_INT64, G_GINT64_CONSTANT (-1), NULL); message = gst_message_new_custom (GST_MESSAGE_BUFFERING, src, structure); return message; |
From: <en...@ke...> - 2008-04-16 18:48:14
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Apr 16 2008 18:48:17 UTC Log message: * gst/gstquery.c: Also use G_GINT64_CONSTANT for the queries. Modified files: . : ChangeLog gst : gstquery.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3783&r2=1.3784 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstquery.c.diff?r1=1.45&r2=1.46 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3783 retrieving revision 1.3784 diff -u -d -r1.3783 -r1.3784 --- ChangeLog 16 Apr 2008 18:38:14 -0000 1.3783 +++ ChangeLog 16 Apr 2008 18:48:01 -0000 1.3784 @@ -1,5 +1,10 @@ 2008-04-16 Stefan Kost <en...@us...> + * gst/gstquery.c: + Also use G_GINT64_CONSTANT for the queries. + +2008-04-16 Stefan Kost <en...@us...> * gst/gstmessage.c: Use G_GINT64_CONSTANT in varargs function. Index: gstquery.c RCS file: /cvs/gstreamer/gstreamer/gst/gstquery.c,v retrieving revision 1.45 retrieving revision 1.46 diff -u -d -r1.45 -r1.46 --- gstquery.c 9 Apr 2008 18:26:15 -0000 1.45 +++ gstquery.c 16 Apr 2008 18:48:03 -0000 1.46 @@ -409,7 +409,7 @@ structure = gst_structure_empty_new ("GstQueryPosition"); gst_structure_id_set (structure, GST_QUARK (FORMAT), GST_TYPE_FORMAT, format, - GST_QUARK (CURRENT), G_TYPE_INT64, (gint64) - 1, NULL); + GST_QUARK (CURRENT), G_TYPE_INT64, G_GINT64_CONSTANT (-1), NULL); query = gst_query_new (GST_QUERY_POSITION, structure); @@ -482,7 +482,7 @@ structure = gst_structure_empty_new ("GstQueryDuration"); - GST_QUARK (DURATION), G_TYPE_INT64, (gint64) - 1, NULL); + GST_QUARK (DURATION), G_TYPE_INT64, G_GINT64_CONSTANT (-1), NULL); query = gst_query_new (GST_QUERY_DURATION, structure); @@ -557,8 +557,8 @@ structure = gst_structure_empty_new ("GstQueryLatency"); GST_QUARK (LIVE), G_TYPE_BOOLEAN, FALSE, - GST_QUARK (MIN_LATENCY), G_TYPE_UINT64, (gint64) 0, - GST_QUARK (MAX_LATENCY), G_TYPE_UINT64, (gint64) - 1, NULL); + GST_QUARK (MIN_LATENCY), G_TYPE_UINT64, G_GUINT64_CONSTANT (0), + GST_QUARK (MAX_LATENCY), G_TYPE_UINT64, G_GUINT64_CONSTANT (-1), NULL); query = gst_query_new (GST_QUERY_LATENCY, structure); @@ -649,7 +649,7 @@ GST_QUARK (SRC_FORMAT), GST_TYPE_FORMAT, src_format, GST_QUARK (SRC_VALUE), G_TYPE_INT64, value, GST_QUARK (DEST_FORMAT), GST_TYPE_FORMAT, dest_format, - GST_QUARK (DEST_VALUE), G_TYPE_INT64, (gint64) - 1, NULL); + GST_QUARK (DEST_VALUE), G_TYPE_INT64, G_GINT64_CONSTANT (-1), NULL); query = gst_query_new (GST_QUERY_CONVERT, structure); @@ -679,7 +679,7 @@ GST_QUARK (SRC_VALUE), G_TYPE_INT64, src_value, - GST_QUARK (DEST_VALUE), G_TYPE_INT64, (gint64) dest_value, NULL); + GST_QUARK (DEST_VALUE), G_TYPE_INT64, dest_value, NULL); } /** @@ -736,8 +736,8 @@ GST_QUARK (RATE), G_TYPE_DOUBLE, (gdouble) 0.0, - GST_QUARK (START_VALUE), G_TYPE_INT64, (gint64) - 1, - GST_QUARK (STOP_VALUE), G_TYPE_INT64, (gint64) - 1, NULL); + GST_QUARK (START_VALUE), G_TYPE_INT64, G_GINT64_CONSTANT (-1), + GST_QUARK (STOP_VALUE), G_TYPE_INT64, G_GINT64_CONSTANT (-1), NULL); query = gst_query_new (GST_QUERY_SEGMENT, structure); @@ -871,8 +871,8 @@ GST_QUARK (SEEKABLE), G_TYPE_BOOLEAN, FALSE, - GST_QUARK (SEGMENT_START), G_TYPE_INT64, (gint64) - 1, - GST_QUARK (SEGMENT_END), G_TYPE_INT64, (gint64) - 1, NULL); + GST_QUARK (SEGMENT_START), G_TYPE_INT64, G_GINT64_CONSTANT (-1), + GST_QUARK (SEGMENT_END), G_TYPE_INT64, G_GINT64_CONSTANT (-1), NULL); query = gst_query_new (GST_QUERY_SEEKING, structure); @@ -1126,11 +1126,11 @@ GST_QUARK (BUFFERING_MODE), GST_TYPE_BUFFERING_MODE, GST_BUFFERING_STREAM, GST_QUARK (AVG_IN_RATE), G_TYPE_INT, -1, GST_QUARK (AVG_OUT_RATE), G_TYPE_INT, -1, - GST_QUARK (BUFFERING_LEFT), G_TYPE_INT64, 0, - GST_QUARK (ESTIMATED_TOTAL), G_TYPE_INT64, -1, + GST_QUARK (BUFFERING_LEFT), G_TYPE_INT64, G_GINT64_CONSTANT (0), + GST_QUARK (ESTIMATED_TOTAL), G_TYPE_INT64, G_GINT64_CONSTANT (-1), query = gst_query_new (GST_QUERY_BUFFERING, structure); |
From: <en...@ke...> - 2008-04-23 07:09:00
|
CVS Root: /cvs/gstreamer Module: gstreamer Changes by: ensonic Date: Wed Apr 23 2008 07:09:07 UTC Log message: * gst/gstsegment.c: Document the new function. Use g_slice_dup() (no need for gst_segment_init()). Modified files: . : ChangeLog gst : gstsegment.c Links: http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/ChangeLog.diff?r1=1.3799&r2=1.3800 http://freedesktop.org/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/gst/gstsegment.c.diff?r1=1.32&r2=1.33 ====Begin Diffs==== Index: ChangeLog =================================================================== RCS file: /cvs/gstreamer/gstreamer/ChangeLog,v retrieving revision 1.3799 retrieving revision 1.3800 diff -u -d -r1.3799 -r1.3800 --- ChangeLog 23 Apr 2008 06:57:26 -0000 1.3799 +++ ChangeLog 23 Apr 2008 07:08:51 -0000 1.3800 @@ -1,5 +1,11 @@ 2008-04-23 Stefan Kost <en...@us...> + * gst/gstsegment.c: + Document the new function. Use g_slice_dup() (no need for + gst_segment_init()). + +2008-04-23 Stefan Kost <en...@us...> * docs/gst/gstreamer-sections.txt: Move GParamSepc macros to standart section. Index: gstsegment.c RCS file: /cvs/gstreamer/gstreamer/gst/gstsegment.c,v retrieving revision 1.32 retrieving revision 1.33 diff -u -d -r1.32 -r1.33 --- gstsegment.c 9 Apr 2008 22:37:22 -0000 1.32 +++ gstsegment.c 23 Apr 2008 07:08:53 -0000 1.33 @@ -87,7 +87,9 @@ * gst_segment_copy: * @segment: a #GstSegment * - * Returns: a copy of @segment, free with gst_segment_free(). + * Create a copy of given @segment. + * + * Returns: a new #GstSegment, free with gst_segment_free(). * Since: 0.10.20 */ @@ -97,8 +99,7 @@ GstSegment *result = NULL; if (segment) { - result = gst_segment_new (); - memcpy (result, segment, sizeof (GstSegment)); + result = g_slice_dup (GstSegment, segment); } return result; } |