From: <bug...@wi...> - 2003-01-24 18:41:46
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by jo...@nl.... --- shadow/104345 Fri Jan 24 13:38:51 2003 +++ shadow/104345.tmp.16694 Fri Jan 24 13:38:51 2003 @@ -0,0 +1,19 @@ +Bug#: 104345 +Product: GStreamer +Version: cvs +OS: Linux +OS Details: +Status: NEW +Resolution: +Severity: normal +Priority: Normal +Component: gst-plugins +AssignedTo: gst...@bu... +ReportedBy: jo...@nl... +QAContact: gst...@bu... +TargetMilestone: 0.4.0 +URL: +Summary: no metadata from flac element + +Just filing a bug for the fact that there's no metadata implementented yet +for the flac element. |
From: <bug...@wi...> - 2003-01-30 18:36:31
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by jo...@nl.... --- shadow/104345 Fri Jan 24 13:38:51 2003 +++ shadow/104345.tmp.12938 Thu Jan 30 13:33:05 2003 @@ -11,9 +11,10 @@ AssignedTo: gst...@bu... ReportedBy: jo...@nl... QAContact: gst...@bu... TargetMilestone: 0.4.0 URL: Summary: no metadata from flac element +OtherBugsDependingOnThis: 104836 Just filing a bug for the fact that there's no metadata implementented yet for the flac element. |
From: <bug...@wi...> - 2003-05-08 12:31:42
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by rb...@ro.... --- shadow/104345 Thu Jan 30 13:33:05 2003 +++ shadow/104345.tmp.30052 Thu May 8 08:31:38 2003 @@ -1,9 +1,9 @@ Bug#: 104345 Product: GStreamer -Version: cvs +Version: HEAD CVS OS: Linux OS Details: Status: NEW Resolution: Severity: normal Priority: Normal @@ -15,6 +15,9 @@ URL: Summary: no metadata from flac element OtherBugsDependingOnThis: 104836 Just filing a bug for the fact that there's no metadata implementented yet for the flac element. + +------- Additional Comments From rb...@ro... 2003-05-08 08:31 ------- +*** Bug 112569 has been marked as a duplicate of this bug. *** |
From: <bug...@wi...> - 2003-05-08 12:33:11
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by rb...@ro.... --- shadow/104345 Thu May 8 08:31:38 2003 +++ shadow/104345.tmp.30978 Thu May 8 08:33:07 2003 @@ -18,6 +18,20 @@ Just filing a bug for the fact that there's no metadata implementented yet for the flac element. ------- Additional Comments From rb...@ro... 2003-05-08 08:31 ------- *** Bug 112569 has been marked as a duplicate of this bug. *** + +------- Additional Comments From rb...@ro... 2003-05-08 08:33 ------- +Hm, seems like there's a lot of interest for FLAC... + +http://flac.sourceforge.net/format.html + +"VORBIS_COMMENT: This block is for storing a list of human-readable +name/value pairs. Values are encoded using UTF-8. It is an +implementation of the Vorbis comment specification. This is the only +officially supported tagging mechanism in FLAC. There may be only one +VORBIS_COMMENT block in a stream." + +According to Ross (rburton), FLAC__file_encoder_set_metadata() is the +way to go here. |
From: <bug...@wi...> - 2003-05-08 13:50:08
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by rb...@ro.... --- shadow/104345 Thu May 8 08:33:07 2003 +++ shadow/104345.tmp.4844 Thu May 8 09:50:02 2003 @@ -32,6 +32,49 @@ implementation of the Vorbis comment specification. This is the only officially supported tagging mechanism in FLAC. There may be only one VORBIS_COMMENT block in a stream." According to Ross (rburton), FLAC__file_encoder_set_metadata() is the way to go here. + +------- Additional Comments From rb...@ro... 2003-05-08 09:50 ------- +So, according to the docs, it'd look like: + +static void +set_metadata (FLAC__StreamEncoder *encoder, + GstCaps *caps) +{ + FLAC__StreamMetadata *meta = g_malloc(sizeof(FLAC__StreamMetadata)); + const gchar **meta_types = { "TITLE", "VERSION", "ALBUM", "TRACKNUMBER", + "ARTIST", "PERFORMER", "COPYRIGHT", +"LICENSE", + "ORGANISATION", "DESCRIPTION", "GENRE", +"DATE", + "LOCATION", "CONTACT", "ISRC", NULL }; + + meta->type = FLAC__METADATA_TYPE_VORBIS_COMMENT; + meta->data.vorbis_comment.vendor_string.length = +strlen(FLAC__VENDOR_STRING); + meta->data.vorbis_comment.vendor_string.entry = FLAC__VENDOR_STRING; + meta->data.num_comments = 0; + meta->data.comments = +g_malloc(sizeof(FLAC__StreamMetadata_VorbisComment_Entry) * 15); /* max */ + + /* num_comments */ + for ( ; *meta_types != NULL; meta_types++) { + if (gst_caps_has_property(caps, *meta_types)) { + gchar *entry; + gst_caps_get_string(caps, *meta_types, &entry); + meta->data.comments[meta->data.num_comments].length = +strlen(entry) + strlen(*meta_types) + 1; + meta->data.comments[meta.data.num_comments].entry = +g_strdup_printf("%s=%s", *meta_types, entry); + + meta->data.num_comments++; + } + } + + FLAC__file_encoder_set_metadata(encoder, &meta, 1); +} + +After initting the encoder, we should free the struct somewhere. +Besides, it's untested. However, it's a start. :). |
From: <bug...@wi...> - 2003-05-09 10:23:27
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by rb...@ro.... --- shadow/104345 Thu May 8 09:50:02 2003 +++ shadow/104345.tmp.3164 Fri May 9 06:23:22 2003 @@ -75,6 +75,17 @@ FLAC__file_encoder_set_metadata(encoder, &meta, 1); } After initting the encoder, we should free the struct somewhere. Besides, it's untested. However, it's a start. :). + +------- Additional Comments From rb...@ro... 2003-05-09 06:23 ------- +From what I understand, flacdec would have to use +FLAC__stream_decoder_set_metadata_callback() to get a metadata +callback when the file in question contains metadata. + +The callback would then have to check whether the metadata block is a +VorbisComment metadata block and - if yes - read the metadata and +signal that it has metadata using the proper GStreamer callbacks +(g_object_notify(object, "metadata") or so)... The way in which we +interpret is is the same as above. |
From: <bug...@wi...> - 2003-05-09 11:42:11
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by rb...@ro.... --- shadow/104345 Fri May 9 06:23:22 2003 +++ shadow/104345.tmp.10241 Fri May 9 07:41:59 2003 @@ -86,6 +86,12 @@ The callback would then have to check whether the metadata block is a VorbisComment metadata block and - if yes - read the metadata and signal that it has metadata using the proper GStreamer callbacks (g_object_notify(object, "metadata") or so)... The way in which we interpret is is the same as above. + +------- Additional Comments From rb...@ro... 2003-05-09 07:41 ------- +apoc just notified me that he added this last week, so I shouldn't +have written all that... Current stuff remaining is that we use the +vorbis comment tags (in caps, see above) for metadata, and we should +translate that to gstreamer tags (lowercase). |
From: <bug...@wi...> - 2003-05-12 13:04:37
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by ur...@li.... --- shadow/104345 Fri May 9 07:41:59 2003 +++ shadow/104345.tmp.2142 Mon May 12 09:04:33 2003 @@ -10,13 +10,13 @@ Component: gst-plugins AssignedTo: gst...@bu... ReportedBy: jo...@nl... QAContact: gst...@bu... TargetMilestone: 0.4.0 URL: -Summary: no metadata from flac element +Summary: vorbis metadata needs converting to gst format OtherBugsDependingOnThis: 104836 Just filing a bug for the fact that there's no metadata implementented yet for the flac element. ------- Additional Comments From rb...@ro... 2003-05-08 08:31 ------- |
From: <bug...@wi...> - 2003-06-30 22:11:12
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by rb...@ro.... --- shadow/104345 Mon May 12 09:04:33 2003 +++ shadow/104345.tmp.21933 Mon Jun 30 18:11:05 2003 @@ -1,13 +1,13 @@ Bug#: 104345 Product: GStreamer Version: HEAD CVS OS: Linux OS Details: -Status: NEW -Resolution: +Status: RESOLVED +Resolution: DUPLICATE Severity: normal Priority: Normal Component: gst-plugins AssignedTo: gst...@bu... ReportedBy: jo...@nl... QAContact: gst...@bu... @@ -92,6 +92,11 @@ ------- Additional Comments From rb...@ro... 2003-05-09 07:41 ------- apoc just notified me that he added this last week, so I shouldn't have written all that... Current stuff remaining is that we use the vorbis comment tags (in caps, see above) for metadata, and we should translate that to gstreamer tags (lowercase). + +------- Additional Comments From rb...@ro... 2003-06-30 18:11 ------- +Hm, we have multiple bugs describing the same issue... + +*** This bug has been marked as a duplicate of 110544 *** |
From: <bug...@wi...> - 2003-12-21 22:46:08
|
Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there. http://bugzilla.gnome.org/show_bug.cgi?id=104345 Changed by wa...@ve.... --- shadow/104345 Sun Aug 3 06:49:34 2003 +++ shadow/104345.tmp.15265 Sun Dec 21 17:46:01 2003 @@ -11,13 +11,13 @@ AssignedTo: gst...@bu... ReportedBy: jo...@nl... QAContact: gst...@bu... TargetMilestone: 0.4.0 URL: Summary: vorbis metadata needs converting to gst format -OtherBugsDependingOnThis: 104836 +OtherBugsDependingOnThis: 104836[FIXED] Just filing a bug for the fact that there's no metadata implementented yet for the flac element. ------- Additional Comments From rb...@ro... 2003-05-08 08:31 ------- *** Bug 112569 has been marked as a duplicate of this bug. *** |