Menu

#380 Use a specific font in tests

v1.0_(example)
closed-fixed
nobody
None
5
2021-03-29
2021-02-19
No

In Fedora we saw that tests are sensitive to fonts installed into a system and sometimes fail because of that. Thus we apply an attached patch. It requests a convert command of ImageMagick to use a known font family. That makes the test more reproducible. Please consider merging the patch. Feel free to choose a different font if DejaVu Sans is not good enough for you.

1 Attachments

Discussion

  • Jeffrey Ratcliffe

    I saw this on Debian, too and reported it as a bug in Imagemagick, which I think should always have sensible defaults for fonts.

    imagemagick upstream suggested this fix:

    https://bugs.debian.org/cgi-bin/bugreport.cgi?att=0;bug=980202;msg=65

    I switched to graphicsmagick (in the Debian packaging) for the tests in question to get them to pass.

    But your patch implements imagemagick upstream's alternative suggestion, so I'll commit it.

    Thanks!

     
  • Jeffrey Ratcliffe

    • status: open --> closed-fixed
     
  • Jeffrey Ratcliffe

    Committed, thanks!

     

Log in to post a comment.