[Grouptime-developers] RE: The pre-FINAL of Coding Standards
Status: Pre-Alpha
Brought to you by:
sauanimal
|
From: Jan U. <sa...@kr...> - 2002-09-07 15:52:36
|
A) Are we sure we want to use spaces (2) instead of tabs?
Using tabs let anyone edit (and see) files as preferred
(just setting tab indentation inside editor), using
spaces doesn't.
Yes, i'm sure i want to use 2 spaces, because usually the tabs are
very different lenght in different users and it ends up kind of a
messy doc. After a while, noone want's to see such crappy idented
files. So - 2 spaces stays.
B) Any file of the project should also have, IMO, the following
rows:
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
*
* (See the included file COPYING)
Agreed in some part, i think that we don't need to add it to the EVERY
file beginning, because we add the full licence text anyway with the
product. But maybe these lines should be added in the beginning of the
initial file (in our case index.php)!?
Also a little addition of this template engine we've been discussing. All
fine, but i'd like to see the template tags like following:
{TMPL_VAR NAME=XXXXX}
Also, maybe method names should be renamed so, that they fit to our
standard, i.e:
setName($template_name)
openLog($logfile, $loglevel)
closeLog()
setOpenTag($open_tag)
setExtensions($ext)
setClassPath($path)
setClassName($name)
forceCompilation()
setParam($var, $value)
getOutput()
What do you guys think!?
With regards,
Jan
|