Thread: [Grouptime-developers] final comments
Status: Pre-Alpha
Brought to you by:
sauanimal
From: Lucas R. <lu...@uf...> - 2002-09-09 15:14:19
|
Hi all! Here are my final comments about the coding standards. ------------- In section 2.1 at the include/require/require_once/include_once explanation topic at line 2 it should be: "When unconditional includings are needed, require_once() should be used. When conditional includings are needed, then include_once() should be used." Instead of: "When the unconditional including needed, the require_once() should be used, when the conditional including needed, then include_once() should be used." ------------- Still at section 2.1 at the html explanation topic last line. It should be: "For designing the templates, CSS should be used:" Instead of: "For designing the template the CSS should be used:" ------------- Section 2.1 (yet!) at simple boolean expression topic. Is should be: "ternary operator can be used for simple boolean expressions as following, but when the expression is more complicated, all the other necessary standards should be used:" Instead of: "simple boolean expressions can be written as following, but when the expression is complicated all the other necessary standards should be used: " ------------- Section 2.2 the inicial text: "In order to understand quickly the content of the directory structure, what some file might contain, we've made a simple file naming standard." Instead of: "In order to understand quickly when looking the directory structure, what some file might contain, we've made a little file naming standard." ------------- Section 2.3, class names: "class names should match its file name without the '.class.php' sufix." Instead of: "class names should match it's file-based name without '_': MyClass.php." ------------- Section 2.4 first topic should be: "all the files, functions, classes and their methods should be commented so properly that even the developers, who are not familiar to the code, can easily understand and contribute." Instead of: "all the files, functions, classes and their methods should be commented so properly that even the developers, who is not familiar the code, can easily understand and make a contribution." -------------- Some "really" final comments: :-) - Theres nothing about how to name variables that are passed via POST or GET. Do you think this important? - I think we could add a last section that would give some practical information about who he/she can contact to get more information. - I think the docs should be distributed in pdf format because its pratical for printing and reading. The formats could be rtf, pdf, html e txt. What do you think? The format conversions are very simples in this case. Thats all! p eace --lucasr |
From: Cosimo V. <co...@da...> - 2002-09-10 17:02:06
|
Hi all, sorry not being here in this days but i wasn't home neither in office. I agreee with your "last" version. Are we sure we don't want to set some standard about variables names? I'm thinking not only to php variables but also (as in the "really final Luca's comments") to GET and POST variables. About on-line meeting, isn't there (during a week) an hour (a couple of hours) when we all are plugged? I repeat my on-line status: 6.00AM -> 00:00AM (GMT 0) (during daytime I'm working but I can "steal" a bit of my time). Cosimo. Il lun, 2002-09-09 alle 17:19, Lucas Rocha ha scritto: > Hi all! Here are my final comments about the coding standards. > > ------------- > > In section 2.1 at the include/require/require_once/include_once explanation topic at line 2 > it should be: > "When unconditional includings are needed, require_once() should be used. > When conditional includings are needed, then include_once() should be used." > > Instead of: > > "When the unconditional including needed, the require_once() should be used, > when the conditional including needed, then include_once() should be used." > > ------------- > > Still at section 2.1 at the html explanation topic last line. It should be: > "For designing the templates, CSS should be used:" > > Instead of: > > "For designing the template the CSS should be used:" > > ------------- > > Section 2.1 (yet!) at simple boolean expression topic. Is should be: > "ternary operator can be used for simple boolean expressions as following, but when the > expression is more complicated, all the other necessary standards should be used:" > > Instead of: > > "simple boolean expressions can be written as following, but when the > expression is complicated all the other necessary standards should be used: " > > ------------- > > Section 2.2 the inicial text: > "In order to understand quickly the content of the directory structure, what some file > might contain, we've made a simple file naming standard." > > Instead of: > > "In order to understand quickly when looking the directory structure, what some file > might contain, we've made a little file naming standard." > > ------------- > > Section 2.3, class names: > "class names should match its file name without the '.class.php' sufix." > > Instead of: > > "class names should match it's file-based name without '_': MyClass.php." > > ------------- > > Section 2.4 first topic should be: > "all the files, functions, classes and their methods should be commented so properly that > even the developers, who are not familiar to the code, can easily understand and contribute." > > Instead of: > > "all the files, functions, classes and their methods should be commented so properly that > even the developers, who is not familiar the code, can easily understand and make a contribution." > > -------------- > > Some "really" final comments: :-) > - Theres nothing about how to name variables that are passed via POST or GET. Do you think this important? > - I think we could add a last section that would give some practical information about who he/she can contact > to get more information. > - I think the docs should be distributed in pdf format because its pratical for printing and reading. The formats > could be rtf, pdf, html e txt. What do you think? The format conversions are very simples in this case. > > Thats all! > > p eace > > --lucasr > > > ------------------------------------------------------- > This sf.net email is sponsored by: OSDN - Tired of that same old > cell phone? Get a new here for FREE! > https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 > _______________________________________________ > Grouptime-developers mailing list > Gro...@li... > https://lists.sourceforge.net/lists/listinfo/grouptime-developers > |
From: Jan U. <sa...@kr...> - 2002-09-10 20:15:16
|
Hi! On 10 Sep 2002, Cosimo Vagarini wrote: > Hi all, > sorry not being here in this days but i wasn't home neither > in office. Don't worry, we all have our personal life aswell :) @ least most of us :) > I agreee with your "last" version. > > Are we sure we don't want to set some standard about variables > names? > I'm thinking not only to php variables but also (as in the > "really final Luca's comments") to GET and POST variables. If i remember correctly, there is standard about var names: all the variable names must begin with lowercased word and if there's another word(s), they must have the first letter capitalized: $myVar; $myNewVar; $_GET['myVar']; $_GET[$myVar]; > About on-line meeting, isn't there (during a week) an hour > (a couple of hours) when we all are plugged? for me, i'm practically all day 9:00am-12:00pm (GMT +3) in IRC, therefore join me. i must say, that we should start using the irc as our basic communication tool, meanign more people in online. PS! Probably soon i'll move the #grouptime channel form mircx.com to openporjects.net server. When i do, i inform you aswell :) > I repeat my on-line status: > 6.00AM -> 00:00AM (GMT 0) (during daytime I'm working but > I can "steal" a bit of my time). Fine, then at least this meating will be starting @ 6am GMT 0, also, in this meeting we should discuss, when is the right time to for meetings, so the most of us will be there. Jan > > Cosimo. > > > > > > Il lun, 2002-09-09 alle 17:19, Lucas Rocha ha scritto: > > Hi all! Here are my final comments about the coding standards. > > > > ------------- > > > > In section 2.1 at the include/require/require_once/include_once explanation topic at line 2 > > it should be: > > "When unconditional includings are needed, require_once() should be used. > > When conditional includings are needed, then include_once() should be used." > > > > Instead of: > > > > "When the unconditional including needed, the require_once() should be used, > > when the conditional including needed, then include_once() should be used." > > > > ------------- > > > > Still at section 2.1 at the html explanation topic last line. It should be: > > "For designing the templates, CSS should be used:" > > > > Instead of: > > > > "For designing the template the CSS should be used:" > > > > ------------- > > > > Section 2.1 (yet!) at simple boolean expression topic. Is should be: > > "ternary operator can be used for simple boolean expressions as following, but when the > > expression is more complicated, all the other necessary standards should be used:" > > > > Instead of: > > > > "simple boolean expressions can be written as following, but when the > > expression is complicated all the other necessary standards should be used: " > > > > ------------- > > > > Section 2.2 the inicial text: > > "In order to understand quickly the content of the directory structure, what some file > > might contain, we've made a simple file naming standard." > > > > Instead of: > > > > "In order to understand quickly when looking the directory structure, what some file > > might contain, we've made a little file naming standard." > > > > ------------- > > > > Section 2.3, class names: > > "class names should match its file name without the '.class.php' sufix." > > > > Instead of: > > > > "class names should match it's file-based name without '_': MyClass.php." > > > > ------------- > > > > Section 2.4 first topic should be: > > "all the files, functions, classes and their methods should be commented so properly that > > even the developers, who are not familiar to the code, can easily understand and contribute." > > > > Instead of: > > > > "all the files, functions, classes and their methods should be commented so properly that > > even the developers, who is not familiar the code, can easily understand and make a contribution." > > > > -------------- > > > > Some "really" final comments: :-) > > - Theres nothing about how to name variables that are passed via POST or GET. Do you think this important? > > - I think we could add a last section that would give some practical information about who he/she can contact > > to get more information. > > - I think the docs should be distributed in pdf format because its pratical for printing and reading. The formats > > could be rtf, pdf, html e txt. What do you think? The format conversions are very simples in this case. > > > > Thats all! > > > > p eace > > > > --lucasr > > > > > > ------------------------------------------------------- > > This sf.net email is sponsored by: OSDN - Tired of that same old > > cell phone? Get a new here for FREE! > > https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 > > _______________________________________________ > > Grouptime-developers mailing list > > Gro...@li... > > https://lists.sourceforge.net/lists/listinfo/grouptime-developers > > > > > > > > ------------------------------------------------------- > This sf.net email is sponsored by: OSDN - Tired of that same old > cell phone? Get a new here for FREE! > https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390 > _______________________________________________ > Grouptime-developers mailing list > Gro...@li... > https://lists.sourceforge.net/lists/listinfo/grouptime-developers > |