Menu
▾
▴
[Gridarta-commit] SF.net SVN: gridarta:[8010] trunk
|
From: <aki...@us...> - 2010-05-26 20:42:22
|
Revision: 8010
http://gridarta.svn.sourceforge.net/gridarta/?rev=8010&view=rev
Author: akirschbaum
Date: 2010-05-26 20:42:15 +0000 (Wed, 26 May 2010)
Log Message:
-----------
Remve outdated TODO comments.
Modified Paths:
--------------
trunk/atrinik/src/app/net/sf/gridarta/var/atrinik/model/gameobject/GameObject.java
trunk/crossfire/src/app/net/sf/gridarta/var/crossfire/model/gameobject/GameObject.java
trunk/daimonin/src/app/net/sf/gridarta/var/daimonin/model/gameobject/GameObject.java
trunk/src/app/net/sf/gridarta/gui/archetypechooser/ArchetypeChooserControl.java
trunk/src/app/net/sf/gridarta/gui/mapuserlistener/MapUserListener.java
trunk/src/app/net/sf/gridarta/mapmanager/DefaultFileControl.java
trunk/src/app/net/sf/gridarta/model/baseobject/BaseObject.java
trunk/src/app/net/sf/gridarta/model/baseobject/GameObjectContainer.java
trunk/src/app/net/sf/gridarta/model/map/maparchobject/MapArchObject.java
trunk/src/app/net/sf/gridarta/model/map/mapmodel/DefaultMapModel.java
trunk/src/app/net/sf/gridarta/model/spells/Spells.java
trunk/src/app/net/sf/gridarta/script/Script.java
Modified: trunk/atrinik/src/app/net/sf/gridarta/var/atrinik/model/gameobject/GameObject.java
===================================================================
--- trunk/atrinik/src/app/net/sf/gridarta/var/atrinik/model/gameobject/GameObject.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/atrinik/src/app/net/sf/gridarta/var/atrinik/model/gameobject/GameObject.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -35,11 +35,6 @@
* @author <a href="mailto:mic...@no...">Michael Toennies</a>
* @author <a href="mailto:and...@gm...">Andreas Vogl</a>
* @author <a href="mailto:ch...@ri...">Christian Hujer</a>
- * @todo the archobject should be directly asked for a face, and eventually it
- * should cache faces itself; that would speed up painting maps
- * @todo this class maybe could be split into 3 classes: AbstractArchObject as
- * abstract base class, DefArchObject for default arches and GameObject for
- * normal arches.
* @todo this class is not always the best place for multipart object handling,
* see also {@link net.sf.gridarta.model.baseobject.GameObjectContainer} for
* issues about this
Modified: trunk/crossfire/src/app/net/sf/gridarta/var/crossfire/model/gameobject/GameObject.java
===================================================================
--- trunk/crossfire/src/app/net/sf/gridarta/var/crossfire/model/gameobject/GameObject.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/crossfire/src/app/net/sf/gridarta/var/crossfire/model/gameobject/GameObject.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -36,11 +36,6 @@
* @author <a href="mailto:mic...@no...">Michael Toennies</a>
* @author <a href="mailto:and...@gm...">Andreas Vogl</a>
* @author <a href="mailto:ch...@ri...">Christian Hujer</a>
- * @todo the archobject should be directly asked for a face, and eventually it
- * should cache faces itself; that would speed up painting maps
- * @todo this class maybe could be split into 3 classes: AbstractArchObject as
- * abstract base class, DefArchObject for default arches and GameObject for
- * normal arches.
* @todo this class is not always the best place for multipart object handling,
* see also {@link net.sf.gridarta.model.baseobject.GameObjectContainer} for
* issues about this
Modified: trunk/daimonin/src/app/net/sf/gridarta/var/daimonin/model/gameobject/GameObject.java
===================================================================
--- trunk/daimonin/src/app/net/sf/gridarta/var/daimonin/model/gameobject/GameObject.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/daimonin/src/app/net/sf/gridarta/var/daimonin/model/gameobject/GameObject.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -35,11 +35,6 @@
* @author <a href="mailto:mic...@no...">Michael Toennies</a>
* @author <a href="mailto:and...@gm...">Andreas Vogl</a>
* @author <a href="mailto:ch...@ri...">Christian Hujer</a>
- * @todo the archobject should be directly asked for a face, and eventually it
- * should cache faces itself; that would speed up painting maps
- * @todo this class maybe could be split into 3 classes: AbstractArchObject as
- * abstract base class, DefArchObject for default arches and GameObject for
- * normal arches.
* @todo this class is not always the best place for multipart object handling,
* see also {@link net.sf.gridarta.model.baseobject.GameObjectContainer} for
* issues about this
Modified: trunk/src/app/net/sf/gridarta/gui/archetypechooser/ArchetypeChooserControl.java
===================================================================
--- trunk/src/app/net/sf/gridarta/gui/archetypechooser/ArchetypeChooserControl.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/gui/archetypechooser/ArchetypeChooserControl.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -147,7 +147,7 @@
@Override
public R getSelection() {
final ArchetypeChooserPanel<G, A, R> selectedPanel = archetypeChooserModel.getSelectedPanel();
- return selectedPanel != null ? selectedPanel.getSelectedFolder().getSelectedArchetype() : null; // XXX: should not cast Archetype -> GameObject
+ return selectedPanel != null ? selectedPanel.getSelectedFolder().getSelectedArchetype() : null;
}
/**
@@ -155,7 +155,7 @@
*/
@NotNull
@Override
- public List<R> getSelections() { // XXX: should return List<Archetype<G, A, R>>
+ public List<R> getSelections() {
final R archObject = getSelection();
if (archObject == null) {
return Collections.emptyList();
Modified: trunk/src/app/net/sf/gridarta/gui/mapuserlistener/MapUserListener.java
===================================================================
--- trunk/src/app/net/sf/gridarta/gui/mapuserlistener/MapUserListener.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/gui/mapuserlistener/MapUserListener.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -35,7 +35,6 @@
import org.jetbrains.annotations.Nullable;
/**
- * TODO Description.
* @author <a href="mailto:dlv...@gm...">Daniel Viegas</a>
*/
public class MapUserListener<G extends GameObject<G, A, R>, A extends MapArchObject<A>, R extends Archetype<G, A, R>> implements MouseListener, MouseMotionListener {
Modified: trunk/src/app/net/sf/gridarta/mapmanager/DefaultFileControl.java
===================================================================
--- trunk/src/app/net/sf/gridarta/mapmanager/DefaultFileControl.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/mapmanager/DefaultFileControl.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -229,8 +229,7 @@
}
} else if (!file.exists()) {
if (isScriptFile) {
- // TODO: pass filename
- scriptEditControl.newScript();
+ scriptEditControl.newScript(); // TODO: pass filename
} else {
newMapDialogFactory.newMap(); // XXX: pass file
}
Modified: trunk/src/app/net/sf/gridarta/model/baseobject/BaseObject.java
===================================================================
--- trunk/src/app/net/sf/gridarta/model/baseobject/BaseObject.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/model/baseobject/BaseObject.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -319,7 +319,6 @@
* @return next of this multipart object or <code>null</code> if this isn't
* a multipart object or this is the last part of a multipart
* object.
- * @todo check whether this should return G or Archetype<G>
*/
@Nullable
T getMultiNext();
Modified: trunk/src/app/net/sf/gridarta/model/baseobject/GameObjectContainer.java
===================================================================
--- trunk/src/app/net/sf/gridarta/model/baseobject/GameObjectContainer.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/model/baseobject/GameObjectContainer.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -589,8 +589,6 @@
/**
* {@inheritDoc}
- * @todo either this class should be Cloneable or the catch clause needs to
- * be changed.
*/
@NotNull
@Override
Modified: trunk/src/app/net/sf/gridarta/model/map/maparchobject/MapArchObject.java
===================================================================
--- trunk/src/app/net/sf/gridarta/model/map/maparchobject/MapArchObject.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/model/map/maparchobject/MapArchObject.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -270,8 +270,6 @@
/**
* Returns the message text.
* @return The message text.
- * @todo original comment said returns map text, so what does it? return map
- * text or message text?
*/
@NotNull
String getText();
Modified: trunk/src/app/net/sf/gridarta/model/map/mapmodel/DefaultMapModel.java
===================================================================
--- trunk/src/app/net/sf/gridarta/model/map/mapmodel/DefaultMapModel.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/model/map/mapmodel/DefaultMapModel.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -725,9 +725,6 @@
* @retval <code>true</code> if the multi-square arch would still fit on
* this map
* @retval <code>false</code> otherwise
- * @todo discuss whether this method really belongs to the interface of
- * MapModel as it is only used by MapModel implementations and heavily
- * depends on how arches, especially multi-square arches are implemented.
*/
private boolean isMultiArchFittingToMap(@NotNull final Archetype<G, A, R> archetype, @NotNull final Point pos, final boolean allowDouble) {
for (Archetype<G, A, R> part = archetype; part != null; part = part.getMultiNext()) {
Modified: trunk/src/app/net/sf/gridarta/model/spells/Spells.java
===================================================================
--- trunk/src/app/net/sf/gridarta/model/spells/Spells.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/model/spells/Spells.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -29,7 +29,6 @@
/**
* Common base class for spells and spell lists.
* @author <a href="mailto:ch...@ri...">Christian Hujer</a>
- * @todo move spell related stuff from CFArchTypeList to this class.
*/
public class Spells<S extends Spell> implements Iterable<S> {
Modified: trunk/src/app/net/sf/gridarta/script/Script.java
===================================================================
--- trunk/src/app/net/sf/gridarta/script/Script.java 2010-05-26 20:24:23 UTC (rev 8009)
+++ trunk/src/app/net/sf/gridarta/script/Script.java 2010-05-26 20:42:15 UTC (rev 8010)
@@ -104,10 +104,8 @@
}
/**
- * Returns the code of this ScriptModel.
- * @return The code of this ScriptModel.
- * @todo Improve name - what code is it? Source code? A special coded
- * String?
+ * Returns the source code of this script model.
+ * @return the source code of this script model
*/
public String getCode() {
return code;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|
