From: <aki...@us...> - 2008-07-14 20:23:28
|
Revision: 4331 http://gridarta.svn.sourceforge.net/gridarta/?rev=4331&view=rev Author: akirschbaum Date: 2008-07-14 13:23:37 -0700 (Mon, 14 Jul 2008) Log Message: ----------- Remove MainControl.getSelectedSquareControl(). Modified Paths: -------------- trunk/crossfire/src/cfeditor/CMainControl.java trunk/daimonin/src/daieditor/CMainControl.java trunk/src/app/net/sf/gridarta/MainControl.java Modified: trunk/crossfire/src/cfeditor/CMainControl.java =================================================================== --- trunk/crossfire/src/cfeditor/CMainControl.java 2008-07-14 20:21:29 UTC (rev 4330) +++ trunk/crossfire/src/cfeditor/CMainControl.java 2008-07-14 20:23:37 UTC (rev 4331) @@ -181,9 +181,6 @@ /** The Spells. */ private final Spells<GameObjectSpell<GameObject, MapArchObject, Archetype>> gameObjectSpells = new Spells<GameObjectSpell<GameObject, MapArchObject, Archetype>>(); - /** List of objects on map (right side). */ - private final SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareControl; - /** The ArchetypeSet, which is a registry of all Archetypes. */ private final ArchetypeSet archetypeSet; @@ -234,7 +231,7 @@ archetypeSet = new ArchetypeSet(this, animationObjects, faceObjects); scriptControl = new ScriptController(this); final boolean mapTileListBottom = prefs.getBoolean(MainView.MAP_TILE_LIST_BOTTOM_KEY, MainView.MAP_TILE_LIST_BOTTOM_DEFAULT); - selectedSquareControl = new SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(ACTION_FACTORY, this, mapTileListBottom, null); + final SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareControl = new SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(ACTION_FACTORY, this, mapTileListBottom, null); mapCursorControl = new MapCursorControl<GameObject, MapArchObject, Archetype, CMapViewBasic>("cfeditor", this, getMapManager(), selectedSquareControl, selectedSquareControl.getSelectedSquareView()); ACTION_FACTORY.createActions(true, this, "createNew", "open", "options", "exit", "newScript", "editScript", "zoom", "gc", "onlineHelp", "tod", "about"); mapManagerActions = new MapManagerActions<GameObject, MapArchObject, Archetype, CMapViewBasic>(getMapManager()); @@ -866,12 +863,6 @@ /** {@inheritDoc} */ @NotNull - public SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic> getSelectedSquareControl() { - return selectedSquareControl; - } - - /** {@inheritDoc} */ - @NotNull public MainActions<GameObject, MapArchObject, Archetype, CMapViewBasic> getMainActions() { return mainActions; } Modified: trunk/daimonin/src/daieditor/CMainControl.java =================================================================== --- trunk/daimonin/src/daieditor/CMainControl.java 2008-07-14 20:21:29 UTC (rev 4330) +++ trunk/daimonin/src/daieditor/CMainControl.java 2008-07-14 20:23:37 UTC (rev 4331) @@ -220,9 +220,6 @@ /** The Spells. */ private final Spells<GameObjectSpell<GameObject, MapArchObject, Archetype>> gameObjectSpells = new Spells<GameObjectSpell<GameObject, MapArchObject, Archetype>>(); - /** List of objects on map (right side). */ - private final SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareControl; - /** The ArchetypeSet, which is a registry of all Archetypes. */ private final ArchetypeSet archetypeSet; @@ -285,7 +282,7 @@ animationObjects = new daieditor.gameobject.anim.AnimationObjects(); archetypeSet = new ArchetypeSet(this, animationObjects, faceObjects); final boolean mapTileListBottom = prefs.getBoolean(MainView.MAP_TILE_LIST_BOTTOM_KEY, MainView.MAP_TILE_LIST_BOTTOM_DEFAULT); - selectedSquareControl = new SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(ACTION_FACTORY, this, mapTileListBottom, GUIUtils.getSysIcon(IGUIConstants.TILE_NORTH)); + final SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareControl = new SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(ACTION_FACTORY, this, mapTileListBottom, GUIUtils.getSysIcon(IGUIConstants.TILE_NORTH)); mapCursorControl = new MapCursorControl<GameObject, MapArchObject, Archetype, CMapViewBasic>("daieditor", this, getMapManager(), selectedSquareControl, selectedSquareControl.getSelectedSquareView()); ACTION_FACTORY.createActions(true, this, "createNew", "open", "options", "exit", "newScript", "editScript", "controlServer", "controlClient", "cleanCompletelyBlockedSquares", "zoom", "gc", "onlineHelp", "tod", "about"); ACTION_FACTORY.createToggles(true, this, "drawDouble"); @@ -1033,12 +1030,6 @@ /** {@inheritDoc} */ @NotNull - public SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic> getSelectedSquareControl() { - return selectedSquareControl; - } - - /** {@inheritDoc} */ - @NotNull public MainActions<GameObject, MapArchObject, Archetype, CMapViewBasic> getMainActions() { return mainActions; } Modified: trunk/src/app/net/sf/gridarta/MainControl.java =================================================================== --- trunk/src/app/net/sf/gridarta/MainControl.java 2008-07-14 20:21:29 UTC (rev 4330) +++ trunk/src/app/net/sf/gridarta/MainControl.java 2008-07-14 20:23:37 UTC (rev 4331) @@ -286,13 +286,6 @@ ObjectChooser<G, A, R, V> getObjectChooser(); /** - * Return the Selected Square Control. - * @return The Selected Square Control. - */ - @NotNull - SelectedSquareControl<G, A, R, V> getSelectedSquareControl(); - - /** * Returns the main actions. * @return the main actions */ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <aki...@us...> - 2008-07-14 20:33:21
|
Revision: 4332 http://gridarta.svn.sourceforge.net/gridarta/?rev=4332&view=rev Author: akirschbaum Date: 2008-07-14 13:33:22 -0700 (Mon, 14 Jul 2008) Log Message: ----------- Remove calls to SelectedSquareControl.getSelectedSquareView(). Modified Paths: -------------- trunk/crossfire/src/cfeditor/CMainControl.java trunk/daimonin/src/daieditor/CMainControl.java Modified: trunk/crossfire/src/cfeditor/CMainControl.java =================================================================== --- trunk/crossfire/src/cfeditor/CMainControl.java 2008-07-14 20:23:37 UTC (rev 4331) +++ trunk/crossfire/src/cfeditor/CMainControl.java 2008-07-14 20:33:22 UTC (rev 4332) @@ -81,6 +81,7 @@ import net.sf.gridarta.gui.prefs.MiscPrefs; import net.sf.gridarta.gui.prefs.UpdatePrefs; import net.sf.gridarta.gui.selectedsquare.SelectedSquareControl; +import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; import net.sf.gridarta.gui.undo.UndoControl; import net.sf.gridarta.io.IOUtils; import net.sf.gridarta.io.PathManager; @@ -232,7 +233,8 @@ scriptControl = new ScriptController(this); final boolean mapTileListBottom = prefs.getBoolean(MainView.MAP_TILE_LIST_BOTTOM_KEY, MainView.MAP_TILE_LIST_BOTTOM_DEFAULT); final SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareControl = new SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(ACTION_FACTORY, this, mapTileListBottom, null); - mapCursorControl = new MapCursorControl<GameObject, MapArchObject, Archetype, CMapViewBasic>("cfeditor", this, getMapManager(), selectedSquareControl, selectedSquareControl.getSelectedSquareView()); + final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView = selectedSquareControl.getSelectedSquareView(); + mapCursorControl = new MapCursorControl<GameObject, MapArchObject, Archetype, CMapViewBasic>("cfeditor", this, getMapManager(), selectedSquareControl, selectedSquareView); ACTION_FACTORY.createActions(true, this, "createNew", "open", "options", "exit", "newScript", "editScript", "zoom", "gc", "onlineHelp", "tod", "about"); mapManagerActions = new MapManagerActions<GameObject, MapArchObject, Archetype, CMapViewBasic>(getMapManager()); globalSettings.readGlobalSettings(); @@ -241,9 +243,9 @@ newMapDialogFactory = new NewMapDialogFactory<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPSIZE, 0, false, false, IGUIConstants.DEF_PICKMAP_WIDTH, IGUIConstants.DEF_PICKMAP_HEIGHT); pickmapChooserControl = new PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(newMapDialogFactory, this, new File(globalSettings.getMapDir(), IGUIConstants.PICKMAP_DIR), mapManager); newMapDialogFactory.setPickmapChooserControl(pickmapChooserControl); - objectChooser = new ObjectChooser(this, selectedSquareControl.getSelectedSquareView(), archetypeChooserControl, mapManager, pickmapChooserControl); + objectChooser = new ObjectChooser(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); mainActions = new MainActions<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, pickmapChooserControl, animationObjects, ACTION_FACTORY, faceObjects, objectChooser); - getGridartaObjectsFactory().init(faceObjects, objectChooser, archetypeChooserControl, pickmapChooserControl, selectedSquareControl.getSelectedSquareView()); + getGridartaObjectsFactory().init(faceObjects, objectChooser, archetypeChooserControl, pickmapChooserControl, selectedSquareView); mainView = new MainView<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, objectChooser, getMapManager(), ACTION_FACTORY, mapManagerActions.getCloseAllAction(), faceObjects); new About("cfeditor", mainView); undoControl = new UndoControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(getMapManager()); @@ -281,7 +283,7 @@ log.fatal("GameObjectMatcher 'exit' does not exist"); throw new MissingResourceException("GameObjectMatcher 'exit' does not exist", null, null); } - mapActions = new MapActions(this, getMapManager(), exitMatcher, mapFileFilter, selectedSquareControl.getSelectedSquareView()); + mapActions = new MapActions(this, getMapManager(), exitMatcher, mapFileFilter, selectedSquareView); typeList.getListTable().put("event", getEventTypes()); try { final String filename = IOUtils.getResourceURLAsString(getConfigurationDirectory(), CommonConstants.TYPEDEF_FILE); @@ -299,8 +301,8 @@ throw new MissingResourceException("GameObjectMatcher 'monster' does not exist", null, null); } final LockedItemsControl<GameObject, MapArchObject, Archetype, CMapViewBasic> lockedItemsControl = new LockedItemsControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(getMapManager(), Archetype.TYPE_LOCKED_DOOR, Archetype.TYPE_SPECIAL_KEY, Archetype.TYPE_TRIGGER_ALTAR, Archetype.TYPE_DETECTOR, Archetype.TYPE_TRIGGER_MARKER, Archetype.TYPE_MARKER, Archetype.TYPE_INVENTORY_CHECKER, Archetype.TYPE_CONTAINER); - final GameObjectAttributesPanel gameObjectAttributesPanel = new GameObjectAttributesPanel(this, getMapManager(), animationObjects, lockedItemsControl, monsterMatcher, selectedSquareControl, selectedSquareControl.getSelectedSquareView()); - mainView.init(gameObjectAttributesPanel, selectedSquareControl.getSelectedSquareView(), typeList, mapTileListBottom, gameObjectMatchers, archetypeChooserControl); + final GameObjectAttributesPanel gameObjectAttributesPanel = new GameObjectAttributesPanel(this, getMapManager(), animationObjects, lockedItemsControl, monsterMatcher, selectedSquareControl, selectedSquareView); + mainView.init(gameObjectAttributesPanel, selectedSquareView, typeList, mapTileListBottom, gameObjectMatchers, archetypeChooserControl); mapActions.updateMenuState(); scriptControl.getView().setMenu((JMenu) ACTION_FACTORY.find(mainView.getJMenuBar(), "plugins")); archetypeParser = new ArchetypeParser(this, archetypeChooserControl, animationObjects, archetypeSet); Modified: trunk/daimonin/src/daieditor/CMainControl.java =================================================================== --- trunk/daimonin/src/daieditor/CMainControl.java 2008-07-14 20:23:37 UTC (rev 4331) +++ trunk/daimonin/src/daieditor/CMainControl.java 2008-07-14 20:33:22 UTC (rev 4332) @@ -88,6 +88,7 @@ import net.sf.gridarta.gui.prefs.MiscPrefs; import net.sf.gridarta.gui.prefs.UpdatePrefs; import net.sf.gridarta.gui.selectedsquare.SelectedSquareControl; +import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; import net.sf.gridarta.gui.undo.UndoControl; import net.sf.gridarta.io.IOUtils; import net.sf.gridarta.io.PathManager; @@ -283,7 +284,8 @@ archetypeSet = new ArchetypeSet(this, animationObjects, faceObjects); final boolean mapTileListBottom = prefs.getBoolean(MainView.MAP_TILE_LIST_BOTTOM_KEY, MainView.MAP_TILE_LIST_BOTTOM_DEFAULT); final SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareControl = new SelectedSquareControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(ACTION_FACTORY, this, mapTileListBottom, GUIUtils.getSysIcon(IGUIConstants.TILE_NORTH)); - mapCursorControl = new MapCursorControl<GameObject, MapArchObject, Archetype, CMapViewBasic>("daieditor", this, getMapManager(), selectedSquareControl, selectedSquareControl.getSelectedSquareView()); + final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView = selectedSquareControl.getSelectedSquareView(); + mapCursorControl = new MapCursorControl<GameObject, MapArchObject, Archetype, CMapViewBasic>("daieditor", this, getMapManager(), selectedSquareControl, selectedSquareView); ACTION_FACTORY.createActions(true, this, "createNew", "open", "options", "exit", "newScript", "editScript", "controlServer", "controlClient", "cleanCompletelyBlockedSquares", "zoom", "gc", "onlineHelp", "tod", "about"); ACTION_FACTORY.createToggles(true, this, "drawDouble"); ACTION_FACTORY.createAction(true, "collectSpells", this); @@ -294,9 +296,9 @@ newMapDialogFactory = new NewMapDialogFactory<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPDIFFICULTY, true, true, IGUIConstants.DEF_PICKMAP_WIDTH, IGUIConstants.DEF_PICKMAP_HEIGHT); pickmapChooserControl = new PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(newMapDialogFactory, this, new File(globalSettings.getArchDefaultFolder(), IGUIConstants.PICKMAP_DIR), mapManager); newMapDialogFactory.setPickmapChooserControl(pickmapChooserControl); - objectChooser = new ObjectChooser(this, selectedSquareControl.getSelectedSquareView(), archetypeChooserControl, mapManager, pickmapChooserControl); + objectChooser = new ObjectChooser(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); mainActions = new MainActions<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, pickmapChooserControl, animationObjects, ACTION_FACTORY, faceObjects, objectChooser); - getGridartaObjectsFactory().init(faceObjects, objectChooser, archetypeChooserControl, pickmapChooserControl, selectedSquareControl.getSelectedSquareView()); + getGridartaObjectsFactory().init(faceObjects, objectChooser, archetypeChooserControl, pickmapChooserControl, selectedSquareView); mainView = new MainView<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, objectChooser, getMapManager(), ACTION_FACTORY, mapManagerActions.getCloseAllAction(), faceObjects); new About("daieditor", mainView); undoControl = new UndoControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(getMapManager()); @@ -337,7 +339,7 @@ log.fatal("GameObjectMatcher 'exit' does not exist"); throw new MissingResourceException("GameObjectMatcher 'exit' does not exist", null, null); } - mapActions = new MapActions(this, getMapManager(), exitMatcher, mapFileFilter, selectedSquareControl.getSelectedSquareView()); + mapActions = new MapActions(this, getMapManager(), exitMatcher, mapFileFilter, selectedSquareView); try { final String filename = IOUtils.getResourceURLAsString(getConfigurationDirectory(), CommonConstants.TYPEDEF_FILE); typeList.loadTypesFromXML(filename); @@ -354,8 +356,8 @@ throw new MissingResourceException("GameObjectMatcher 'monster' does not exist", null, null); } final LockedItemsControl<GameObject, MapArchObject, Archetype, CMapViewBasic> lockedItemsControl = new LockedItemsControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(getMapManager(), Archetype.TYPE_LOCKED_DOOR, Archetype.TYPE_SPECIAL_KEY, Archetype.TYPE_ALTAR_TRIGGER, Archetype.TYPE_MARKER, Archetype.TYPE_INVENTORY_CHECKER, Archetype.TYPE_SPAWN_POINT, Archetype.TYPE_CONTAINER); - final GameObjectAttributesPanel gameObjectAttributesPanel = new GameObjectAttributesPanel(this, getMapManager(), animationObjects, lockedItemsControl, monsterMatcher, selectedSquareControl, selectedSquareControl.getSelectedSquareView()); - mainView.init(gameObjectAttributesPanel, selectedSquareControl.getSelectedSquareView(), typeList, mapTileListBottom, gameObjectMatchers, archetypeChooserControl); + final GameObjectAttributesPanel gameObjectAttributesPanel = new GameObjectAttributesPanel(this, getMapManager(), animationObjects, lockedItemsControl, monsterMatcher, selectedSquareControl, selectedSquareView); + mainView.init(gameObjectAttributesPanel, selectedSquareView, typeList, mapTileListBottom, gameObjectMatchers, archetypeChooserControl); mapActions.updateMenuState(); archetypeParser = new ArchetypeParser(this, archetypeChooserControl, animationObjects, archetypeSet); archetypeSet.loadArchetypes(archetypeParser); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <aki...@us...> - 2008-07-14 20:44:42
|
Revision: 4334 http://gridarta.svn.sourceforge.net/gridarta/?rev=4334&view=rev Author: akirschbaum Date: 2008-07-14 13:44:45 -0700 (Mon, 14 Jul 2008) Log Message: ----------- Remove uneeded code. Modified Paths: -------------- trunk/crossfire/src/cfeditor/gui/ObjectChooser.java trunk/daimonin/src/daieditor/gui/ObjectChooser.java trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java trunk/src/app/net/sf/gridarta/gui/MainView.java Modified: trunk/crossfire/src/cfeditor/gui/ObjectChooser.java =================================================================== --- trunk/crossfire/src/cfeditor/gui/ObjectChooser.java 2008-07-14 20:42:09 UTC (rev 4333) +++ trunk/crossfire/src/cfeditor/gui/ObjectChooser.java 2008-07-14 20:44:45 UTC (rev 4334) @@ -129,11 +129,6 @@ } /** {@inheritDoc} */ - @Override - public void appExitNotify() { - } - - /** {@inheritDoc} */ @Nullable public GameObject getObjectChooserHighlight() { return isPickmapActive() ? pickmapChooserControl.getSelection() : archetypeChooserControl.getSelection(); Modified: trunk/daimonin/src/daieditor/gui/ObjectChooser.java =================================================================== --- trunk/daimonin/src/daieditor/gui/ObjectChooser.java 2008-07-14 20:42:09 UTC (rev 4333) +++ trunk/daimonin/src/daieditor/gui/ObjectChooser.java 2008-07-14 20:44:45 UTC (rev 4334) @@ -136,11 +136,6 @@ } /** {@inheritDoc} */ - @Override - public void appExitNotify() { - } - - /** {@inheritDoc} */ @Nullable public GameObject getObjectChooserHighlight() { return isPickmapActive() ? pickmapChooserControl.getSelection() : archetypeChooserControl.getSelection(); Modified: trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java =================================================================== --- trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java 2008-07-14 20:42:09 UTC (rev 4333) +++ trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java 2008-07-14 20:44:45 UTC (rev 4334) @@ -101,6 +101,4 @@ return newObject; } - public abstract void appExitNotify(); - } // class AbstractObjectChooser Modified: trunk/src/app/net/sf/gridarta/gui/MainView.java =================================================================== --- trunk/src/app/net/sf/gridarta/gui/MainView.java 2008-07-14 20:42:09 UTC (rev 4333) +++ trunk/src/app/net/sf/gridarta/gui/MainView.java 2008-07-14 20:44:45 UTC (rev 4334) @@ -527,7 +527,6 @@ prefs.putInt(DIVIDER_LOCATION_KEY3, splitRightPane.getDividerLocation()); prefs.putInt(WINDOW_STATE, getExtendedState()); - objectChooser.appExitNotify(); gameObjectAttributesPanel.appExitNotify(); } This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <aki...@us...> - 2008-07-15 05:50:10
|
Revision: 4336 http://gridarta.svn.sourceforge.net/gridarta/?rev=4336&view=rev Author: akirschbaum Date: 2008-07-14 22:50:20 -0700 (Mon, 14 Jul 2008) Log Message: ----------- Rename field names. Modified Paths: -------------- trunk/crossfire/build.xml trunk/crossfire/crossfire.iml trunk/daimonin/daimonin.iml trunk/gridarta.iml trunk/gridarta.ipr Modified: trunk/crossfire/build.xml =================================================================== --- trunk/crossfire/build.xml 2008-07-15 05:28:31 UTC (rev 4335) +++ trunk/crossfire/build.xml 2008-07-15 05:50:20 UTC (rev 4336) @@ -134,6 +134,7 @@ <fileset dir="../src/app" excludes="**/*.java,**/package.html,**/overview.html" /> <fileset dir="../resource"> <include name="system/**"/> + <include name="toolbarButtonGraphics/**/*.*"/> </fileset> <zipfileset src="../lib/log4j-1.2.13.jar" /> <zipfileset src="${lib.dir}/jdom.jar" excludes="META-INF/**" /> Modified: trunk/crossfire/crossfire.iml =================================================================== --- trunk/crossfire/crossfire.iml 2008-07-15 05:28:31 UTC (rev 4335) +++ trunk/crossfire/crossfire.iml 2008-07-15 05:50:20 UTC (rev 4336) @@ -4,10 +4,13 @@ <output url="file://$MODULE_DIR$/classes" /> <exclude-output /> <content url="file://$MODULE_DIR$"> + <sourceFolder url="file://$MODULE_DIR$/resource/icons" isTestSource="false" packagePrefix="icons" /> <sourceFolder url="file://$MODULE_DIR$/src" isTestSource="false" /> <excludeFolder url="file://$MODULE_DIR$/lib" /> <excludeFolder url="file://$MODULE_DIR$/patches" /> - <excludeFolder url="file://$MODULE_DIR$/resource" /> + <excludeFolder url="file://$MODULE_DIR$/resource/HelpFiles" /> + <excludeFolder url="file://$MODULE_DIR$/resource/conf" /> + <excludeFolder url="file://$MODULE_DIR$/resource/system" /> </content> <orderEntry type="inheritedJdk" /> <orderEntry type="sourceFolder" forTests="false" /> Modified: trunk/daimonin/daimonin.iml =================================================================== --- trunk/daimonin/daimonin.iml 2008-07-15 05:28:31 UTC (rev 4335) +++ trunk/daimonin/daimonin.iml 2008-07-15 05:50:20 UTC (rev 4336) @@ -10,7 +10,7 @@ <output url="file://$MODULE_DIR$/classes" /> <exclude-output /> <content url="file://$MODULE_DIR$"> - <sourceFolder url="file://$MODULE_DIR$/resource" isTestSource="false" /> + <sourceFolder url="file://$MODULE_DIR$/resource/icons" isTestSource="false" packagePrefix="icons" /> <sourceFolder url="file://$MODULE_DIR$/src" isTestSource="false" /> <sourceFolder url="file://$MODULE_DIR$/src/test" isTestSource="true" packagePrefix="test" /> <excludeFolder url="file://$MODULE_DIR$/debug" /> Modified: trunk/gridarta.iml =================================================================== --- trunk/gridarta.iml 2008-07-15 05:28:31 UTC (rev 4335) +++ trunk/gridarta.iml 2008-07-15 05:50:20 UTC (rev 4336) @@ -4,6 +4,7 @@ <output url="file://$MODULE_DIR$/classes" /> <exclude-output /> <content url="file://$MODULE_DIR$"> + <sourceFolder url="file://$MODULE_DIR$/resource/system" isTestSource="false" packagePrefix="system" /> <sourceFolder url="file://$MODULE_DIR$/src/app" isTestSource="false" /> <sourceFolder url="file://$MODULE_DIR$/src/test" isTestSource="true" packagePrefix="test" /> <excludeFolder url="file://$MODULE_DIR$/crossfire" /> Modified: trunk/gridarta.ipr =================================================================== --- trunk/gridarta.ipr 2008-07-15 05:28:31 UTC (rev 4335) +++ trunk/gridarta.ipr 2008-07-15 05:50:20 UTC (rev 4336) @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<project version="4" relativePaths="false"> +<project relativePaths="false" version="4"> <component name="AntConfiguration"> <defaultAnt bundledAnt="true" /> </component> @@ -18,9 +18,12 @@ <value> <option name="LINE_SEPARATOR" value=" " /> <option name="INDENT_CASE_FROM_SWITCH" value="false" /> + <option name="ALIGN_MULTILINE_PARAMETERS" value="false" /> + <option name="ALIGN_MULTILINE_FOR" value="false" /> <option name="BLANK_LINES_BEFORE_PACKAGE" value="1" /> <option name="BLANK_LINES_AROUND_FIELD" value="1" /> <option name="BLANK_LINES_AFTER_CLASS_HEADER" value="1" /> + <option name="SPACE_BEFORE_ARRAY_INITIALIZER_LBRACE" value="true" /> <option name="GENERATE_FINAL_LOCALS" value="true" /> <option name="GENERATE_FINAL_PARAMETERS" value="true" /> <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="1000" /> @@ -33,23 +36,31 @@ <package name="" withSubpackages="true" /> </value> </option> - <option name="RIGHT_MARGIN" value="160" /> + <option name="RIGHT_MARGIN" value="80" /> + <option name="WRAP_COMMENTS" value="true" /> <option name="IF_BRACE_FORCE" value="3" /> <option name="DOWHILE_BRACE_FORCE" value="3" /> <option name="WHILE_BRACE_FORCE" value="3" /> <option name="FOR_BRACE_FORCE" value="3" /> - <option name="JD_ADD_BLANK_AFTER_PARM_COMMENTS" value="true" /> - <option name="JD_ADD_BLANK_AFTER_RETURN" value="true" /> + <option name="JD_ALIGN_PARAM_COMMENTS" value="false" /> + <option name="JD_ALIGN_EXCEPTION_COMMENTS" value="false" /> + <option name="JD_ADD_BLANK_AFTER_DESCRIPTION" value="false" /> <option name="JD_DO_NOT_WRAP_ONE_LINE_COMMENTS" value="true" /> <option name="XML_SPACE_INSIDE_EMPTY_TAG" value="true" /> <option name="HTML_TEXT_WRAP" value="0" /> <option name="HTML_SPACE_INSIDE_EMPTY_TAG" value="true" /> <option name="HTML_DO_NOT_INDENT_CHILDREN_OF" value="" /> <option name="HTML_DO_NOT_ALIGN_CHILDREN_OF_MIN_LINES" value="10000" /> - <option name="METHOD_ANNOTATION_WRAP" value="1" /> - <option name="CLASS_ANNOTATION_WRAP" value="1" /> - <option name="FIELD_ANNOTATION_WRAP" value="1" /> <option name="ENUM_CONSTANTS_WRAP" value="2" /> + <ADDITIONAL_INDENT_OPTIONS fileType="js"> + <option name="INDENT_SIZE" value="4" /> + <option name="CONTINUATION_INDENT_SIZE" value="8" /> + <option name="TAB_SIZE" value="4" /> + <option name="USE_TAB_CHARACTER" value="false" /> + <option name="SMART_TABS" value="false" /> + <option name="LABEL_INDENT_SIZE" value="0" /> + <option name="LABEL_INDENT_ABSOLUTE" value="false" /> + </ADDITIONAL_INDENT_OPTIONS> </value> </option> <option name="USE_PER_PROJECT_SETTINGS" value="true" /> @@ -74,11 +85,12 @@ <entry name="?*.testdata" /> </wildcardResourcePatterns> </component> - <component name="DataSourceManagerImpl" /> + <component name="CppTools.Loader" warnedAboutFileOutOfSourceRoot="true" /> <component name="DependenciesAnalyzeManager"> <option name="myForwardDirection" value="false" /> </component> <component name="DependencyValidationManager"> + <option name="SKIP_IMPORT_STATEMENTS" value="false" /> <scope name="Project without textedit" pattern="!src[gridarta]:net.sf.gridarta.textedit.scripteditor..*&&!src[gridarta]:net.sf.gridarta.textedit.textarea..*&&!src[textedit]:*..*" /> </component> <component name="EclipseCompilerSettings"> @@ -96,14 +108,13 @@ <option name="MAXIMUM_HEAP_SIZE" value="128" /> </component> <component name="EntryPointsManager"> - <entry_points /> + <entry_points version="2.0" /> </component> <component name="ExportToHTMLSettings"> <option name="PRINT_LINE_NUMBERS" value="false" /> <option name="OPEN_IN_BROWSER" value="false" /> <option name="OUTPUT_DIRECTORY" /> </component> - <component name="GUI Designer component loader factory" /> <component name="IdProvider" IDEtalkID="2C998304C446463F0F811673874877B6" /> <component name="InspectionProjectProfileManager"> <option name="PROJECT_PROFILE" value="No errors allowed here" /> @@ -113,24 +124,6 @@ <profile version="1.0" is_locked="false"> <option name="myName" value="Javadoc Issues" /> <option name="myLocal" value="false" /> - <used_levels> - <error> - <option name="myName" value="ERROR" /> - <option name="myVal" value="400" /> - </error> - <warning> - <option name="myName" value="WARNING" /> - <option name="myVal" value="300" /> - </warning> - <information> - <option name="myName" value="INFO" /> - <option name="myVal" value="200" /> - </information> - <server> - <option name="myName" value="SERVER PROBLEM" /> - <option name="myVal" value="100" /> - </server> - </used_levels> <inspection_tool class="CheckEmptyScriptTag" level="WARNING" enabled="false" /> <inspection_tool class="FunctionWithInconsistentReturnsJS" level="WARNING" enabled="false" /> <inspection_tool class="InfiniteLoopStatement" level="WARNING" enabled="false" /> @@ -150,13 +143,9 @@ </inspection_tool> <inspection_tool class="GwtInconsistentI18nInterface" level="ERROR" enabled="false" /> <inspection_tool class="StringToString" level="WARNING" enabled="false" /> - <inspection_tool class="AnalyzingStaticVariables" level="ERROR" enabled="false"> - <option name="CHECKED_TYPES" value="javax.servlet.http.HttpSession;com.ulcjava.base.application.ULCProxy" /> - </inspection_tool> <inspection_tool class="BoundFieldAssignment" level="WARNING" enabled="false" /> <inspection_tool class="NullArgumentToVariableArgMethod" level="WARNING" enabled="false" /> <inspection_tool class="JSUndeclaredVariable" level="INFO" enabled="false" /> - <inspection_tool class="PersistenceModelErrorInspection" level="ERROR" enabled="false" /> <inspection_tool class="LoopStatementsThatDontLoop" level="WARNING" enabled="false" /> <inspection_tool class="RedundantThrows" level="WARNING" enabled="false" /> <inspection_tool class="StrutsValidatorFormInspection" level="ERROR" enabled="false" /> @@ -173,10 +162,10 @@ <inspection_tool class="Glassfish" level="ERROR" enabled="false" /> <inspection_tool class="ConstantConditions" level="WARNING" enabled="false"> <option name="SUGGEST_NULLABLE_ANNOTATIONS" value="false" /> + <option name="DONT_REPORT_TRUE_ASSERT_STATEMENTS" value="false" /> </inspection_tool> <inspection_tool class="GwtServiceNotRegistered" level="ERROR" enabled="false" /> <inspection_tool class="EjbErrorInspection" level="ERROR" enabled="false" /> - <inspection_tool class="PersistenceDataSourceORMInspection" level="ERROR" enabled="false" /> <inspection_tool class="CanBeFinal" level="WARNING" enabled="false"> <option name="REPORT_CLASSES" value="false" /> <option name="REPORT_METHODS" value="false" /> @@ -191,18 +180,10 @@ <option name="REPORT_POSTFIX_EXPRESSIONS" value="true" /> <option name="REPORT_REDUNDANT_INITIALIZER" value="true" /> </inspection_tool> - <inspection_tool class="AnalyzingVariableNaming" level="WARNING" enabled="false"> - <option name="IGNORE_SERIAL_VERSION_UID" value="true" /> - <option name="CHECK_STATIC_FINAL_FIELDS" value="true" /> - <option name="CHECK_STATIC_FIELDS" value="true" /> - <option name="CHECK_FIELDS" value="true" /> - <option name="CHECK_PARAMETERS" value="true" /> - </inspection_tool> <inspection_tool class="WebProperties" level="ERROR" enabled="false" /> <inspection_tool class="PointlessArithmeticExpressionJS" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryConditionalExpression" level="WARNING" enabled="false" /> <inspection_tool class="StringConcatenationInsideStringBufferAppend" level="WARNING" enabled="false" /> - <inspection_tool class="AnalyzingJLSModifierOrder" level="WARNING" enabled="false" /> <inspection_tool class="AntDuplicateImportedTargetsInspection" level="WARNING" enabled="false" /> <inspection_tool class="UNUSED_SYMBOL" level="WARNING" enabled="false"> <option name="LOCAL_VARIABLE" value="true" /> @@ -210,6 +191,7 @@ <option name="METHOD" value="true" /> <option name="CLASS" value="true" /> <option name="PARAMETER" value="true" /> + <option name="REPORT_PARAMETER_FOR_PUBLIC_METHODS" value="true" /> <option name="INJECTION_ANNOS"> <value> <list size="0" /> @@ -247,7 +229,6 @@ <inspection_tool class="CheckValidXmlInScriptTagBody" level="ERROR" enabled="false" /> <inspection_tool class="ManualArrayCopy" level="WARNING" enabled="false" /> <inspection_tool class="Weblogic" level="ERROR" enabled="false" /> - <inspection_tool class="PersistenceDataSourceORMDomInspection" level="ERROR" enabled="false" /> <inspection_tool class="FallthroughInSwitchStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="IgnoreResultOfCall" level="WARNING" enabled="false"> <option name="m_reportAllNonLibraryCalls" value="false" /> @@ -257,18 +238,13 @@ <inspection_tool class="RedundantCast" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryReturn" level="WARNING" enabled="false" /> <inspection_tool class="FinalStaticMethod" level="WARNING" enabled="false" /> - <inspection_tool class="SuspiciousMethodCalls" level="WARNING" enabled="false" /> - <inspection_tool class="HTML" level="WARNING" enabled="false"> - <option name="myAdditionalHtmlTags" value="embed,nobr,noembed,comment,script" /> - <option name="myAdditionalHtmlAttributes" value="type,wmode,src,width,height" /> - <option name="myCheckHtmlTags" value="true" /> - <option name="myCheckHtmlAttributes" value="true" /> + <inspection_tool class="SuspiciousMethodCalls" level="WARNING" enabled="false"> + <option name="REPORT_CONVERTIBLE_METHOD_CALLS" value="true" /> </inspection_tool> <inspection_tool class="UnnecessaryUnboxing" level="WARNING" enabled="false" /> <inspection_tool class="SameParameterValue" level="WARNING" enabled="false" /> <inspection_tool class="NoExplicitFinalizeCalls" level="WARNING" enabled="false" /> <inspection_tool class="FinalPrivateMethod" level="WARNING" enabled="false" /> - <inspection_tool class="AnalyzingRedundantFieldInitialization" level="WARNING" enabled="false" /> <inspection_tool class="ReservedWordUsedAsNameJS" level="WARNING" enabled="false" /> <inspection_tool class="ExtendsAnnotation" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryReturnJS" level="WARNING" enabled="false" /> @@ -280,17 +256,15 @@ <inspection_tool class="UnnecessaryLabelOnContinueStatement" level="WARNING" enabled="false" /> <inspection_tool class="NoLabelFor" level="WARNING" enabled="false" /> <inspection_tool class="SynchronizeOnNonFinalField" level="WARNING" enabled="false" /> - <inspection_tool class="AnalyzingLoggingWithoutLogLevelCheck" level="WARNING" enabled="false"> - <option name="CHECK_DEBUG" value="true" /> - <option name="CHECK_INFO" value="true" /> - <option name="IGNORE_SIMPLE_STATEMENTS" value="true" /> - </inspection_tool> <inspection_tool class="AntDuplicateTargetsInspection" level="ERROR" enabled="false" /> <inspection_tool class="NullableProblems" level="WARNING" enabled="false"> <option name="REPORT_NULLABLE_METHOD_OVERRIDES_NOTNULL" value="true" /> <option name="REPORT_NOT_ANNOTATED_METHOD_OVERRIDES_NOTNULL" value="true" /> <option name="REPORT_NOTNULL_PARAMETER_OVERRIDES_NULLABLE" value="true" /> <option name="REPORT_NOT_ANNOTATED_PARAMETER_OVERRIDES_NOTNULL" value="true" /> + <option name="REPORT_NOT_ANNOTATED_GETTER" value="true" /> + <option name="REPORT_NOT_ANNOTATED_SETTER_PARAMETER" value="true" /> + <option name="REPORT_ANNOTATION_NOT_PROPAGATED_TO_OVERRIDERS" value="true" /> </inspection_tool> <inspection_tool class="ReferencesToClassesFromDefaultPackagesInJSPFile" level="ERROR" enabled="false" /> <inspection_tool class="TrivialIf" level="WARNING" enabled="false" /> @@ -313,11 +287,6 @@ <inspection_tool class="IncompatibleMaskJS" level="WARNING" enabled="false" /> <inspection_tool class="NonJREEmulationClassesInClientCode" level="ERROR" enabled="false" /> <inspection_tool class="OctalLiteral" level="WARNING" enabled="false" /> - <inspection_tool class="AnalyzingRedundantModifier" level="WARNING" enabled="false"> - <option name="CHECK_FINAL_METHODS" value="true" /> - <option name="CHECK_PUBLIC_INTERFACE_METHODS" value="true" /> - <option name="CHECK_TRANSIENT_STATIC_FIELDS" value="true" /> - </inspection_tool> <inspection_tool class="WhileCanBeForeach" level="WARNING" enabled="false" /> <inspection_tool class="InfiniteRecursion" level="WARNING" enabled="false" /> <inspection_tool class="Geronimo" level="ERROR" enabled="false" /> @@ -329,6 +298,7 @@ <inspection_tool class="EmptyCatchBlock" level="WARNING" enabled="false"> <option name="m_includeComments" value="true" /> <option name="m_ignoreTestCases" value="true" /> + <option name="m_ignoreIgnoreParameter" value="true" /> </inspection_tool> <inspection_tool class="Dependency" level="ERROR" enabled="false" /> <inspection_tool class="UnnecessaryLocalVariable" level="WARNING" enabled="false"> @@ -341,8 +311,9 @@ <option name="m_reportEmptyBlocks" value="false" /> </inspection_tool> <inspection_tool class="ThrowFromFinallyBlockJS" level="WARNING" enabled="false" /> - <inspection_tool class="PersistenceORMDomInspection" level="ERROR" enabled="false" /> - <inspection_tool class="ForCanBeForeach" level="WARNING" enabled="false" /> + <inspection_tool class="ForCanBeForeach" level="WARNING" enabled="false"> + <option name="REPORT_INDEXED_LOOP" value="true" /> + </inspection_tool> <inspection_tool class="TypeParameterExtendsObject" level="WARNING" enabled="false" /> <inspection_tool class="FieldCanBeLocal" level="WARNING" enabled="false" /> <inspection_tool class="UNCHECKED_WARNING" level="WARNING" enabled="false" /> @@ -358,9 +329,7 @@ <inspection_tool class="TrivialIfJS" level="WARNING" enabled="false" /> <inspection_tool class="SimplifiableConditionalExpression" level="WARNING" enabled="false" /> <inspection_tool class="IncompatibleMask" level="WARNING" enabled="false" /> - <inspection_tool class="UNUSED_IMPORT" level="WARNING" enabled="false" /> <inspection_tool class="DuplicateCaseLabelJS" level="WARNING" enabled="false" /> - <inspection_tool class="PersistenceModelWarningInspection" level="WARNING" enabled="false" /> <inspection_tool class="PointlessBitwiseExpressionJS" level="WARNING" enabled="false"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> @@ -368,17 +337,9 @@ <inspection_tool class="BooleanConstructor" level="WARNING" enabled="false" /> <inspection_tool class="ExtendsObject" level="WARNING" enabled="false" /> <inspection_tool class="RedundantArrayCreation" level="WARNING" enabled="false" /> - <inspection_tool class="PersistenceQlInspection" level="ERROR" enabled="false" /> <inspection_tool class="UnnecessaryLabelOnContinueStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="CheckImageSize" level="WARNING" enabled="false" /> - <inspection_tool class="EmptyMethod" level="WARNING" enabled="false"> - <option name="EXCLUDE_ANNOS"> - <value> - <list size="0" /> - </value> - </option> - </inspection_tool> - <inspection_tool class="PersistenceDomInspection" level="ERROR" enabled="false" /> + <inspection_tool class="EmptyMethod" level="WARNING" enabled="false" /> <inspection_tool class="EmptyTryBlock" level="WARNING" enabled="false" /> <inspection_tool class="MalformedFormatString" level="WARNING" enabled="false" /> <inspection_tool class="ComponentRegistrationProblems" level="ERROR" enabled="false"> @@ -418,16 +379,21 @@ <inspection_tool class="JBoss" level="ERROR" enabled="false" /> <inspection_tool class="UnusedDeclaration" level="WARNING" enabled="false"> <option name="ADD_MAINS_TO_ENTRIES" value="true" /> - <option name="ADD_JUNIT_TO_ENTRIES" value="true" /> - <option name="ADD_EJB_TO_ENTRIES" value="true" /> <option name="ADD_APPLET_TO_ENTRIES" value="true" /> <option name="ADD_SERVLET_TO_ENTRIES" value="true" /> <option name="ADD_NONJAVA_TO_ENTRIES" value="true" /> + <option name="ADDITIONAL_ANNOTATIONS"> + <value> + <list size="0" /> + </value> + </option> + <option name="ADD_EJB_TO_ENTRIES" value="true" /> + <option name="ADD_JUNIT_TO_ENTRIES" value="true" /> + <option name="ADD_TESTNG_TO_ENTRIES" value="true" /> </inspection_tool> <inspection_tool class="Deprecation" level="WARNING" enabled="false" /> <inspection_tool class="StrutsInspection" level="ERROR" enabled="false" /> - <inspection_tool class="MissingDeprecatedAnnotation" level="WARNING" enabled="true" /> - <inspection_tool class="JavaDoc" level="WARNING" enabled="true"> + <inspection_tool class="JavaDoc" level="WARNING" enabled="false"> <option name="TOP_LEVEL_CLASS_OPTIONS"> <value> <option name="ACCESS_JAVADOC_REQUIRED_FOR" value="public" /> @@ -456,55 +422,40 @@ <option name="IGNORE_JAVADOC_PERIOD" value="false" /> <option name="myAdditionalJavadocTags" value="todo,note,todo,xxx,note,todo,fixme,fixme,warning,invariant,retval,pre" /> </inspection_tool> + <inspection_tool class="JavadocReference" level="ERROR" enabled="false" /> + <inspection_tool class="OnDemandImport" level="WARNING" enabled="true" /> + <inspection_tool class="SamePackageImport" level="WARNING" enabled="true" /> + <inspection_tool class="JavaLangImport" level="WARNING" enabled="true" /> + <inspection_tool class="RedundantImport" level="WARNING" enabled="true" /> + <inspection_tool class="UnusedImport" level="WARNING" enabled="true" /> + <inspection_tool class="UNUSED_IMPORT" level="WARNING" enabled="false" /> </profile> <profile version="1.0" is_locked="true"> <option name="myName" value="No errors allowed here" /> <option name="myLocal" value="false" /> - <used_levels> - <error> - <option name="myName" value="ERROR" /> - <option name="myVal" value="400" /> - </error> - <warning> - <option name="myName" value="WARNING" /> - <option name="myVal" value="300" /> - </warning> - <information> - <option name="myName" value="INFO" /> - <option name="myVal" value="200" /> - </information> - <server> - <option name="myName" value="SERVER PROBLEM" /> - <option name="myVal" value="100" /> - </server> - </used_levels> <inspection_tool class="CheckEmptyScriptTag" level="WARNING" enabled="false" /> <inspection_tool class="FunctionWithInconsistentReturnsJS" level="WARNING" enabled="false" /> - <inspection_tool class="InfiniteLoopStatement" level="WARNING" enabled="false" /> + <inspection_tool class="InfiniteLoopStatement" level="WARNING" enabled="true" /> <inspection_tool class="UnusedMessageFormatParameter" level="WARNING" enabled="true" /> <inspection_tool class="ConstantIfStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="FacesModelInspection" level="ERROR" enabled="false" /> <inspection_tool class="UnhandledExceptionInJSP" level="WARNING" enabled="false" /> <inspection_tool class="SillyAssignmentJS" level="WARNING" enabled="false" /> - <inspection_tool class="UnnecessaryLabelOnBreakStatement" level="ERROR" enabled="true" /> + <inspection_tool class="UnnecessaryLabelOnBreakStatement" level="WARNING" enabled="true" /> <inspection_tool class="ShiftOutOfRangeJS" level="WARNING" enabled="false" /> <inspection_tool class="JSUnresolvedVariable" level="INFO" enabled="false" /> <inspection_tool class="DuplicateThrows" level="WARNING" enabled="false" /> <inspection_tool class="ELValidationInJSP" level="WARNING" enabled="false" /> <inspection_tool class="ConstantConditionalExpressionJS" level="WARNING" enabled="false" /> - <inspection_tool class="PointlessBooleanExpression" level="ERROR" enabled="true"> + <inspection_tool class="PointlessBooleanExpression" level="WARNING" enabled="true"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> <inspection_tool class="GwtInconsistentI18nInterface" level="ERROR" enabled="false" /> - <inspection_tool class="StringToString" level="ERROR" enabled="true" /> - <inspection_tool class="AnalyzingStaticVariables" level="ERROR" enabled="true"> - <option name="CHECKED_TYPES" value="javax.servlet.http.HttpSession;com.ulcjava.base.application.ULCProxy" /> - </inspection_tool> + <inspection_tool class="StringToString" level="WARNING" enabled="true" /> <inspection_tool class="BoundFieldAssignment" level="WARNING" enabled="false" /> - <inspection_tool class="NullArgumentToVariableArgMethod" level="ERROR" enabled="true" /> + <inspection_tool class="NullArgumentToVariableArgMethod" level="WARNING" enabled="true" /> <inspection_tool class="JSUndeclaredVariable" level="INFO" enabled="false" /> - <inspection_tool class="PersistenceModelErrorInspection" level="ERROR" enabled="false" /> - <inspection_tool class="LoopStatementsThatDontLoop" level="ERROR" enabled="true" /> + <inspection_tool class="LoopStatementsThatDontLoop" level="WARNING" enabled="true" /> <inspection_tool class="RedundantThrows" level="WARNING" enabled="false" /> <inspection_tool class="StrutsValidatorFormInspection" level="ERROR" enabled="false" /> <inspection_tool class="UnnecessaryLabelOnBreakStatementJS" level="WARNING" enabled="false" /> @@ -520,10 +471,10 @@ <inspection_tool class="Glassfish" level="ERROR" enabled="false" /> <inspection_tool class="ConstantConditions" level="WARNING" enabled="true"> <option name="SUGGEST_NULLABLE_ANNOTATIONS" value="true" /> + <option name="DONT_REPORT_TRUE_ASSERT_STATEMENTS" value="false" /> </inspection_tool> <inspection_tool class="GwtServiceNotRegistered" level="ERROR" enabled="false" /> <inspection_tool class="EjbErrorInspection" level="ERROR" enabled="false" /> - <inspection_tool class="PersistenceDataSourceORMInspection" level="ERROR" enabled="false" /> <inspection_tool class="CanBeFinal" level="WARNING" enabled="true"> <option name="REPORT_CLASSES" value="false" /> <option name="REPORT_METHODS" value="false" /> @@ -531,25 +482,17 @@ </inspection_tool> <inspection_tool class="NoScrollPane" level="WARNING" enabled="true" /> <inspection_tool class="JSUnresolvedFunction" level="INFO" enabled="false" /> - <inspection_tool class="InstantiatingObjectToGetClassObject" level="ERROR" enabled="true" /> + <inspection_tool class="InstantiatingObjectToGetClassObject" level="WARNING" enabled="true" /> <inspection_tool class="ReturnFromFinallyBlockJS" level="WARNING" enabled="false" /> <inspection_tool class="UnusedAssignment" level="WARNING" enabled="true"> <option name="REPORT_PREFIX_EXPRESSIONS" value="true" /> <option name="REPORT_POSTFIX_EXPRESSIONS" value="true" /> <option name="REPORT_REDUNDANT_INITIALIZER" value="true" /> </inspection_tool> - <inspection_tool class="AnalyzingVariableNaming" level="WARNING" enabled="false"> - <option name="IGNORE_SERIAL_VERSION_UID" value="true" /> - <option name="CHECK_STATIC_FINAL_FIELDS" value="true" /> - <option name="CHECK_STATIC_FIELDS" value="true" /> - <option name="CHECK_FIELDS" value="true" /> - <option name="CHECK_PARAMETERS" value="true" /> - </inspection_tool> <inspection_tool class="WebProperties" level="ERROR" enabled="false" /> <inspection_tool class="PointlessArithmeticExpressionJS" level="WARNING" enabled="false" /> - <inspection_tool class="UnnecessaryConditionalExpression" level="ERROR" enabled="true" /> - <inspection_tool class="StringConcatenationInsideStringBufferAppend" level="ERROR" enabled="true" /> - <inspection_tool class="AnalyzingJLSModifierOrder" level="ERROR" enabled="true" /> + <inspection_tool class="UnnecessaryConditionalExpression" level="WARNING" enabled="true" /> + <inspection_tool class="StringConcatenationInsideStringBufferAppend" level="WARNING" enabled="true" /> <inspection_tool class="AntDuplicateImportedTargetsInspection" level="WARNING" enabled="true" /> <inspection_tool class="UNUSED_SYMBOL" level="WARNING" enabled="false"> <option name="LOCAL_VARIABLE" value="true" /> @@ -557,6 +500,7 @@ <option name="METHOD" value="true" /> <option name="CLASS" value="true" /> <option name="PARAMETER" value="true" /> + <option name="REPORT_PARAMETER_FOR_PUBLIC_METHODS" value="true" /> <option name="INJECTION_ANNOS"> <value> <list size="0" /> @@ -579,20 +523,19 @@ <inspection_tool class="PointlessArithmeticExpression" level="WARNING" enabled="false"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> - <inspection_tool class="UnnecessaryTemporaryOnConversionToString" level="ERROR" enabled="true" /> - <inspection_tool class="UnnecessaryContinue" level="ERROR" enabled="true" /> + <inspection_tool class="UnnecessaryTemporaryOnConversionToString" level="WARNING" enabled="true" /> + <inspection_tool class="UnnecessaryContinue" level="WARNING" enabled="true" /> <inspection_tool class="SameReturnValue" level="WARNING" enabled="false" /> - <inspection_tool class="UnusedLabel" level="ERROR" enabled="true" /> + <inspection_tool class="UnusedLabel" level="WARNING" enabled="true" /> <inspection_tool class="NoButtonGroup" level="WARNING" enabled="true" /> <inspection_tool class="GWTStyleCheck" level="ERROR" enabled="false" /> <inspection_tool class="NonSerializableServiceParameters" level="ERROR" enabled="false" /> <inspection_tool class="CloneCallsSuperClone" level="INFO" enabled="true" /> - <inspection_tool class="ReturnFromFinallyBlock" level="ERROR" enabled="true" /> + <inspection_tool class="ReturnFromFinallyBlock" level="WARNING" enabled="true" /> <inspection_tool class="UnreachableCodeJS" level="WARNING" enabled="false" /> <inspection_tool class="CheckValidXmlInScriptTagBody" level="ERROR" enabled="false" /> - <inspection_tool class="ManualArrayCopy" level="ERROR" enabled="true" /> + <inspection_tool class="ManualArrayCopy" level="WARNING" enabled="true" /> <inspection_tool class="Weblogic" level="ERROR" enabled="false" /> - <inspection_tool class="PersistenceDataSourceORMDomInspection" level="ERROR" enabled="false" /> <inspection_tool class="FallthroughInSwitchStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="IgnoreResultOfCall" level="WARNING" enabled="true"> <option name="m_reportAllNonLibraryCalls" value="true" /> @@ -600,45 +543,38 @@ </inspection_tool> <inspection_tool class="ThrowFromFinallyBlock" level="WARNING" enabled="false" /> <inspection_tool class="RedundantCast" level="WARNING" enabled="true" /> - <inspection_tool class="UnnecessaryReturn" level="ERROR" enabled="true" /> - <inspection_tool class="FinalStaticMethod" level="ERROR" enabled="true" /> - <inspection_tool class="SuspiciousMethodCalls" level="ERROR" enabled="true" /> - <inspection_tool class="HTML" level="WARNING" enabled="false"> - <option name="myAdditionalHtmlTags" value="embed,nobr,noembed,comment,script" /> - <option name="myAdditionalHtmlAttributes" value="type,wmode,src,width,height" /> - <option name="myCheckHtmlTags" value="true" /> - <option name="myCheckHtmlAttributes" value="true" /> + <inspection_tool class="UnnecessaryReturn" level="WARNING" enabled="true" /> + <inspection_tool class="FinalStaticMethod" level="WARNING" enabled="true" /> + <inspection_tool class="SuspiciousMethodCalls" level="WARNING" enabled="true"> + <option name="REPORT_CONVERTIBLE_METHOD_CALLS" value="true" /> </inspection_tool> <inspection_tool class="SameParameterValue" level="WARNING" enabled="false" /> - <inspection_tool class="AnalyzingRedundantFieldInitialization" level="WARNING" enabled="false" /> <inspection_tool class="ReservedWordUsedAsNameJS" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryReturnJS" level="WARNING" enabled="false" /> - <inspection_tool class="ConstantIfStatement" level="ERROR" enabled="true" /> + <inspection_tool class="ConstantIfStatement" level="WARNING" enabled="true" /> <inspection_tool class="ComponentNotRegistered" level="WARNING" enabled="false"> <option name="CHECK_ACTIONS" value="true" /> <option name="IGNORE_NON_PUBLIC" value="true" /> </inspection_tool> - <inspection_tool class="UnnecessaryLabelOnContinueStatement" level="ERROR" enabled="true" /> + <inspection_tool class="UnnecessaryLabelOnContinueStatement" level="WARNING" enabled="true" /> <inspection_tool class="NoLabelFor" level="WARNING" enabled="true" /> <inspection_tool class="SynchronizeOnNonFinalField" level="WARNING" enabled="false" /> - <inspection_tool class="AnalyzingLoggingWithoutLogLevelCheck" level="WARNING" enabled="false"> - <option name="CHECK_DEBUG" value="true" /> - <option name="CHECK_INFO" value="true" /> - <option name="IGNORE_SIMPLE_STATEMENTS" value="true" /> - </inspection_tool> <inspection_tool class="AntDuplicateTargetsInspection" level="ERROR" enabled="true" /> - <inspection_tool class="NullableProblems" level="ERROR" enabled="true"> + <inspection_tool class="NullableProblems" level="WARNING" enabled="true"> <option name="REPORT_NULLABLE_METHOD_OVERRIDES_NOTNULL" value="true" /> <option name="REPORT_NOT_ANNOTATED_METHOD_OVERRIDES_NOTNULL" value="true" /> <option name="REPORT_NOTNULL_PARAMETER_OVERRIDES_NULLABLE" value="true" /> <option name="REPORT_NOT_ANNOTATED_PARAMETER_OVERRIDES_NOTNULL" value="true" /> + <option name="REPORT_NOT_ANNOTATED_GETTER" value="true" /> + <option name="REPORT_NOT_ANNOTATED_SETTER_PARAMETER" value="true" /> + <option name="REPORT_ANNOTATION_NOT_PROPAGATED_TO_OVERRIDERS" value="true" /> </inspection_tool> <inspection_tool class="ReferencesToClassesFromDefaultPackagesInJSPFile" level="ERROR" enabled="false" /> - <inspection_tool class="TrivialIf" level="ERROR" enabled="true" /> - <inspection_tool class="AntMissingPropertiesFileInspection" level="ERROR" enabled="true" /> - <inspection_tool class="ObjectEqualsNull" level="ERROR" enabled="true" /> + <inspection_tool class="TrivialIf" level="WARNING" enabled="true" /> + <inspection_tool class="AntMissingPropertiesFileInspection" level="WARNING" enabled="true" /> + <inspection_tool class="ObjectEqualsNull" level="WARNING" enabled="true" /> <inspection_tool class="GwtToHtmlReferences" level="ERROR" enabled="false" /> - <inspection_tool class="EmptyFinallyBlock" level="ERROR" enabled="true" /> + <inspection_tool class="EmptyFinallyBlock" level="WARNING" enabled="true" /> <inspection_tool class="MismatchedCollectionQueryUpdate" level="WARNING" enabled="true" /> <inspection_tool class="EmptyStatementBody" level="WARNING" enabled="true"> <option name="m_reportEmptyBlocks" value="false" /> @@ -650,16 +586,11 @@ <inspection_tool class="TrivialConditionalJS" level="WARNING" enabled="false" /> <inspection_tool class="OneButtonGroup" level="WARNING" enabled="true" /> <inspection_tool class="StrutsTilesInspection" level="ERROR" enabled="false" /> - <inspection_tool class="ReflectionForUnavailableAnnotation" level="ERROR" enabled="true" /> + <inspection_tool class="ReflectionForUnavailableAnnotation" level="WARNING" enabled="true" /> <inspection_tool class="IncompatibleMaskJS" level="WARNING" enabled="false" /> <inspection_tool class="NonJREEmulationClassesInClientCode" level="ERROR" enabled="false" /> <inspection_tool class="OctalLiteral" level="WARNING" enabled="false" /> - <inspection_tool class="AnalyzingRedundantModifier" level="ERROR" enabled="true"> - <option name="CHECK_FINAL_METHODS" value="true" /> - <option name="CHECK_PUBLIC_INTERFACE_METHODS" value="true" /> - <option name="CHECK_TRANSIENT_STATIC_FIELDS" value="true" /> - </inspection_tool> - <inspection_tool class="InfiniteRecursion" level="ERROR" enabled="true" /> + <inspection_tool class="InfiniteRecursion" level="WARNING" enabled="true" /> <inspection_tool class="Geronimo" level="ERROR" enabled="false" /> <inspection_tool class="InfiniteLoopJS" level="WARNING" enabled="false" /> <inspection_tool class="SelfIncludingJspFiles" level="ERROR" enabled="false" /> @@ -669,51 +600,42 @@ <inspection_tool class="EmptyCatchBlock" level="WARNING" enabled="false"> <option name="m_includeComments" value="true" /> <option name="m_ignoreTestCases" value="true" /> + <option name="m_ignoreIgnoreParameter" value="true" /> </inspection_tool> <inspection_tool class="UnnecessaryLocalVariable" level="WARNING" enabled="false"> <option name="m_ignoreImmediatelyReturnedVariables" value="false" /> <option name="m_ignoreAnnotatedVariables" value="false" /> </inspection_tool> - <inspection_tool class="UnnecessaryTemporaryOnConversionFromString" level="ERROR" enabled="true" /> + <inspection_tool class="UnnecessaryTemporaryOnConversionFromString" level="WARNING" enabled="true" /> <inspection_tool class="EmptyStatementBodyJS" level="WARNING" enabled="false"> <option name="m_reportEmptyBlocks" value="false" /> </inspection_tool> <inspection_tool class="ThrowFromFinallyBlockJS" level="WARNING" enabled="false" /> - <inspection_tool class="PersistenceORMDomInspection" level="ERROR" enabled="false" /> - <inspection_tool class="TypeParameterExtendsObject" level="ERROR" enabled="true" /> - <inspection_tool class="FieldCanBeLocal" level="ERROR" enabled="true" /> + <inspection_tool class="TypeParameterExtendsObject" level="WARNING" enabled="true" /> + <inspection_tool class="FieldCanBeLocal" level="WARNING" enabled="true" /> <inspection_tool class="UNCHECKED_WARNING" level="WARNING" enabled="false" /> <inspection_tool class="LoopStatementThatDoesntLoopJS" level="WARNING" enabled="false" /> - <inspection_tool class="SuspiciousNameCombination" level="ERROR" enabled="true"> + <inspection_tool class="SuspiciousNameCombination" level="WARNING" enabled="true"> <group names="x,width,left,right" /> <group names="y,height,top,bottom" /> </inspection_tool> - <inspection_tool class="MalformedRegex" level="ERROR" enabled="true" /> + <inspection_tool class="MalformedRegex" level="WARNING" enabled="true" /> <inspection_tool class="TrivialIfJS" level="WARNING" enabled="false" /> - <inspection_tool class="SimplifiableConditionalExpression" level="ERROR" enabled="true" /> - <inspection_tool class="UNUSED_IMPORT" level="ERROR" enabled="true" /> + <inspection_tool class="SimplifiableConditionalExpression" level="WARNING" enabled="true" /> + <inspection_tool class="UNUSED_IMPORT" level="WARNING" enabled="true" /> <inspection_tool class="DuplicateCaseLabelJS" level="WARNING" enabled="false" /> - <inspection_tool class="PersistenceModelWarningInspection" level="WARNING" enabled="false" /> <inspection_tool class="PointlessBitwiseExpressionJS" level="WARNING" enabled="false"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> <inspection_tool class="SimplifiableIfStatement" level="WARNING" enabled="false" /> - <inspection_tool class="BooleanConstructor" level="ERROR" enabled="true" /> - <inspection_tool class="ExtendsObject" level="ERROR" enabled="true" /> + <inspection_tool class="BooleanConstructor" level="WARNING" enabled="true" /> + <inspection_tool class="ExtendsObject" level="WARNING" enabled="true" /> <inspection_tool class="RedundantArrayCreation" level="WARNING" enabled="true" /> - <inspection_tool class="PersistenceQlInspection" level="ERROR" enabled="false" /> <inspection_tool class="UnnecessaryLabelOnContinueStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="CheckImageSize" level="WARNING" enabled="false" /> - <inspection_tool class="EmptyMethod" level="WARNING" enabled="false"> - <option name="EXCLUDE_ANNOS"> - <value> - <list size="0" /> - </value> - </option> - </inspection_tool> - <inspection_tool class="PersistenceDomInspection" level="ERROR" enabled="false" /> + <inspection_tool class="EmptyMethod" level="WARNING" enabled="false" /> <inspection_tool class="EmptyTryBlock" level="WARNING" enabled="false" /> - <inspection_tool class="MalformedFormatString" level="ERROR" enabled="true" /> + <inspection_tool class="MalformedFormatString" level="WARNING" enabled="true" /> <inspection_tool class="ComponentRegistrationProblems" level="ERROR" enabled="false"> <option name="CHECK_PLUGIN_XML" value="true" /> <option name="CHECK_JAVA_CODE" value="true" /> @@ -722,14 +644,14 @@ <inspection_tool class="PointlessBooleanExpressionJS" level="WARNING" enabled="false" /> <inspection_tool class="CssUnitlessNumber" level="WARNING" enabled="false" /> <inspection_tool class="ExceptionCaughtLocallyJS" level="WARNING" enabled="false" /> - <inspection_tool class="ConstantConditionalExpression" level="ERROR" enabled="true" /> + <inspection_tool class="ConstantConditionalExpression" level="WARNING" enabled="true" /> <inspection_tool class="MissingMnemonic" level="WARNING" enabled="true" /> <inspection_tool class="CloneDeclaresCloneNotSupported" level="INFO" enabled="true" /> - <inspection_tool class="MalformedXPath" level="ERROR" enabled="true" /> + <inspection_tool class="MalformedXPath" level="WARNING" enabled="true" /> <inspection_tool class="AccessStaticViaInstance" level="WARNING" enabled="true" /> <inspection_tool class="UnusedParameters" level="WARNING" enabled="false" /> <inspection_tool class="DuplicateMnemonic" level="WARNING" enabled="true" /> - <inspection_tool class="StringConstructor" level="ERROR" enabled="true"> + <inspection_tool class="StringConstructor" level="WARNING" enabled="true"> <option name="ignoreSubstringArguments" value="false" /> </inspection_tool> <inspection_tool class="GWTRemoteServiceAsyncCheck" level="ERROR" enabled="false" /> @@ -737,26 +659,32 @@ <inspection_tool class="MismatchedArrayReadWrite" level="WARNING" enabled="true" /> <inspection_tool class="UnusedReturnValue" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryContinueJS" level="WARNING" enabled="false" /> - <inspection_tool class="FinallyBlockCannotCompleteNormally" level="ERROR" enabled="true" /> + <inspection_tool class="FinallyBlockCannotCompleteNormally" level="WARNING" enabled="true" /> <inspection_tool class="BadExpressionStatementJS" level="WARNING" enabled="false" /> - <inspection_tool class="PrimitiveArrayArgumentToVariableArgMethod" level="ERROR" enabled="true" /> + <inspection_tool class="PrimitiveArrayArgumentToVariableArgMethod" level="WARNING" enabled="true" /> <inspection_tool class="InfiniteRecursionJS" level="WARNING" enabled="false" /> <inspection_tool class="StrutsValidatorInspection" level="ERROR" enabled="false" /> - <inspection_tool class="ContinueOrBreakFromFinallyBlock" level="ERROR" enabled="true" /> + <inspection_tool class="ContinueOrBreakFromFinallyBlock" level="WARNING" enabled="true" /> <inspection_tool class="DuplicatePropertyOnObjectJS" level="WARNING" enabled="false" /> <inspection_tool class="JBoss" level="ERROR" enabled="false" /> <inspection_tool class="UnusedDeclaration" level="WARNING" enabled="false"> <option name="ADD_MAINS_TO_ENTRIES" value="true" /> - <option name="ADD_JUNIT_TO_ENTRIES" value="true" /> - <option name="ADD_EJB_TO_ENTRIES" value="true" /> <option name="ADD_APPLET_TO_ENTRIES" value="true" /> <option name="ADD_SERVLET_TO_ENTRIES" value="true" /> <option name="ADD_NONJAVA_TO_ENTRIES" value="true" /> + <option name="ADDITIONAL_ANNOTATIONS"> + <value> + <list size="0" /> + </value> + </option> + <option name="ADD_EJB_TO_ENTRIES" value="true" /> + <option name="ADD_JUNIT_TO_ENTRIES" value="true" /> + <option name="ADD_TESTNG_TO_ENTRIES" value="true" /> </inspection_tool> <inspection_tool class="Deprecation" level="WARNING" enabled="false" /> <inspection_tool class="StrutsInspection" level="ERROR" enabled="false" /> - <inspection_tool class="MissingDeprecatedAnnotation" level="ERROR" enabled="true" /> - <inspection_tool class="JavaDoc" level="ERROR" enabled="true"> + <inspection_tool class="MissingDeprecatedAnnotation" level="WARNING" enabled="true" /> + <inspection_tool class="JavaDoc" level="WARNING" enabled="true"> <option name="TOP_LEVEL_CLASS_OPTIONS"> <value> <option name="ACCESS_JAVADOC_REQUIRED_FOR" value="none" /> @@ -785,174 +713,178 @@ <option name="IGNORE_JAVADOC_PERIOD" value="false" /> <option name="myAdditionalJavadocTags" value="todo,note,todo,xxx,note,todo,fixme,fixme,warning,invariant,retval,pre" /> </inspection_tool> - <inspection_tool class="MissingOverrideAnnotation" level="ERROR" enabled="true" /> - <inspection_tool class="AbstractMethodWithMissingImplementations" level="ERROR" enabled="true" /> - <inspection_tool class="EqualsAndHashcode" level="ERROR" enabled="true" /> + <inspection_tool class="MissingOverrideAnnotation" level="WARNING" enabled="true"> + <option name="useJdk6Rules" value="false" /> + </inspection_tool> + <inspection_tool class="AbstractMethodWithMissingImplementations" level="WARNING" enabled="true" /> + <inspection_tool class="EqualsAndHashcode" level="WARNING" enabled="true" /> <inspection_tool class="Dependency" level="ERROR" enabled="false" /> - <inspection_tool class="FinalizeNotProtected" level="ERROR" enabled="true" /> - <inspection_tool class="NoExplicitFinalizeCalls" level="ERROR" enabled="true" /> - <inspection_tool class="FinalizeCallsSuperFinalize" level="ERROR" enabled="true"> + <inspection_tool class="FinalizeNotProtected" level="WARNING" enabled="true" /> + <inspection_tool class="NoExplicitFinalizeCalls" level="WARNING" enabled="true" /> + <inspection_tool class="FinalizeCallsSuperFinalize" level="WARNING" enabled="true"> <option name="m_ignoreForObjectSubclasses" value="false" /> </inspection_tool> - <inspection_tool class="OnDemandImport" level="ERROR" enabled="true" /> - <inspection_tool class="JavaLangImport" level="ERROR" enabled="true" /> - <inspection_tool class="SamePackageImport" level="ERROR" enabled="true" /> - <inspection_tool class="RedundantImport" level="ERROR" enabled="true" /> - <inspection_tool class="InstanceofThis" level="ERROR" enabled="true" /> - <inspection_tool class="ReplaceAssignmentWithOperatorAssignment" level="ERROR" enabled="true"> + <inspection_tool class="OnDemandImport" level="WARNING" enabled="true" /> + <inspection_tool class="JavaLangImport" level="WARNING" enabled="true" /> + <inspection_tool class="SamePackageImport" level="WARNING" enabled="true" /> + <inspection_tool class="RedundantImport" level="WARNING" enabled="true" /> + <inspection_tool class="InstanceofThis" level="WARNING" enabled="true" /> + <inspection_tool class="ReplaceAssignmentWithOperatorAssignment" level="WARNING" enabled="true"> <option name="ignoreLazyOperators" value="true" /> <option name="ignoreObscureOperators" value="false" /> </inspection_tool> - <inspection_tool class="AssignmentToCatchBlockParameter" level="ERROR" enabled="true" /> - <inspection_tool class="ShiftOutOfRange" level="ERROR" enabled="true" /> - <inspection_tool class="PointlessBitwiseExpression" level="ERROR" enabled="true"> + <inspection_tool class="AssignmentToCatchBlockParameter" level="WARNING" enabled="true" /> + <inspection_tool class="ShiftOutOfRange" level="WARNING" enabled="true" /> + <inspection_tool class="PointlessBitwiseExpression" level="WARNING" enabled="true"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> - <inspection_tool class="IncompatibleMask" level="ERROR" enabled="true" /> - <inspection_tool class="FinalMethodInFinalClass" level="ERROR" enabled="true" /> - <inspection_tool class="FinalPrivateMethod" level="ERROR" enabled="true" /> - <inspection_tool class="ProtectedMemberInFinalClass" level="ERROR" enabled="true" /> - <inspection_tool class="PublicConstructorInNonPublicClass" level="ERROR" enabled="true" /> - <inspection_tool class="ExtendsConcreteCollection" level="ERROR" enabled="true" /> - <inspection_tool class="AbstractClassNeverImplemented" level="ERROR" enabled="true" /> - <inspection_tool class="ExtendsAnnotation" level="ERROR" enabled="true" /> - <inspection_tool class="AbstractMethodOverridesAbstractMethod" level="ERROR" enabled="true" /> - <inspection_tool class="NonProtectedConstructorInAbstractClass" level="ERROR" enabled="true"> + <inspection_tool class="IncompatibleMask" level="WARNING" enabled="true" /> + <inspection_tool class="FinalMethodInFinalClass" level="WARNING" enabled="true" /> + <inspection_tool class="FinalPrivateMethod" level="WARNING" enabled="true" /> + <inspection_tool class="ProtectedMemberInFinalClass" level="WARNING" enabled="true" /> + <inspection_tool class="PublicConstructorInNonPublicClass" level="WARNING" enabled="true" /> + <inspection_tool class="ExtendsConcreteCollection" level="WARNING" enabled="true" /> + <inspection_tool class="AbstractClassNeverImplemented" level="WARNING" enabled="true" /> + <inspection_tool class="ExtendsAnnotation" level="WARNING" enabled="true" /> + <inspection_tool class="AbstractMethodOverridesAbstractMethod" level="WARNING" enabled="true" /> + <inspection_tool class="NonProtectedConstructorInAbstractClass" level="WARNING" enabled="true"> <option name="m_ignoreNonPublicClasses" value="true" /> </inspection_tool> - <inspection_tool class="StaticInheritance" level="ERROR" enabled="true" /> - <inspection_tool class="TypeParameterExtendsFinalClass" level="ERROR" enabled="true" /> - <inspection_tool class="AbstractMethodCallInConstructor" level="ERROR" enabled="true" /> - <inspection_tool class="IndexOfReplaceableByContains" level="ERROR" enabled="true" /> - <inspection_tool class="ForCanBeForeach" level="ERROR" enabled="true" /> - <inspection_tool class="UnnecessaryBoxing" level="ERROR" enabled="true" /> - <inspection_tool class="UnnecessaryUnboxing" level="ERROR" enabled="true" /> - <inspection_tool class="WhileCanBeForeach" level="ERROR" enabled="true" /> - <inspection_tool class="AssertAsName" level="ERROR" enabled="true" /> - <inspection_tool class="EnumAsName" level="ERROR" enabled="true" /> - <inspection_tool class="BeforeOrAfterIsPublicVoidNoArg" level="ERROR" enabled="true" /> - <inspection_tool class="BeforeClassOrAfterClassIsPublicStaticVoidNoArg" level="ERROR" enabled="true" /> - <inspection_tool class="ClassWithMultipleLoggers" level="ERROR" enabled="true"> + <inspection_tool class="StaticInheritance" level="WARNING" enabled="true" /> + <inspection_tool class="TypeParameterExtendsFinalClass" level="WARNING" enabled="true" /> + <inspection_tool class="AbstractMethodCallInConstructor" level="WARNING" enabled="true" /> + <inspection_tool class="IndexOfReplaceableByContains" level="WARNING" enabled="true" /> + <inspection_tool class="ForCanBeForeach" level="WARNING" enabled="true"> + <option name="REPORT_INDEXED_LOOP" value="true" /> + </inspection_tool> + <inspection_tool class="UnnecessaryBoxing" level="WARNING" enabled="true" /> + <inspection_tool class="UnnecessaryUnboxing" level="WARNING" enabled="true" /> + <inspection_tool class="WhileCanBeForeach" level="WARNING" enabled="true" /> + <inspection_tool class="AssertAsName" level="WARNING" enabled="true" /> + <inspection_tool class="EnumAsName" level="WARNING" enabled="true" /> + <inspection_tool class="BeforeOrAfterIsPublicVoidNoArg" level="WARNING" enabled="true" /> + <inspection_tool class="BeforeClassOrAfterClassIsPublicStaticVoidNoArg" level="WARNING" enabled="true" /> + <inspection_tool class="ClassWithMultipleLoggers" level="WARNING" enabled="true"> <option name="loggerClassName" value="org.apache.log4j.Logger" /> </inspection_tool> - <inspection_tool class="AnnotationNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="AnnotationNamingConvention" level="WARNING" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*" /> <option name="m_minLength" value="8" /> <option name="m_maxLength" value="64" /> </inspection_tool> - <inspection_tool class="ClassNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="ClassNamingConvention" level="WARNING" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*" /> <option name="m_minLength" value="6" /> <option name="m_maxLength" value="64" /> </inspection_tool> - <inspection_tool class="ConfusingMainMethod" level="ERROR" enabled="true" /> - <inspection_tool class="ConstantNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="ConfusingMainMethod" level="WARNING" enabled="true" /> + <inspection_tool class="ConstantNamingConvention" level="WARNING" enabled="true"> <option name="m_regex" value="[A-Z_\d]*|log" /> <option name="m_minLength" value="4" /> <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="DollarSignInName" level="ERROR" enabled="true" /> - <inspection_tool class="EnumeratedClassNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="DollarSignInName" level="WARNING" enabled="true" /> + <inspection_tool class="EnumeratedClassNamingConvention" level="WARNING" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*" /> <option name="m_minLength" value="4" /> <option name="m_maxLength" value="64" /> </inspection_tool> - <inspection_tool class="EnumeratedConstantNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="EnumeratedConstantNamingConvention" level="WARNING" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*|[A-Z][A-Z_]*" /> <option name="m_minLength" value="3" /> <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="ExceptionNameDoesntEndWithException" level="ERROR" enabled="true" /> - <inspection_tool class="InstanceMethodNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="ExceptionNameDoesntEndWithException" level="WARNING" enabled="true" /> + <inspection_tool class="InstanceMethodNamingConvention" level="WARNING" enabled="true"> <option name="m_regex" value="[a-z][A-Za-z\d]*" /> <option name="m_minLength" value="3" /> - <option name="m_maxLength" value="32" /> + <option name="m_maxLength" value="99" /> </inspection_tool> - <inspection_tool class="InstanceVariableNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="InstanceVariableNamingConvention" level="WARNING" enabled="true"> <option name="m_regex" value="[a-z][A-Za-z\d]*" /> <option name="m_minLength" value="3" /> <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="InterfaceNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="InterfaceNamingConvention" level="WARNING" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*" /> <option name="m_minLength" value="4" /> <option name="m_maxLength" value="64" /> </inspection_tool> - <inspection_tool class="LocalVariableNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="LocalVariableNamingConvention" level="WARNING" enabled="true"> <option name="m_ignoreForLoopParameters" value="false" /> <option name="m_ignoreCatchParameters" value="false" /> <option name="m_regex" value="[a-z][A-Za-z\d]*" /> <option name="m_minLength" value="1" /> <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="MethodNamesDifferOnlyByCase" level="ERROR" enabled="true" /> - <inspection_tool class="ParameterNamingConvention" level="ERROR" enabled="true"> + <inspection_tool class="MethodNamesDifferOnlyByCase" level="WARNING" enabled="tru... [truncated message content] |
From: <aki...@us...> - 2008-07-15 05:53:02
|
Revision: 4337 http://gridarta.svn.sourceforge.net/gridarta/?rev=4337&view=rev Author: akirschbaum Date: 2008-07-14 22:52:57 -0700 (Mon, 14 Jul 2008) Log Message: ----------- Revert previous commit. Modified Paths: -------------- trunk/crossfire/build.xml trunk/crossfire/crossfire.iml trunk/daimonin/daimonin.iml trunk/gridarta.iml trunk/gridarta.ipr Modified: trunk/crossfire/build.xml =================================================================== --- trunk/crossfire/build.xml 2008-07-15 05:50:20 UTC (rev 4336) +++ trunk/crossfire/build.xml 2008-07-15 05:52:57 UTC (rev 4337) @@ -134,7 +134,6 @@ <fileset dir="../src/app" excludes="**/*.java,**/package.html,**/overview.html" /> <fileset dir="../resource"> <include name="system/**"/> - <include name="toolbarButtonGraphics/**/*.*"/> </fileset> <zipfileset src="../lib/log4j-1.2.13.jar" /> <zipfileset src="${lib.dir}/jdom.jar" excludes="META-INF/**" /> Modified: trunk/crossfire/crossfire.iml =================================================================== --- trunk/crossfire/crossfire.iml 2008-07-15 05:50:20 UTC (rev 4336) +++ trunk/crossfire/crossfire.iml 2008-07-15 05:52:57 UTC (rev 4337) @@ -4,13 +4,10 @@ <output url="file://$MODULE_DIR$/classes" /> <exclude-output /> <content url="file://$MODULE_DIR$"> - <sourceFolder url="file://$MODULE_DIR$/resource/icons" isTestSource="false" packagePrefix="icons" /> <sourceFolder url="file://$MODULE_DIR$/src" isTestSource="false" /> <excludeFolder url="file://$MODULE_DIR$/lib" /> <excludeFolder url="file://$MODULE_DIR$/patches" /> - <excludeFolder url="file://$MODULE_DIR$/resource/HelpFiles" /> - <excludeFolder url="file://$MODULE_DIR$/resource/conf" /> - <excludeFolder url="file://$MODULE_DIR$/resource/system" /> + <excludeFolder url="file://$MODULE_DIR$/resource" /> </content> <orderEntry type="inheritedJdk" /> <orderEntry type="sourceFolder" forTests="false" /> Modified: trunk/daimonin/daimonin.iml =================================================================== --- trunk/daimonin/daimonin.iml 2008-07-15 05:50:20 UTC (rev 4336) +++ trunk/daimonin/daimonin.iml 2008-07-15 05:52:57 UTC (rev 4337) @@ -10,7 +10,7 @@ <output url="file://$MODULE_DIR$/classes" /> <exclude-output /> <content url="file://$MODULE_DIR$"> - <sourceFolder url="file://$MODULE_DIR$/resource/icons" isTestSource="false" packagePrefix="icons" /> + <sourceFolder url="file://$MODULE_DIR$/resource" isTestSource="false" /> <sourceFolder url="file://$MODULE_DIR$/src" isTestSource="false" /> <sourceFolder url="file://$MODULE_DIR$/src/test" isTestSource="true" packagePrefix="test" /> <excludeFolder url="file://$MODULE_DIR$/debug" /> Modified: trunk/gridarta.iml =================================================================== --- trunk/gridarta.iml 2008-07-15 05:50:20 UTC (rev 4336) +++ trunk/gridarta.iml 2008-07-15 05:52:57 UTC (rev 4337) @@ -4,7 +4,6 @@ <output url="file://$MODULE_DIR$/classes" /> <exclude-output /> <content url="file://$MODULE_DIR$"> - <sourceFolder url="file://$MODULE_DIR$/resource/system" isTestSource="false" packagePrefix="system" /> <sourceFolder url="file://$MODULE_DIR$/src/app" isTestSource="false" /> <sourceFolder url="file://$MODULE_DIR$/src/test" isTestSource="true" packagePrefix="test" /> <excludeFolder url="file://$MODULE_DIR$/crossfire" /> Modified: trunk/gridarta.ipr =================================================================== --- trunk/gridarta.ipr 2008-07-15 05:50:20 UTC (rev 4336) +++ trunk/gridarta.ipr 2008-07-15 05:52:57 UTC (rev 4337) @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<project relativePaths="false" version="4"> +<project version="4" relativePaths="false"> <component name="AntConfiguration"> <defaultAnt bundledAnt="true" /> </component> @@ -18,12 +18,9 @@ <value> <option name="LINE_SEPARATOR" value=" " /> <option name="INDENT_CASE_FROM_SWITCH" value="false" /> - <option name="ALIGN_MULTILINE_PARAMETERS" value="false" /> - <option name="ALIGN_MULTILINE_FOR" value="false" /> <option name="BLANK_LINES_BEFORE_PACKAGE" value="1" /> <option name="BLANK_LINES_AROUND_FIELD" value="1" /> <option name="BLANK_LINES_AFTER_CLASS_HEADER" value="1" /> - <option name="SPACE_BEFORE_ARRAY_INITIALIZER_LBRACE" value="true" /> <option name="GENERATE_FINAL_LOCALS" value="true" /> <option name="GENERATE_FINAL_PARAMETERS" value="true" /> <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="1000" /> @@ -36,31 +33,23 @@ <package name="" withSubpackages="true" /> </value> </option> - <option name="RIGHT_MARGIN" value="80" /> - <option name="WRAP_COMMENTS" value="true" /> + <option name="RIGHT_MARGIN" value="160" /> <option name="IF_BRACE_FORCE" value="3" /> <option name="DOWHILE_BRACE_FORCE" value="3" /> <option name="WHILE_BRACE_FORCE" value="3" /> <option name="FOR_BRACE_FORCE" value="3" /> - <option name="JD_ALIGN_PARAM_COMMENTS" value="false" /> - <option name="JD_ALIGN_EXCEPTION_COMMENTS" value="false" /> - <option name="JD_ADD_BLANK_AFTER_DESCRIPTION" value="false" /> + <option name="JD_ADD_BLANK_AFTER_PARM_COMMENTS" value="true" /> + <option name="JD_ADD_BLANK_AFTER_RETURN" value="true" /> <option name="JD_DO_NOT_WRAP_ONE_LINE_COMMENTS" value="true" /> <option name="XML_SPACE_INSIDE_EMPTY_TAG" value="true" /> <option name="HTML_TEXT_WRAP" value="0" /> <option name="HTML_SPACE_INSIDE_EMPTY_TAG" value="true" /> <option name="HTML_DO_NOT_INDENT_CHILDREN_OF" value="" /> <option name="HTML_DO_NOT_ALIGN_CHILDREN_OF_MIN_LINES" value="10000" /> + <option name="METHOD_ANNOTATION_WRAP" value="1" /> + <option name="CLASS_ANNOTATION_WRAP" value="1" /> + <option name="FIELD_ANNOTATION_WRAP" value="1" /> <option name="ENUM_CONSTANTS_WRAP" value="2" /> - <ADDITIONAL_INDENT_OPTIONS fileType="js"> - <option name="INDENT_SIZE" value="4" /> - <option name="CONTINUATION_INDENT_SIZE" value="8" /> - <option name="TAB_SIZE" value="4" /> - <option name="USE_TAB_CHARACTER" value="false" /> - <option name="SMART_TABS" value="false" /> - <option name="LABEL_INDENT_SIZE" value="0" /> - <option name="LABEL_INDENT_ABSOLUTE" value="false" /> - </ADDITIONAL_INDENT_OPTIONS> </value> </option> <option name="USE_PER_PROJECT_SETTINGS" value="true" /> @@ -85,12 +74,11 @@ <entry name="?*.testdata" /> </wildcardResourcePatterns> </component> - <component name="CppTools.Loader" warnedAboutFileOutOfSourceRoot="true" /> + <component name="DataSourceManagerImpl" /> <component name="DependenciesAnalyzeManager"> <option name="myForwardDirection" value="false" /> </component> <component name="DependencyValidationManager"> - <option name="SKIP_IMPORT_STATEMENTS" value="false" /> <scope name="Project without textedit" pattern="!src[gridarta]:net.sf.gridarta.textedit.scripteditor..*&&!src[gridarta]:net.sf.gridarta.textedit.textarea..*&&!src[textedit]:*..*" /> </component> <component name="EclipseCompilerSettings"> @@ -108,13 +96,14 @@ <option name="MAXIMUM_HEAP_SIZE" value="128" /> </component> <component name="EntryPointsManager"> - <entry_points version="2.0" /> + <entry_points /> </component> <component name="ExportToHTMLSettings"> <option name="PRINT_LINE_NUMBERS" value="false" /> <option name="OPEN_IN_BROWSER" value="false" /> <option name="OUTPUT_DIRECTORY" /> </component> + <component name="GUI Designer component loader factory" /> <component name="IdProvider" IDEtalkID="2C998304C446463F0F811673874877B6" /> <component name="InspectionProjectProfileManager"> <option name="PROJECT_PROFILE" value="No errors allowed here" /> @@ -124,6 +113,24 @@ <profile version="1.0" is_locked="false"> <option name="myName" value="Javadoc Issues" /> <option name="myLocal" value="false" /> + <used_levels> + <error> + <option name="myName" value="ERROR" /> + <option name="myVal" value="400" /> + </error> + <warning> + <option name="myName" value="WARNING" /> + <option name="myVal" value="300" /> + </warning> + <information> + <option name="myName" value="INFO" /> + <option name="myVal" value="200" /> + </information> + <server> + <option name="myName" value="SERVER PROBLEM" /> + <option name="myVal" value="100" /> + </server> + </used_levels> <inspection_tool class="CheckEmptyScriptTag" level="WARNING" enabled="false" /> <inspection_tool class="FunctionWithInconsistentReturnsJS" level="WARNING" enabled="false" /> <inspection_tool class="InfiniteLoopStatement" level="WARNING" enabled="false" /> @@ -143,9 +150,13 @@ </inspection_tool> <inspection_tool class="GwtInconsistentI18nInterface" level="ERROR" enabled="false" /> <inspection_tool class="StringToString" level="WARNING" enabled="false" /> + <inspection_tool class="AnalyzingStaticVariables" level="ERROR" enabled="false"> + <option name="CHECKED_TYPES" value="javax.servlet.http.HttpSession;com.ulcjava.base.application.ULCProxy" /> + </inspection_tool> <inspection_tool class="BoundFieldAssignment" level="WARNING" enabled="false" /> <inspection_tool class="NullArgumentToVariableArgMethod" level="WARNING" enabled="false" /> <inspection_tool class="JSUndeclaredVariable" level="INFO" enabled="false" /> + <inspection_tool class="PersistenceModelErrorInspection" level="ERROR" enabled="false" /> <inspection_tool class="LoopStatementsThatDontLoop" level="WARNING" enabled="false" /> <inspection_tool class="RedundantThrows" level="WARNING" enabled="false" /> <inspection_tool class="StrutsValidatorFormInspection" level="ERROR" enabled="false" /> @@ -162,10 +173,10 @@ <inspection_tool class="Glassfish" level="ERROR" enabled="false" /> <inspection_tool class="ConstantConditions" level="WARNING" enabled="false"> <option name="SUGGEST_NULLABLE_ANNOTATIONS" value="false" /> - <option name="DONT_REPORT_TRUE_ASSERT_STATEMENTS" value="false" /> </inspection_tool> <inspection_tool class="GwtServiceNotRegistered" level="ERROR" enabled="false" /> <inspection_tool class="EjbErrorInspection" level="ERROR" enabled="false" /> + <inspection_tool class="PersistenceDataSourceORMInspection" level="ERROR" enabled="false" /> <inspection_tool class="CanBeFinal" level="WARNING" enabled="false"> <option name="REPORT_CLASSES" value="false" /> <option name="REPORT_METHODS" value="false" /> @@ -180,10 +191,18 @@ <option name="REPORT_POSTFIX_EXPRESSIONS" value="true" /> <option name="REPORT_REDUNDANT_INITIALIZER" value="true" /> </inspection_tool> + <inspection_tool class="AnalyzingVariableNaming" level="WARNING" enabled="false"> + <option name="IGNORE_SERIAL_VERSION_UID" value="true" /> + <option name="CHECK_STATIC_FINAL_FIELDS" value="true" /> + <option name="CHECK_STATIC_FIELDS" value="true" /> + <option name="CHECK_FIELDS" value="true" /> + <option name="CHECK_PARAMETERS" value="true" /> + </inspection_tool> <inspection_tool class="WebProperties" level="ERROR" enabled="false" /> <inspection_tool class="PointlessArithmeticExpressionJS" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryConditionalExpression" level="WARNING" enabled="false" /> <inspection_tool class="StringConcatenationInsideStringBufferAppend" level="WARNING" enabled="false" /> + <inspection_tool class="AnalyzingJLSModifierOrder" level="WARNING" enabled="false" /> <inspection_tool class="AntDuplicateImportedTargetsInspection" level="WARNING" enabled="false" /> <inspection_tool class="UNUSED_SYMBOL" level="WARNING" enabled="false"> <option name="LOCAL_VARIABLE" value="true" /> @@ -191,7 +210,6 @@ <option name="METHOD" value="true" /> <option name="CLASS" value="true" /> <option name="PARAMETER" value="true" /> - <option name="REPORT_PARAMETER_FOR_PUBLIC_METHODS" value="true" /> <option name="INJECTION_ANNOS"> <value> <list size="0" /> @@ -229,6 +247,7 @@ <inspection_tool class="CheckValidXmlInScriptTagBody" level="ERROR" enabled="false" /> <inspection_tool class="ManualArrayCopy" level="WARNING" enabled="false" /> <inspection_tool class="Weblogic" level="ERROR" enabled="false" /> + <inspection_tool class="PersistenceDataSourceORMDomInspection" level="ERROR" enabled="false" /> <inspection_tool class="FallthroughInSwitchStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="IgnoreResultOfCall" level="WARNING" enabled="false"> <option name="m_reportAllNonLibraryCalls" value="false" /> @@ -238,13 +257,18 @@ <inspection_tool class="RedundantCast" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryReturn" level="WARNING" enabled="false" /> <inspection_tool class="FinalStaticMethod" level="WARNING" enabled="false" /> - <inspection_tool class="SuspiciousMethodCalls" level="WARNING" enabled="false"> - <option name="REPORT_CONVERTIBLE_METHOD_CALLS" value="true" /> + <inspection_tool class="SuspiciousMethodCalls" level="WARNING" enabled="false" /> + <inspection_tool class="HTML" level="WARNING" enabled="false"> + <option name="myAdditionalHtmlTags" value="embed,nobr,noembed,comment,script" /> + <option name="myAdditionalHtmlAttributes" value="type,wmode,src,width,height" /> + <option name="myCheckHtmlTags" value="true" /> + <option name="myCheckHtmlAttributes" value="true" /> </inspection_tool> <inspection_tool class="UnnecessaryUnboxing" level="WARNING" enabled="false" /> <inspection_tool class="SameParameterValue" level="WARNING" enabled="false" /> <inspection_tool class="NoExplicitFinalizeCalls" level="WARNING" enabled="false" /> <inspection_tool class="FinalPrivateMethod" level="WARNING" enabled="false" /> + <inspection_tool class="AnalyzingRedundantFieldInitialization" level="WARNING" enabled="false" /> <inspection_tool class="ReservedWordUsedAsNameJS" level="WARNING" enabled="false" /> <inspection_tool class="ExtendsAnnotation" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryReturnJS" level="WARNING" enabled="false" /> @@ -256,15 +280,17 @@ <inspection_tool class="UnnecessaryLabelOnContinueStatement" level="WARNING" enabled="false" /> <inspection_tool class="NoLabelFor" level="WARNING" enabled="false" /> <inspection_tool class="SynchronizeOnNonFinalField" level="WARNING" enabled="false" /> + <inspection_tool class="AnalyzingLoggingWithoutLogLevelCheck" level="WARNING" enabled="false"> + <option name="CHECK_DEBUG" value="true" /> + <option name="CHECK_INFO" value="true" /> + <option name="IGNORE_SIMPLE_STATEMENTS" value="true" /> + </inspection_tool> <inspection_tool class="AntDuplicateTargetsInspection" level="ERROR" enabled="false" /> <inspection_tool class="NullableProblems" level="WARNING" enabled="false"> <option name="REPORT_NULLABLE_METHOD_OVERRIDES_NOTNULL" value="true" /> <option name="REPORT_NOT_ANNOTATED_METHOD_OVERRIDES_NOTNULL" value="true" /> <option name="REPORT_NOTNULL_PARAMETER_OVERRIDES_NULLABLE" value="true" /> <option name="REPORT_NOT_ANNOTATED_PARAMETER_OVERRIDES_NOTNULL" value="true" /> - <option name="REPORT_NOT_ANNOTATED_GETTER" value="true" /> - <option name="REPORT_NOT_ANNOTATED_SETTER_PARAMETER" value="true" /> - <option name="REPORT_ANNOTATION_NOT_PROPAGATED_TO_OVERRIDERS" value="true" /> </inspection_tool> <inspection_tool class="ReferencesToClassesFromDefaultPackagesInJSPFile" level="ERROR" enabled="false" /> <inspection_tool class="TrivialIf" level="WARNING" enabled="false" /> @@ -287,6 +313,11 @@ <inspection_tool class="IncompatibleMaskJS" level="WARNING" enabled="false" /> <inspection_tool class="NonJREEmulationClassesInClientCode" level="ERROR" enabled="false" /> <inspection_tool class="OctalLiteral" level="WARNING" enabled="false" /> + <inspection_tool class="AnalyzingRedundantModifier" level="WARNING" enabled="false"> + <option name="CHECK_FINAL_METHODS" value="true" /> + <option name="CHECK_PUBLIC_INTERFACE_METHODS" value="true" /> + <option name="CHECK_TRANSIENT_STATIC_FIELDS" value="true" /> + </inspection_tool> <inspection_tool class="WhileCanBeForeach" level="WARNING" enabled="false" /> <inspection_tool class="InfiniteRecursion" level="WARNING" enabled="false" /> <inspection_tool class="Geronimo" level="ERROR" enabled="false" /> @@ -298,7 +329,6 @@ <inspection_tool class="EmptyCatchBlock" level="WARNING" enabled="false"> <option name="m_includeComments" value="true" /> <option name="m_ignoreTestCases" value="true" /> - <option name="m_ignoreIgnoreParameter" value="true" /> </inspection_tool> <inspection_tool class="Dependency" level="ERROR" enabled="false" /> <inspection_tool class="UnnecessaryLocalVariable" level="WARNING" enabled="false"> @@ -311,9 +341,8 @@ <option name="m_reportEmptyBlocks" value="false" /> </inspection_tool> <inspection_tool class="ThrowFromFinallyBlockJS" level="WARNING" enabled="false" /> - <inspection_tool class="ForCanBeForeach" level="WARNING" enabled="false"> - <option name="REPORT_INDEXED_LOOP" value="true" /> - </inspection_tool> + <inspection_tool class="PersistenceORMDomInspection" level="ERROR" enabled="false" /> + <inspection_tool class="ForCanBeForeach" level="WARNING" enabled="false" /> <inspection_tool class="TypeParameterExtendsObject" level="WARNING" enabled="false" /> <inspection_tool class="FieldCanBeLocal" level="WARNING" enabled="false" /> <inspection_tool class="UNCHECKED_WARNING" level="WARNING" enabled="false" /> @@ -329,7 +358,9 @@ <inspection_tool class="TrivialIfJS" level="WARNING" enabled="false" /> <inspection_tool class="SimplifiableConditionalExpression" level="WARNING" enabled="false" /> <inspection_tool class="IncompatibleMask" level="WARNING" enabled="false" /> + <inspection_tool class="UNUSED_IMPORT" level="WARNING" enabled="false" /> <inspection_tool class="DuplicateCaseLabelJS" level="WARNING" enabled="false" /> + <inspection_tool class="PersistenceModelWarningInspection" level="WARNING" enabled="false" /> <inspection_tool class="PointlessBitwiseExpressionJS" level="WARNING" enabled="false"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> @@ -337,9 +368,17 @@ <inspection_tool class="BooleanConstructor" level="WARNING" enabled="false" /> <inspection_tool class="ExtendsObject" level="WARNING" enabled="false" /> <inspection_tool class="RedundantArrayCreation" level="WARNING" enabled="false" /> + <inspection_tool class="PersistenceQlInspection" level="ERROR" enabled="false" /> <inspection_tool class="UnnecessaryLabelOnContinueStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="CheckImageSize" level="WARNING" enabled="false" /> - <inspection_tool class="EmptyMethod" level="WARNING" enabled="false" /> + <inspection_tool class="EmptyMethod" level="WARNING" enabled="false"> + <option name="EXCLUDE_ANNOS"> + <value> + <list size="0" /> + </value> + </option> + </inspection_tool> + <inspection_tool class="PersistenceDomInspection" level="ERROR" enabled="false" /> <inspection_tool class="EmptyTryBlock" level="WARNING" enabled="false" /> <inspection_tool class="MalformedFormatString" level="WARNING" enabled="false" /> <inspection_tool class="ComponentRegistrationProblems" level="ERROR" enabled="false"> @@ -379,21 +418,16 @@ <inspection_tool class="JBoss" level="ERROR" enabled="false" /> <inspection_tool class="UnusedDeclaration" level="WARNING" enabled="false"> <option name="ADD_MAINS_TO_ENTRIES" value="true" /> + <option name="ADD_JUNIT_TO_ENTRIES" value="true" /> + <option name="ADD_EJB_TO_ENTRIES" value="true" /> <option name="ADD_APPLET_TO_ENTRIES" value="true" /> <option name="ADD_SERVLET_TO_ENTRIES" value="true" /> <option name="ADD_NONJAVA_TO_ENTRIES" value="true" /> - <option name="ADDITIONAL_ANNOTATIONS"> - <value> - <list size="0" /> - </value> - </option> - <option name="ADD_EJB_TO_ENTRIES" value="true" /> - <option name="ADD_JUNIT_TO_ENTRIES" value="true" /> - <option name="ADD_TESTNG_TO_ENTRIES" value="true" /> </inspection_tool> <inspection_tool class="Deprecation" level="WARNING" enabled="false" /> <inspection_tool class="StrutsInspection" level="ERROR" enabled="false" /> - <inspection_tool class="JavaDoc" level="WARNING" enabled="false"> + <inspection_tool class="MissingDeprecatedAnnotation" level="WARNING" enabled="true" /> + <inspection_tool class="JavaDoc" level="WARNING" enabled="true"> <option name="TOP_LEVEL_CLASS_OPTIONS"> <value> <option name="ACCESS_JAVADOC_REQUIRED_FOR" value="public" /> @@ -422,40 +456,55 @@ <option name="IGNORE_JAVADOC_PERIOD" value="false" /> <option name="myAdditionalJavadocTags" value="todo,note,todo,xxx,note,todo,fixme,fixme,warning,invariant,retval,pre" /> </inspection_tool> - <inspection_tool class="JavadocReference" level="ERROR" enabled="false" /> - <inspection_tool class="OnDemandImport" level="WARNING" enabled="true" /> - <inspection_tool class="SamePackageImport" level="WARNING" enabled="true" /> - <inspection_tool class="JavaLangImport" level="WARNING" enabled="true" /> - <inspection_tool class="RedundantImport" level="WARNING" enabled="true" /> - <inspection_tool class="UnusedImport" level="WARNING" enabled="true" /> - <inspection_tool class="UNUSED_IMPORT" level="WARNING" enabled="false" /> </profile> <profile version="1.0" is_locked="true"> <option name="myName" value="No errors allowed here" /> <option name="myLocal" value="false" /> + <used_levels> + <error> + <option name="myName" value="ERROR" /> + <option name="myVal" value="400" /> + </error> + <warning> + <option name="myName" value="WARNING" /> + <option name="myVal" value="300" /> + </warning> + <information> + <option name="myName" value="INFO" /> + <option name="myVal" value="200" /> + </information> + <server> + <option name="myName" value="SERVER PROBLEM" /> + <option name="myVal" value="100" /> + </server> + </used_levels> <inspection_tool class="CheckEmptyScriptTag" level="WARNING" enabled="false" /> <inspection_tool class="FunctionWithInconsistentReturnsJS" level="WARNING" enabled="false" /> - <inspection_tool class="InfiniteLoopStatement" level="WARNING" enabled="true" /> + <inspection_tool class="InfiniteLoopStatement" level="WARNING" enabled="false" /> <inspection_tool class="UnusedMessageFormatParameter" level="WARNING" enabled="true" /> <inspection_tool class="ConstantIfStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="FacesModelInspection" level="ERROR" enabled="false" /> <inspection_tool class="UnhandledExceptionInJSP" level="WARNING" enabled="false" /> <inspection_tool class="SillyAssignmentJS" level="WARNING" enabled="false" /> - <inspection_tool class="UnnecessaryLabelOnBreakStatement" level="WARNING" enabled="true" /> + <inspection_tool class="UnnecessaryLabelOnBreakStatement" level="ERROR" enabled="true" /> <inspection_tool class="ShiftOutOfRangeJS" level="WARNING" enabled="false" /> <inspection_tool class="JSUnresolvedVariable" level="INFO" enabled="false" /> <inspection_tool class="DuplicateThrows" level="WARNING" enabled="false" /> <inspection_tool class="ELValidationInJSP" level="WARNING" enabled="false" /> <inspection_tool class="ConstantConditionalExpressionJS" level="WARNING" enabled="false" /> - <inspection_tool class="PointlessBooleanExpression" level="WARNING" enabled="true"> + <inspection_tool class="PointlessBooleanExpression" level="ERROR" enabled="true"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> <inspection_tool class="GwtInconsistentI18nInterface" level="ERROR" enabled="false" /> - <inspection_tool class="StringToString" level="WARNING" enabled="true" /> + <inspection_tool class="StringToString" level="ERROR" enabled="true" /> + <inspection_tool class="AnalyzingStaticVariables" level="ERROR" enabled="true"> + <option name="CHECKED_TYPES" value="javax.servlet.http.HttpSession;com.ulcjava.base.application.ULCProxy" /> + </inspection_tool> <inspection_tool class="BoundFieldAssignment" level="WARNING" enabled="false" /> - <inspection_tool class="NullArgumentToVariableArgMethod" level="WARNING" enabled="true" /> + <inspection_tool class="NullArgumentToVariableArgMethod" level="ERROR" enabled="true" /> <inspection_tool class="JSUndeclaredVariable" level="INFO" enabled="false" /> - <inspection_tool class="LoopStatementsThatDontLoop" level="WARNING" enabled="true" /> + <inspection_tool class="PersistenceModelErrorInspection" level="ERROR" enabled="false" /> + <inspection_tool class="LoopStatementsThatDontLoop" level="ERROR" enabled="true" /> <inspection_tool class="RedundantThrows" level="WARNING" enabled="false" /> <inspection_tool class="StrutsValidatorFormInspection" level="ERROR" enabled="false" /> <inspection_tool class="UnnecessaryLabelOnBreakStatementJS" level="WARNING" enabled="false" /> @@ -471,10 +520,10 @@ <inspection_tool class="Glassfish" level="ERROR" enabled="false" /> <inspection_tool class="ConstantConditions" level="WARNING" enabled="true"> <option name="SUGGEST_NULLABLE_ANNOTATIONS" value="true" /> - <option name="DONT_REPORT_TRUE_ASSERT_STATEMENTS" value="false" /> </inspection_tool> <inspection_tool class="GwtServiceNotRegistered" level="ERROR" enabled="false" /> <inspection_tool class="EjbErrorInspection" level="ERROR" enabled="false" /> + <inspection_tool class="PersistenceDataSourceORMInspection" level="ERROR" enabled="false" /> <inspection_tool class="CanBeFinal" level="WARNING" enabled="true"> <option name="REPORT_CLASSES" value="false" /> <option name="REPORT_METHODS" value="false" /> @@ -482,17 +531,25 @@ </inspection_tool> <inspection_tool class="NoScrollPane" level="WARNING" enabled="true" /> <inspection_tool class="JSUnresolvedFunction" level="INFO" enabled="false" /> - <inspection_tool class="InstantiatingObjectToGetClassObject" level="WARNING" enabled="true" /> + <inspection_tool class="InstantiatingObjectToGetClassObject" level="ERROR" enabled="true" /> <inspection_tool class="ReturnFromFinallyBlockJS" level="WARNING" enabled="false" /> <inspection_tool class="UnusedAssignment" level="WARNING" enabled="true"> <option name="REPORT_PREFIX_EXPRESSIONS" value="true" /> <option name="REPORT_POSTFIX_EXPRESSIONS" value="true" /> <option name="REPORT_REDUNDANT_INITIALIZER" value="true" /> </inspection_tool> + <inspection_tool class="AnalyzingVariableNaming" level="WARNING" enabled="false"> + <option name="IGNORE_SERIAL_VERSION_UID" value="true" /> + <option name="CHECK_STATIC_FINAL_FIELDS" value="true" /> + <option name="CHECK_STATIC_FIELDS" value="true" /> + <option name="CHECK_FIELDS" value="true" /> + <option name="CHECK_PARAMETERS" value="true" /> + </inspection_tool> <inspection_tool class="WebProperties" level="ERROR" enabled="false" /> <inspection_tool class="PointlessArithmeticExpressionJS" level="WARNING" enabled="false" /> - <inspection_tool class="UnnecessaryConditionalExpression" level="WARNING" enabled="true" /> - <inspection_tool class="StringConcatenationInsideStringBufferAppend" level="WARNING" enabled="true" /> + <inspection_tool class="UnnecessaryConditionalExpression" level="ERROR" enabled="true" /> + <inspection_tool class="StringConcatenationInsideStringBufferAppend" level="ERROR" enabled="true" /> + <inspection_tool class="AnalyzingJLSModifierOrder" level="ERROR" enabled="true" /> <inspection_tool class="AntDuplicateImportedTargetsInspection" level="WARNING" enabled="true" /> <inspection_tool class="UNUSED_SYMBOL" level="WARNING" enabled="false"> <option name="LOCAL_VARIABLE" value="true" /> @@ -500,7 +557,6 @@ <option name="METHOD" value="true" /> <option name="CLASS" value="true" /> <option name="PARAMETER" value="true" /> - <option name="REPORT_PARAMETER_FOR_PUBLIC_METHODS" value="true" /> <option name="INJECTION_ANNOS"> <value> <list size="0" /> @@ -523,19 +579,20 @@ <inspection_tool class="PointlessArithmeticExpression" level="WARNING" enabled="false"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> - <inspection_tool class="UnnecessaryTemporaryOnConversionToString" level="WARNING" enabled="true" /> - <inspection_tool class="UnnecessaryContinue" level="WARNING" enabled="true" /> + <inspection_tool class="UnnecessaryTemporaryOnConversionToString" level="ERROR" enabled="true" /> + <inspection_tool class="UnnecessaryContinue" level="ERROR" enabled="true" /> <inspection_tool class="SameReturnValue" level="WARNING" enabled="false" /> - <inspection_tool class="UnusedLabel" level="WARNING" enabled="true" /> + <inspection_tool class="UnusedLabel" level="ERROR" enabled="true" /> <inspection_tool class="NoButtonGroup" level="WARNING" enabled="true" /> <inspection_tool class="GWTStyleCheck" level="ERROR" enabled="false" /> <inspection_tool class="NonSerializableServiceParameters" level="ERROR" enabled="false" /> <inspection_tool class="CloneCallsSuperClone" level="INFO" enabled="true" /> - <inspection_tool class="ReturnFromFinallyBlock" level="WARNING" enabled="true" /> + <inspection_tool class="ReturnFromFinallyBlock" level="ERROR" enabled="true" /> <inspection_tool class="UnreachableCodeJS" level="WARNING" enabled="false" /> <inspection_tool class="CheckValidXmlInScriptTagBody" level="ERROR" enabled="false" /> - <inspection_tool class="ManualArrayCopy" level="WARNING" enabled="true" /> + <inspection_tool class="ManualArrayCopy" level="ERROR" enabled="true" /> <inspection_tool class="Weblogic" level="ERROR" enabled="false" /> + <inspection_tool class="PersistenceDataSourceORMDomInspection" level="ERROR" enabled="false" /> <inspection_tool class="FallthroughInSwitchStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="IgnoreResultOfCall" level="WARNING" enabled="true"> <option name="m_reportAllNonLibraryCalls" value="true" /> @@ -543,38 +600,45 @@ </inspection_tool> <inspection_tool class="ThrowFromFinallyBlock" level="WARNING" enabled="false" /> <inspection_tool class="RedundantCast" level="WARNING" enabled="true" /> - <inspection_tool class="UnnecessaryReturn" level="WARNING" enabled="true" /> - <inspection_tool class="FinalStaticMethod" level="WARNING" enabled="true" /> - <inspection_tool class="SuspiciousMethodCalls" level="WARNING" enabled="true"> - <option name="REPORT_CONVERTIBLE_METHOD_CALLS" value="true" /> + <inspection_tool class="UnnecessaryReturn" level="ERROR" enabled="true" /> + <inspection_tool class="FinalStaticMethod" level="ERROR" enabled="true" /> + <inspection_tool class="SuspiciousMethodCalls" level="ERROR" enabled="true" /> + <inspection_tool class="HTML" level="WARNING" enabled="false"> + <option name="myAdditionalHtmlTags" value="embed,nobr,noembed,comment,script" /> + <option name="myAdditionalHtmlAttributes" value="type,wmode,src,width,height" /> + <option name="myCheckHtmlTags" value="true" /> + <option name="myCheckHtmlAttributes" value="true" /> </inspection_tool> <inspection_tool class="SameParameterValue" level="WARNING" enabled="false" /> + <inspection_tool class="AnalyzingRedundantFieldInitialization" level="WARNING" enabled="false" /> <inspection_tool class="ReservedWordUsedAsNameJS" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryReturnJS" level="WARNING" enabled="false" /> - <inspection_tool class="ConstantIfStatement" level="WARNING" enabled="true" /> + <inspection_tool class="ConstantIfStatement" level="ERROR" enabled="true" /> <inspection_tool class="ComponentNotRegistered" level="WARNING" enabled="false"> <option name="CHECK_ACTIONS" value="true" /> <option name="IGNORE_NON_PUBLIC" value="true" /> </inspection_tool> - <inspection_tool class="UnnecessaryLabelOnContinueStatement" level="WARNING" enabled="true" /> + <inspection_tool class="UnnecessaryLabelOnContinueStatement" level="ERROR" enabled="true" /> <inspection_tool class="NoLabelFor" level="WARNING" enabled="true" /> <inspection_tool class="SynchronizeOnNonFinalField" level="WARNING" enabled="false" /> + <inspection_tool class="AnalyzingLoggingWithoutLogLevelCheck" level="WARNING" enabled="false"> + <option name="CHECK_DEBUG" value="true" /> + <option name="CHECK_INFO" value="true" /> + <option name="IGNORE_SIMPLE_STATEMENTS" value="true" /> + </inspection_tool> <inspection_tool class="AntDuplicateTargetsInspection" level="ERROR" enabled="true" /> - <inspection_tool class="NullableProblems" level="WARNING" enabled="true"> + <inspection_tool class="NullableProblems" level="ERROR" enabled="true"> <option name="REPORT_NULLABLE_METHOD_OVERRIDES_NOTNULL" value="true" /> <option name="REPORT_NOT_ANNOTATED_METHOD_OVERRIDES_NOTNULL" value="true" /> <option name="REPORT_NOTNULL_PARAMETER_OVERRIDES_NULLABLE" value="true" /> <option name="REPORT_NOT_ANNOTATED_PARAMETER_OVERRIDES_NOTNULL" value="true" /> - <option name="REPORT_NOT_ANNOTATED_GETTER" value="true" /> - <option name="REPORT_NOT_ANNOTATED_SETTER_PARAMETER" value="true" /> - <option name="REPORT_ANNOTATION_NOT_PROPAGATED_TO_OVERRIDERS" value="true" /> </inspection_tool> <inspection_tool class="ReferencesToClassesFromDefaultPackagesInJSPFile" level="ERROR" enabled="false" /> - <inspection_tool class="TrivialIf" level="WARNING" enabled="true" /> - <inspection_tool class="AntMissingPropertiesFileInspection" level="WARNING" enabled="true" /> - <inspection_tool class="ObjectEqualsNull" level="WARNING" enabled="true" /> + <inspection_tool class="TrivialIf" level="ERROR" enabled="true" /> + <inspection_tool class="AntMissingPropertiesFileInspection" level="ERROR" enabled="true" /> + <inspection_tool class="ObjectEqualsNull" level="ERROR" enabled="true" /> <inspection_tool class="GwtToHtmlReferences" level="ERROR" enabled="false" /> - <inspection_tool class="EmptyFinallyBlock" level="WARNING" enabled="true" /> + <inspection_tool class="EmptyFinallyBlock" level="ERROR" enabled="true" /> <inspection_tool class="MismatchedCollectionQueryUpdate" level="WARNING" enabled="true" /> <inspection_tool class="EmptyStatementBody" level="WARNING" enabled="true"> <option name="m_reportEmptyBlocks" value="false" /> @@ -586,11 +650,16 @@ <inspection_tool class="TrivialConditionalJS" level="WARNING" enabled="false" /> <inspection_tool class="OneButtonGroup" level="WARNING" enabled="true" /> <inspection_tool class="StrutsTilesInspection" level="ERROR" enabled="false" /> - <inspection_tool class="ReflectionForUnavailableAnnotation" level="WARNING" enabled="true" /> + <inspection_tool class="ReflectionForUnavailableAnnotation" level="ERROR" enabled="true" /> <inspection_tool class="IncompatibleMaskJS" level="WARNING" enabled="false" /> <inspection_tool class="NonJREEmulationClassesInClientCode" level="ERROR" enabled="false" /> <inspection_tool class="OctalLiteral" level="WARNING" enabled="false" /> - <inspection_tool class="InfiniteRecursion" level="WARNING" enabled="true" /> + <inspection_tool class="AnalyzingRedundantModifier" level="ERROR" enabled="true"> + <option name="CHECK_FINAL_METHODS" value="true" /> + <option name="CHECK_PUBLIC_INTERFACE_METHODS" value="true" /> + <option name="CHECK_TRANSIENT_STATIC_FIELDS" value="true" /> + </inspection_tool> + <inspection_tool class="InfiniteRecursion" level="ERROR" enabled="true" /> <inspection_tool class="Geronimo" level="ERROR" enabled="false" /> <inspection_tool class="InfiniteLoopJS" level="WARNING" enabled="false" /> <inspection_tool class="SelfIncludingJspFiles" level="ERROR" enabled="false" /> @@ -600,42 +669,51 @@ <inspection_tool class="EmptyCatchBlock" level="WARNING" enabled="false"> <option name="m_includeComments" value="true" /> <option name="m_ignoreTestCases" value="true" /> - <option name="m_ignoreIgnoreParameter" value="true" /> </inspection_tool> <inspection_tool class="UnnecessaryLocalVariable" level="WARNING" enabled="false"> <option name="m_ignoreImmediatelyReturnedVariables" value="false" /> <option name="m_ignoreAnnotatedVariables" value="false" /> </inspection_tool> - <inspection_tool class="UnnecessaryTemporaryOnConversionFromString" level="WARNING" enabled="true" /> + <inspection_tool class="UnnecessaryTemporaryOnConversionFromString" level="ERROR" enabled="true" /> <inspection_tool class="EmptyStatementBodyJS" level="WARNING" enabled="false"> <option name="m_reportEmptyBlocks" value="false" /> </inspection_tool> <inspection_tool class="ThrowFromFinallyBlockJS" level="WARNING" enabled="false" /> - <inspection_tool class="TypeParameterExtendsObject" level="WARNING" enabled="true" /> - <inspection_tool class="FieldCanBeLocal" level="WARNING" enabled="true" /> + <inspection_tool class="PersistenceORMDomInspection" level="ERROR" enabled="false" /> + <inspection_tool class="TypeParameterExtendsObject" level="ERROR" enabled="true" /> + <inspection_tool class="FieldCanBeLocal" level="ERROR" enabled="true" /> <inspection_tool class="UNCHECKED_WARNING" level="WARNING" enabled="false" /> <inspection_tool class="LoopStatementThatDoesntLoopJS" level="WARNING" enabled="false" /> - <inspection_tool class="SuspiciousNameCombination" level="WARNING" enabled="true"> + <inspection_tool class="SuspiciousNameCombination" level="ERROR" enabled="true"> <group names="x,width,left,right" /> <group names="y,height,top,bottom" /> </inspection_tool> - <inspection_tool class="MalformedRegex" level="WARNING" enabled="true" /> + <inspection_tool class="MalformedRegex" level="ERROR" enabled="true" /> <inspection_tool class="TrivialIfJS" level="WARNING" enabled="false" /> - <inspection_tool class="SimplifiableConditionalExpression" level="WARNING" enabled="true" /> - <inspection_tool class="UNUSED_IMPORT" level="WARNING" enabled="true" /> + <inspection_tool class="SimplifiableConditionalExpression" level="ERROR" enabled="true" /> + <inspection_tool class="UNUSED_IMPORT" level="ERROR" enabled="true" /> <inspection_tool class="DuplicateCaseLabelJS" level="WARNING" enabled="false" /> + <inspection_tool class="PersistenceModelWarningInspection" level="WARNING" enabled="false" /> <inspection_tool class="PointlessBitwiseExpressionJS" level="WARNING" enabled="false"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> <inspection_tool class="SimplifiableIfStatement" level="WARNING" enabled="false" /> - <inspection_tool class="BooleanConstructor" level="WARNING" enabled="true" /> - <inspection_tool class="ExtendsObject" level="WARNING" enabled="true" /> + <inspection_tool class="BooleanConstructor" level="ERROR" enabled="true" /> + <inspection_tool class="ExtendsObject" level="ERROR" enabled="true" /> <inspection_tool class="RedundantArrayCreation" level="WARNING" enabled="true" /> + <inspection_tool class="PersistenceQlInspection" level="ERROR" enabled="false" /> <inspection_tool class="UnnecessaryLabelOnContinueStatementJS" level="WARNING" enabled="false" /> <inspection_tool class="CheckImageSize" level="WARNING" enabled="false" /> - <inspection_tool class="EmptyMethod" level="WARNING" enabled="false" /> + <inspection_tool class="EmptyMethod" level="WARNING" enabled="false"> + <option name="EXCLUDE_ANNOS"> + <value> + <list size="0" /> + </value> + </option> + </inspection_tool> + <inspection_tool class="PersistenceDomInspection" level="ERROR" enabled="false" /> <inspection_tool class="EmptyTryBlock" level="WARNING" enabled="false" /> - <inspection_tool class="MalformedFormatString" level="WARNING" enabled="true" /> + <inspection_tool class="MalformedFormatString" level="ERROR" enabled="true" /> <inspection_tool class="ComponentRegistrationProblems" level="ERROR" enabled="false"> <option name="CHECK_PLUGIN_XML" value="true" /> <option name="CHECK_JAVA_CODE" value="true" /> @@ -644,14 +722,14 @@ <inspection_tool class="PointlessBooleanExpressionJS" level="WARNING" enabled="false" /> <inspection_tool class="CssUnitlessNumber" level="WARNING" enabled="false" /> <inspection_tool class="ExceptionCaughtLocallyJS" level="WARNING" enabled="false" /> - <inspection_tool class="ConstantConditionalExpression" level="WARNING" enabled="true" /> + <inspection_tool class="ConstantConditionalExpression" level="ERROR" enabled="true" /> <inspection_tool class="MissingMnemonic" level="WARNING" enabled="true" /> <inspection_tool class="CloneDeclaresCloneNotSupported" level="INFO" enabled="true" /> - <inspection_tool class="MalformedXPath" level="WARNING" enabled="true" /> + <inspection_tool class="MalformedXPath" level="ERROR" enabled="true" /> <inspection_tool class="AccessStaticViaInstance" level="WARNING" enabled="true" /> <inspection_tool class="UnusedParameters" level="WARNING" enabled="false" /> <inspection_tool class="DuplicateMnemonic" level="WARNING" enabled="true" /> - <inspection_tool class="StringConstructor" level="WARNING" enabled="true"> + <inspection_tool class="StringConstructor" level="ERROR" enabled="true"> <option name="ignoreSubstringArguments" value="false" /> </inspection_tool> <inspection_tool class="GWTRemoteServiceAsyncCheck" level="ERROR" enabled="false" /> @@ -659,32 +737,26 @@ <inspection_tool class="MismatchedArrayReadWrite" level="WARNING" enabled="true" /> <inspection_tool class="UnusedReturnValue" level="WARNING" enabled="false" /> <inspection_tool class="UnnecessaryContinueJS" level="WARNING" enabled="false" /> - <inspection_tool class="FinallyBlockCannotCompleteNormally" level="WARNING" enabled="true" /> + <inspection_tool class="FinallyBlockCannotCompleteNormally" level="ERROR" enabled="true" /> <inspection_tool class="BadExpressionStatementJS" level="WARNING" enabled="false" /> - <inspection_tool class="PrimitiveArrayArgumentToVariableArgMethod" level="WARNING" enabled="true" /> + <inspection_tool class="PrimitiveArrayArgumentToVariableArgMethod" level="ERROR" enabled="true" /> <inspection_tool class="InfiniteRecursionJS" level="WARNING" enabled="false" /> <inspection_tool class="StrutsValidatorInspection" level="ERROR" enabled="false" /> - <inspection_tool class="ContinueOrBreakFromFinallyBlock" level="WARNING" enabled="true" /> + <inspection_tool class="ContinueOrBreakFromFinallyBlock" level="ERROR" enabled="true" /> <inspection_tool class="DuplicatePropertyOnObjectJS" level="WARNING" enabled="false" /> <inspection_tool class="JBoss" level="ERROR" enabled="false" /> <inspection_tool class="UnusedDeclaration" level="WARNING" enabled="false"> <option name="ADD_MAINS_TO_ENTRIES" value="true" /> + <option name="ADD_JUNIT_TO_ENTRIES" value="true" /> + <option name="ADD_EJB_TO_ENTRIES" value="true" /> <option name="ADD_APPLET_TO_ENTRIES" value="true" /> <option name="ADD_SERVLET_TO_ENTRIES" value="true" /> <option name="ADD_NONJAVA_TO_ENTRIES" value="true" /> - <option name="ADDITIONAL_ANNOTATIONS"> - <value> - <list size="0" /> - </value> - </option> - <option name="ADD_EJB_TO_ENTRIES" value="true" /> - <option name="ADD_JUNIT_TO_ENTRIES" value="true" /> - <option name="ADD_TESTNG_TO_ENTRIES" value="true" /> </inspection_tool> <inspection_tool class="Deprecation" level="WARNING" enabled="false" /> <inspection_tool class="StrutsInspection" level="ERROR" enabled="false" /> - <inspection_tool class="MissingDeprecatedAnnotation" level="WARNING" enabled="true" /> - <inspection_tool class="JavaDoc" level="WARNING" enabled="true"> + <inspection_tool class="MissingDeprecatedAnnotation" level="ERROR" enabled="true" /> + <inspection_tool class="JavaDoc" level="ERROR" enabled="true"> <option name="TOP_LEVEL_CLASS_OPTIONS"> <value> <option name="ACCESS_JAVADOC_REQUIRED_FOR" value="none" /> @@ -713,178 +785,174 @@ <option name="IGNORE_JAVADOC_PERIOD" value="false" /> <option name="myAdditionalJavadocTags" value="todo,note,todo,xxx,note,todo,fixme,fixme,warning,invariant,retval,pre" /> </inspection_tool> - <inspection_tool class="MissingOverrideAnnotation" level="WARNING" enabled="true"> - <option name="useJdk6Rules" value="false" /> - </inspection_tool> - <inspection_tool class="AbstractMethodWithMissingImplementations" level="WARNING" enabled="true" /> - <inspection_tool class="EqualsAndHashcode" level="WARNING" enabled="true" /> + <inspection_tool class="MissingOverrideAnnotation" level="ERROR" enabled="true" /> + <inspection_tool class="AbstractMethodWithMissingImplementations" level="ERROR" enabled="true" /> + <inspection_tool class="EqualsAndHashcode" level="ERROR" enabled="true" /> <inspection_tool class="Dependency" level="ERROR" enabled="false" /> - <inspection_tool class="FinalizeNotProtected" level="WARNING" enabled="true" /> - <inspection_tool class="NoExplicitFinalizeCalls" level="WARNING" enabled="true" /> - <inspection_tool class="FinalizeCallsSuperFinalize" level="WARNING" enabled="true"> + <inspection_tool class="FinalizeNotProtected" level="ERROR" enabled="true" /> + <inspection_tool class="NoExplicitFinalizeCalls" level="ERROR" enabled="true" /> + <inspection_tool class="FinalizeCallsSuperFinalize" level="ERROR" enabled="true"> <option name="m_ignoreForObjectSubclasses" value="false" /> </inspection_tool> - <inspection_tool class="OnDemandImport" level="WARNING" enabled="true" /> - <inspection_tool class="JavaLangImport" level="WARNING" enabled="true" /> - <inspection_tool class="SamePackageImport" level="WARNING" enabled="true" /> - <inspection_tool class="RedundantImport" level="WARNING" enabled="true" /> - <inspection_tool class="InstanceofThis" level="WARNING" enabled="true" /> - <inspection_tool class="ReplaceAssignmentWithOperatorAssignment" level="WARNING" enabled="true"> + <inspection_tool class="OnDemandImport" level="ERROR" enabled="true" /> + <inspection_tool class="JavaLangImport" level="ERROR" enabled="true" /> + <inspection_tool class="SamePackageImport" level="ERROR" enabled="true" /> + <inspection_tool class="RedundantImport" level="ERROR" enabled="true" /> + <inspection_tool class="InstanceofThis" level="ERROR" enabled="true" /> + <inspection_tool class="ReplaceAssignmentWithOperatorAssignment" level="ERROR" enabled="true"> <option name="ignoreLazyOperators" value="true" /> <option name="ignoreObscureOperators" value="false" /> </inspection_tool> - <inspection_tool class="AssignmentToCatchBlockParameter" level="WARNING" enabled="true" /> - <inspection_tool class="ShiftOutOfRange" level="WARNING" enabled="true" /> - <inspection_tool class="PointlessBitwiseExpression" level="WARNING" enabled="true"> + <inspection_tool class="AssignmentToCatchBlockParameter" level="ERROR" enabled="true" /> + <inspection_tool class="ShiftOutOfRange" level="ERROR" enabled="true" /> + <inspection_tool class="PointlessBitwiseExpression" level="ERROR" enabled="true"> <option name="m_ignoreExpressionsContainingConstants" value="false" /> </inspection_tool> - <inspection_tool class="IncompatibleMask" level="WARNING" enabled="true" /> - <inspection_tool class="FinalMethodInFinalClass" level="WARNING" enabled="true" /> - <inspection_tool class="FinalPrivateMethod" level="WARNING" enabled="true" /> - <inspection_tool class="ProtectedMemberInFinalClass" level="WARNING" enabled="true" /> - <inspection_tool class="PublicConstructorInNonPublicClass" level="WARNING" enabled="true" /> - <inspection_tool class="ExtendsConcreteCollection" level="WARNING" enabled="true" /> - <inspection_tool class="AbstractClassNeverImplemented" level="WARNING" enabled="true" /> - <inspection_tool class="ExtendsAnnotation" level="WARNING" enabled="true" /> - <inspection_tool class="AbstractMethodOverridesAbstractMethod" level="WARNING" enabled="true" /> - <inspection_tool class="NonProtectedConstructorInAbstractClass" level="WARNING" enabled="true"> + <inspection_tool class="IncompatibleMask" level="ERROR" enabled="true" /> + <inspection_tool class="FinalMethodInFinalClass" level="ERROR" enabled="true" /> + <inspection_tool class="FinalPrivateMethod" level="ERROR" enabled="true" /> + <inspection_tool class="ProtectedMemberInFinalClass" level="ERROR" enabled="true" /> + <inspection_tool class="PublicConstructorInNonPublicClass" level="ERROR" enabled="true" /> + <inspection_tool class="ExtendsConcreteCollection" level="ERROR" enabled="true" /> + <inspection_tool class="AbstractClassNeverImplemented" level="ERROR" enabled="true" /> + <inspection_tool class="ExtendsAnnotation" level="ERROR" enabled="true" /> + <inspection_tool class="AbstractMethodOverridesAbstractMethod" level="ERROR" enabled="true" /> + <inspection_tool class="NonProtectedConstructorInAbstractClass" level="ERROR" enabled="true"> <option name="m_ignoreNonPublicClasses" value="true" /> </inspection_tool> - <inspection_tool class="StaticInheritance" level="WARNING" enabled="true" /> - <inspection_tool class="TypeParameterExtendsFinalClass" level="WARNING" enabled="true" /> - <inspection_tool class="AbstractMethodCallInConstructor" level="WARNING" enabled="true" /> - <inspection_tool class="IndexOfReplaceableByContains" level="WARNING" enabled="true" /> - <inspection_tool class="ForCanBeForeach" level="WARNING" enabled="true"> - <option name="REPORT_INDEXED_LOOP" value="true" /> - </inspection_tool> - <inspection_tool class="UnnecessaryBoxing" level="WARNING" enabled="true" /> - <inspection_tool class="UnnecessaryUnboxing" level="WARNING" enabled="true" /> - <inspection_tool class="WhileCanBeForeach" level="WARNING" enabled="true" /> - <inspection_tool class="AssertAsName" level="WARNING" enabled="true" /> - <inspection_tool class="EnumAsName" level="WARNING" enabled="true" /> - <inspection_tool class="BeforeOrAfterIsPublicVoidNoArg" level="WARNING" enabled="true" /> - <inspection_tool class="BeforeClassOrAfterClassIsPublicStaticVoidNoArg" level="WARNING" enabled="true" /> - <inspection_tool class="ClassWithMultipleLoggers" level="WARNING" enabled="true"> + <inspection_tool class="StaticInheritance" level="ERROR" enabled="true" /> + <inspection_tool class="TypeParameterExtendsFinalClass" level="ERROR" enabled="true" /> + <inspection_tool class="AbstractMethodCallInConstructor" level="ERROR" enabled="true" /> + <inspection_tool class="IndexOfReplaceableByContains" level="ERROR" enabled="true" /> + <inspection_tool class="ForCanBeForeach" level="ERROR" enabled="true" /> + <inspection_tool class="UnnecessaryBoxing" level="ERROR" enabled="true" /> + <inspection_tool class="UnnecessaryUnboxing" level="ERROR" enabled="true" /> + <inspection_tool class="WhileCanBeForeach" level="ERROR" enabled="true" /> + <inspection_tool class="AssertAsName" level="ERROR" enabled="true" /> + <inspection_tool class="EnumAsName" level="ERROR" enabled="true" /> + <inspection_tool class="BeforeOrAfterIsPublicVoidNoArg" level="ERROR" enabled="true" /> + <inspection_tool class="BeforeClassOrAfterClassIsPublicStaticVoidNoArg" level="ERROR" enabled="true" /> + <inspection_tool class="ClassWithMultipleLoggers" level="ERROR" enabled="true"> <option name="loggerClassName" value="org.apache.log4j.Logger" /> </inspection_tool> - <inspection_tool class="AnnotationNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="AnnotationNamingConvention" level="ERROR" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*" /> <option name="m_minLength" value="8" /> <option name="m_maxLength" value="64" /> </inspection_tool> - <inspection_tool class="ClassNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="ClassNamingConvention" level="ERROR" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*" /> <option name="m_minLength" value="6" /> <option name="m_maxLength" value="64" /> </inspection_tool> - <inspection_tool class="ConfusingMainMethod" level="WARNING" enabled="true" /> - <inspection_tool class="ConstantNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="ConfusingMainMethod" level="ERROR" enabled="true" /> + <inspection_tool class="ConstantNamingConvention" level="ERROR" enabled="true"> <option name="m_regex" value="[A-Z_\d]*|log" /> <option name="m_minLength" value="4" /> <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="DollarSignInName" level="WARNING" enabled="true" /> - <inspection_tool class="EnumeratedClassNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="DollarSignInName" level="ERROR" enabled="true" /> + <inspection_tool class="EnumeratedClassNamingConvention" level="ERROR" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*" /> <option name="m_minLength" value="4" /> <option name="m_maxLength" value="64" /> </inspection_tool> - <inspection_tool class="EnumeratedConstantNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="EnumeratedConstantNamingConvention" level="ERROR" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*|[A-Z][A-Z_]*" /> <option name="m_minLength" value="3" /> <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="ExceptionNameDoesntEndWithException" level="WARNING" enabled="true" /> - <inspection_tool class="InstanceMethodNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="ExceptionNameDoesntEndWithException" level="ERROR" enabled="true" /> + <inspection_tool class="InstanceMethodNamingConvention" level="ERROR" enabled="true"> <option name="m_regex" value="[a-z][A-Za-z\d]*" /> <option name="m_minLength" value="3" /> - <option name="m_maxLength" value="99" /> + <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="InstanceVariableNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="InstanceVariableNamingConvention" level="ERROR" enabled="true"> <option name="m_regex" value="[a-z][A-Za-z\d]*" /> <option name="m_minLength" value="3" /> <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="InterfaceNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="InterfaceNamingConvention" level="ERROR" enabled="true"> <option name="m_regex" value="[A-Z][A-Za-z\d]*" /> <option name="m_minLength" value="4" /> <option name="m_maxLength" value="64" /> </inspection_tool> - <inspection_tool class="LocalVariableNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="LocalVariableNamingConvention" level="ERROR" enabled="true"> <option name="m_ignoreForLoopParameters" value="false" /> <option name="m_ignoreCatchParameters" value="false" /> <option name="m_regex" value="[a-z][A-Za-z\d]*" /> <option name="m_minLength" value="1" /> <option name="m_maxLength" value="32" /> </inspection_tool> - <inspection_tool class="MethodNamesDifferOnlyByCase" level="WARNING" enabled="true" /> - <inspection_tool class="ParameterNamingConvention" level="WARNING" enabled="true"> + <inspection_tool class="MethodNamesDifferOnlyByCase" level="ERROR" enable... [truncated message content] |
From: <aki...@us...> - 2008-07-15 18:11:48
|
Revision: 4341 http://gridarta.svn.sourceforge.net/gridarta/?rev=4341&view=rev Author: akirschbaum Date: 2008-07-15 11:11:35 -0700 (Tue, 15 Jul 2008) Log Message: ----------- Rename message resource key. Modified Paths: -------------- trunk/crossfire/src/cfeditor/gameobject/face/FaceObjects.java trunk/crossfire/src/cfeditor/messages.properties trunk/daimonin/src/daieditor/gameobject/face/FaceObjects.java trunk/daimonin/src/daieditor/messages.properties Modified: trunk/crossfire/src/cfeditor/gameobject/face/FaceObjects.java =================================================================== --- trunk/crossfire/src/cfeditor/gameobject/face/FaceObjects.java 2008-07-15 17:47:06 UTC (rev 4340) +++ trunk/crossfire/src/cfeditor/gameobject/face/FaceObjects.java 2008-07-15 18:11:35 UTC (rev 4341) @@ -133,7 +133,7 @@ if (treeIn != null) { final String originalFilename = treeIn.readLine(); if (originalFilename == null) { - log.warn(ACTION_FACTORY.format("faceObjectWithoutOriginalName", faceName)); + log.warn(ACTION_FACTORY.format("logFaceObjectWithoutOriginalName", faceName)); } else { addFaceObject(faceName, originalFilename, actualFilename, offset, size); } Modified: trunk/crossfire/src/cfeditor/messages.properties =================================================================== --- trunk/crossfire/src/cfeditor/messages.properties 2008-07-15 17:47:06 UTC (rev 4340) +++ trunk/crossfire/src/cfeditor/messages.properties 2008-07-15 18:11:35 UTC (rev 4341) @@ -401,7 +401,7 @@ # Various Log Messages logExitWithExit=Exiting with System.exit(). logExitWithoutExit=Trying to exit without System.exit(). -faceObjectWithoutOriginalName=No originalName for {0}! +logFaceObjectWithoutOriginalName=No originalName for {0}! logDuplicateAnimation=Duplicate Animation: {0} logInventoryInDefArch=Found inventory Object in def arch: {0} logFoundCoordInDefArchSingleTileOrHead=Found {0} cmd in single tile or head (add it to arch text): {1} Modified: trunk/daimonin/src/daieditor/gameobject/face/FaceObjects.java =================================================================== --- trunk/daimonin/src/daieditor/gameobject/face/FaceObjects.java 2008-07-15 17:47:06 UTC (rev 4340) +++ trunk/daimonin/src/daieditor/gameobject/face/FaceObjects.java 2008-07-15 18:11:35 UTC (rev 4341) @@ -126,7 +126,7 @@ if (treeIn != null) { final String originalFilename = treeIn.readLine(); if (originalFilename == null) { - log.warn(ACTION_FACTORY.format("faceObjectWithoutOriginalName", faceName)); + log.warn(ACTION_FACTORY.format("logFaceObjectWithoutOriginalName", faceName)); } else { addFaceObject(faceName, originalFilename, actualFilename, offset, size); } Modified: trunk/daimonin/src/daieditor/messages.properties =================================================================== --- trunk/daimonin/src/daieditor/messages.properties 2008-07-15 17:47:06 UTC (rev 4340) +++ trunk/daimonin/src/daieditor/messages.properties 2008-07-15 18:11:35 UTC (rev 4341) @@ -456,7 +456,7 @@ # Various Log Messages logExitWithExit=Exiting with System.exit(). logExitWithoutExit=Trying to exit without System.exit(). -faceObjectWithoutOriginalName=No originalName for {0}! +logFaceObjectWithoutOriginalName=No originalName for {0}! logDuplicateAnimation=Duplicate Animation: {0} logInventoryInDefArch=Found inventory Object in def arch: {0} logFoundCoordInDefArchSingleTileOrHead=Found {0} cmd in single tile or head (add it to arch text): {1} This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <aki...@us...> - 2008-07-15 19:19:30
|
Revision: 4343 http://gridarta.svn.sourceforge.net/gridarta/?rev=4343&view=rev Author: akirschbaum Date: 2008-07-15 12:19:27 -0700 (Tue, 15 Jul 2008) Log Message: ----------- Replace CMainControl with MainControl. Modified Paths: -------------- trunk/crossfire/src/cfeditor/gui/ObjectChooser.java trunk/daimonin/src/daieditor/gui/ObjectChooser.java Modified: trunk/crossfire/src/cfeditor/gui/ObjectChooser.java =================================================================== --- trunk/crossfire/src/cfeditor/gui/ObjectChooser.java 2008-07-15 19:13:03 UTC (rev 4342) +++ trunk/crossfire/src/cfeditor/gui/ObjectChooser.java 2008-07-15 19:19:27 UTC (rev 4343) @@ -19,7 +19,6 @@ package cfeditor.gui; -import cfeditor.CMainControl; import cfeditor.gameobject.Archetype; import cfeditor.gameobject.GameObject; import cfeditor.gui.map.CMapViewBasic; @@ -29,6 +28,7 @@ import javax.swing.JSplitPane; import javax.swing.JTabbedPane; import javax.swing.SwingConstants; +import net.sf.gridarta.MainControl; import net.sf.gridarta.MapManager; import net.sf.gridarta.gui.AbstractObjectChooser; import net.sf.gridarta.gui.ArchNPickChangeListener; @@ -82,13 +82,13 @@ /** * Build Panel. - * @param mainControl CMainControl + * @param mainControl the main control * @param selectedSquareView the selected square view * @param archetypeChooserControl the archetype chooser control * @param mapManager the map manager instance * @param pickmapChooserControl the pickmap chooser control */ - public ObjectChooser(final CMainControl mainControl, @NotNull final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView, @NotNull final ArchetypeChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> archetypeChooserControl, @NotNull final MapManager<GameObject, MapArchObject, Archetype, CMapViewBasic> mapManager, @NotNull final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl) { + public ObjectChooser(final MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mainControl, @NotNull final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView, @NotNull final ArchetypeChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> archetypeChooserControl, @NotNull final MapManager<GameObject, MapArchObject, Archetype, CMapViewBasic> mapManager, @NotNull final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl) { super(archetypeChooserControl, pickmapChooserControl); archetypeChooserControl.addArchetypeChooserListener(new ArchetypeChooserListener<GameObject, MapArchObject, Archetype>() { /** {@inheritDoc} */ Modified: trunk/daimonin/src/daieditor/gui/ObjectChooser.java =================================================================== --- trunk/daimonin/src/daieditor/gui/ObjectChooser.java 2008-07-15 19:13:03 UTC (rev 4342) +++ trunk/daimonin/src/daieditor/gui/ObjectChooser.java 2008-07-15 19:19:27 UTC (rev 4343) @@ -19,7 +19,6 @@ package daieditor.gui; -import daieditor.CMainControl; import daieditor.gameobject.Archetype; import daieditor.gameobject.GameObject; import daieditor.gui.map.CMapViewBasic; @@ -29,6 +28,7 @@ import javax.swing.JSplitPane; import javax.swing.JTabbedPane; import javax.swing.SwingConstants; +import net.sf.gridarta.MainControl; import net.sf.gridarta.MapManager; import net.sf.gridarta.gui.AbstractObjectChooser; import net.sf.gridarta.gui.ArchNPickChangeListener; @@ -82,13 +82,13 @@ /** * Build Panel. - * @param mainControl CMainControl + * @param mainControl the main control * @param selectedSquareView the selected square view * @param archetypeChooserControl the archetype chooser control * @param mapManager the map manager instance * @param pickmapChooserControl the pickmap chooser control */ - public ObjectChooser(final CMainControl mainControl, @NotNull final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView, @NotNull final ArchetypeChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> archetypeChooserControl, @NotNull final MapManager<GameObject, MapArchObject, Archetype, CMapViewBasic> mapManager, @NotNull final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl) { + public ObjectChooser(final MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mainControl, @NotNull final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView, @NotNull final ArchetypeChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> archetypeChooserControl, @NotNull final MapManager<GameObject, MapArchObject, Archetype, CMapViewBasic> mapManager, @NotNull final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl) { super(archetypeChooserControl, pickmapChooserControl); archetypeChooserControl.addArchetypeChooserListener(new ArchetypeChooserListener<GameObject, MapArchObject, Archetype>() { /** {@inheritDoc} */ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <aki...@us...> - 2008-07-15 19:34:23
|
Revision: 4345 http://gridarta.svn.sourceforge.net/gridarta/?rev=4345&view=rev Author: akirschbaum Date: 2008-07-15 12:34:00 -0700 (Tue, 15 Jul 2008) Log Message: ----------- Move ObjectChooser code to common code base. Modified Paths: -------------- trunk/crossfire/src/cfeditor/gui/ObjectChooser.java trunk/crossfire/src/cfeditor/messages.properties trunk/crossfire/src/cfeditor/messages_de.properties trunk/crossfire/src/cfeditor/messages_fr.properties trunk/crossfire/src/cfeditor/messages_sv.properties trunk/daimonin/src/daieditor/gui/ObjectChooser.java trunk/daimonin/src/daieditor/messages.properties trunk/daimonin/src/daieditor/messages_de.properties trunk/daimonin/src/daieditor/messages_fr.properties trunk/daimonin/src/daieditor/messages_sv.properties trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java trunk/src/app/net/sf/gridarta/messages.properties trunk/src/app/net/sf/gridarta/messages_de.properties trunk/src/app/net/sf/gridarta/messages_fr.properties trunk/src/app/net/sf/gridarta/messages_sv.properties Modified: trunk/crossfire/src/cfeditor/gui/ObjectChooser.java =================================================================== --- trunk/crossfire/src/cfeditor/gui/ObjectChooser.java 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/crossfire/src/cfeditor/gui/ObjectChooser.java 2008-07-15 19:34:00 UTC (rev 4345) @@ -23,26 +23,13 @@ import cfeditor.gameobject.GameObject; import cfeditor.gui.map.CMapViewBasic; import cfeditor.map.MapArchObject; -import java.awt.BorderLayout; -import java.util.List; -import javax.swing.JSplitPane; -import javax.swing.JTabbedPane; -import javax.swing.SwingConstants; import net.sf.gridarta.MainControl; import net.sf.gridarta.MapManager; import net.sf.gridarta.gui.AbstractObjectChooser; -import net.sf.gridarta.gui.ArchNPickChangeListener; -import net.sf.gridarta.gui.GSplitPane; -import net.sf.gridarta.gui.ObjectChoiceDisplay; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; -import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserListener; -import net.sf.gridarta.gui.map.tools.ToolPalette; import net.sf.gridarta.gui.pickmapchooser.PickmapChooserControl; -import net.sf.gridarta.gui.pickmapchooser.PickmapChooserListener; import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; -import net.sf.japi.swing.ActionFactory; import org.jetbrains.annotations.NotNull; -import org.jetbrains.annotations.Nullable; /** * The <code>ObjectChooser</code> holds the tile palette. @@ -53,34 +40,10 @@ */ public final class ObjectChooser extends AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> implements net.sf.gridarta.gui.ObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> { - /** Action Factory. */ - private static final ActionFactory ACTION_FACTORY = ActionFactory.getFactory("cfeditor"); - /** Serial Version UID. */ private static final long serialVersionUID = 1L; - /** ToolSelector of this subview. */ - private final ToolPalette<GameObject, MapArchObject, Archetype, CMapViewBasic> toolPalette; - - /** Panel holding both archlist and pickmaps. */ - private final JTabbedPane archAndPickPane = new JTabbedPane(SwingConstants.TOP); - - /** The data/view of selected objects in tab panel. */ - private final ObjectChoiceDisplay<GameObject, MapArchObject, Archetype, CMapViewBasic> objectChoiceDisplay; - /** - * The listener attached to {@link #pickmapChooserControl}. - */ - private final PickmapChooserListener pickmapChooserListener = new PickmapChooserListener() { - - /** {@inheritDoc} */ - public void activePickmapChanged() { - showObjectChooserQuickObject(null); - } - - }; - - /** * Build Panel. * @param mainControl the main control * @param selectedSquareView the selected square view @@ -89,81 +52,7 @@ * @param pickmapChooserControl the pickmap chooser control */ public ObjectChooser(final MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mainControl, @NotNull final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView, @NotNull final ArchetypeChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> archetypeChooserControl, @NotNull final MapManager<GameObject, MapArchObject, Archetype, CMapViewBasic> mapManager, @NotNull final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl) { - super(archetypeChooserControl, pickmapChooserControl); - archetypeChooserControl.addArchetypeChooserListener(new ArchetypeChooserListener<GameObject, MapArchObject, Archetype>() { - /** {@inheritDoc} */ - public void selectedArchetypeChanged(@NotNull final GameObject archetype) { - showObjectChooserQuickObject(archetype); - } - - /** {@inheritDoc} */ - public void displayObjectNamesChanged(final boolean displayObjectNames) { - // ignore - } - }); - toolPalette = new ToolPalette<GameObject, MapArchObject, Archetype, CMapViewBasic>(mainControl, selectedSquareView, this); - - objectChoiceDisplay = new ObjectChoiceDisplay<GameObject, MapArchObject, Archetype, CMapViewBasic>(mainControl, this); - - // archAndPickPane is the panel containing both archpanel and pickmaps - archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.archetypesTabTitle"), archetypeChooserControl.getArchetypePanel()); - archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.pickmapsTabTitle"), pickmapChooserControl.getPickmapPanel()); - // this listener informs the mainview which panel is active: archlist or pickmaps? - archAndPickPane.addChangeListener(new ArchNPickChangeListener(this, archAndPickPane)); - - // TODO: introduce a tool registry - final JSplitPane splitPane = new GSplitPane(JSplitPane.VERTICAL_SPLIT, toolPalette, archAndPickPane); - splitPane.setContinuousLayout(true); - add(splitPane, BorderLayout.CENTER); - add(objectChoiceDisplay, BorderLayout.SOUTH); + super(mainControl, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); } - /** {@inheritDoc} */ - public void moveArchetypeChooserToFront() { - archAndPickPane.setSelectedIndex(0); - } - - /** {@inheritDoc} */ - public void movePickmapChooserToFront() { - archAndPickPane.setSelectedIndex(1); - } - - /** {@inheritDoc} */ - public void showObjectChooserQuickObject(@Nullable final GameObject gameObject) { - objectChoiceDisplay.showObjectChooserQuickObject(gameObject); - } - - /** {@inheritDoc} */ - @Nullable - public GameObject getObjectChooserHighlight() { - return isPickmapActive() ? pickmapChooserControl.getSelection() : archetypeChooserControl.getSelection(); - } - - /** {@inheritDoc} */ - @NotNull - public List<GameObject> getObjectChooserSelection() { - return isPickmapActive() ? pickmapChooserControl.getSelections() : archetypeChooserControl.getSelections(); - } - - /** {@inheritDoc} */ - @Override - public void setPickmapActive(final boolean pickmapActive) { - super.setPickmapActive(pickmapActive); - pickmapChooserControl.setActive(pickmapActive); - } - - /** - * Returns the tool selector pane. - * @return The tool selector pane. - */ - public ToolPalette<GameObject, MapArchObject, Archetype, CMapViewBasic> getToolSelectorPane() { - return toolPalette; - } - - /** {@inheritDoc} */ - public void selectArchetype(final Archetype archetype) { - moveArchetypeChooserToFront(); - archetypeChooserControl.selectArchetype(archetype); - } - } // class ObjectChooser Modified: trunk/crossfire/src/cfeditor/messages.properties =================================================================== --- trunk/crossfire/src/cfeditor/messages.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/crossfire/src/cfeditor/messages.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -391,12 +391,6 @@ pluginConfirmSaveChanges.message=Do you want to save changes to plugin {0}? -################ -# Object Chooser -objectChooser.archetypesTabTitle=Archetypes -objectChooser.pickmapsTabTitle=Pickmaps - - ####################### # Various Log Messages logExitWithExit=Exiting with System.exit(). Modified: trunk/crossfire/src/cfeditor/messages_de.properties =================================================================== --- trunk/crossfire/src/cfeditor/messages_de.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/crossfire/src/cfeditor/messages_de.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -351,9 +351,3 @@ pluginConfirmSaveChanges.title=\xC4nderungen sichern? pluginConfirmSaveChanges.message=Wollen Sie die \xC4nderungen des Plugins {0} sichern? - - -################ -# Object Chooser -objectChooser.archetypesTabTitle=Archetypen -objectChooser.pickmapsTabTitle=Pickmaps Modified: trunk/crossfire/src/cfeditor/messages_fr.properties =================================================================== --- trunk/crossfire/src/cfeditor/messages_fr.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/crossfire/src/cfeditor/messages_fr.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -352,9 +352,3 @@ #pluginConfirmSaveChanges.title=\xC4nderungen sichern? #pluginConfirmSaveChanges.message= - - -################ -# Object Chooser -objectChooser.archetypesTabTitle=Arches -#objectChooser.pickmapsTabTitle= Modified: trunk/crossfire/src/cfeditor/messages_sv.properties =================================================================== --- trunk/crossfire/src/cfeditor/messages_sv.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/crossfire/src/cfeditor/messages_sv.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -350,9 +350,3 @@ pluginConfirmSaveChanges.title=Spara \xE4ndringar? #pluginConfirmSaveChanges.message= - - -################ -# Object Chooser -#objectChooser.archetypesTabTitle= -#objectChooser.pickmapsTabTitle= Modified: trunk/daimonin/src/daieditor/gui/ObjectChooser.java =================================================================== --- trunk/daimonin/src/daieditor/gui/ObjectChooser.java 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/daimonin/src/daieditor/gui/ObjectChooser.java 2008-07-15 19:34:00 UTC (rev 4345) @@ -23,26 +23,13 @@ import daieditor.gameobject.GameObject; import daieditor.gui.map.CMapViewBasic; import daieditor.map.MapArchObject; -import java.awt.BorderLayout; -import java.util.List; -import javax.swing.JSplitPane; -import javax.swing.JTabbedPane; -import javax.swing.SwingConstants; import net.sf.gridarta.MainControl; import net.sf.gridarta.MapManager; import net.sf.gridarta.gui.AbstractObjectChooser; -import net.sf.gridarta.gui.ArchNPickChangeListener; -import net.sf.gridarta.gui.GSplitPane; -import net.sf.gridarta.gui.ObjectChoiceDisplay; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; -import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserListener; -import net.sf.gridarta.gui.map.tools.ToolPalette; import net.sf.gridarta.gui.pickmapchooser.PickmapChooserControl; -import net.sf.gridarta.gui.pickmapchooser.PickmapChooserListener; import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; -import net.sf.japi.swing.ActionFactory; import org.jetbrains.annotations.NotNull; -import org.jetbrains.annotations.Nullable; /** * The <code>ObjectChooser</code> holds the tile palette. @@ -53,34 +40,10 @@ */ public final class ObjectChooser extends AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> implements net.sf.gridarta.gui.ObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> { - /** Action Factory. */ - private static final ActionFactory ACTION_FACTORY = ActionFactory.getFactory("daieditor"); - /** Serial Version UID. */ private static final long serialVersionUID = 1L; - /** ToolSelector of this subview. */ - private final ToolPalette<GameObject, MapArchObject, Archetype, CMapViewBasic> toolPalette; - - /** Panel holding both archlist and pickmaps. */ - private final JTabbedPane archAndPickPane = new JTabbedPane(SwingConstants.TOP); - - /** The data/view of selected objects in tab panel. */ - private final ObjectChoiceDisplay<GameObject, MapArchObject, Archetype, CMapViewBasic> objectChoiceDisplay; - /** - * The listener attached to {@link #pickmapChooserControl}. - */ - private final PickmapChooserListener pickmapChooserListener = new PickmapChooserListener() { - - /** {@inheritDoc} */ - public void activePickmapChanged() { - showObjectChooserQuickObject(null); - } - - }; - - /** * Build Panel. * @param mainControl the main control * @param selectedSquareView the selected square view @@ -89,81 +52,7 @@ * @param pickmapChooserControl the pickmap chooser control */ public ObjectChooser(final MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mainControl, @NotNull final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView, @NotNull final ArchetypeChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> archetypeChooserControl, @NotNull final MapManager<GameObject, MapArchObject, Archetype, CMapViewBasic> mapManager, @NotNull final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl) { - super(archetypeChooserControl, pickmapChooserControl); - archetypeChooserControl.addArchetypeChooserListener(new ArchetypeChooserListener<GameObject, MapArchObject, Archetype>() { - /** {@inheritDoc} */ - public void selectedArchetypeChanged(@NotNull final GameObject archetype) { - showObjectChooserQuickObject(archetype); - } - - /** {@inheritDoc} */ - public void displayObjectNamesChanged(final boolean displayObjectNames) { - // ignore - } - }); - toolPalette = new ToolPalette<GameObject, MapArchObject, Archetype, CMapViewBasic>(mainControl, selectedSquareView, this); - - objectChoiceDisplay = new ObjectChoiceDisplay<GameObject, MapArchObject, Archetype, CMapViewBasic>(mainControl, this); - - // archAndPickPane is the panel containing both archpanel and pickmaps - archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.archetypesTabTitle"), archetypeChooserControl.getArchetypePanel()); - archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.pickmapsTabTitle"), pickmapChooserControl.getPickmapPanel()); - // this listener informs the mainview which panel is active: archlist or pickmaps? - archAndPickPane.addChangeListener(new ArchNPickChangeListener(this, archAndPickPane)); - - // TODO: introduce a tool registry - final JSplitPane splitPane = new GSplitPane(JSplitPane.VERTICAL_SPLIT, toolPalette, archAndPickPane); - splitPane.setContinuousLayout(true); - add(splitPane, BorderLayout.CENTER); - add(objectChoiceDisplay, BorderLayout.SOUTH); + super(mainControl, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); } - /** {@inheritDoc} */ - public void moveArchetypeChooserToFront() { - archAndPickPane.setSelectedIndex(0); - } - - /** {@inheritDoc} */ - public void movePickmapChooserToFront() { - archAndPickPane.setSelectedIndex(1); - } - - /** {@inheritDoc} */ - public void showObjectChooserQuickObject(@Nullable final GameObject gameObject) { - objectChoiceDisplay.showObjectChooserQuickObject(gameObject); - } - - /** {@inheritDoc} */ - @Nullable - public GameObject getObjectChooserHighlight() { - return isPickmapActive() ? pickmapChooserControl.getSelection() : archetypeChooserControl.getSelection(); - } - - /** {@inheritDoc} */ - @NotNull - public List<GameObject> getObjectChooserSelection() { - return isPickmapActive() ? pickmapChooserControl.getSelections() : archetypeChooserControl.getSelections(); - } - - /** {@inheritDoc} */ - @Override - public void setPickmapActive(final boolean pickmapActive) { - super.setPickmapActive(pickmapActive); - pickmapChooserControl.setActive(pickmapActive); - } - - /** - * Returns the tool selector pane. - * @return The tool selector pane. - */ - public ToolPalette<GameObject, MapArchObject, Archetype, CMapViewBasic> getToolSelectorPane() { - return toolPalette; - } - - /** {@inheritDoc} */ - public void selectArchetype(final Archetype archetype) { - moveArchetypeChooserToFront(); - archetypeChooserControl.selectArchetype(archetype); - } - } // class ObjectChooser Modified: trunk/daimonin/src/daieditor/messages.properties =================================================================== --- trunk/daimonin/src/daieditor/messages.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/daimonin/src/daieditor/messages.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -446,12 +446,6 @@ editPopup.text=Edit Archetype -################ -# Object Chooser -objectChooser.archetypesTabTitle=Archetypes -objectChooser.pickmapsTabTitle=Pickmaps - - ####################### # Various Log Messages logExitWithExit=Exiting with System.exit(). Modified: trunk/daimonin/src/daieditor/messages_de.properties =================================================================== --- trunk/daimonin/src/daieditor/messages_de.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/daimonin/src/daieditor/messages_de.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -406,9 +406,3 @@ #################### # Archetype Chooser editPopup.text=Archetyp bearbeiten - - -################ -# Object Chooser -objectChooser.archetypesTabTitle=Archetypen -objectChooser.pickmapsTabTitle=Pickmaps Modified: trunk/daimonin/src/daieditor/messages_fr.properties =================================================================== --- trunk/daimonin/src/daieditor/messages_fr.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/daimonin/src/daieditor/messages_fr.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -400,9 +400,3 @@ #################### # Archetype Chooser #editPopup.text= - - -################ -# Object Chooser -objectChooser.archetypesTabTitle=Arches -#objectChooser.pickmapsTabTitle= Modified: trunk/daimonin/src/daieditor/messages_sv.properties =================================================================== --- trunk/daimonin/src/daieditor/messages_sv.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/daimonin/src/daieditor/messages_sv.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -401,9 +401,3 @@ #################### # Archetype Chooser #editPopup.text= - - -################ -# Object Chooser -#objectChooser.archetypesTabTitle= -#objectChooser.pickmapsTabTitle= Modified: trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java =================================================================== --- trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java 2008-07-15 19:34:00 UTC (rev 4345) @@ -21,15 +21,26 @@ import java.awt.BorderLayout; import java.awt.Point; +import java.util.List; import javax.swing.JMenu; import javax.swing.JPanel; +import javax.swing.JSplitPane; +import javax.swing.JTabbedPane; +import javax.swing.SwingConstants; +import net.sf.gridarta.MainControl; +import net.sf.gridarta.MapManager; import net.sf.gridarta.gameobject.Archetype; import net.sf.gridarta.gameobject.GameObject; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; +import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserListener; import net.sf.gridarta.gui.map.MapViewBasic; +import net.sf.gridarta.gui.map.tools.ToolPalette; import net.sf.gridarta.gui.pickmapchooser.PickmapChooserControl; +import net.sf.gridarta.gui.pickmapchooser.PickmapChooserListener; +import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; import net.sf.gridarta.map.MapArchObject; import net.sf.gridarta.map.MapControl; +import net.sf.japi.swing.ActionFactory; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -39,13 +50,37 @@ */ public abstract class AbstractObjectChooser<G extends GameObject<G, A, R>, A extends MapArchObject<A>, R extends Archetype<G, A, R>, V extends MapViewBasic<G, A, R, V>> extends JPanel implements ObjectChooser<G, A, R, V> { + /** Action Factory. */ + private static final ActionFactory ACTION_FACTORY = ActionFactory.getFactory("net.sf.gridarta"); + /** The archetype chooser control. */ protected final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl; /** The archetype chooser control. */ protected final PickmapChooserControl<G, A, R, V> pickmapChooserControl; + /** ToolSelector of this subview. */ + private final ToolPalette<G, A, R, V> toolPalette; + + /** Panel holding both archlist and pickmaps. */ + private final JTabbedPane archAndPickPane = new JTabbedPane(SwingConstants.TOP); + + /** The data/view of selected objects in tab panel. */ + private final ObjectChoiceDisplay<G, A, R, V> objectChoiceDisplay; + /** + * The listener attached to {@link #pickmapChooserControl}. + */ + private final PickmapChooserListener pickmapChooserListener = new PickmapChooserListener() { + + /** {@inheritDoc} */ + public void activePickmapChanged() { + showObjectChooserQuickObject(null); + } + + }; + + /** * <code>true</code> if the PickmapChooser is active, <code>false</code> if * the Archetype Chooser is active. */ @@ -56,15 +91,42 @@ * @param archetypeChooserControl the archetype chooser control * @param pickmapChooserControl the pickmap chooser control */ - protected AbstractObjectChooser(@NotNull final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl, final PickmapChooserControl<G, A, R, V> pickmapChooserControl) { + protected AbstractObjectChooser(final MainControl<G, A, R, V> mainControl, @NotNull final SelectedSquareView<G, A, R, V> selectedSquareView, @NotNull final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl, @NotNull final MapManager<G, A, R, V> mapManager, @NotNull final PickmapChooserControl<G, A, R, V> pickmapChooserControl) { super(new BorderLayout()); this.archetypeChooserControl = archetypeChooserControl; this.pickmapChooserControl = pickmapChooserControl; + archetypeChooserControl.addArchetypeChooserListener(new ArchetypeChooserListener<G, A, R>() { + /** {@inheritDoc} */ + public void selectedArchetypeChanged(@NotNull final G archetype) { + showObjectChooserQuickObject(archetype); + } + + /** {@inheritDoc} */ + public void displayObjectNamesChanged(final boolean displayObjectNames) { + // ignore + } + }); + toolPalette = new ToolPalette<G, A, R, V>(mainControl, selectedSquareView, this); + + objectChoiceDisplay = new ObjectChoiceDisplay<G, A, R, V>(mainControl, this); + + // archAndPickPane is the panel containing both archpanel and pickmaps + archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.archetypesTabTitle"), archetypeChooserControl.getArchetypePanel()); + archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.pickmapsTabTitle"), pickmapChooserControl.getPickmapPanel()); + // this listener informs the mainview which panel is active: archlist or pickmaps? + archAndPickPane.addChangeListener(new ArchNPickChangeListener(this, archAndPickPane)); + + // TODO: introduce a tool registry + final JSplitPane splitPane = new GSplitPane(JSplitPane.VERTICAL_SPLIT, toolPalette, archAndPickPane); + splitPane.setContinuousLayout(true); + add(splitPane, BorderLayout.CENTER); + add(objectChoiceDisplay, BorderLayout.SOUTH); } /** {@inheritDoc} */ public void setPickmapActive(final boolean pickmapActive) { this.pickmapActive = pickmapActive; + pickmapChooserControl.setActive(pickmapActive); } /** {@inheritDoc} */ @@ -101,4 +163,45 @@ return newObject; } + /** {@inheritDoc} */ + public void moveArchetypeChooserToFront() { + archAndPickPane.setSelectedIndex(0); + } + + /** {@inheritDoc} */ + public void movePickmapChooserToFront() { + archAndPickPane.setSelectedIndex(1); + } + + /** {@inheritDoc} */ + public void showObjectChooserQuickObject(@Nullable final G gameObject) { + objectChoiceDisplay.showObjectChooserQuickObject(gameObject); + } + + /** {@inheritDoc} */ + @Nullable + public G getObjectChooserHighlight() { + return isPickmapActive() ? pickmapChooserControl.getSelection() : archetypeChooserControl.getSelection(); + } + + /** {@inheritDoc} */ + @NotNull + public List<G> getObjectChooserSelection() { + return isPickmapActive() ? pickmapChooserControl.getSelections() : archetypeChooserControl.getSelections(); + } + + /** + * Returns the tool selector pane. + * @return The tool selector pane. + */ + public ToolPalette<G, A, R, V> getToolSelectorPane() { + return toolPalette; + } + + /** {@inheritDoc} */ + public void selectArchetype(final R archetype) { + moveArchetypeChooserToFront(); + archetypeChooserControl.selectArchetype(archetype); + } + } // class AbstractObjectChooser Modified: trunk/src/app/net/sf/gridarta/messages.properties =================================================================== --- trunk/src/app/net/sf/gridarta/messages.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/src/app/net/sf/gridarta/messages.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -972,3 +972,9 @@ updateProgress=Update in progress updateActiveVersionUnavailable.title=Update warning updateActiveVersionUnavailable.message=I was unable to determine my version.\nI will assume that the update is newer than your current version. + + +################ +# Object Chooser +objectChooser.archetypesTabTitle=Archetypes +objectChooser.pickmapsTabTitle=Pickmaps Modified: trunk/src/app/net/sf/gridarta/messages_de.properties =================================================================== --- trunk/src/app/net/sf/gridarta/messages_de.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/src/app/net/sf/gridarta/messages_de.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -834,3 +834,9 @@ updateProgress=Aktualisierung wird durchgef\xFChrt updateActiveVersionUnavailable.title=Warnung updateActiveVersionUnavailable.message=Die aktuelle Editor-Version konnte nicht ermittelt werden.\nDas verf\xFCgbare Update wird installiert. + + +################ +# Object Chooser +objectChooser.archetypesTabTitle=Archetypen +objectChooser.pickmapsTabTitle=Pickmaps Modified: trunk/src/app/net/sf/gridarta/messages_fr.properties =================================================================== --- trunk/src/app/net/sf/gridarta/messages_fr.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/src/app/net/sf/gridarta/messages_fr.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -833,3 +833,9 @@ #updateProgress= #updateActiveVersionUnavailable.title= #updateActiveVersionUnavailable.message= + + +################ +# Object Chooser +objectChooser.archetypesTabTitle=Arches +#objectChooser.pickmapsTabTitle= Modified: trunk/src/app/net/sf/gridarta/messages_sv.properties =================================================================== --- trunk/src/app/net/sf/gridarta/messages_sv.properties 2008-07-15 19:27:30 UTC (rev 4344) +++ trunk/src/app/net/sf/gridarta/messages_sv.properties 2008-07-15 19:34:00 UTC (rev 4345) @@ -837,3 +837,9 @@ updateProgress=Uppdatering p\xE5g\xE5r updateActiveVersionUnavailable.title=Uppdateringsvarning updateActiveVersionUnavailable.message=Jag kunde inte best\xE4mma min nuvarande version.\nJag kommer att anta att uppdateringen \xE4r nyare \xE4n den nuvarande installationen. + + +################ +# Object Chooser +#objectChooser.archetypesTabTitle= +#objectChooser.pickmapsTabTitle= This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <aki...@us...> - 2008-07-15 19:48:33
|
Revision: 4346 http://gridarta.svn.sourceforge.net/gridarta/?rev=4346&view=rev Author: akirschbaum Date: 2008-07-15 12:48:30 -0700 (Tue, 15 Jul 2008) Log Message: ----------- Move ObjectChooser to common code base. Modified Paths: -------------- trunk/crossfire/src/cfeditor/CMainControl.java trunk/crossfire/src/cfeditor/CrossfireObjectsFactory.java trunk/daimonin/src/daieditor/CMainControl.java trunk/daimonin/src/daieditor/DaimoninObjectsFactory.java trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java Removed Paths: ------------- trunk/crossfire/src/cfeditor/gui/ObjectChooser.java trunk/daimonin/src/daieditor/gui/ObjectChooser.java Modified: trunk/crossfire/src/cfeditor/CMainControl.java =================================================================== --- trunk/crossfire/src/cfeditor/CMainControl.java 2008-07-15 19:34:00 UTC (rev 4345) +++ trunk/crossfire/src/cfeditor/CMainControl.java 2008-07-15 19:48:30 UTC (rev 4346) @@ -28,7 +28,6 @@ import cfeditor.gameobject.face.FaceObjects; import cfeditor.gameobject.scripts.ScriptArchUtils; import cfeditor.gui.GameObjectAttributesPanel; -import cfeditor.gui.ObjectChooser; import cfeditor.gui.gameobjectattributesdialog.GameObjectAttributesDialogFactory; import cfeditor.gui.map.CMapViewBasic; import cfeditor.gui.prefs.GUIPrefs; @@ -63,12 +62,14 @@ import net.sf.gridarta.gameobject.match.GameObjectMatchersInstance; import net.sf.gridarta.gameobject.scripts.AbstractScriptArchEditor; import net.sf.gridarta.gui.About; +import net.sf.gridarta.gui.AbstractObjectChooser; import net.sf.gridarta.gui.HideFileFilterProxy; import net.sf.gridarta.gui.MainActions; import net.sf.gridarta.gui.MainView; import net.sf.gridarta.gui.MapFileFilter; import net.sf.gridarta.gui.MapManagerActions; import net.sf.gridarta.gui.MapPreview; +import net.sf.gridarta.gui.ObjectChooser; import net.sf.gridarta.gui.RecentManager; import net.sf.gridarta.gui.SystemIcons; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; @@ -156,7 +157,7 @@ private final MapActions mapActions; /** The object chooser. */ - private final ObjectChooser objectChooser; + private final AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> objectChooser; /** The pickmap chooser control. */ private final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl; @@ -243,7 +244,7 @@ newMapDialogFactory = new NewMapDialogFactory<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPSIZE, 0, false, false, IGUIConstants.DEF_PICKMAP_WIDTH, IGUIConstants.DEF_PICKMAP_HEIGHT); pickmapChooserControl = new PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(newMapDialogFactory, this, new File(globalSettings.getMapDir(), IGUIConstants.PICKMAP_DIR), mapManager); newMapDialogFactory.setPickmapChooserControl(pickmapChooserControl); - objectChooser = new ObjectChooser(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); + objectChooser = new AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); mainActions = new MainActions<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, pickmapChooserControl, animationObjects, ACTION_FACTORY, faceObjects, objectChooser); getGridartaObjectsFactory().init(faceObjects, objectChooser, archetypeChooserControl, pickmapChooserControl, selectedSquareView); mainView = new MainView<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, objectChooser, getMapManager(), ACTION_FACTORY, mapManagerActions.getCloseAllAction(), faceObjects); @@ -859,7 +860,7 @@ } /** {@inheritDoc} */ - public ObjectChooser getObjectChooser() { + public ObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> getObjectChooser() { return objectChooser; } Modified: trunk/crossfire/src/cfeditor/CrossfireObjectsFactory.java =================================================================== --- trunk/crossfire/src/cfeditor/CrossfireObjectsFactory.java 2008-07-15 19:34:00 UTC (rev 4345) +++ trunk/crossfire/src/cfeditor/CrossfireObjectsFactory.java 2008-07-15 19:48:30 UTC (rev 4346) @@ -38,6 +38,7 @@ import net.sf.gridarta.gameobject.ArchetypeSet; import net.sf.gridarta.gameobject.face.FaceObjects; import net.sf.gridarta.gameobject.match.GameObjectMatchersInstance; +import net.sf.gridarta.gui.AbstractObjectChooser; import net.sf.gridarta.gui.ObjectChooser; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; import net.sf.gridarta.gui.map.LevelRenderer; @@ -142,7 +143,7 @@ /** {@inheritDoc} */ @NotNull public MapView<GameObject, MapArchObject, Archetype, CMapViewBasic> newMapView(@NotNull final MapControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mapControl, @Nullable final Point viewPosition, final int viewCounter) { - return new MapView<GameObject, MapArchObject, Archetype, CMapViewBasic>((MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic>) (MainControl) AbstractMainControl.getInstance(), mapControl, viewCounter, new CMapViewBasic(CMainControl.getInstance(), mapControl, viewPosition, faceObjects, pickmapChooserControl, ((cfeditor.gui.ObjectChooser) objectChooser).getToolSelectorPane(), 32, 32, selectedSquareView), ACTION_FACTORY); + return new MapView<GameObject, MapArchObject, Archetype, CMapViewBasic>((MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic>) (MainControl) AbstractMainControl.getInstance(), mapControl, viewCounter, new CMapViewBasic(CMainControl.getInstance(), mapControl, viewPosition, faceObjects, pickmapChooserControl, ((AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>) objectChooser).getToolSelectorPane(), 32, 32, selectedSquareView), ACTION_FACTORY); } /** {@inheritDoc} */ Deleted: trunk/crossfire/src/cfeditor/gui/ObjectChooser.java =================================================================== --- trunk/crossfire/src/cfeditor/gui/ObjectChooser.java 2008-07-15 19:34:00 UTC (rev 4345) +++ trunk/crossfire/src/cfeditor/gui/ObjectChooser.java 2008-07-15 19:48:30 UTC (rev 4346) @@ -1,58 +0,0 @@ -/* - * Gridarta MMORPG map editor for Crossfire, Daimonin and similar games. - * Copyright (C) 2000-2007 The Gridarta Developers. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - */ - -package cfeditor.gui; - -import cfeditor.gameobject.Archetype; -import cfeditor.gameobject.GameObject; -import cfeditor.gui.map.CMapViewBasic; -import cfeditor.map.MapArchObject; -import net.sf.gridarta.MainControl; -import net.sf.gridarta.MapManager; -import net.sf.gridarta.gui.AbstractObjectChooser; -import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; -import net.sf.gridarta.gui.pickmapchooser.PickmapChooserControl; -import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; -import org.jetbrains.annotations.NotNull; - -/** - * The <code>ObjectChooser</code> holds the tile palette. - * @author <a href="mailto:mic...@no...">Michael Toennies</a> - * @author <a href="mailto:and...@gm...">Andreas Vogl</a> - * @author <a href="mailto:ch...@ri...">Christian Hujer</a> - * @author Andreas Kirschbaum - */ -public final class ObjectChooser extends AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> implements net.sf.gridarta.gui.ObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> { - - /** Serial Version UID. */ - private static final long serialVersionUID = 1L; - - /** - * Build Panel. - * @param mainControl the main control - * @param selectedSquareView the selected square view - * @param archetypeChooserControl the archetype chooser control - * @param mapManager the map manager instance - * @param pickmapChooserControl the pickmap chooser control - */ - public ObjectChooser(final MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mainControl, @NotNull final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView, @NotNull final ArchetypeChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> archetypeChooserControl, @NotNull final MapManager<GameObject, MapArchObject, Archetype, CMapViewBasic> mapManager, @NotNull final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl) { - super(mainControl, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); - } - -} // class ObjectChooser Modified: trunk/daimonin/src/daieditor/CMainControl.java =================================================================== --- trunk/daimonin/src/daieditor/CMainControl.java 2008-07-15 19:34:00 UTC (rev 4345) +++ trunk/daimonin/src/daieditor/CMainControl.java 2008-07-15 19:48:30 UTC (rev 4346) @@ -27,7 +27,6 @@ import daieditor.gameobject.face.FaceObjects; import daieditor.gameobject.scripts.ScriptArchUtils; import daieditor.gui.GameObjectAttributesPanel; -import daieditor.gui.ObjectChooser; import daieditor.gui.gameobjectattributesdialog.GameObjectAttributesDialogFactory; import daieditor.gui.map.CMapViewBasic; import daieditor.gui.prefs.AppPrefs; @@ -69,6 +68,7 @@ import net.sf.gridarta.gameobject.match.ViewGameObjectMatcherManager; import net.sf.gridarta.gameobject.scripts.AbstractScriptArchEditor; import net.sf.gridarta.gui.About; +import net.sf.gridarta.gui.AbstractObjectChooser; import net.sf.gridarta.gui.GUIUtils; import net.sf.gridarta.gui.HideFileFilterProxy; import net.sf.gridarta.gui.MainActions; @@ -76,6 +76,7 @@ import net.sf.gridarta.gui.MapFileFilter; import net.sf.gridarta.gui.MapManagerActions; import net.sf.gridarta.gui.MapPreview; +import net.sf.gridarta.gui.ObjectChooser; import net.sf.gridarta.gui.RecentManager; import net.sf.gridarta.gui.SystemIcons; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; @@ -192,7 +193,7 @@ private final MapActions mapActions; /** The object chooser. */ - private final ObjectChooser objectChooser; + private final AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> objectChooser; /** The pickmap chooser control. */ private final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl; @@ -296,7 +297,7 @@ newMapDialogFactory = new NewMapDialogFactory<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPDIFFICULTY, true, true, IGUIConstants.DEF_PICKMAP_WIDTH, IGUIConstants.DEF_PICKMAP_HEIGHT); pickmapChooserControl = new PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(newMapDialogFactory, this, new File(globalSettings.getArchDefaultFolder(), IGUIConstants.PICKMAP_DIR), mapManager); newMapDialogFactory.setPickmapChooserControl(pickmapChooserControl); - objectChooser = new ObjectChooser(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); + objectChooser = new AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); mainActions = new MainActions<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, pickmapChooserControl, animationObjects, ACTION_FACTORY, faceObjects, objectChooser); getGridartaObjectsFactory().init(faceObjects, objectChooser, archetypeChooserControl, pickmapChooserControl, selectedSquareView); mainView = new MainView<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, objectChooser, getMapManager(), ACTION_FACTORY, mapManagerActions.getCloseAllAction(), faceObjects); @@ -1026,7 +1027,7 @@ } /** {@inheritDoc} */ - public ObjectChooser getObjectChooser() { + public ObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> getObjectChooser() { return objectChooser; } Modified: trunk/daimonin/src/daieditor/DaimoninObjectsFactory.java =================================================================== --- trunk/daimonin/src/daieditor/DaimoninObjectsFactory.java 2008-07-15 19:34:00 UTC (rev 4345) +++ trunk/daimonin/src/daieditor/DaimoninObjectsFactory.java 2008-07-15 19:48:30 UTC (rev 4346) @@ -38,6 +38,7 @@ import net.sf.gridarta.gameobject.ArchetypeSet; import net.sf.gridarta.gameobject.face.FaceObjects; import net.sf.gridarta.gameobject.match.GameObjectMatchersInstance; +import net.sf.gridarta.gui.AbstractObjectChooser; import net.sf.gridarta.gui.ObjectChooser; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; import net.sf.gridarta.gui.map.LevelRenderer; @@ -144,7 +145,7 @@ /** {@inheritDoc} */ @NotNull public MapView<GameObject, MapArchObject, Archetype, CMapViewBasic> newMapView(@NotNull final MapControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mapControl, @Nullable final Point viewPosition, final int viewCounter) { - return new MapView<GameObject, MapArchObject, Archetype, CMapViewBasic>((MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic>) (MainControl) AbstractMainControl.getInstance(), mapControl, viewCounter, new CMapViewBasic(CMainControl.getInstance(), mapControl, viewPosition, faceObjects, pickmapChooserControl, ((daieditor.gui.ObjectChooser) objectChooser).getToolSelectorPane(), IGUIConstants.TILE_ISO_XLEN, IGUIConstants.TILE_ISO_YLEN, selectedSquareView), ACTION_FACTORY); + return new MapView<GameObject, MapArchObject, Archetype, CMapViewBasic>((MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic>) (MainControl) AbstractMainControl.getInstance(), mapControl, viewCounter, new CMapViewBasic(CMainControl.getInstance(), mapControl, viewPosition, faceObjects, pickmapChooserControl, ((AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>) objectChooser).getToolSelectorPane(), IGUIConstants.TILE_ISO_XLEN, IGUIConstants.TILE_ISO_YLEN, selectedSquareView), ACTION_FACTORY); } /** {@inheritDoc} */ Deleted: trunk/daimonin/src/daieditor/gui/ObjectChooser.java =================================================================== --- trunk/daimonin/src/daieditor/gui/ObjectChooser.java 2008-07-15 19:34:00 UTC (rev 4345) +++ trunk/daimonin/src/daieditor/gui/ObjectChooser.java 2008-07-15 19:48:30 UTC (rev 4346) @@ -1,58 +0,0 @@ -/* - * Gridarta MMORPG map editor for Crossfire, Daimonin and similar games. - * Copyright (C) 2000-2007 The Gridarta Developers. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - */ - -package daieditor.gui; - -import daieditor.gameobject.Archetype; -import daieditor.gameobject.GameObject; -import daieditor.gui.map.CMapViewBasic; -import daieditor.map.MapArchObject; -import net.sf.gridarta.MainControl; -import net.sf.gridarta.MapManager; -import net.sf.gridarta.gui.AbstractObjectChooser; -import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; -import net.sf.gridarta.gui.pickmapchooser.PickmapChooserControl; -import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; -import org.jetbrains.annotations.NotNull; - -/** - * The <code>ObjectChooser</code> holds the tile palette. - * @author <a href="mailto:mic...@no...">Michael Toennies</a> - * @author <a href="mailto:and...@gm...">Andreas Vogl</a> - * @author <a href="mailto:ch...@ri...">Christian Hujer</a> - * @author Andreas Kirschbaum - */ -public final class ObjectChooser extends AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> implements net.sf.gridarta.gui.ObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> { - - /** Serial Version UID. */ - private static final long serialVersionUID = 1L; - - /** - * Build Panel. - * @param mainControl the main control - * @param selectedSquareView the selected square view - * @param archetypeChooserControl the archetype chooser control - * @param mapManager the map manager instance - * @param pickmapChooserControl the pickmap chooser control - */ - public ObjectChooser(final MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mainControl, @NotNull final SelectedSquareView<GameObject, MapArchObject, Archetype, CMapViewBasic> selectedSquareView, @NotNull final ArchetypeChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> archetypeChooserControl, @NotNull final MapManager<GameObject, MapArchObject, Archetype, CMapViewBasic> mapManager, @NotNull final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl) { - super(mainControl, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); - } - -} // class ObjectChooser Modified: trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java =================================================================== --- trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java 2008-07-15 19:34:00 UTC (rev 4345) +++ trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java 2008-07-15 19:48:30 UTC (rev 4346) @@ -48,11 +48,14 @@ * Abstract base class for the Object Chooser. * @author Andreas Kirschbaum */ -public abstract class AbstractObjectChooser<G extends GameObject<G, A, R>, A extends MapArchObject<A>, R extends Archetype<G, A, R>, V extends MapViewBasic<G, A, R, V>> extends JPanel implements ObjectChooser<G, A, R, V> { +public class AbstractObjectChooser<G extends GameObject<G, A, R>, A extends MapArchObject<A>, R extends Archetype<G, A, R>, V extends MapViewBasic<G, A, R, V>> extends JPanel implements ObjectChooser<G, A, R, V> { /** Action Factory. */ private static final ActionFactory ACTION_FACTORY = ActionFactory.getFactory("net.sf.gridarta"); + /** The serial version UID. */ + private static final long serialVersionUID = 1; + /** The archetype chooser control. */ protected final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl; @@ -91,7 +94,7 @@ * @param archetypeChooserControl the archetype chooser control * @param pickmapChooserControl the pickmap chooser control */ - protected AbstractObjectChooser(final MainControl<G, A, R, V> mainControl, @NotNull final SelectedSquareView<G, A, R, V> selectedSquareView, @NotNull final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl, @NotNull final MapManager<G, A, R, V> mapManager, @NotNull final PickmapChooserControl<G, A, R, V> pickmapChooserControl) { + public AbstractObjectChooser(final MainControl<G, A, R, V> mainControl, @NotNull final SelectedSquareView<G, A, R, V> selectedSquareView, @NotNull final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl, @NotNull final MapManager<G, A, R, V> mapManager, @NotNull final PickmapChooserControl<G, A, R, V> pickmapChooserControl) { super(new BorderLayout()); this.archetypeChooserControl = archetypeChooserControl; this.pickmapChooserControl = pickmapChooserControl; This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <aki...@us...> - 2008-07-15 19:56:25
|
Revision: 4347 http://gridarta.svn.sourceforge.net/gridarta/?rev=4347&view=rev Author: akirschbaum Date: 2008-07-15 12:55:49 -0700 (Tue, 15 Jul 2008) Log Message: ----------- Rename AbstractObjectChooser to DefaultObjectChooser since it is not anymore abstract. Modified Paths: -------------- trunk/crossfire/src/cfeditor/CMainControl.java trunk/crossfire/src/cfeditor/CrossfireObjectsFactory.java trunk/daimonin/src/daieditor/CMainControl.java trunk/daimonin/src/daieditor/DaimoninObjectsFactory.java trunk/src/app/net/sf/gridarta/gui/MainView.java Added Paths: ----------- trunk/src/app/net/sf/gridarta/gui/DefaultObjectChooser.java Removed Paths: ------------- trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java Modified: trunk/crossfire/src/cfeditor/CMainControl.java =================================================================== --- trunk/crossfire/src/cfeditor/CMainControl.java 2008-07-15 19:48:30 UTC (rev 4346) +++ trunk/crossfire/src/cfeditor/CMainControl.java 2008-07-15 19:55:49 UTC (rev 4347) @@ -62,7 +62,7 @@ import net.sf.gridarta.gameobject.match.GameObjectMatchersInstance; import net.sf.gridarta.gameobject.scripts.AbstractScriptArchEditor; import net.sf.gridarta.gui.About; -import net.sf.gridarta.gui.AbstractObjectChooser; +import net.sf.gridarta.gui.DefaultObjectChooser; import net.sf.gridarta.gui.HideFileFilterProxy; import net.sf.gridarta.gui.MainActions; import net.sf.gridarta.gui.MainView; @@ -157,7 +157,7 @@ private final MapActions mapActions; /** The object chooser. */ - private final AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> objectChooser; + private final DefaultObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> objectChooser; /** The pickmap chooser control. */ private final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl; @@ -244,7 +244,7 @@ newMapDialogFactory = new NewMapDialogFactory<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPSIZE, 0, false, false, IGUIConstants.DEF_PICKMAP_WIDTH, IGUIConstants.DEF_PICKMAP_HEIGHT); pickmapChooserControl = new PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(newMapDialogFactory, this, new File(globalSettings.getMapDir(), IGUIConstants.PICKMAP_DIR), mapManager); newMapDialogFactory.setPickmapChooserControl(pickmapChooserControl); - objectChooser = new AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); + objectChooser = new DefaultObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); mainActions = new MainActions<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, pickmapChooserControl, animationObjects, ACTION_FACTORY, faceObjects, objectChooser); getGridartaObjectsFactory().init(faceObjects, objectChooser, archetypeChooserControl, pickmapChooserControl, selectedSquareView); mainView = new MainView<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, objectChooser, getMapManager(), ACTION_FACTORY, mapManagerActions.getCloseAllAction(), faceObjects); Modified: trunk/crossfire/src/cfeditor/CrossfireObjectsFactory.java =================================================================== --- trunk/crossfire/src/cfeditor/CrossfireObjectsFactory.java 2008-07-15 19:48:30 UTC (rev 4346) +++ trunk/crossfire/src/cfeditor/CrossfireObjectsFactory.java 2008-07-15 19:55:49 UTC (rev 4347) @@ -38,7 +38,7 @@ import net.sf.gridarta.gameobject.ArchetypeSet; import net.sf.gridarta.gameobject.face.FaceObjects; import net.sf.gridarta.gameobject.match.GameObjectMatchersInstance; -import net.sf.gridarta.gui.AbstractObjectChooser; +import net.sf.gridarta.gui.DefaultObjectChooser; import net.sf.gridarta.gui.ObjectChooser; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; import net.sf.gridarta.gui.map.LevelRenderer; @@ -143,7 +143,7 @@ /** {@inheritDoc} */ @NotNull public MapView<GameObject, MapArchObject, Archetype, CMapViewBasic> newMapView(@NotNull final MapControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mapControl, @Nullable final Point viewPosition, final int viewCounter) { - return new MapView<GameObject, MapArchObject, Archetype, CMapViewBasic>((MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic>) (MainControl) AbstractMainControl.getInstance(), mapControl, viewCounter, new CMapViewBasic(CMainControl.getInstance(), mapControl, viewPosition, faceObjects, pickmapChooserControl, ((AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>) objectChooser).getToolSelectorPane(), 32, 32, selectedSquareView), ACTION_FACTORY); + return new MapView<GameObject, MapArchObject, Archetype, CMapViewBasic>((MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic>) (MainControl) AbstractMainControl.getInstance(), mapControl, viewCounter, new CMapViewBasic(CMainControl.getInstance(), mapControl, viewPosition, faceObjects, pickmapChooserControl, ((DefaultObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>) objectChooser).getToolSelectorPane(), 32, 32, selectedSquareView), ACTION_FACTORY); } /** {@inheritDoc} */ Modified: trunk/daimonin/src/daieditor/CMainControl.java =================================================================== --- trunk/daimonin/src/daieditor/CMainControl.java 2008-07-15 19:48:30 UTC (rev 4346) +++ trunk/daimonin/src/daieditor/CMainControl.java 2008-07-15 19:55:49 UTC (rev 4347) @@ -68,7 +68,7 @@ import net.sf.gridarta.gameobject.match.ViewGameObjectMatcherManager; import net.sf.gridarta.gameobject.scripts.AbstractScriptArchEditor; import net.sf.gridarta.gui.About; -import net.sf.gridarta.gui.AbstractObjectChooser; +import net.sf.gridarta.gui.DefaultObjectChooser; import net.sf.gridarta.gui.GUIUtils; import net.sf.gridarta.gui.HideFileFilterProxy; import net.sf.gridarta.gui.MainActions; @@ -193,7 +193,7 @@ private final MapActions mapActions; /** The object chooser. */ - private final AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> objectChooser; + private final DefaultObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic> objectChooser; /** The pickmap chooser control. */ private final PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic> pickmapChooserControl; @@ -297,7 +297,7 @@ newMapDialogFactory = new NewMapDialogFactory<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPSIZE, IGUIConstants.DEF_MAPDIFFICULTY, true, true, IGUIConstants.DEF_PICKMAP_WIDTH, IGUIConstants.DEF_PICKMAP_HEIGHT); pickmapChooserControl = new PickmapChooserControl<GameObject, MapArchObject, Archetype, CMapViewBasic>(newMapDialogFactory, this, new File(globalSettings.getArchDefaultFolder(), IGUIConstants.PICKMAP_DIR), mapManager); newMapDialogFactory.setPickmapChooserControl(pickmapChooserControl); - objectChooser = new AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); + objectChooser = new DefaultObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, selectedSquareView, archetypeChooserControl, mapManager, pickmapChooserControl); mainActions = new MainActions<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, pickmapChooserControl, animationObjects, ACTION_FACTORY, faceObjects, objectChooser); getGridartaObjectsFactory().init(faceObjects, objectChooser, archetypeChooserControl, pickmapChooserControl, selectedSquareView); mainView = new MainView<GameObject, MapArchObject, Archetype, CMapViewBasic>(this, objectChooser, getMapManager(), ACTION_FACTORY, mapManagerActions.getCloseAllAction(), faceObjects); Modified: trunk/daimonin/src/daieditor/DaimoninObjectsFactory.java =================================================================== --- trunk/daimonin/src/daieditor/DaimoninObjectsFactory.java 2008-07-15 19:48:30 UTC (rev 4346) +++ trunk/daimonin/src/daieditor/DaimoninObjectsFactory.java 2008-07-15 19:55:49 UTC (rev 4347) @@ -38,7 +38,7 @@ import net.sf.gridarta.gameobject.ArchetypeSet; import net.sf.gridarta.gameobject.face.FaceObjects; import net.sf.gridarta.gameobject.match.GameObjectMatchersInstance; -import net.sf.gridarta.gui.AbstractObjectChooser; +import net.sf.gridarta.gui.DefaultObjectChooser; import net.sf.gridarta.gui.ObjectChooser; import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; import net.sf.gridarta.gui.map.LevelRenderer; @@ -145,7 +145,7 @@ /** {@inheritDoc} */ @NotNull public MapView<GameObject, MapArchObject, Archetype, CMapViewBasic> newMapView(@NotNull final MapControl<GameObject, MapArchObject, Archetype, CMapViewBasic> mapControl, @Nullable final Point viewPosition, final int viewCounter) { - return new MapView<GameObject, MapArchObject, Archetype, CMapViewBasic>((MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic>) (MainControl) AbstractMainControl.getInstance(), mapControl, viewCounter, new CMapViewBasic(CMainControl.getInstance(), mapControl, viewPosition, faceObjects, pickmapChooserControl, ((AbstractObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>) objectChooser).getToolSelectorPane(), IGUIConstants.TILE_ISO_XLEN, IGUIConstants.TILE_ISO_YLEN, selectedSquareView), ACTION_FACTORY); + return new MapView<GameObject, MapArchObject, Archetype, CMapViewBasic>((MainControl<GameObject, MapArchObject, Archetype, CMapViewBasic>) (MainControl) AbstractMainControl.getInstance(), mapControl, viewCounter, new CMapViewBasic(CMainControl.getInstance(), mapControl, viewPosition, faceObjects, pickmapChooserControl, ((DefaultObjectChooser<GameObject, MapArchObject, Archetype, CMapViewBasic>) objectChooser).getToolSelectorPane(), IGUIConstants.TILE_ISO_XLEN, IGUIConstants.TILE_ISO_YLEN, selectedSquareView), ACTION_FACTORY); } /** {@inheritDoc} */ Deleted: trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java =================================================================== --- trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java 2008-07-15 19:48:30 UTC (rev 4346) +++ trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java 2008-07-15 19:55:49 UTC (rev 4347) @@ -1,210 +0,0 @@ -/* - * Gridarta MMORPG map editor for Crossfire, Daimonin and similar games. - * Copyright (C) 2000-2007 The Gridarta Developers. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - */ - -package net.sf.gridarta.gui; - -import java.awt.BorderLayout; -import java.awt.Point; -import java.util.List; -import javax.swing.JMenu; -import javax.swing.JPanel; -import javax.swing.JSplitPane; -import javax.swing.JTabbedPane; -import javax.swing.SwingConstants; -import net.sf.gridarta.MainControl; -import net.sf.gridarta.MapManager; -import net.sf.gridarta.gameobject.Archetype; -import net.sf.gridarta.gameobject.GameObject; -import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; -import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserListener; -import net.sf.gridarta.gui.map.MapViewBasic; -import net.sf.gridarta.gui.map.tools.ToolPalette; -import net.sf.gridarta.gui.pickmapchooser.PickmapChooserControl; -import net.sf.gridarta.gui.pickmapchooser.PickmapChooserListener; -import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; -import net.sf.gridarta.map.MapArchObject; -import net.sf.gridarta.map.MapControl; -import net.sf.japi.swing.ActionFactory; -import org.jetbrains.annotations.NotNull; -import org.jetbrains.annotations.Nullable; - -/** - * Abstract base class for the Object Chooser. - * @author Andreas Kirschbaum - */ -public class AbstractObjectChooser<G extends GameObject<G, A, R>, A extends MapArchObject<A>, R extends Archetype<G, A, R>, V extends MapViewBasic<G, A, R, V>> extends JPanel implements ObjectChooser<G, A, R, V> { - - /** Action Factory. */ - private static final ActionFactory ACTION_FACTORY = ActionFactory.getFactory("net.sf.gridarta"); - - /** The serial version UID. */ - private static final long serialVersionUID = 1; - - /** The archetype chooser control. */ - protected final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl; - - /** The archetype chooser control. */ - protected final PickmapChooserControl<G, A, R, V> pickmapChooserControl; - - /** ToolSelector of this subview. */ - private final ToolPalette<G, A, R, V> toolPalette; - - /** Panel holding both archlist and pickmaps. */ - private final JTabbedPane archAndPickPane = new JTabbedPane(SwingConstants.TOP); - - /** The data/view of selected objects in tab panel. */ - private final ObjectChoiceDisplay<G, A, R, V> objectChoiceDisplay; - - /** - * The listener attached to {@link #pickmapChooserControl}. - */ - private final PickmapChooserListener pickmapChooserListener = new PickmapChooserListener() { - - /** {@inheritDoc} */ - public void activePickmapChanged() { - showObjectChooserQuickObject(null); - } - - }; - - /** - * <code>true</code> if the PickmapChooser is active, <code>false</code> if - * the Archetype Chooser is active. - */ - private boolean pickmapActive = false; - - /** - * Creates a new instance. - * @param archetypeChooserControl the archetype chooser control - * @param pickmapChooserControl the pickmap chooser control - */ - public AbstractObjectChooser(final MainControl<G, A, R, V> mainControl, @NotNull final SelectedSquareView<G, A, R, V> selectedSquareView, @NotNull final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl, @NotNull final MapManager<G, A, R, V> mapManager, @NotNull final PickmapChooserControl<G, A, R, V> pickmapChooserControl) { - super(new BorderLayout()); - this.archetypeChooserControl = archetypeChooserControl; - this.pickmapChooserControl = pickmapChooserControl; - archetypeChooserControl.addArchetypeChooserListener(new ArchetypeChooserListener<G, A, R>() { - /** {@inheritDoc} */ - public void selectedArchetypeChanged(@NotNull final G archetype) { - showObjectChooserQuickObject(archetype); - } - - /** {@inheritDoc} */ - public void displayObjectNamesChanged(final boolean displayObjectNames) { - // ignore - } - }); - toolPalette = new ToolPalette<G, A, R, V>(mainControl, selectedSquareView, this); - - objectChoiceDisplay = new ObjectChoiceDisplay<G, A, R, V>(mainControl, this); - - // archAndPickPane is the panel containing both archpanel and pickmaps - archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.archetypesTabTitle"), archetypeChooserControl.getArchetypePanel()); - archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.pickmapsTabTitle"), pickmapChooserControl.getPickmapPanel()); - // this listener informs the mainview which panel is active: archlist or pickmaps? - archAndPickPane.addChangeListener(new ArchNPickChangeListener(this, archAndPickPane)); - - // TODO: introduce a tool registry - final JSplitPane splitPane = new GSplitPane(JSplitPane.VERTICAL_SPLIT, toolPalette, archAndPickPane); - splitPane.setContinuousLayout(true); - add(splitPane, BorderLayout.CENTER); - add(objectChoiceDisplay, BorderLayout.SOUTH); - } - - /** {@inheritDoc} */ - public void setPickmapActive(final boolean pickmapActive) { - this.pickmapActive = pickmapActive; - pickmapChooserControl.setActive(pickmapActive); - } - - /** {@inheritDoc} */ - public boolean isPickmapActive() { - return pickmapActive; - } - - /** {@inheritDoc} */ - public void setPickmapFoldersMenu(@Nullable final JMenu folderMenu) { - pickmapChooserControl.setPickmapFoldersMenu(folderMenu); - } - - /** {@inheritDoc} */ - @Nullable - public G insertSelectedObject(@NotNull final MapControl<G, A, R, V> mapControl, @NotNull final Point pos, final boolean allowMany) { - if (mapControl.isPickmap()) { - mapControl.insertMapArchToPickmap(pos); - return null; - } - - // this is the arch that would get inserted from pickmap, but it also could - // be a default arch (when pickmap has no selection) - final MapControl<G, A, R, V> activePickmap = pickmapChooserControl.getCurrentPickmap(); - final G newarch = activePickmap == null ? null : activePickmap.getMapViewFrame().getSelectedGameObject(); - - if (pickmapActive && (newarch == null || !newarch.isArchetype())) { - return mapControl.getMapModel().addArchToPickmap(pos, allowMany, newarch); - } - - // insert default arch from archlist: - mapControl.getMapModel().beginTransaction("Insert"); // TODO: I18N/L10N - final G newObject = mapControl.getMapModel().addArchToMap(archetypeChooserControl.getSelectedArch(), pos, allowMany, true, false); - mapControl.getMapModel().endTransaction(); - return newObject; - } - - /** {@inheritDoc} */ - public void moveArchetypeChooserToFront() { - archAndPickPane.setSelectedIndex(0); - } - - /** {@inheritDoc} */ - public void movePickmapChooserToFront() { - archAndPickPane.setSelectedIndex(1); - } - - /** {@inheritDoc} */ - public void showObjectChooserQuickObject(@Nullable final G gameObject) { - objectChoiceDisplay.showObjectChooserQuickObject(gameObject); - } - - /** {@inheritDoc} */ - @Nullable - public G getObjectChooserHighlight() { - return isPickmapActive() ? pickmapChooserControl.getSelection() : archetypeChooserControl.getSelection(); - } - - /** {@inheritDoc} */ - @NotNull - public List<G> getObjectChooserSelection() { - return isPickmapActive() ? pickmapChooserControl.getSelections() : archetypeChooserControl.getSelections(); - } - - /** - * Returns the tool selector pane. - * @return The tool selector pane. - */ - public ToolPalette<G, A, R, V> getToolSelectorPane() { - return toolPalette; - } - - /** {@inheritDoc} */ - public void selectArchetype(final R archetype) { - moveArchetypeChooserToFront(); - archetypeChooserControl.selectArchetype(archetype); - } - -} // class AbstractObjectChooser Copied: trunk/src/app/net/sf/gridarta/gui/DefaultObjectChooser.java (from rev 4346, trunk/src/app/net/sf/gridarta/gui/AbstractObjectChooser.java) =================================================================== --- trunk/src/app/net/sf/gridarta/gui/DefaultObjectChooser.java (rev 0) +++ trunk/src/app/net/sf/gridarta/gui/DefaultObjectChooser.java 2008-07-15 19:55:49 UTC (rev 4347) @@ -0,0 +1,210 @@ +/* + * Gridarta MMORPG map editor for Crossfire, Daimonin and similar games. + * Copyright (C) 2000-2007 The Gridarta Developers. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +package net.sf.gridarta.gui; + +import java.awt.BorderLayout; +import java.awt.Point; +import java.util.List; +import javax.swing.JMenu; +import javax.swing.JPanel; +import javax.swing.JSplitPane; +import javax.swing.JTabbedPane; +import javax.swing.SwingConstants; +import net.sf.gridarta.MainControl; +import net.sf.gridarta.MapManager; +import net.sf.gridarta.gameobject.Archetype; +import net.sf.gridarta.gameobject.GameObject; +import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserControl; +import net.sf.gridarta.gui.archetypechooser.ArchetypeChooserListener; +import net.sf.gridarta.gui.map.MapViewBasic; +import net.sf.gridarta.gui.map.tools.ToolPalette; +import net.sf.gridarta.gui.pickmapchooser.PickmapChooserControl; +import net.sf.gridarta.gui.pickmapchooser.PickmapChooserListener; +import net.sf.gridarta.gui.selectedsquare.SelectedSquareView; +import net.sf.gridarta.map.MapArchObject; +import net.sf.gridarta.map.MapControl; +import net.sf.japi.swing.ActionFactory; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +/** + * The object Chooser implementation. + * @author Andreas Kirschbaum + */ +public class DefaultObjectChooser<G extends GameObject<G, A, R>, A extends MapArchObject<A>, R extends Archetype<G, A, R>, V extends MapViewBasic<G, A, R, V>> extends JPanel implements ObjectChooser<G, A, R, V> { + + /** Action Factory. */ + private static final ActionFactory ACTION_FACTORY = ActionFactory.getFactory("net.sf.gridarta"); + + /** The serial version UID. */ + private static final long serialVersionUID = 1; + + /** The archetype chooser control. */ + protected final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl; + + /** The archetype chooser control. */ + protected final PickmapChooserControl<G, A, R, V> pickmapChooserControl; + + /** ToolSelector of this subview. */ + private final ToolPalette<G, A, R, V> toolPalette; + + /** Panel holding both archlist and pickmaps. */ + private final JTabbedPane archAndPickPane = new JTabbedPane(SwingConstants.TOP); + + /** The data/view of selected objects in tab panel. */ + private final ObjectChoiceDisplay<G, A, R, V> objectChoiceDisplay; + + /** + * The listener attached to {@link #pickmapChooserControl}. + */ + private final PickmapChooserListener pickmapChooserListener = new PickmapChooserListener() { + + /** {@inheritDoc} */ + public void activePickmapChanged() { + showObjectChooserQuickObject(null); + } + + }; + + /** + * <code>true</code> if the PickmapChooser is active, <code>false</code> if + * the Archetype Chooser is active. + */ + private boolean pickmapActive = false; + + /** + * Creates a new instance. + * @param archetypeChooserControl the archetype chooser control + * @param pickmapChooserControl the pickmap chooser control + */ + public DefaultObjectChooser(final MainControl<G, A, R, V> mainControl, @NotNull final SelectedSquareView<G, A, R, V> selectedSquareView, @NotNull final ArchetypeChooserControl<G, A, R, V> archetypeChooserControl, @NotNull final MapManager<G, A, R, V> mapManager, @NotNull final PickmapChooserControl<G, A, R, V> pickmapChooserControl) { + super(new BorderLayout()); + this.archetypeChooserControl = archetypeChooserControl; + this.pickmapChooserControl = pickmapChooserControl; + archetypeChooserControl.addArchetypeChooserListener(new ArchetypeChooserListener<G, A, R>() { + /** {@inheritDoc} */ + public void selectedArchetypeChanged(@NotNull final G archetype) { + showObjectChooserQuickObject(archetype); + } + + /** {@inheritDoc} */ + public void displayObjectNamesChanged(final boolean displayObjectNames) { + // ignore + } + }); + toolPalette = new ToolPalette<G, A, R, V>(mainControl, selectedSquareView, this); + + objectChoiceDisplay = new ObjectChoiceDisplay<G, A, R, V>(mainControl, this); + + // archAndPickPane is the panel containing both archpanel and pickmaps + archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.archetypesTabTitle"), archetypeChooserControl.getArchetypePanel()); + archAndPickPane.addTab(ACTION_FACTORY.getString("objectChooser.pickmapsTabTitle"), pickmapChooserControl.getPickmapPanel()); + // this listener informs the mainview which panel is active: archlist or pickmaps? + archAndPickPane.addChangeListener(new ArchNPickChangeListener(this, archAndPickPane)); + + // TODO: introduce a tool registry + final JSplitPane splitPane = new GSplitPane(JSplitPane.VERTICAL_SPLIT, toolPalette, archAndPickPane); + splitPane.setContinuousLayout(true); + add(splitPane, BorderLayout.CENTER); + add(objectChoiceDisplay, BorderLayout.SOUTH); + } + + /** {@inheritDoc} */ + public void setPickmapActive(final boolean pickmapActive) { + this.pickmapActive = pickmapActive; + pickmapChooserControl.setActive(pickmapActive); + } + + /** {@inheritDoc} */ + public boolean isPickmapActive() { + return pickmapActive; + } + + /** {@inheritDoc} */ + public void setPickmapFoldersMenu(@Nullable final JMenu folderMenu) { + pickmapChooserControl.setPickmapFoldersMenu(folderMenu); + } + + /** {@inheritDoc} */ + @Nullable + public G insertSelectedObject(@NotNull final MapControl<G, A, R, V> mapControl, @NotNull final Point pos, final boolean allowMany) { + if (mapControl.isPickmap()) { + mapControl.insertMapArchToPickmap(pos); + return null; + } + + // this is the arch that would get inserted from pickmap, but it also could + // be a default arch (when pickmap has no selection) + final MapControl<G, A, R, V> activePickmap = pickmapChooserControl.getCurrentPickmap(); + final G newarch = activePickmap == null ? null : activePickmap.getMapViewFrame().getSelectedGameObject(); + + if (pickmapActive && (newarch == null || !newarch.isArchetype())) { + return mapControl.getMapModel().addArchToPickmap(pos, allowMany, newarch); + } + + // insert default arch from archlist: + mapControl.getMapModel().beginTransaction("Insert"); // TODO: I18N/L10N + final G newObject = mapControl.getMapModel().addArchToMap(archetypeChooserControl.getSelectedArch(), pos, allowMany, true, false); + mapControl.getMapModel().endTransaction(); + return newObject; + } + + /** {@inheritDoc} */ + public void moveArchetypeChooserToFront() { + archAndPickPane.setSelectedIndex(0); + } + + /** {@inheritDoc} */ + public void movePickmapChooserToFront() { + archAndPickPane.setSelectedIndex(1); + } + + /** {@inheritDoc} */ + public void showObjectChooserQuickObject(@Nullable final G gameObject) { + objectChoiceDisplay.showObjectChooserQuickObject(gameObject); + } + + /** {@inheritDoc} */ + @Nullable + public G getObjectChooserHighlight() { + return isPickmapActive() ? pickmapChooserControl.getSelection() : archetypeChooserControl.getSelection(); + } + + /** {@inheritDoc} */ + @NotNull + public List<G> getObjectChooserSelection() { + return isPickmapActive() ? pickmapChooserControl.getSelections() : archetypeChooserControl.getSelections(); + } + + /** + * Returns the tool selector pane. + * @return The tool selector pane. + */ + public ToolPalette<G, A, R, V> getToolSelectorPane() { + return toolPalette; + } + + /** {@inheritDoc} */ + public void selectArchetype(final R archetype) { + moveArchetypeChooserToFront(); + archetypeChooserControl.selectArchetype(archetype); + } + +} // class AbstractObjectChooser Property changes on: trunk/src/app/net/sf/gridarta/gui/DefaultObjectChooser.java ___________________________________________________________________ Name: svn:mime-type + text/plain Name: svn:mergeinfo + Name: svn:eol-style + LF Modified: trunk/src/app/net/sf/gridarta/gui/MainView.java =================================================================== --- trunk/src/app/net/sf/gridarta/gui/MainView.java 2008-07-15 19:48:30 UTC (rev 4346) +++ trunk/src/app/net/sf/gridarta/gui/MainView.java 2008-07-15 19:55:49 UTC (rev 4347) @@ -153,7 +153,7 @@ private final ActionFactory actionFactory; /** The panel that contains the object chooser. */ - private final AbstractObjectChooser<G, A, R, V> objectChooser; + private final DefaultObjectChooser<G, A, R, V> objectChooser; /** All open level views. */ private final List<MapView<G, A, R, V>> mapViews = Collections.synchronizedList(new ArrayList<MapView<G, A, R, V>>()); @@ -239,7 +239,7 @@ * @param aCloseAll the action "close all map windows" * @param faceObjects the FaceObjects instance to use */ - public MainView(@NotNull final MainControl<G, A, R, V> mainControl, @NotNull final AbstractObjectChooser<G, A, R, V> objectChooser, @NotNull final MapManager<G, A, R, V> mapManager, @NotNull final ActionFactory actionFactory, @NotNull final Action aCloseAll, @NotNull final FaceObjects faceObjects) { + public MainView(@NotNull final MainControl<G, A, R, V> mainControl, @NotNull final DefaultObjectChooser<G, A, R, V> objectChooser, @NotNull final MapManager<G, A, R, V> mapManager, @NotNull final ActionFactory actionFactory, @NotNull final Action aCloseAll, @NotNull final FaceObjects faceObjects) { super(actionFactory.format("mainWindow.title", AbstractMainControl.getBuildNumberAsString())); this.mapManager = mapManager; mapFileAction = new MapFileActions<G, A, R, V>(mainControl, mapManager, null); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |