UserService class re-factoring
Status: Beta
Brought to you by:
mark-jj
Menu
▾
▴
#8 UserService class re-factoring
As Adam and I previously discussed, the class com.tiol.server.service.impl.UserService is way too heavy. Even the name of the class is too generic (not specific enough) which indicates a conceptual problem. It is doing too many things and it is coupled to too many other classes. See class diagram: http://www.theisleoflady.com/xwiki/bin/download/TechnicalDetails/TechnicalDetails/business-preview.cld.jpg
Therefore, UserService should be re-analyzed, re-thought and re-factored into 2 or more classes. There should be fewer relationships between it and any other classes.
Let's keep the coupling to the minimum, and the cohesion to the maximum.
UML class diagram of the GreatCOW system
Logged In: YES
user_id=1691791
Originator: YES
File Added: business-preview.cld.jpg
Logged In: YES
user_id=1691791
Originator: YES
For your easy reference, I have attached here the UML class diagram of our web application. I recommend that, as we plan the redesigning and re-factoring work, we should attach here a new (and improved) class diagram reflecting the new (re-factored) classes.