Menu

#595 use allocate memory before null check

v1.0_(example)
closed-fixed
None
5
2019-03-31
2019-03-26
wjq
No

In the latest version of GraphicsMagick, allocated memory is used without null pointer check which can cause a null pointer de-reference bug.
In codes/pdb.c line 673,674,675;
In codes/render.c line 2506 and following lines;
In magick/segment.c line 399 and following lines;
In magick/xwindow.c line 4669 and following lines;

Discussion

  • Bob Friesenhahn

    Bob Friesenhahn - 2019-03-28
    • assigned_to: Bob Friesenhahn
     
  • Bob Friesenhahn

    Bob Friesenhahn - 2019-03-31
    • status: open --> closed-fixed
     
  • Bob Friesenhahn

    Bob Friesenhahn - 2019-03-31
    • I have implemented a fix for pdb.c.
    • The source code in magick/render.c line 2506 is specifically to deal with memory allocation failure so I wonder what you mean by "latest version of GraphicsMagick".
    • I have impemented a fix for segment.c
    • I have implemented a fix for xwindow.c

    The fixes are implemented in changeset 15944:4188ef30df01. Thanks for inspecting the code and reporting these issues.

     

Log in to post a comment.

MongoDB Logo MongoDB