#564 WIN64 has incorrect type sizes

[Egor Pugin]

magick/magick_types.h.in
lines 54,77

#  if defined(WIN64)

is wrong. Also WIN32 is wrong (but defined in windows.h).

WIN64 must be _WIN64 and
WIN32 must be _WIN32

tested with msvc

[Bob Friesenhahn]

On Mon, 21 May 2018, Egor Pugin wrote:

magick/magick_types.h.in
lines 54,77
~~~

if defined(WIN64)

~~~
is wrong. Also WIN32 is wrong (but defined in windows.h).

~~~
WIN64 must be _WIN64 and
WIN32 must be _WIN32
~~~

Please see the comment at the top of magick/api.h. These defines come
from the VisualStudio project file (are produced by the configure
program) and are not the same as the internal Windows defines.

Is there some problem you are trying to solve?

Bob

[Egor Pugin]

I see. Thank you.
I'm doing custom builds, so it is the issue. (I did not define a lot of symbols.)

From my POV _WIN32/64 was more correct as it comes from MSVC by default.
Also seems that doing extra work (defining WIN32/64 manually) could be bad for custom builds.

Sorry for bothering, closing.

[Egor Pugin]

Please, close.

[Bob Friesenhahn]

GraphicsMagick has used project-generated defines since the VisualStudio project was developed. There are other defines used as well to indicate if code is being built for a DLL library or DLL module.