Re: [Gramps-devel] Missing 'all Calendar with pypi'

[John R. <jr...@ce...>]

On Sep 29, 2013, at 3:33 AM, Vassilii Khachaturov <vas...@ta...> wrote:

> On 29.09.2013 11:32, Helge.Herz wrote:
>> Devs,
>> 
>> since a while I get for Gramps 3.4.6 (from svn) and also for gramps
>> 4.0.2 (r23218M from svn) on win os this message during startup:
>> WARNING: calendar.py: line 586: sdn not available. Install Calendar with
>> pypi for native Hebrew calendar calculations.
>> 
>> Any idea/suggestion what's to do for me?
>> Shall I file one issue for each Gramps version in the bug tracker?
> I've added you to the already filed bug #7088 list for more context.
> If you're wondering what to do creating a Windows package, I propose to 
> install the "Calendar" python package from pypi as part of your Gramps 
> bundle, it'll give better Hebrew calendar calculations in Gramps.

Vassilii,

In http://www.gramps-project.org/bugs/view.php?id=7066#c31326 you wrote:
> OK, I decided to try the head-on approach and it worked.
> I took the jewish.c from the Calendar package sdn subdir,
> and it turns out that we had an earlier fork of the same code,
> down to the comments and line splits in them. The upstream
> had apparently had some bugs fixed since. I did the re-alignment
> and BINGO! the thing worked.
> 
> I still leave the sdn dependency as an option for those who have it installed,
> the others will have the python-only in-gramps fork fallback.

Given that there's already a pure-python solution in Gramps and that the calendar
package seems not to be actively maintained (the files inside the tarball are mostly 
dated 23 Oct 2006, with one header dated 24 Dec 2007), what's the point of the import?

Regards,
John Ralls