Menu
▾
▴
Re: [Gramps-devel] Bugs in Regular expressions in the Place completion Tool
|
From: jerome <rom...@ya...> - 2012-06-24 13:39:05
|
Some months ago, regex matching has been fixed on filter sidebar rules. Maybe, these changes are missing on PlaceCompletion addon? --- En date de : Sam 23.6.12, Benny Malengier <ben...@gm...> a écrit : De: Benny Malengier <ben...@gm...> Objet: Re: [Gramps-devel] Bugs in Regular expressions in the Place completion Tool À: "doug" <do...@o2...> Cc: "Gramps-developers mailing list" <gra...@li...> Date: Samedi 23 juin 2012, 19h40 It seems to be something very strange. The piece of code self.matchtitle.match(place.get_title()) returns in gramps32 a list of matches, while in gramps 34 it returns None. Doing a diff between the two versions of placecompletion does not show what can cause this. Benny 2012/6/19 doug <do...@o2...> Hello Mathieu, Comments in-line: On 18/06/12 21:51, Mathieu MD wrote: > Hello, > > AFAIK, I don't think the "Parse title:" is made to accept > any custom regex except the 4 availables (I didn't check the > code, though). AFAIK it would have been possible to assign the 9 fields in Location. At the time I wrote the Parse Title section in the Wiki article on the Place Completion Tool I could assign 5 fields. > If the bug #5780 is due to the fact that a custom inputed > regex is not parsed, then I guess it's not because it would > be overrided by "Change title into:", but simply because > it's not implemented! > You may well be right; if so, some code that existed previously must have gone missing. Unfortunately I don't know when that might have been. At the time the Wiki Parse Title section was written, the custom examples Regex A and Regex B did work exactly as described, because I used them on several databases imported from the IGI. > By the way, "Change title into;" do have a blank option: "No > changes". As far as I remember, "No changes" used to be the option I set in order for the custom "Parse Title" to work; in other words it behaved like a blank option. I've been assuming, perhaps incorrectly, that it's now behaving as a positive option *preventing* Parse Title from having any effect. > > I just tested below patterns (with Gramps 3.4.0-0.SVN19344), > and it does seems to work as expected, in the right order > (ie. first parse title, then change title): > - "Parse title: <empty>" and "Change title into: No changes" > - "Parse title: <empty>" and "Change title into: City[, State]" > - "Parse title: City [,|.] Country" and "Change title into: > No changes" > - "Parse title: City [,|.] Country" and "Change title into: > City[, State]" > > Am I missing something? As I said, originally Parse Title allowed *free-form* regex. This provides only a few pre-defined options. Doug ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Gramps-devel mailing list Gra...@li... https://lists.sourceforge.net/lists/listinfo/gramps-devel -----La pièce jointe associée suit----- ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ -----La pièce jointe associée suit----- _______________________________________________ Gramps-devel mailing list Gra...@li... https://lists.sourceforge.net/lists/listinfo/gramps-devel |