From: Brian M. <br...@gr...> - 2010-01-04 20:37:14
|
> > With the active state code removed then DbState is > valid outside the GUI. > > > > So my thoughts are: > > > > 1. Put the active state code in a separate class. > > Ok, you have a better grasp on this at the moment, so go > ahead. Should > Brian have a different idea, he'll let us know. We should > not create a > class just for the sake of it if DisplayState is a good > container > however. It's OK with me. Almost anywhere is better than DbState. > > 2. Maybe return a string from navigation_type rather > than an integer. > > I leave this up to you. The fact that the integers are the > positions > in a list is not that clear on first browsing the code, a > dictionary > looks like a nicer construct to me, but probably a > negligible little > bit slower. I haven't followed along close enough to understand the concept of "navigation type". In my mind, the GUI should always have one *focused* handle per primary object (Person, Place, Family, etc). If a particular view or gramplet wants to follow that focused object, it can via these signals. If that's the current concept, then the term "navigation type" confuses me. Why don't we just call it "active person", "active family", etc? Anyway, based on my limited understanding, it sounds like the direction you are going is good. ~Brian |