From: Benny M. <ben...@gm...> - 2008-12-06 07:57:44
|
Frederik, can you look at the first problem Luigi mentions: Grampsdisplay help? You have expertise in that regard Stephane, About the rest, It is not good to do string changes so close before a release. Let's do them after 3.0.4 and some less problematic only in trunk, like that all translators have time to catch up before 3.0.5. To fix the .desktop would be great however, Luigi can you commit and notify Stephane when finished? About the % in translation text, are there no default solutions to that, like escaping it or so (\%) ? Obviously it can cause a lot of problems with translators not knowing the tranlation may not be of the form %d, ... (I now understand why python 3.1 will deprecate % for string identifiers) Benny 2008/12/6 Luigi Toscano <lui...@ti...> > Stéphane Charette ha scritto: > > We had talked about releasing 3.0.4 on the weekend of Dec. 6-7. > > [..] > > Are we good for this? I know we have some database fixes, but if > > someone else knows of a problem where we should wait, or has > > additional fixes pending, please speak up now. Otherwise, I'll put > > 3.0.4 together this weekend. > > > Hi, I have some fixes and (small) suggestions. Even if some of them are > not particularly urgent, I prefer to report them now, otherwise I'll > forget them :) > > == Bugs: > - GrampsDisplay.help is sometimes called with the wrong number of > parameters (see ./plugins/FindDupes.py:149, ./ScratchPad.py:1255). I > suppose that this issue is due to the behavior changes of > GrampsDisplay.help (as it uses no more the gnome help but it refers to > the website). Probably the first parameter (target) can be dropped and > all the invocations update accordingly. > I haven't checked if other calls to "help" are affected by this bug. > > - The translation of the following message: > msgid " has 1 of 1 individual (100.00% complete)\n" > gives a gettext validation error (test msgfmt with -c) with some > languages (including for example Italian, French and Norwegian Bokmaal, > but not German and Catalan): > po/fr.po:8117: 'msgstr' is not a valid Python format string, unlike > 'msgid'. Reason: In the directive number 1, the character ')' is not a > valid conversion specifier. > I think that it tries to interpret it as a special python converter (in > fact, I cheated with the current Italian translation removing the > "#,python-format" comment, and it complains no more, even if something > else must be broken, I suppose...) > > > == Minor bug: > - the .desktop file doesn't conform to the specification (test it with > desktop-file-validate); the patch is really trivial, if you want I can > commit it. > > == Translation issues > - If I understand correctly, the central person is sometimes referred to > as "home person" and sometimes as "default person". I suggest to use > always "default person" instead of "home person". > > - It'll be nice to differentiate (with a context?) "none" from > src/gen/lib/date/ and the one in src/const.py; in italian they have > different genders. > The same for "Generation 1" and "Generation %n" from *Report.py and > DefaultGramplet.py. > > - Are "Repo Reference Editor" and "Repository Reference Editor" the same > string? The same for "Last Changed" and "Last modified" (and maybe "Last > Change"). > > > - CSV import/export: I don't think that the column headers should be > translated; it makes more difficult data exchange between users with > different locales, imho. > > == Other > - I tried to write the class for displaying and parsing italian dates, > "stealing" code from the Catalan one (probably the simplest one). It > seems to works, and I'd like to commit it. But I'd > also like to know if the extra code I see in other date handler is > really important or not (i.e. the French one contains code to better > handle the revolution calendar). > > Ok, that'd be enough :) > > Regards, > -- > Luigi > > > ------------------------------------------------------------------------------ > SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. > The future of the web can't happen without you. Join us at MIX09 to help > pave the way to the Next Web now. Learn more and register at > > http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel > |