Greetings:

I think it would be great to see the similar pieces of these two plugins become accessible by an import cammand.  There is quick a bit of like code among them.  Just for example:

Calendar_build routines
easter, and dst
collect_data
process_holiday_file
add_day_item, etc...

Doug can it still be done without WebCal stabilizing?  It would allow both of these two plugins to become less code complexity!  The duplicated pieces could be taken out of each and imported in...

Brian:  If you would like to keep them two seperate plugins, that is fine.  But it still would be great to see the duplicated pieces seperated.

Sincerely,
Rob


On Tue, Dec 16, 2008 at 8:05 PM, Brian Matherly <brian@gramps-project.org> wrote:
Rob,

> Greetings:
>
> These two plugins are the same except Calendar is in text
> form and WebCal is
> in web form.  Pretty basic concept considering their names?
>
> I was wondering if these two plugins should become one?
> You could be able
> to choose if you want text or web output?
>
> Brian and Benny:  What is your thoughts of this one?

I would be careful with this. the WebCal is not *just* an HTML version of the Calendar. WebCal produces multiple HTML documents with links between them.

I do agree that any common code should be generalized and shared between the two. But please don't turn two simple reports into one complicated report just because they both deal with calendars.

~Brian