It is probably a good idea if you look at the differences between my checked-in
version and the one that you sent me.
We all appreciate your enthousiasm. But personally I would like to see your
programming skills improve. That's why I go over them and make changes. I don't
know if Peter just checked them in unmodified. That way you'll never know what
you should improve.
Here are a couple of things that I noticed in the latest delta:
* easter() can be a generic utility fuinction (does not have to be a WebCalReport
function). Please also rename to _easter to make it local to WebCal.py
* why the extra self.use_home variable? It is just a copy of self.home_link.
* why the extra _note variable at line 1049?
* you're making WebCalReport.process_holiday_file() more confusing because by
adding the 'year' argument and not using it. And there is also another
* calendar_build() still uses self.year
* duplicate new function display_nav_links() ???? what is that?
* why not rename that argument "list_" when you created write_events?
And why not look at the code a bit? There is a lines variable, not used.
* blank_year() did get a new argument (year), but self.year is still used.
* and more...
Peter (assuming you are the Peter that Rob is talking about), why did you let
this slip by?
On Monday 28 July 2008, Rob Healey wrote:
> Dear Kess:
> Thank you for being willing to commit for me. I do appreciate it very much,
> but someday, I would like to be able to do it myself. Become one of the
> trusted elite...
> Instead of saying that you can fix my mistakes, I would have rather seeing
> make changes to make it better than I had it. I run through my changes to
> an exhaustive amount of times to make sure it works and it works well....
> On Sun, Jul 27, 2008 at 12:06 PM, Kees Bakker <firstname.lastname@example.org> wrote:
> > Hi Rob,
> > I'm happy to commit the changes for you. That also gives me
> > the opportunity to look at the changes and to correct them before
> > checking them in.
> > Kees
> > Op zondag 27 juli 2008, schreef Rob Healey:
> > > Dear Brian:
> > >
> > > I have submitted some more WebCal code enhancements and optimization of
> > code
> > > to Peter Lundgreen.
> > >
> > > Would it be possible to get svn commit access for myself?
> > >
> > > Sincerely,
> > > Rob
> > >
Evil has been dealt a serious blow, but will be back