2011/8/28 Tim Lyons <guy.linton@gmail.com>

On 23 Aug 2011, at 21:29, Benny Malengier wrote:

This is the first use of citations, so why even count it and try to calculate. Just do comething like C%05d or so, and increase your own counter.

About your use of global. I don't like the use of globals in python :-)

Thanks for your advice, which I have implemented.

A remark, every sourceref becomes a citation. Is the idea not that we can collaps sourceref in one single citation that is shared?  I'm a bit afraid users will have a huge time needed to merge citations to something manageable.

Yes, every sourceref becomes a citation.

A key objective in the way I have specified GEPS 023 is that it should be as simple as possible for users.

in fact, users should not notice any difference due to the introduction of citations, unless they want to take advantage of new features.

There is no need for users to merge citations unless they want to. I intend to implement a separate Gramplet to merge citations where they refer to the same source and have the same Volume/Page etc. I think it will be better to separate out merging rather that to do it automatically on upgrade. This will allow the user to choose whether they want to merge or not. It will also make it much simpler to change the criteria for merging without changing the main gramps code. I hope you think this approach is OK.

Yes, this is the typical approach.

However, this is something that should be a tool in my opinion, not a gramplet, that is, something you run perhaps once a year. After the upgrade a request to the user if he wants to run the tool then right away, would be nice.
It should also be part of gramps, and ready at time of release :-)