2011/6/15 Nick Hall <nick__hall@hotmail.com>


On 15/06/11 00:08, Doug Blank wrote:
> On Tue, Jun 14, 2011 at 6:19 PM, Nick Hall<nick__hall@hotmail.com>  wrote:
>> Devs,
>>
>> I have started to think about more advanced bottombar gramplets, and
>> have created a new Extended Sources bottombar gramplet in trunk.  It is
>> available in views with a navigation type of "Person".
>>
>> It shows the sources for the active person and also sources for child
>> objects.
>>
>> I seem to remember that someone requested something similar in the
>> Person Editor before.
>>
>> Let me know if you think it might be useful, in which case I'll make it
>> available in gramps33.
> +1, nice!
>
> In fact, can this just become the "Sources" gramplet? I don't see the
> need for the other as this subsumes it, right?
>

Thanks for the bug fix - I have rebuilt the tgz file.

Yes, I was thinking of using it as the default Sources tab, but wanted
to get some feedback.  I suppose in gramps33 we should just provide it
as a third-party addon though.

We are at 3.3.0 and this is a single plugin. Let's not be overzealous. If it's an improvement over the current gramplet, then push it to 3.3 if well tested.  In a month or so we should stop doing such stuff, but now it is really early days and I'd like to avoid simple things to diverge too quickly from branch33.

Benny

Nick.


> -Doug
>
> PS - fixed a little typo, but I didn't regenerate the plugin:
>
> Index: contrib/ExtendedSources/ExtendedSources.py
> ===================================================================
> --- contrib/ExtendedSources/ExtendedSources.py        (revision 953)
> +++ contrib/ExtendedSources/ExtendedSources.py        (working copy)
> @@ -131,11 +131,11 @@
>               except Errors.WindowActiveError:
>                   pass
>
> -    def get_has_data(self, obj):
> +    def get_has_data(self, person):
>           """
>           Return True if the gramplet has data, else return False.
>           """
> -        if obj is None:
> +        if person is None:
>               return False
>           if self.check_sources(person):
>               return True
>
>
>> Nick.
>>
>> ------------------------------------------------------------------------------
>> EditLive Enterprise is the world's most technically advanced content
>> authoring tool. Experience the power of Track Changes, Inline Image
>> Editing and ensure content is compliant with Accessibility Checking.
>> http://p.sf.net/sfu/ephox-dev2dev
>> _______________________________________________
>> Gramps-devel mailing list
>> Gramps-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>>
>

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Gramps-devel mailing list
Gramps-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gramps-devel