Index out of bounds in evaluate_gradp

[Max Mertens]

Hello,
there seems to be an array index out of bounds error in the recent GRAMPC (v2.1 and v2.2).
In the file grampc_run.c towards the end of function evaluate_gradp(), the element t[i] is accessed, which is already behind the array bounds. This causes undefined behavior (undefined t values are given to the dVdp function). I guess it should be changed to t[grampc->opt->Nhor-1] (or t[i-1]).
Thanks and kind regards,
Max

[Andreas Völz]

Hello Max,

thanks for the hint! You are right, line 892 in grampc_run.c should be changed from

       WtermParam(s, t[i], x, p_, dcdp, grampc);

to

    WtermParam(s, t[grampc->opt->Nhor - 1], x, p_, dcdp, grampc);

The bugfix will be included in the next version of GRAMPC.

Regards,
Andreas