#5 Duplicate command does not use the patch strip level

[Vincent Legoll]

Version 0.25-2 from debian

when using duplicate patch, gquilt does not automatically use the original patch strip level (-pNNN) for the new one, so it cannot apply properly...

But if you can add " -pNNN" in the new patch name as a workaround. But I think this is a side effect of the way patches are duplicated, as can be seen in the following quilt console recording:

%2013-09-27 18:29:06: playground: /tmp/toto
%2013-09-27 18:29:25: quilt import -P p5 -p0 patches/p2
Importing patch patches/p2 (stored as p5)
%2013-09-27 18:29:25: set description for "p5 -p0"
%

As evidenced here the patch name cannot contain spaces, as it is not quoted with '' or ""...

So as enhancement requests:

• quote patch name: quilt import -P "patch with space in its name" patches/original
• use the same patch level as original patch
  optional :
• display patch strip level (maybe just in the duplicate window)

[Vincent Legoll]

I may have a look at fixing this myself. But don't hold your breath...

[Vincent Legoll]

OK you may start to breathe again...

Notes:

• quilt does not handle patches which have
  spaces in the name, so quoting is not useful.
  Nothing done on that front.

• quilt default patch strip level to 1, so patches
  with no specified strip level get that. But if you
  explicitely create a patch with a specified strip
  level of 1, it gets a "-p1" in the series file.
  And if you duplicate this patch, the dupe will not
  get the -p1 added to it. This is really minor, as
  quilt has the default -p1 hardcoded everywhere in
  its scripts, so it's not likely to change anytime
  soon, and we should be safe.

[Vincent Legoll]

I should have read other gquilt bug reports...
https://sourceforge.net/p/gquilt/bugs/4/