[gq-commit] gq configure.in,1.56,1.57
Status: Beta
Brought to you by:
sur5r
From: <sta...@us...> - 2003-11-03 21:07:59
|
Update of /cvsroot/gqclient/gq In directory sc8-pr-cvs1:/tmp/cvs-serv32757 Modified Files: configure.in Log Message: * Improved code quality by trying out many gcc warning option to find potential problems: - hiding of global/local variables in some scope - Added many const keywords where appropriate and useful - Cleaned up some header files and made many functions static - took care of some signed/unsigned situations - some minor cosmetic changes - added some missing initialization values - Use some more warning options permanently with gcc Index: configure.in =================================================================== RCS file: /cvsroot/gqclient/gq/configure.in,v retrieving revision 1.56 retrieving revision 1.57 diff -C2 -d -r1.56 -r1.57 *** configure.in 2 Nov 2003 17:23:49 -0000 1.56 --- configure.in 3 Nov 2003 21:07:56 -0000 1.57 *************** *** 492,501 **** dnl Only use -Wall if we have gcc if test "x$GCC" = "xyes"; then ! if test -z "`echo "$CFLAGS" | grep "\-Wall" 2> /dev/null`" ; then ! CFLAGS="$CFLAGS -Wall" ! fi ! if test -z "`echo "$CFLAGS" | grep "\-Wmissing-declarations" 2> /dev/null`" ; then ! CFLAGS="$CFLAGS -Wmissing-declarations" fi fi --- 492,504 ---- dnl Only use -Wall if we have gcc if test "x$GCC" = "xyes"; then ! for A in -Wall -W -Wno-unused -Wmissing-declarations -Wcast-align -Wpointer-arith -Wfloat-equal ! do ! # The following should work as well, but might (?) be less portable ! # if ! echo "$CFLAGS" | grep -q -w -- "$A" ; then ! ! if test -z "`echo "$CFLAGS" | grep -w -- "$A" 2> /dev/null`" ; then ! CFLAGS="$CFLAGS $A" fi + done fi |