[gq-commit] gq/src browse.c,1.92,1.93 configfile.c,1.48,1.49 dt_generic_binary.c,1.12,1.13 filter.c,1.24,1.25 formfill.c,1.42,1.43 gq-xml.c,1.9,1.10 input.c,1.79,1.80 input.h,1.18,1.19 mainwin.c,1.52,1.53 prefs.c,1.53,1.54 ref-browse.c,1.8,1.9 search.c,1.60,1.61 server-browse.c,1.7,1.8 state.c,1.10,1.11 syntax.c,1.19,1.20

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory sc8-pr-cvs1:/tmp/cvs-serv10199/src

Modified Files:
	browse.c configfile.c dt_generic_binary.c filter.c formfill.c 
	gq-xml.c input.c input.h mainwin.c prefs.c ref-browse.c 
	search.c server-browse.c state.c syntax.c 
Log Message:
* Added -Wmissing-declarations when using gcc to catch bugs due to forgotten
  header inclusion when defining a previously declared function when 
  prototypes do not match
* Fixed all warnings generated by -Wmissing-declarations


Index: browse.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/browse.c,v
retrieving revision 1.92
retrieving revision 1.93
diff -C2 -d -r1.92 -r1.93
*** browse.c	2 Nov 2003 07:20:43 -0000	1.92
--- browse.c	2 Nov 2003 17:23:49 -0000	1.93
***************
*** 258,262 ****
   * add all configured servers to the root node
   */
! void add_all_servers(GtkCTree *ctree)
  {
       struct ldapserver *server;
--- 258,262 ----
   * add all configured servers to the root node
   */
! static void add_all_servers(GtkCTree *ctree)
  {
       struct ldapserver *server;
***************
*** 297,301 ****
  
  
! void tree_row_selected(GtkCTree *ctree, GtkCTreeNode *node, int column, struct tab *tab)
  {
       browse_entry *entry;
--- 297,302 ----
  
  
! void tree_row_selected(GtkCTree *ctree, GtkCTreeNode *node,
! 		       int column, struct tab *tab)
  {
       browse_entry *entry;
***************
*** 378,382 ****
  	  error_flush(ctx);
       }
- 
  }
  
--- 379,382 ----
***************
*** 398,403 ****
  
  
! 
! void tree_row_expand_all(GtkMenuItem *menuitem, struct tab *tab)
  {
       GtkCTree *ctree;
--- 398,403 ----
  
  
! #if DEAD_CODE
! static void tree_row_expand_all(GtkMenuItem *menuitem, struct tab *tab)
  {
       GtkCTree *ctree;
***************
*** 419,422 ****
--- 419,423 ----
  
  }
+ #endif
  
  static void browse_save_snapshot(int error_context, 
***************
*** 678,688 ****
  }
  
! GtkCTreeNode *node_from_entry(GtkCTree *ctreeroot, 
! 			      GtkCTreeNode *top,
! 			      browse_entry *e)
  {
       return gtk_ctree_find_by_row_data(GTK_CTREE(ctreeroot),
  				       top, e);
  }
  
  
--- 679,691 ----
  }
  
! #if DEAD_CODE
! static GtkCTreeNode *node_from_entry(GtkCTree *ctreeroot, 
! 				     GtkCTreeNode *top,
! 				     browse_entry *e)
  {
       return gtk_ctree_find_by_row_data(GTK_CTREE(ctreeroot),
  				       top, e);
  }
+ #endif
  
  
***************
*** 748,752 ****
  
  
! GtkCTreeNode *server_node_from_server(GtkCTree *ctree, struct ldapserver *server)
  {
  
--- 751,756 ----
  
  
! static GtkCTreeNode *server_node_from_server(GtkCTree *ctree,
! 					     struct ldapserver *server)
  {
  
***************
*** 754,758 ****
  }
  
! 
  static void remove_single_server_internal(GtkCTree *ctree, struct ldapserver *server)
  {
--- 758,762 ----
  }
  
! #if DEAD_CODE
  static void remove_single_server_internal(GtkCTree *ctree, struct ldapserver *server)
  {
***************
*** 766,775 ****
  
  
! void remove_single_server(struct tab *tab, struct ldapserver *server)
  {
- 
       remove_single_server_internal(BROWSETAB(tab)->ctreeroot, server);
  }
! 
  
  static void destroy_browse_mode(GtkWidget *w, struct tab *tab)
--- 770,778 ----
  
  
! static void remove_single_server(struct tab *tab, struct ldapserver *server)
  {
       remove_single_server_internal(BROWSETAB(tab)->ctreeroot, server);
  }
! #endif
  
  static void destroy_browse_mode(GtkWidget *w, struct tab *tab)
***************
*** 1054,1059 ****
  }
  
! 
! void _gtk_ctree_toggle_is_leaf(GtkCTree * ctree, GtkCTreeNode * node)
  {
       gchar *text, *temp;
--- 1057,1062 ----
  }
  
! #if DEAD_CODE
! static void _gtk_ctree_toggle_is_leaf(GtkCTree * ctree, GtkCTreeNode * node)
  {
       gchar *text, *temp;
***************
*** 1079,1083 ****
       g_free(temp);
  }
! 
  
  
--- 1082,1086 ----
       g_free(temp);
  }
! #endif
  
  

Index: configfile.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/configfile.c,v
retrieving revision 1.48
retrieving revision 1.49
diff -C2 -d -r1.48 -r1.49
*** configfile.c	2 Nov 2003 07:20:43 -0000	1.48
--- configfile.c	2 Nov 2003 17:23:49 -0000	1.49
***************
*** 504,510 ****
  }
  
! gboolean save_config_internal(int write_context,
! 			      struct gq_config *cfg,
! 			      const char *rcpath)
  {
       GList *templatelist, *oclist, *filterlist;
--- 504,511 ----
  }
  
! 
! static gboolean save_config_internal(int write_context,
! 				     struct gq_config *cfg,
! 				     const char *rcpath)
  {
       GList *templatelist, *oclist, *filterlist;

Index: dt_generic_binary.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/dt_generic_binary.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** dt_generic_binary.c	2 Nov 2003 07:20:43 -0000	1.12
--- dt_generic_binary.c	2 Nov 2003 17:23:49 -0000	1.13
***************
*** 111,116 ****
  
  
! void dt_generic_binary_create_menu(GtkWidget *hbox, GtkWidget *vbox,
! 				   GByteArray *data)
  {
       GtkWidget *menu, *menu_item, *submenu;
--- 111,116 ----
  
  
! static void dt_generic_binary_create_menu(GtkWidget *hbox, GtkWidget *vbox,
! 					  GByteArray *data)
  {
       GtkWidget *menu, *menu_item, *submenu;

Index: filter.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/filter.c,v
retrieving revision 1.24
retrieving revision 1.25
diff -C2 -d -r1.24 -r1.25
*** filter.c	2 Nov 2003 07:20:44 -0000	1.24
--- filter.c	2 Nov 2003 17:23:49 -0000	1.25
***************
*** 50,53 ****
--- 50,54 ----
  #include "i18n.h"
  #include "input.h"
+ #include "state.h"
  
  static void copy_existing_filter(GtkCList *filter_clist);

Index: formfill.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/formfill.c,v
retrieving revision 1.42
retrieving revision 1.43
diff -C2 -d -r1.42 -r1.43
*** formfill.c	2 Nov 2003 07:20:44 -0000	1.42
--- formfill.c	2 Nov 2003 17:23:49 -0000	1.43
***************
*** 512,520 ****
  
  
! 
  /*
   * arrow next to inputfield hit: add empty field below this one
   */
! void add_field_to_formfill(GList *formlist, char *attr)
  {
       struct formfill *form;
--- 512,520 ----
  
  
! #if DEAD_CODE
  /*
   * arrow next to inputfield hit: add empty field below this one
   */
! static void add_field_to_formfill(GList *formlist, char *attr)
  {
       struct formfill *form;
***************
*** 532,536 ****
  
  }
! 
  
  
--- 532,536 ----
  
  }
! #endif
  
  

Index: gq-xml.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/gq-xml.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -C2 -d -r1.9 -r1.10
*** gq-xml.c	23 Oct 2003 05:26:37 -0000	1.9
--- gq-xml.c	2 Nov 2003 17:23:49 -0000	1.10
***************
*** 77,82 ****
  }
  
! long longCDATA(struct parser_context *ctx,
! 	       struct tagstack_entry *e) 
  {
      char *ep;
--- 77,82 ----
  }
  
! static long longCDATA(struct parser_context *ctx,
! 		      struct tagstack_entry *e) 
  {
      char *ep;

Index: input.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/input.c,v
retrieving revision 1.79
retrieving revision 1.80
diff -C2 -d -r1.79 -r1.80
*** input.c	2 Nov 2003 07:20:44 -0000	1.79
--- input.c	2 Nov 2003 17:23:49 -0000	1.80
***************
*** 561,565 ****
  
  
! void schema_show_attr(GtkMenuItem *menuitem, struct formfill *form)
  {
       struct server_schema *ss = NULL;
--- 561,565 ----
  
  
! static void schema_show_attr(GtkMenuItem *menuitem, struct formfill *form)
  {
       struct server_schema *ss = NULL;
***************
*** 579,583 ****
  }
  
! void remove_dt_default_for_attr(GtkMenuItem *menuitem, struct formfill *form)
  {
       gpointer okey;
--- 579,584 ----
  }
  
! static void remove_dt_default_for_attr(GtkMenuItem *menuitem,
! 				       struct formfill *form)
  {
       gpointer okey;
***************
*** 600,604 ****
  }
  
! void make_dt_default_for_attr(GtkMenuItem *menuitem, struct formfill *form)
  {
       int dt;
--- 601,606 ----
  }
  
! static void make_dt_default_for_attr(GtkMenuItem *menuitem, 
! 				     struct formfill *form)
  {
       int dt;
***************
*** 1221,1225 ****
  
  
! char *get_new_dn(struct inputform *iform)
  {
       char *content, *content_enc;
--- 1223,1227 ----
  
  
! static char *get_new_dn(struct inputform *iform)
  {
       char *content, *content_enc;

Index: input.h
===================================================================
RCS file: /cvsroot/gqclient/gq/src/input.h,v
retrieving revision 1.18
retrieving revision 1.19
diff -C2 -d -r1.18 -r1.19
*** input.h	2 Nov 2003 07:20:44 -0000	1.18
--- input.h	2 Nov 2003 17:23:49 -0000	1.19
***************
*** 97,99 ****
--- 97,101 ----
  void set_hide_empty_attributes(int hidden, struct inputform *form);
  
+ GdkWindow *get_any_gdk_window(GtkWidget *w);
+ 
  #endif

Index: mainwin.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/mainwin.c,v
retrieving revision 1.52
retrieving revision 1.53
diff -C2 -d -r1.52 -r1.53
*** mainwin.c	2 Nov 2003 07:20:44 -0000	1.52
--- mainwin.c	2 Nov 2003 17:23:49 -0000	1.53
***************
*** 116,120 ****
  }
  
! gboolean mainwin_restore_snapshot(struct mainwin_data *win)
  {
       int i, type;
--- 116,120 ----
  }
  
! static gboolean mainwin_restore_snapshot(struct mainwin_data *win)
  {
       int i, type;
***************
*** 159,163 ****
  }
  
! void mainwin_save_snapshot(struct mainwin_data *win)
  {
       struct tab *tab = NULL; 
--- 159,163 ----
  }
  
! static void mainwin_save_snapshot(struct mainwin_data *win)
  {
       struct tab *tab = NULL; 

Index: prefs.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/prefs.c,v
retrieving revision 1.53
retrieving revision 1.54
diff -C2 -d -r1.53 -r1.54
*** prefs.c	2 Nov 2003 07:20:44 -0000	1.53
--- prefs.c	2 Nov 2003 17:23:49 -0000	1.54
***************
*** 369,373 ****
  }
  
! void host_changed_callback(GtkEditable *host, GtkWidget *port) 
  {
       gchar *s = gtk_editable_get_chars(host, 0, -1);
--- 369,373 ----
  }
  
! static void host_changed_callback(GtkEditable *host, GtkWidget *port) 
  {
       gchar *s = gtk_editable_get_chars(host, 0, -1);
***************
*** 1081,1086 ****
  
  
! void serverstab_deletebutton_callback(GtkWidget *widget, 
! 				      struct prefs_windata *pw)
  {
       GtkWidget *clist = pw->serverstab_server_clist;
--- 1081,1086 ----
  
  
! static void serverstab_deletebutton_callback(GtkWidget *widget, 
! 					     struct prefs_windata *pw)
  {
       GtkWidget *clist = pw->serverstab_server_clist;
***************
*** 1119,1123 ****
  }
  
! void serverstab_newbutton_callback(GtkWidget *widget, struct prefs_windata *pw)
  {
       create_edit_server_window(NULL, pw->prefswindow);
--- 1119,1124 ----
  }
  
! static void serverstab_newbutton_callback(GtkWidget *widget, 
! 					  struct prefs_windata *pw)
  {
       create_edit_server_window(NULL, pw->prefswindow);
***************
*** 1197,1201 ****
  
  
! void prefs_okbutton_callback(GtkWidget *button, struct prefs_windata *pw)
  {
       int type;
--- 1198,1203 ----
  
  
! static void prefs_okbutton_callback(GtkWidget *button,
! 				          struct prefs_windata *pw)
  {
       int type;

Index: ref-browse.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/ref-browse.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -d -r1.8 -r1.9
*** ref-browse.c	2 Nov 2003 07:20:44 -0000	1.8
--- ref-browse.c	2 Nov 2003 17:23:49 -0000	1.9
***************
*** 298,302 ****
  }
  
! char* ref_browse_entry_get_name(browse_entry *entry, gboolean long_form)
  {
       char *g;
--- 298,302 ----
  }
  
! static char* ref_browse_entry_get_name(browse_entry *entry, gboolean long_form)
  {
       char *g;

Index: search.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/search.c,v
retrieving revision 1.60
retrieving revision 1.61
diff -C2 -d -r1.60 -r1.61
*** search.c	2 Nov 2003 07:20:44 -0000	1.60
--- search.c	2 Nov 2003 17:23:49 -0000	1.61
***************
*** 1089,1093 ****
  
  
! void add_to_search_history(struct tab *tab)
  {
       gchar *searchterm;
--- 1089,1093 ----
  
  
! static void add_to_search_history(struct tab *tab)
  {
       gchar *searchterm;

Index: server-browse.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/server-browse.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** server-browse.c	2 Nov 2003 07:20:44 -0000	1.7
--- server-browse.c	2 Nov 2003 17:23:49 -0000	1.8
***************
*** 53,59 ****
   *  Really add a single suffix to the tree 
   */
! void add_suffix(server_browse_entry *entry, 
! 		GtkCTree *ctreeroot, GtkCTreeNode *node,
! 		char *suffix)
  {
       GtkCTreeNode *new_item;
--- 53,59 ----
   *  Really add a single suffix to the tree 
   */
! static void add_suffix(server_browse_entry *entry, 
! 		       GtkCTree *ctreeroot, GtkCTreeNode *node,
! 		       char *suffix)
  {
       GtkCTreeNode *new_item;
***************
*** 509,514 ****
  
  
! char* server_browse_entry_get_name(browse_entry *entry,
! 				   gboolean long_form)
  {
       assert(IS_SERVER_ENTRY(entry));
--- 509,514 ----
  
  
! static char* server_browse_entry_get_name(browse_entry *entry,
! 					  gboolean long_form)
  {
       assert(IS_SERVER_ENTRY(entry));

Index: state.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/state.c,v
retrieving revision 1.10
retrieving revision 1.11
diff -C2 -d -r1.10 -r1.11
*** state.c	2 Nov 2003 07:20:44 -0000	1.10
--- state.c	2 Nov 2003 17:23:49 -0000	1.11
***************
*** 46,49 ****
--- 46,50 ----
  #include "xmlutil.h"
  #include "i18n.h"
+ #include "state.h"
  
  enum state_value_type {
***************
*** 83,87 ****
  static GHashTable *entities = NULL;
  
! struct state_value *new_state_value(enum state_value_type t) {
      struct state_value *v = g_malloc0(sizeof(struct state_value));
      v->type = t;
--- 84,89 ----
  static GHashTable *entities = NULL;
  
! static struct state_value *new_state_value(enum state_value_type t)
! {
      struct state_value *v = g_malloc0(sizeof(struct state_value));
      v->type = t;
***************
*** 102,106 ****
  }
  
! void free_state_value(struct state_value *v) 
  {
      assert(v);
--- 104,108 ----
  }
  
! static void free_state_value(struct state_value *v) 
  {
      assert(v);
***************
*** 127,131 ****
  
  
! struct state_entity *new_state_entity() 
  {
      struct state_entity *e = g_malloc0(sizeof(struct state_entity));
--- 129,133 ----
  
  
! static struct state_entity *new_state_entity() 
  {
      struct state_entity *e = g_malloc0(sizeof(struct state_entity));
***************
*** 487,491 ****
  /* filename_config returns the name of the config file. The returned
     pointer must g_free'd. */
! gchar *filename_state(int context)
  {
       gchar *rcpath = NULL;
--- 489,493 ----
  /* filename_config returns the name of the config file. The returned
     pointer must g_free'd. */
! static gchar *filename_state(int context)
  {
       gchar *rcpath = NULL;
***************
*** 823,828 ****
  };
  
! GHashTable *process_statefile_XML(int error_context,
! 				  const char *filename)
  {
      xmlSAXHandler *handler = g_malloc0(sizeof(xmlSAXHandler));
--- 825,830 ----
  };
  
! static GHashTable *process_statefile_XML(int error_context,
! 					 const char *filename)
  {
      xmlSAXHandler *handler = g_malloc0(sizeof(xmlSAXHandler));

Index: syntax.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/syntax.c,v
retrieving revision 1.19
retrieving revision 1.20
diff -C2 -d -r1.19 -r1.20
*** syntax.c	2 Nov 2003 07:20:44 -0000	1.19
--- syntax.c	2 Nov 2003 17:23:49 -0000	1.20
***************
*** 455,459 ****
  static GList *selectable_dt_list = NULL;
  
! void add_syntax(int type, display_type_handler *dt_handler)
  {
       int *p = (int *) g_malloc(sizeof(int)); /* leak memory */
--- 455,459 ----
  static GList *selectable_dt_list = NULL;
  
! static void add_syntax(int type, display_type_handler *dt_handler)
  {
       int *p = (int *) g_malloc(sizeof(int)); /* leak memory */