gqclient-commit — CVS commits

[gq-commit] gq/src Makefile.am,1.19,1.20

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv29320

Modified Files:
	Makefile.am 
Log Message:
* Added another comment to remind me of yet-another debugging flag


Index: Makefile.am
===================================================================
RCS file: /cvsroot/gqclient/gq/src/Makefile.am,v
retrieving revision 1.19
retrieving revision 1.20
diff -C2 -d -r1.19 -r1.20
*** Makefile.am	11 Jun 2002 21:15:25 -0000	1.19
--- Makefile.am	3 Jul 2002 19:11:06 -0000	1.20
***************
*** 4,7 ****
--- 4,8 ----
  
  # CFLAGS	=	@CFLAGS@ -DMEMDEBUG
+ # CFLAGS	=	@CFLAGS@ -DERROR_SHOW_LINE
  gq_SOURCES = \
          mainwin.c \

[gq-commit] gq/src configfile.c,1.22,1.23 configfile.h,1.13,1.14

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv22659

Modified Files:
	configfile.c configfile.h 
Log Message:
* Made a message string translateable by removing a #define and putting 
  its value directly into the code.


Index: configfile.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/configfile.c,v
retrieving revision 1.22
retrieving revision 1.23
diff -C2 -d -r1.22 -r1.23
*** configfile.c	18 Jun 2002 22:07:14 -0000	1.22
--- configfile.c	3 Jul 2002 18:49:45 -0000	1.23
***************
*** 607,611 ****
       /* refuse to read config file if world readable (bind passwords) */
       if( (sfile.st_mode & ~S_IFMT) != 00600 ) {
! 	  snprintf(errstr, sizeof(errstr), RCFILE_MODE_MSG, rcpath);
  	  error_push(load_context, errstr);
  	  error_flush(load_context);
--- 607,616 ----
       /* refuse to read config file if world readable (bind passwords) */
       if( (sfile.st_mode & ~S_IFMT) != 00600 ) {
! 	  snprintf(errstr, sizeof(errstr), 
! 		   _("%s is group and/or world readable.\n"
! 		     "This file can contain passwords in cleartext,\n"
! 		     "and should be mode 0600.\n\n"
! 		     "Continuing with default settings...\n"),
! 		   rcpath);
  	  error_push(load_context, errstr);
  	  error_flush(load_context);

Index: configfile.h
===================================================================
RCS file: /cvsroot/gqclient/gq/src/configfile.h,v
retrieving revision 1.13
retrieving revision 1.14
diff -C2 -d -r1.13 -r1.14
*** configfile.h	5 Jun 2002 15:32:07 -0000	1.13
--- configfile.h	3 Jul 2002 18:49:45 -0000	1.14
***************
*** 36,44 ****
  #define RCFILE           ".gq"
  
- #define RCFILE_MODE_MSG "%s is world readable.\nThis file can contain " \
- 			"passwords,\n and should be mode 0600.\n\n" \
- 			"Continuing with default settings...\n"
- 
- 
  /* tokens for config file */
  #define T_UNKNOWN             0
--- 36,39 ----

[gq-commit] gq/src dt_cert.c,1.3,1.4 dt_crl.c,1.1,1.2

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv27249

Modified Files:
	dt_cert.c dt_crl.c 
Log Message:
Contributed by Bernhard Reiter <ber...@in...>:

* Fix an off-by-one error regarding version numbers of certificates and
  CRLs
* Add the number of revoked certificates to the info shown for a CRL


Index: dt_cert.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/dt_cert.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** dt_cert.c	11 Jun 2002 21:15:25 -0000	1.3
--- dt_cert.c	27 Jun 2002 20:01:26 -0000	1.4
***************
*** 218,223 ****
  		    gtk_clist_append(GTK_CLIST(clist), cols);
  
  		    BIO_reset(bufbio);
! 		    BIO_printf(bufbio, "%ld", X509_get_version(x));
  		    BIO_get_mem_ptr(bufbio, &bm);
  
--- 218,225 ----
  		    gtk_clist_append(GTK_CLIST(clist), cols);
  
+ 		    /* Version:
+ 		     * Version 0x00 actually means Version 1 */
  		    BIO_reset(bufbio);
! 		    BIO_printf(bufbio, "%ld", X509_get_version(x) + 1);
  		    BIO_get_mem_ptr(bufbio, &bm);
  

Index: dt_crl.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/dt_crl.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** dt_crl.c	11 Jun 2002 21:15:25 -0000	1.1
--- dt_crl.c	27 Jun 2002 20:01:26 -0000	1.2
***************
*** 149,152 ****
--- 149,155 ----
  		    BUF_MEM *bm;
  		    char *cols[3] = { NULL, NULL, NULL };
+ 	            STACK_OF(X509_REVOKED) *rev;
+ 	            /* X509_REVOKED *r;
+ 		       int i; */
  
  		    X509_NAME_print(bufbio, n, 0);
***************
*** 175,180 ****
  		    gtk_clist_append(GTK_CLIST(clist), cols);
  
  		    BIO_reset(bufbio);
! 		    BIO_printf(bufbio, "%ld", X509_CRL_get_version(x));
  		    BIO_get_mem_ptr(bufbio, &bm);
  
--- 178,207 ----
  		    gtk_clist_append(GTK_CLIST(clist), cols);
  
+ 		    /* list of revoked certs */
+ 
+ 		    rev = X509_CRL_get_REVOKED(x); 
+ 		    /* NOTE: we do _not_ have to free rev, it is part
+ 		       of the CRL itself */
+ 		    cols[0] = _("Number of revoked certificates");
+ 		    
  		    BIO_reset(bufbio);
! 		    BIO_printf(bufbio, "%ld", sk_X509_REVOKED_num(rev));
! 		    BIO_get_mem_ptr(bufbio, &bm);
! 		    cols[1] = bm->data;
! 
! 		    /*
! 		    for(i = 0 ; i < sk_X509_REVOKED_num(rev) ; i++) {
! 		        r = sk_X509_REVOKED_value(rev, i);
! 		        BIO_printf(bufbio, "%ld", r->serialNumber);
! 		        BIO_get_mem_ptr(bufbio, &bm);
! 			cols[1] = bm->data;
! 		    }
! 		    */
! 		    gtk_clist_append(GTK_CLIST(clist), cols);
! 		    
! 		    /* Version:
! 		     * Version 0x00 actually means Version 1 */
! 		    BIO_reset(bufbio);
! 		    BIO_printf(bufbio, "%ld", X509_CRL_get_version(x) + 1);
  		    BIO_get_mem_ptr(bufbio, &bm);
  

[gq-commit] gq/src errorchain.c,1.8,1.9

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv25521

Modified Files:
	errorchain.c 
Log Message:
* Stupid me: #ifdef'd the wrong function...

Index: errorchain.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/errorchain.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -d -r1.8 -r1.9
*** errorchain.c	27 Jun 2002 08:13:21 -0000	1.8
--- errorchain.c	27 Jun 2002 08:39:15 -0000	1.9
***************
*** 68,72 ****
  }
  
- #ifdef ERROR_SHOW_LINE
  void error_push_production(int context, char *msg)
  {
--- 68,71 ----
***************
*** 91,96 ****
  
  }
- #endif
  
  void error_push_debug(int context, char *msg, char *file, int line)
  {
--- 90,95 ----
  
  }
  
+ #ifdef ERROR_SHOW_LINE
  void error_push_debug(int context, char *msg, char *file, int line)
  {
***************
*** 101,104 ****
--- 100,104 ----
       g_free(s);
  }
+ #endif
  
  /* 

[gq-commit] gq TODO,1.23,1.24

[<sta...@us...>]

Update of /cvsroot/gqclient/gq
In directory usw-pr-cvs1:/tmp/cvs-serv21946

Modified Files:
	TODO 
Log Message:
* More TODOs for 1.0...

Index: TODO
===================================================================
RCS file: /cvsroot/gqclient/gq/TODO,v
retrieving revision 1.23
retrieving revision 1.24
diff -C2 -d -r1.23 -r1.24
*** TODO	18 Jun 2002 22:17:14 -0000	1.23
--- TODO	27 Jun 2002 08:27:24 -0000	1.24
***************
*** 22,25 ****
--- 22,31 ----
  * Fix dt_password.c: handling of the construction of encoded passwords
    (get rid of any strcpy, strcat and only using GByteArray methods)
+ * Think about the moving stuff in browse mode: 
+   Either
+     - Should move deletion out of the moving business and delay
+       it until _after_ we have ended the moving
+     - OR should we delete and retry in order to circumvent any
+       sizelimits???
  
  UNINTERESTING BUGS
***************
*** 41,44 ****
--- 47,53 ----
  * import from LDIF
  * Better keyboard support (at least for main menu) (peter)
+ * never do ldap_add when moving trees. Use triangulation like with the
+   towers of hanoi
+ 
  
  BLUE SKY

[gq-commit] gq README,1.6,1.7

[<sta...@us...>]

Update of /cvsroot/gqclient/gq
In directory usw-pr-cvs1:/tmp/cvs-serv21271

Modified Files:
	README 
Log Message:
* more dependencies
* more info about I18N/codeset issues
* mentioning requirement for OpenSSL, gdb-pixbuf.
* note about OpenLDAP 2.1.x

Index: README
===================================================================
RCS file: /cvsroot/gqclient/gq/README,v
retrieving revision 1.6
retrieving revision 1.7
diff -C2 -d -r1.6 -r1.7
*** README	13 Jun 2002 19:16:18 -0000	1.6
--- README	27 Jun 2002 08:25:26 -0000	1.7
***************
*** 27,33 ****
    functionality won't be available at all.
  
    You will also need gtk+ 1.2.x installed.
  
!   For generic installation instructions, see the file INSTALL.
  
    If your OpenLDAP installation is in a nonstandard place, use
--- 27,77 ----
    functionality won't be available at all.
  
+   If you have trouble compiling gq, please first try to compile gq with a 
+   recent version of OpenLDAP. Note that the "officially supported"
+   (this only means that the maintainer of gq uses it) OpenLDAP is at version
+   2.0.23 or above. Support for OpenLDAP 2.1.x is not yet fully tested, but some
+   code dealing with peculiarities of 2.1 is already present. Testers (and
+   contributors) are welcome.
+   
    You will also need gtk+ 1.2.x installed.
  
!   For support of the advanced support for the jpegPhoto attribute you will
!   also need gdk-pixbuf.
! 
!   To be able to use the advanced support for X509 certificates, for a
!   correct treatment of the userPassword attribute and for TLS/SSL
!   support of gq you will also need OpenSSL (0.9.6b is known to
!   work). [Note: The use of OpenSSL may not be legal in your country
!   due to laws prohibiting its use. Nobody connected with gq advises you
!   to use OpenSSL in this situation or takes any responsibility if you
!   nevertheless do so.]
! 
!   NOTE: since 0.6.0 gq contains support for internationalized messages
!   and for the detection of client side codepages (eg. ISO-8859-2 if you
!   live in a country in the eastern part of Europe.) For this to work
!   you _might_ have to use the --with-localedir configure option to point
!   to your system locale directory (In this case you might have to be
!   root to install gq, as the message catalogs are stored
!   there). Otherwise your system library might not be able to find the
!   correct codepage to use for your locale. If this is no option, you might
!   alternativly try any of the following methods:
! 
!   1.) Use the --with-default-codeset option of the configure script.
! 
!   2.) Copy the stuff for your locale found under your system locale
!       directory to the equivalent position below the gq locale directory
!       (most importantly the LC_CTYPE file)
! 
!   Note that I never tried the 2nd possibility. Also note that I am not
!   an I18N/codeset expert, so all of the above may be complete
!   non-sense... you have been warned. Any clarifications/reports about this
!   are welcome.
! 
!   Having said all of the above there is hope that a recent reordering
!   of how things are done during detection of the codeset none of all
!   of the above is actually necessary. Please try it and report any
!   problems!
! 
!   For more generic installation instructions, see the file INSTALL.
  
    If your OpenLDAP installation is in a nonstandard place, use
***************
*** 83,85 ****
  	mode and many other fixes. He is also a GTK+ wizard.
    Alexander Guy (a7...@an...) added support for TLS with LDAPv3.
- 
--- 127,128 ----

[gq-commit] gq ChangeLog,1.29,1.30

[<sta...@us...>]

Update of /cvsroot/gqclient/gq
In directory usw-pr-cvs1:/tmp/cvs-serv20001

Modified Files:
	ChangeLog 
Log Message:
* Wrote down changes done during the last couple of days.

Index: ChangeLog
===================================================================
RCS file: /cvsroot/gqclient/gq/ChangeLog,v
retrieving revision 1.29
retrieving revision 1.30
diff -C2 -d -r1.29 -r1.30
*** ChangeLog	18 Jun 2002 22:17:43 -0000	1.29
--- ChangeLog	27 Jun 2002 08:22:00 -0000	1.30
***************
*** 1,2 ****
--- 1,14 ----
+ 2002-06-25 Peter Stamfest <pe...@st...>
+ 	* Fixed a problem (reusing freed memory) causing crashes when
+ 	  connection caching is turned off. Problem pointed out by Stephan
+ 	  Duehr <ste...@su...>
+ 2002-06-20 Peter Stamfest <pe...@st...>
+ 	* Kerberos compile fixes (first attempt) by Andreas Hasenack 
+ 	  <an...@co...>
+ 	* Fixes in the browse tree causing a core dump due to mixing object
+ 	  classes in the per-node data structures.
+ 	* Better error messages (including source line numbers for debugging)
+ 2002-06-19 Peter Stamfest <pe...@st...>
+ 	* gq-0.6.0beta2
  2002-06-18 Peter Stamfest <pe...@st...>
  	* Fixed some possible NULL pointer derefs causing crashes. Fixed by 

[gq-commit] gq/src errorchain.h,1.4,1.5

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv19747

Modified Files:
	errorchain.h 
Log Message:
* Changes related to changes in errorchain.c

Index: errorchain.h
===================================================================
RCS file: /cvsroot/gqclient/gq/src/errorchain.h,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -d -r1.4 -r1.5
*** errorchain.h	21 Jun 2002 00:30:29 -0000	1.4
--- errorchain.h	27 Jun 2002 08:21:20 -0000	1.5
***************
*** 30,34 ****
  
  int error_new_context(char *title);
! void error_push(int context, char *msg);
  struct errchain *error_chain_by_context(int q);
  void error_flush(int context);
--- 30,45 ----
  
  int error_new_context(char *title);
! void error_push_production(int context, char *msg);
! 
! #ifdef ERROR_SHOW_LINE
! 
! void error_push_debug(int context, char *msg, char *file, int line);
! #  define error_push(c, m) error_push_debug((c), (m), __FILE__, __LINE__)
! 
! #else
! #  define error_push(c, m) error_push_production((c), (m))
! #endif
! 
! 
  struct errchain *error_chain_by_context(int q);
  void error_flush(int context);

[gq-commit] gq/src util.c,1.39,1.40

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv19332

Modified Files:
	util.c 
Log Message:
* Some error-reporting related fixes
* Drop the call to clear_server_schema when disconnecting - otherwise
  schema browse mode would reference an already freed schema! This is
  not optimal, as changes to the schema might go unnoticed. This must be
  an ancient bug, and I wonder why it hasn't raised its ugly head before
  (or has nobody noticed)? Related bug reported by Stephan Duehr
  <ste...@su...>.


Index: util.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/util.c,v
retrieving revision 1.39
retrieving revision 1.40
diff -C2 -d -r1.39 -r1.40
*** util.c	21 Jun 2002 00:32:42 -0000	1.39
--- util.c	27 Jun 2002 08:20:23 -0000	1.40
***************
*** 105,111 ****
  				   &version) == LDAP_OPT_SUCCESS) {
  		    server->version = LDAP_VERSION3;
! 	       } else {
! 		    error_push(open_context, message);
! 		    push_ldap_addl_error(ld, open_context);
  	       }
  	  }
--- 105,111 ----
  				   &version) == LDAP_OPT_SUCCESS) {
  		    server->version = LDAP_VERSION3;
! /*  	       } else { */
! /*  		    error_push(open_context, message); */
! /*  		    push_ldap_addl_error(ld, open_context); */
  	       }
  	  }
***************
*** 119,123 ****
  				  _("Couldn't set protocol version to LDAPv3."));
  			 error_push(open_context, message);
- 			 push_ldap_addl_error(ld, open_context);
  		    }
  	       }
--- 119,122 ----
***************
*** 175,179 ****
  			       _("GQ was compiled without Kerberos support.\n"
  				 "Run 'configure --help' for more information\n"));
- 		    push_ldap_addl_error(ld, open_context);
  		    statusbar_msg("");
  		    ldap_unbind(ld);
--- 174,177 ----
***************
*** 188,192 ****
  			       _("GQ was compiled without SASL support.\n"
  				 "Run 'configure --help' for more information\n"));
- 		    push_ldap_addl_error(ld, open_context);
  		    statusbar_msg("");
  		    ldap_unbind(ld);
--- 186,189 ----
***************
*** 325,330 ****
  	   || always) ) {
  
  	  clear_server_schema(server);
! 
  	  /* definitely close this connection */
  	  ldap_unbind(server->connection);
--- 322,340 ----
  	   || always) ) {
  
+ #if 0
+ 	  /*
+ 	   * DO NOT clear the schema - we might be disconnecting
+ 	   * because we are not caching the connection.
+ 	   * 
+ 	   * This fixes a bug reported by Stephan Duehr <ste...@su...>
+ 	   *
+ 	   * BUT: FIXME: Think about how to deal with schema changes
+ 	   * due to server restarts (Popup menu on the schema top
+ 	   * nodes [ie. resurrect the refresh popup already there]?)
+ 	   * 
+ 	   */
+  
  	  clear_server_schema(server);
! #endif
  	  /* definitely close this connection */
  	  ldap_unbind(server->connection);

[gq-commit] gq/src ldapops.c,1.12,1.13

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv18141

Modified Files:
	ldapops.c 
Log Message:
* Better error reporting


Index: ldapops.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/ldapops.c,v
retrieving revision 1.12
retrieving revision 1.13
diff -C2 -d -r1.12 -r1.13
*** ldapops.c	18 Jun 2002 22:07:14 -0000	1.12
--- ldapops.c	27 Jun 2002 08:16:24 -0000	1.13
***************
*** 83,86 ****
--- 83,87 ----
  	  if (e == NULL) {
  	       error_push(err_ctx, ldap_err2string(ldap_result2error(sld, res, 0)));
+ 	       push_ldap_addl_error(sld, err_ctx); 
  /*  	       ldap_perror(sld, "ldap_first_entry"); */
  	       goto fail;   /* only sometimes goto makes sense */
***************
*** 97,100 ****
--- 98,102 ----
  	  }
  	  error_push(err_ctx, ldap_err2string(ldap_result2error(sld, res, 0)));
+ 	  push_ldap_addl_error(sld, err_ctx); 
  /*  	  ldap_perror(sld, "search"); */
  	  goto fail;
***************
*** 132,135 ****
--- 134,138 ----
       LDAPMod **mods;
       gboolean ok = TRUE;
+      char message[MAX_DN_LEN + 256];
  
       sdn =  gq_ldap_explode_dn(source_dn, 0);
***************
*** 149,155 ****
  			     NULL, NULL);
  
- /*  	  printf("ldap_rename %s -> %s rc=%d\n", source_dn, target_dn, rc); */
- 	  
  	  if (rc == LDAP_SUCCESS) {
  	       result = newdn;
  	       goto done;
--- 152,158 ----
  			     NULL, NULL);
  
  	  if (rc == LDAP_SUCCESS) {
+ /*  	       printf("ldap_rename %s -> %s rc=%d\n", */
+ /*  		      source_dn, target_dn, rc); */
  	       result = newdn;
  	       goto done;
***************
*** 161,164 ****
--- 164,169 ----
  	       /* we probably have a subtree - do not indicate an error */
  /*  	       error_push(error_context, ldap_err2string(rc)); */
+ /*  	       push_ldap_addl_error(sld, error_context);  */
+ 
  	  }
       }
***************
*** 207,210 ****
--- 212,218 ----
       
       if (rc == LDAP_SUCCESS) {
+ /*  	  printf("ldap_add %s -> %s rc=%d\n", */
+ /*  		 source_dn, newdn, rc); */
+ 
  	  if (progress) {
  	       progress(source_dn, target_dn, newdn);
***************
*** 221,225 ****
  	       res = NULL;
  	       
! 	       /* If we are allowed to do the deleting, we should
                    again after each bunch we copy, as the server may be
                    limiting the number of entries returned. But if we
--- 229,233 ----
  	       res = NULL;
  	       
! 	       /* If we are allowed to do the deleting, we should retry
                    again after each bunch we copy, as the server may be
                    limiting the number of entries returned. But if we
***************
*** 256,260 ****
  		    } else if (rc == LDAP_SERVER_DOWN) {
  			 source_server->server_down++;
! 		    }
  		    if (res) {
  			 ldap_msgfree(res);
--- 264,274 ----
  		    } else if (rc == LDAP_SERVER_DOWN) {
  			 source_server->server_down++;
! 		    } else {
! 			 snprintf(message, sizeof(message), 
! 				  "%s: %s", source_dn, ldap_err2string(rc));
! 			 error_push(error_context, message);
! 			 push_ldap_addl_error(sld, error_context); 
! 		    }			 
! 
  		    if (res) {
  			 ldap_msgfree(res);
***************
*** 269,272 ****
--- 283,293 ----
  
  	  }
+ 
+ 	  /* Should move deletion out of the moving business and delay
+ 	     it until _after_ we have ended the moving
+ 
+ 	     OR should we delete and retry in order to circumvent any
+ 	     sizelimits???
+ 	  */
  	  
  	  if (flags & MOVE_DELETE_MOVED && ok) {
***************
*** 275,284 ****
  	       ldap_uncache_entry(sld, source_dn);
  #endif
! 	       if (rc == LDAP_SUCCESS) {
  	       } else {
  		    if (rc == LDAP_SERVER_DOWN) {
  			 source_server->server_down++;
  		    }
! 		    error_push(error_context, ldap_err2string(rc));
  		    goto done;
  	       }
--- 296,308 ----
  	       ldap_uncache_entry(sld, source_dn);
  #endif
! 	       if (rc == LDAP_SUCCESS || rc == LDAP_NO_SUCH_OBJECT) {
  	       } else {
  		    if (rc == LDAP_SERVER_DOWN) {
  			 source_server->server_down++;
  		    }
! 		    snprintf(message, sizeof(message), 
! 			     "%s: %s", source_dn, ldap_err2string(rc));
! 		    error_push(error_context, message);
! 		    push_ldap_addl_error(sld, error_context); 
  		    goto done;
  	       }
***************
*** 287,290 ****
--- 311,315 ----
       } else {
  	  error_push(error_context, ldap_err2string(rc));
+ 	  push_ldap_addl_error(tld, error_context); 
  /*  	  ldap_perror(sld, "ldap_add"); */
  	  goto done;

[gq-commit] gq/src gq.c,1.10,1.11

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv18021

Modified Files:
	gq.c 
Log Message:
* Move setting of the LOCALEDIR to happen after codepage
  detection. Maybe this obsoletes the --with-localedir again. By doing this
  we hopefully trick gq in using the system default locale directory for 
  codepage detection and the LOCALEDIR for message translation.


Index: gq.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/gq.c,v
retrieving revision 1.10
retrieving revision 1.11
diff -C2 -d -r1.10 -r1.11
*** gq.c	18 Jun 2002 06:19:31 -0000	1.10
--- gq.c	27 Jun 2002 08:15:47 -0000	1.11
***************
*** 56,64 ****
       setlocale(LC_ALL, "");
       textdomain(PACKAGE);
-      bindtextdomain(PACKAGE, LOCALEDIR);
-      /* I think the following will be required for gtk 2 (Isn't UTF-8
-         the standard for widget texts there? - this will allow to have
-         the messages in UTF-8) */
- /*       bind_textdomain_codeset(PACKAGE, LDAP_CODESET); */
  
  #  if HAVE_LANGINFO_CODESET
--- 56,59 ----
***************
*** 77,80 ****
--- 72,81 ----
  #  endif /* HAVE_LANGINFO_CODESET */
  #endif
+ 
+      bindtextdomain(PACKAGE, LOCALEDIR);
+      /* I think the following will be required for gtk 2 (Isn't UTF-8
+         the standard for widget texts there? - this will allow to have
+         the messages in UTF-8) */
+ /*       bind_textdomain_codeset(PACKAGE, LDAP_CODESET); */
  
       gtk_set_locale();

[gq-commit] gq/src errorchain.c,1.7,1.8

[<sta...@us...>]

Update of /cvsroot/gqclient/gq/src
In directory usw-pr-cvs1:/tmp/cvs-serv17599

Modified Files:
	errorchain.c 
Log Message:
* Possibility for error reporting including source position (good for
  debugging)


Index: errorchain.c
===================================================================
RCS file: /cvsroot/gqclient/gq/src/errorchain.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** errorchain.c	21 Jun 2002 00:30:29 -0000	1.7
--- errorchain.c	27 Jun 2002 08:13:21 -0000	1.8
***************
*** 68,73 ****
  }
  
! 
! void error_push(int context, char *msg)
  {
       struct errchain *chain;
--- 68,73 ----
  }
  
! #ifdef ERROR_SHOW_LINE
! void error_push_production(int context, char *msg)
  {
       struct errchain *chain;
***************
*** 91,94 ****
--- 91,104 ----
  
  }
+ #endif
+ 
+ void error_push_debug(int context, char *msg, char *file, int line)
+ {
+      int len = strlen(msg) + strlen(file) + 100;
+      char *s = g_malloc(len);
+      snprintf(s, len, "%s:%d %s", file, line, msg);
+      error_push_production(context, s);
+      g_free(s);
+ }
  
  /* 
***************
*** 208,212 ****
  	       msg_label = gtk_label_new(cur_msg->msg);
  	       gtk_label_set_justify(GTK_LABEL(msg_label), GTK_JUSTIFY_LEFT);
! 
  	       gtk_widget_show(msg_label);
  	       gtk_box_pack_start(GTK_BOX(vbox), msg_label, FALSE, FALSE, 0);
--- 218,222 ----
  	       msg_label = gtk_label_new(cur_msg->msg);
  	       gtk_label_set_justify(GTK_LABEL(msg_label), GTK_JUSTIFY_LEFT);
! 	       gtk_misc_set_alignment(GTK_MISC(msg_label), 0, 0);
  	       gtk_widget_show(msg_label);
  	       gtk_box_pack_start(GTK_BOX(vbox), msg_label, FALSE, FALSE, 0);

[gq-commit] gq configure.in,1.32,1.33

[<sta...@us...>]

Update of /cvsroot/gqclient/gq
In directory usw-pr-cvs1:/tmp/cvs-serv17320

Modified Files:
	configure.in 
Log Message:
* Added the --with-localedir option
* Kerberos compilation fixes (hopefully this works for most people)

Index: configure.in
===================================================================
RCS file: /cvsroot/gqclient/gq/configure.in,v
retrieving revision 1.32
retrieving revision 1.33
diff -C2 -d -r1.32 -r1.33
*** configure.in	18 Jun 2002 22:21:27 -0000	1.32
--- configure.in	27 Jun 2002 08:12:05 -0000	1.33
***************
*** 118,122 ****
  	    [  --with-kerberos-prefix=PFX Prefix where Kerberos is installed],
  	    [
! 	     LIBS="-L$with_kerberos_prefix/lib -lkrb -ldes $LIBS"
  	     AC_DEFINE(HAVE_KERBEROS)
  	     HAVE_KERBEROS=1
--- 118,122 ----
  	    [  --with-kerberos-prefix=PFX Prefix where Kerberos is installed],
  	    [
! 	     LIBS="-L$with_kerberos_prefix/lib -lkrb5 -ldes425 $LIBS"
  	     AC_DEFINE(HAVE_KERBEROS)
  	     HAVE_KERBEROS=1
***************
*** 312,316 ****
--- 312,326 ----
  
  localedir="${datadir}/locale"
+ AC_ARG_WITH(with-localedir,
+ 	    [  --with-localedir=DIR    Where locale data should be stored (or can be found)
+ 			  Please see the README file for more details about this.])
+ 
+ if test "x$with_localedir" != "x"
+ then
+ 	localedir=$with_localedir
+ fi
+ 
  CFLAGS="$CFLAGS -DLOCALEDIR=\\\"$localedir\\\""
+ 
  
  AC_OUTPUT([

[gq-commit] gq README.TLS,1.1,1.2

[<sta...@us...>]

Update of /cvsroot/gqclient/gq
In directory usw-pr-cvs1:/tmp/cvs-serv17135

Modified Files:
	README.TLS 
Log Message:
* Added a note regarding OpenLDAP 2.1.x and TLS

Index: README.TLS
===================================================================
RCS file: /cvsroot/gqclient/gq/README.TLS,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** README.TLS	1 Jan 2001 00:30:53 -0000	1.1
--- README.TLS	27 Jun 2002 08:11:15 -0000	1.2
***************
*** 15,16 ****
--- 15,27 ----
  as per-server LDAP version configuration will probably be added.
  
+ When building gq against OpenLDAP 2.1.x (tested with x == 2) TLS
+ support may not work if it did with 2.0.x. This might be a
+ configuration issue on the client side regarding the verification of
+ the server certificate, but this has not been investigated in
+ detail. Note that having something like
+ 
+ TLS_CACERT /path/to/cacert.pem
+ 
+ in ~/.ldaprc might help (tested locally).
+ 
+ 

[gq-commit] CVSROOT loginfo,1.4,1.5

[<sta...@us...>]

Update of /cvsroot/gqclient/CVSROOT
In directory usw-pr-cvs1:/tmp/cvs-serv2262

Modified Files:
	loginfo 
Log Message:
* Removed explicit mailing of commitinfos to me and bert (boldly assuming
  it is OK for him, he will definitly speak up if it isn't :-) 


Index: loginfo
===================================================================
RCS file: /cvsroot/gqclient/CVSROOT/loginfo,v
retrieving revision 1.4
retrieving revision 1.5
diff -C2 -d -r1.4 -r1.5
*** loginfo	21 Apr 2002 15:20:21 -0000	1.4
--- loginfo	23 Jun 2002 16:09:56 -0000	1.5
***************
*** 28,30 ****
  #
  # CVSROOT $CVSROOT/CVSROOT/syncmail %{sVv} you@someplace.else
! DEFAULT $CVSROOT/CVSROOT/syncmail %{sVv} be...@bi... pe...@st... gqc...@li...
--- 28,30 ----
  #
  # CVSROOT $CVSROOT/CVSROOT/syncmail %{sVv} you@someplace.else
! DEFAULT $CVSROOT/CVSROOT/syncmail %{sVv} gqc...@li...

[gq-commit] CVSROOT syncmail,1.2,1.3

[<sta...@us...>]

Update of /cvsroot/gqclient/CVSROOT
In directory usw-pr-cvs1:/tmp/cvs-serv1374

Modified Files:
	syncmail 
Log Message:
* Arghhhh, I lost the execute bit when upgrading. Fixed. (Had to 
  add a space somewhere to actually be able to check this in)


Index: syncmail
===================================================================
RCS file: /cvsroot/gqclient/CVSROOT/syncmail,v
retrieving revision 1.2
retrieving revision 1.3
diff -C2 -d -r1.2 -r1.3
*** syncmail	23 Jun 2002 16:03:59 -0000	1.2
--- syncmail	23 Jun 2002 16:05:39 -0000	1.3
***************
*** 8,12 ****
  This script is used to provide email notifications of changes to the CVS
  repository.  These email changes will include context diffs of the changes.
! Really big diffs will be trimmed.
  
  This script is run from a CVS loginfo file (see $CVSROOT/CVSROOT/loginfo).  To
--- 8,12 ----
  This script is used to provide email notifications of changes to the CVS
  repository.  These email changes will include context diffs of the changes.
! Really big diffs will be trimmed. 
  
  This script is run from a CVS loginfo file (see $CVSROOT/CVSROOT/loginfo).  To

[gq-commit] test 4

[Peter S. <sta...@us...>]

test 4

[gq-commit] test 3

[Peter S. <pet...@eu...>]

[gq-commit] test 2

[Bert V. <be...@bi...>]

test 2


Bert Vermeulen
be...@bi...
--
Profanity is the inevitable linguistic crutch of the inarticulate motherfucker.

[gq-commit] test 1

[Bert V. <be...@bi...>]

test 1


Bert Vermeulen
be...@bi...
--
Profanity is the inevitable linguistic crutch of the inarticulate motherfucker.