Menu

#297 gpdis.c:632: bad if test ?

None
closed-accepted
None
1
2016-11-29
2016-11-23
dcb
No

gpdis.c:632:56: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

   if ((file1 == PIC14_REG_PCLATH) && ((tmp >= 3) || (tmp <= 6))) {

Suggest new code

   if ((file1 == PIC14_REG_PCLATH) && ((tmp >= 3) && (tmp <= 6))) {

Discussion

  • Molnár Károly

    Molnár Károly - 2016-11-24
    • assigned_to: Molnár Károly
     
  • Molnár Károly

    Molnár Károly - 2016-11-24

    Thank you for your report.

    Molnár Károly

     
  • Molnár Károly

    Molnár Károly - 2016-11-29
    • status: open --> closed-accepted
     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB