Re: [Gptfdisk-general] [PATCH 00/15] Clean up makefiles and support building sgdisk executable for Windows

[Bin M. <bme...@gm...>]

Hi Rod,

On Sun, Apr 10, 2022 at 9:34 PM Rod Smith <rod...@ro...> wrote:
>
> On 4/2/22 03:00, Bin Meng wrote:
> > This series was originated from trying to build the sgdisk executable
> > for Windows host, that has not been formally supported as of today.
>
> Thanks for your extensive patch set! It's taken me a while to review it,
> but I've incorporated it into the latest version on the project's git
> repository. (I expect to do a new full release soon, too.) I made a few
> tweaks, mostly to the README.Windows file to more clearly describe how
> to get it to work; and I added the ability to build cgdisk for Windows,
> as well as sgdisk. (This currently works in Windows but not in my Ubuntu
> build environment, though.)
>

Thanks for merging the series. It looks like all my patches are
squashed into a single commit.

Two minor issues:

1. Makefile.mingw64 still contains "-g"
2. Makefile.mingw64 is missing "-static -static-libgcc
-static-libstdc++" in CXXFLAGS

Regards,
Bin