Re: [Gptfdisk-general] [PATCH 00/15] Clean up makefiles and support building sgdisk executable for Windows

[Rod S. <rod...@ro...>]

On 4/2/22 03:00, Bin Meng wrote:
> This series was originated from trying to build the sgdisk executable
> for Windows host, that has not been formally supported as of today.

Thanks for your extensive patch set! It's taken me a while to review it,
but I've incorporated it into the latest version on the project's git
repository. (I expect to do a new full release soon, too.) I made a few
tweaks, mostly to the README.Windows file to more clearly describe how
to get it to work; and I added the ability to build cgdisk for Windows,
as well as sgdisk. (This currently works in Windows but not in my Ubuntu
build environment, though.)

> The series starts from several patches to do some clean-ups to existing
> makefiles for various platforms (patch 1, 2, 3, 4, 6, 7).
> 
> Patch 5 is a build warning fix as the result of adding the '-O2' flag.
> 
> Patch 8 fixes several issues in the 'sgdisk' build rule for mingw*
> builds, and patch 9 enables the sgdisk build by default.
> 
> Path 10 does further clean-up to simplify the build rules.
> 
> Path 11 and 12 are fixes when using newer version gcc (e.g.: gcc 11)
> which is the one that ships on MSYS2.
> 
> Patch 13 switches the Windows executable build from static to shared.
> 
> Patch 14 allows MinGW compiler on both Linux and Windows to be used.
> 
> Patch 15 updates the Windows documentation with the latest information.
> 
> 
> Bin Meng (15):
>   makefile: Drop CC and CFLAGS
>   makefile: Remove the 'testguid' rule for mac build
>   makefile: Fix the 'clean' rule for freebsd/mingw* builds
>   makefile: Drop "-g" compiler flag for mac/mingw* builds
>   gptcl: Silence the compiler warning in BuildMBR()
>   makefile: Add "-O2" compiler flag for linux/freebsd builds
>   makefile: Drop duplicated "-static-libgcc" flag in mingw* builds
>   makefile: Fix the 'sgdisk' rule for mingw* builds
>   makefile: Enable building sgdisk by default for mingw* builds
>   makefile: Consolidate build rules with LDFLAGS and LDLIBS
>   crc32: Remove deprecated 'register' specifier for C++17
>   Explicitly namespace-qualify all std names in header files
>   makefile: Switch to building shared executables for mingw* builds
>   makefile: Avoid absolute path in CXX for mingw* builds
>   README: Update build instructions for Windows executables
> 
>  Makefile         | 17 +++++++----------
>  Makefile.freebsd | 22 +++++++++-------------
>  Makefile.mac     | 22 +++++++---------------
>  Makefile.mingw   | 26 +++++++++++++-------------
>  Makefile.mingw64 | 26 +++++++++++++-------------
>  README.Windows   | 37 ++++++++++++++++++++-----------------
>  attributes.h     | 10 ++++------
>  basicmbr.h       | 12 +++++-------
>  bsd.h            |  5 +----
>  crc32.cc         |  2 +-
>  diskio.h         | 16 +++++++---------
>  gdisk.cc         |  2 ++
>  gpt.h            | 20 +++++++++-----------
>  gptcl.cc         |  4 +++-
>  gptcl.h          | 10 ++++------
>  gptcurses.h      | 10 ++++------
>  gptpart.cc       | 11 +++++------
>  gptpart.h        |  6 ++----
>  gpttext.h        | 12 +++++-------
>  guid.h           | 12 +++++-------
>  mbr.h            |  4 +---
>  mbrpart.h        |  2 --
>  parttypes.h      | 16 +++++++---------
>  support.h        | 16 +++++++---------
>  24 files changed, 141 insertions(+), 179 deletions(-)
> 


-- 
Rod Smith
rod...@ro...
http://www.rodsbooks.com