Re: [Gptfdisk-general] GPTPart::GetDescription broken in 1.0.7 on Big Endian systems

[Rod S. <rod...@ro...>]

On 6/8/21 9:17 AM, Erik Larsson wrote:
> Hi Christian,
> 
> I have created a merge request to address the issue with big-endian
> partition names:
> https://sourceforge.net/p/gptfdisk/code/merge-requests/26/

Wow! I woke up to quite the flurry of activity on this. (I'm on the US
East Coast.) Anyhow, thanks to both you and Christian for tracking this
down and submitting the MR so quickly. I've accepted it, so if
subsequent testing shows a need for more changes, please alert me and
I'll handle it. There aren't a lot of changes from 1.0.7 to the current
state, but given that this is kind of important for big-endian systems,
I'll release this change as 1.0.8 soon -- but I'll give it a day or two
in case something else crops up.

> Please comment in there and test the state of the pull request to make
> sure it works for you. We can discuss there what to do about existing
> volumes.
> 
> Best regards,
> 
> - Erik
> 
> 
>>>>>>>>> On 8.6.2021 10.12, Christian Ehrhardt wrote:
>>>>>>>>>> Hi,
>>>>>>>>>> I wanted to let you know that the recent try to fix big endian
>>>>>>>>>> byte
>>>>>>>>>> swapping is actually breaking big endian in 1.0.7.
>>>>>>>>>>
>>>>>>>>>> This is broken on s390x (=big endian) in Debian [1] and Ubuntu
>>>>>>>>>> [2].
>>>>>>>>>>
>>>>>>>>>> When you look at just these logs it seems it is just failing
>>>>>>>>>> for no
>>>>>>>>>> apparent reason,
>>>>>>>>>> but with -x enabled in gdisk_test.sh one quickly sees there is
>>>>>>>>>> some
>>>>>>>>>> string-mangling happening:
>>>>>>>>>>
>>>>>>>>>> Number  Start (sector)    End (sector)  Size       Code Name
>>>>>>>>>>        1            2048          131038   63.0 MiB 8300
>>>>>>>>>> 䰀椀渀甀砀 昀椀氀攀猀礀猀琀攀洀
>>>>>>>>>>
>>>>>>>>>> Reading the very same file with the old gdisk is good - so likely
>>>>>>>>>> the
>>>>>>>>>> on-dis content is good as well:
>>>>>>>>>> Number  Start (sector)    End (sector)  Size       Code Name
>>>>>>>>>>        1            2048          131038   63.0 MiB 8300  Linux
>>>>>>>>>> filesystem
>>>>>>>>>>
>>>>>>>>>> This is caused by GPTPart::GetDescription due to this change [3]
>>>>>>>>>> in 1.0.7
>>>>>>>>>>
>>>>>>>>>> Reverting this fixes change fixes the problem.
>>>>>>>>>>
>>>>>>>>>> [1]:
>>>>>>>>>> https://buildd.debian.org/status/fetch.php?pkg=gdisk&arch=s390x&ver=1.0.7-1&stamp=1617791278&raw=0
>>>>>>>>>>
>>>>>>>>>> [2]:
>>>>>>>>>> https://launchpadlibrarian.net/540613637/buildlog_ubuntu-impish-s390x.gdisk_1.0.7-1_BUILDING.txt.gz
>>>>>>>>>>
>>>>>>>>>> [3]:
>>>>>>>>>> https://sourceforge.net/p/gptfdisk/code/ci/86dd5fea351a5a55bea26b7622eb85ebd6075a60/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>
>>>
>>>
>>> -- 
>>> Christian Ehrhardt
>>> Staff Engineer, Ubuntu Server
>>> Canonical Ltd
>>
>>
> 
> 
> _______________________________________________
> Gptfdisk-general mailing list
> Gpt...@li...
> https://lists.sourceforge.net/lists/listinfo/gptfdisk-general


-- 
Rod Smith
rod...@ro...
http://www.rodsbooks.com